| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Checked on Linux with the following command lines:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/app/*
BUG=367595,376000
R=thestig@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/1572673002
Cr-Commit-Position: refs/heads/master@{#368491}
|
|
|
|
|
|
|
|
|
|
| |
Moved gyp build to third_party/kasko
Also fixed some build issues that came with rebasing to tip of tree.
Review URL: https://codereview.chromium.org/1526213002
Cr-Commit-Position: refs/heads/master@{#368212}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Checked on Linux with the following command lines:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/tools/*
BUG=367595,376000
R=thestig@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/1562053002
Cr-Commit-Position: refs/heads/master@{#367938}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1552833002
Cr-Commit-Position: refs/heads/master@{#367209}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Checked on Linux with the following command lines:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/utility/*
BUG=367595,376000
R=thestig@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/1534763003
Cr-Commit-Position: refs/heads/master@{#365923}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1490243003
Cr-Commit-Position: refs/heads/master@{#364093}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes various missing dependencies.
In static builds, the //content target now exports content/public/browser, etc. as public dependencies.
Add an ipc_param_traits target that allows targets like events/latency_info.h to define IPC traits, without actually linking in all of IPC (because in this case events has no use of IPC).
Move some targets to public deps. The rule is that test_support targets should export the corresponding regular target as a public dep so tests don't have to depend on both.
Mark a few conditional includes "// nogncheck" where the checker got confused.
Fix manifest for views_unittests
Review URL: https://codereview.chromium.org/1501823003
Cr-Commit-Position: refs/heads/master@{#363690}
|
|
|
|
|
|
|
|
| |
BUG=460828
Review URL: https://codereview.chromium.org/1503483003
Cr-Commit-Position: refs/heads/master@{#363605}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds GYP and GN build files. Only building C++ code. Architecture-specific assembly code will be added in follow-up CL(s).
(This is a reupload of https://codereview.chromium.org/1403893007/ after having split it up into pieces and removed decoding and tests).
BUG=500605, 468365
Review URL: https://codereview.chromium.org/1446453004
Cr-Commit-Position: refs/heads/master@{#363443}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1484643002
Cr-Commit-Position: refs/heads/master@{#363307}
|
|
|
|
|
|
|
|
| |
BUG=564869
Review URL: https://codereview.chromium.org/1493043002
Cr-Commit-Position: refs/heads/master@{#363053}
|
|
|
|
|
|
|
|
| |
It checks cleanly, even though //third_party/WebKit/public does not.
Review URL: https://codereview.chromium.org/1491333002
Cr-Commit-Position: refs/heads/master@{#363027}
|
|
|
|
|
|
|
|
|
|
|
|
| |
All components now pass a "gn check" step. Whitelist with a wildcard.
Reland of https://codereview.chromium.org/1490113006
Reland of https://codereview.chromium.org/1491743002
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1496493003
Cr-Commit-Position: refs/heads/master@{#362841}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1490113006/ )
Reason for revert:
Breaks Linux ChromeOS GN: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN%20(dbg)
Log:
/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/buildtools/linux64/gn gen //out/Debug '--args=target_os="chromeos" is_debug=true is_component_build=true use_goma=true goma_dir="/b/build/goma"' --check --runtime-deps-list-file=/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/out/Debug/runtime_deps
-> returned 1
ERROR Unresolved dependencies.
//ui/ozone:ozone(//build/toolchain/linux:clang_x64)
needs //ui/events/ozone:events_ozone(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/drm:gbm(//build/toolchain/linux:clang_x64)
needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/egltest:egltest(//build/toolchain/linux:clang_x64)
needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)
Original issue's description:
> Add all components to "gn check".
>
> All components now pass a "gn check" step. Whitelist with a wildcard.
>
> R=dpranke@chromium.org
> Reland of https://codereview.chromium.org/1491743002
>
> Committed: https://crrev.com/3b5cac24943ce9e682c806f844a6aec90481774c
> Cr-Commit-Position: refs/heads/master@{#362776}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1491273003
Cr-Commit-Position: refs/heads/master@{#362785}
|
|
|
|
|
|
|
|
|
|
|
| |
All components now pass a "gn check" step. Whitelist with a wildcard.
R=dpranke@chromium.org
Reland of https://codereview.chromium.org/1491743002
Review URL: https://codereview.chromium.org/1490113006
Cr-Commit-Position: refs/heads/master@{#362776}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1491743002/ )
Reason for revert:
Failing Perf (Official) Linux Builder.
https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder/builds/7266
ERROR at //components/version_info/version_info.cc:12:11: Include not allowed.
#include "ui/base/l10n/l10n_util.h"
^-----------------------
It is not in any dependency of
//components/version_info:version_info
The include file is in the target(s):
//ui/base:base
which should somehow be reachable.
GN gen failed: 1
Original issue's description:
> Add all components to "gn check".
>
> All components now pass a "gn check" step. Whitelist with a wildcard.
>
> R=dpranke@chromium.org
>
> Committed: https://crrev.com/273b751649ebe3cc3579d9c87166ed3802827fb0
> Cr-Commit-Position: refs/heads/master@{#362652}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1490313002
Cr-Commit-Position: refs/heads/master@{#362725}
|
|
|
|
|
|
|
|
|
|
| |
All components now pass a "gn check" step. Whitelist with a wildcard.
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1491743002
Cr-Commit-Position: refs/heads/master@{#362652}
|
|
|
|
|
|
|
|
| |
This adds some missing dependencies so that components/nacl passes "gn check". This directory is now in the check whitelist.
Review URL: https://codereview.chromium.org/1490603002
Cr-Commit-Position: refs/heads/master@{#362572}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The components test setup needs to register browserJNI calls but this is not part of the content API. This makes a new content test wrapper API for doing this.
This change fixes the components tests "gn check" failures so these targets can now be added to the whitelist.
Cleans up the components/test DEPS file. The dependency allowances for this directory are quite wide so whitelisting every header file, as was done before, was needlessly complicated.
Review URL: https://codereview.chromium.org/1485893003
Cr-Commit-Position: refs/heads/master@{#362476}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added components are:
bitmap_uploader
browser_sync
dom_distiller
exp
proxy_config
query_parser
rappor
renderer_context_menu
resource_provider
resources
rlz
safe_browsing_db
safe_json
scheduler
search
The dom distiller GN build was a little messed up. The JNI registrar files were in core but referenced files in content. I moved the registrar files to content/browser which is where they're needed and matches some other components. There were also some other duplicated java targets, and I split out the content build file into separate subdirectories and renamed the targets to match.
TBR=dpranke@chromium.org
BUG=562773
Review URL: https://codereview.chromium.org/1487433002
Cr-Commit-Position: refs/heads/master@{#362234}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pdf
pdf_viewer
plugins
policy
power
precache
pref_registry
printing
proximity_auth
BUG=562685, 562683
TBR=dpranke
Review URL: https://codereview.chromium.org/1479373002
Cr-Commit-Position: refs/heads/master@{#362040}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
omnibox
search_engines
search_provider_logos
security_interstitials
service_tab_launcher
session_manager
sessions
signin
ssl_config
ssl_errors
This also moves net/test/test_certificate_data.h from net_unittests to net_test_support in both the GYP and the GN builds, because it is being used in a bunch of places outside of net.
TBR=dpranke (random GN)
TBR=bnc (net)
Review URL: https://codereview.chromium.org/1479093002
Cr-Commit-Position: refs/heads/master@{#362027}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
network_hints
network_time
offline_pages
omnibox
onc
open_from_clipboard
os_crypt
ownership
packed_ct_ev_whitelist
page_load_metrics
pairing
password_manager
TBR=dpranke
Review URL: https://codereview.chromium.org/1482653002
Cr-Commit-Position: refs/heads/master@{#362017}
|
|
|
|
|
|
|
|
|
|
| |
This fixes some dependency warnings on Windows.
TBR=dpranke
Review URL: https://codereview.chromium.org/1476323002
Cr-Commit-Position: refs/heads/master@{#362015}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds:
gcm_driver
gpu
guest_view
handoff
infobars
invalidation
json_schema
keyed_service
language_usage_metrics
leveldb_proto
login
memory_pressure
message_port
metrics
metrics_services_manager
mime_util
Review URL: https://codereview.chromium.org/1472053004
Cr-Commit-Position: refs/heads/master@{#361804}
|
|
|
|
|
|
|
|
|
|
| |
BUG=475612
R=agrieve, newt, pvalenzuela, zea
TBR=brettw for .gn whitelisting usage fo gypi_to_gn in protocol_sources.gni
Review URL: https://codereview.chromium.org/1458353002
Cr-Commit-Position: refs/heads/master@{#361561}
|
|
|
|
|
|
|
|
|
|
| |
This also makes //win8/* pass "gn check".
BUG=512864,512869
Review URL: https://codereview.chromium.org/1464263003
Cr-Commit-Position: refs/heads/master@{#361211}
|
|
|
|
|
|
|
|
|
|
|
|
| |
First of many.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1458623003
Cr-Commit-Position: refs/heads/master@{#360239}
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=532905
Review URL: https://codereview.chromium.org/1440803002
Cr-Commit-Position: refs/heads/master@{#359263}
|
|
|
|
|
|
|
|
| |
This was marked with a comment about a generated file confusing things, but when I went to fix it, it seems to work fine. Just enable checking on this target.
Review URL: https://codereview.chromium.org/1433513003
Cr-Commit-Position: refs/heads/master@{#358054}
|
|
|
|
|
|
|
|
|
|
|
| |
These ones pass 'gn check out-gn/Release' on Linux.
BUG=367595,376000
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/1429143002
Cr-Commit-Position: refs/heads/master@{#357552}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Someone removed this from gn check a while back when it was fine. This
fixes the issues that crept in and adds it back to .gn.
BUG=none
TEST=none
R=brettw@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/1410743006
Cr-Commit-Position: refs/heads/master@{#357410}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the dependencies that //components/crash that were
missing that was making `gn check` upset and, in at least one case,
causing us to actually miscompile things because the public_configs
were not being propagated from content properly.
R=rsesek@chromium.org, jam@chromium.org, pkotwicz@chromium.org
BUG=547635
Review URL: https://codereview.chromium.org/1423043002
Cr-Commit-Position: refs/heads/master@{#356993}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Port the GYP configs to BUILD.gn so that this test
can be built with GN.
BUG=chromium:412865, chromium:471903
R=kbr@chromium.org, piman@chromium.org, dpranke@chromium.org, brettw@chromium.org
TEST=Verify khronos_glcts_test builds and runs with GN build
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Review URL: https://codereview.chromium.org/1413303003
Cr-Commit-Position: refs/heads/master@{#356871}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the remaining components as commented-out lines so it's easier to see what remains.
Some of the existing entries were missing the * so only the exact target was being checked, excluding unit test and test_support targets. This patch addresses those problems and adds the stars.
BUG=
Review URL: https://codereview.chromium.org/1422803002
Cr-Commit-Position: refs/heads/master@{#355936}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1417233002
Cr-Commit-Position: refs/heads/master@{#355749}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1413713009
Cr-Commit-Position: refs/heads/master@{#355675}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1408933002
Cr-Commit-Position: refs/heads/master@{#355508}
|
|
|
|
|
|
|
|
|
|
| |
Adds translate, ui/zoom, upload_list, visitedlink, web_resource, webusb
Makes CLD 2 forward public deps properly
Review URL: https://codereview.chromium.org/1410683002
Cr-Commit-Position: refs/heads/master@{#354453}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds some dependencies and marks them all public. Since chrome/common doesn't have much of an API or structure, deciding what should be public or not is basically impossible.
Removes the include of content_switches from chrome_switches. Files depending on this have already been updated to include content_switches directly.
Moves the nss_security_manager code out of chrome_browser. This was used only by chrome_common. In GYP This is now part of chrome_common_net. In GN, this is a separate target that chrome_common_net depends on.
Reland of https://codereview.chromium.org/1393953003/
TBR=dpranke
Review URL: https://codereview.chromium.org/1406053002
Cr-Commit-Position: refs/heads/master@{#354391}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were some existing cloud_print targets that were hooked up only on Linux, but most of the code was Windows-only. This adds the missing targets and should bring us up to GYP parity.
Fix the cloud print size_t to int warnings and remove the warning disable from GYP.
Move generated resources file from cloud_print/resources.h to cloud_print/service/resources.h to match where the source file is.
Cloud print does some messy things to get the content switches constants, including the file directly in its sources and manually setting LINK_CONTENT_STATICALLY for all targets. In GN, this adds a static_switches target in content that does this in an official way.
Reland of https://codereview.chromium.org/1397433004/ with grid directory fixes
Reland of https://codereview.chromium.org/1393123003/ with warning fixes
TBR=dpranke
Review URL: https://codereview.chromium.org/1408623002
Cr-Commit-Position: refs/heads/master@{#354154}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1393953003/ )
Reason for revert:
Causes compile failure on the official builder: Google Chrome Linux x64
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/4921
[4392/21662] CXX obj/v8/v8_base/bytecode-generator.o
FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/third_party/mozilla_security_manager/mozilla_security_manager/nsNSSCertHelper.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_PROPRIETARY_CODECS -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=247874-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nss -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nspr -I../../third_party/boringssl/src/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -pthread -m64 -march=x86-64 -Wall -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-reserved-user-defined-literal -Wno-shift-negative-value -Wno-bitfield-width -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=/b/build/slave/google-chrome-rel-linux_64/build/src/build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wno-header-guard -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp -o obj/chrome/third_party/mozilla_security_manager/mozilla_security_manager/nsNSSCertHelper.o
../../chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp:55:10: fatal error: 'chrome/grit/generated_resources.h' file not found
#include "chrome/grit/generated_resources.h"
^
1 error generated.
FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/third_party/mozilla_security_manager/mozilla_security_manager/nsUsageArrayHelper.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_PROPRIETARY_CODECS -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=247874-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nss -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nspr -I../../third_party/boringssl/src/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -pthread -m64 -march=x86-64 -Wall -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-reserved-user-defined-literal -Wno-shift-negative-value -Wno-bitfield-width -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=/b/build/slave/google-chrome-rel-linux_64/build/src/build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wno-header-guard -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../chrome/third_party/mozilla_security_manager/nsUsageArrayHelper.cpp -o obj/chrome/third_party/mozilla_security_manager/mozilla_security_manager/nsUsageArrayHelper.o
../../chrome/third_party/mozilla_security_manager/nsUsageArrayHelper.cpp:40:10: fatal error: 'chrome/grit/generated_resources.h' file not found
#include "chrome/grit/generated_resources.h"
^
1 error generated.
Original issue's description:
> Make chrome/common pass "gn check"
>
> This adds some dependencies and marks them all public. Since chrome/common doesn't have much of an API or structure, deciding what should be public or not is basically impossible.
>
> Removes the include of content_switches from chrome_switches. Files depending on this have already been updated to include content_switches directly.
>
> Moves the nss_security_manager code out of chrome_browser. This was used only by chrome_common. In GYP This is now part of chrome_common_net. In GN, this is a separate target that chrome_common_net depends on.
>
> Committed: https://crrev.com/fdb7f7fa8b32547063721d66e504bbabd804a574
> Cr-Commit-Position: refs/heads/master@{#354132}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1396663005
Cr-Commit-Position: refs/heads/master@{#354144}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds some dependencies and marks them all public. Since chrome/common doesn't have much of an API or structure, deciding what should be public or not is basically impossible.
Removes the include of content_switches from chrome_switches. Files depending on this have already been updated to include content_switches directly.
Moves the nss_security_manager code out of chrome_browser. This was used only by chrome_common. In GYP This is now part of chrome_common_net. In GN, this is a separate target that chrome_common_net depends on.
Review URL: https://codereview.chromium.org/1393953003
Cr-Commit-Position: refs/heads/master@{#354132}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1397433004/ )
Reason for revert:
Causes compile failures:
http://build.chromium.org/p/chromium/builders/Win/builds/36509/steps/compile/logs/stdio
ninja:error: 'gen/cloud_print/service_resources_en.rc', needed by 'obj/cloud_print/service/win/gen/cloud_print/cloud_print_service.service_resources_en.res', missing and no known rule to make it
Original issue's description:
> Add cloud_print to the GN build.
>
> There were some existing cloud_print targets that were hooked up only on Linux, but most of the code was Windows-only. This adds the missing targets and should bring us up to GYP parity.
>
> Fix the cloud print size_t to int warnings and remove the warning disable from GYP.
>
> Move generated resources file from cloud_print/resources.h to cloud_print/service/resources.h to match where the source file is.
>
> Cloud print does some messy things to get the content switches constants, including the file directly in its sources and manually setting LINK_CONTENT_STATICALLY for all targets. In GN, this adds a static_switches target in content that does this in an official way.
>
> Reland of https://codereview.chromium.org/1393123003/ with warning fixes
> TBR=dpranke
>
> Committed: https://crrev.com/70d2f990df7755c6e76aa20f156ff1f92a25f318
> Cr-Commit-Position: refs/heads/master@{#354089}
TBR=dpranke@google.com,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1409563002
Cr-Commit-Position: refs/heads/master@{#354098}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were some existing cloud_print targets that were hooked up only on Linux, but most of the code was Windows-only. This adds the missing targets and should bring us up to GYP parity.
Fix the cloud print size_t to int warnings and remove the warning disable from GYP.
Move generated resources file from cloud_print/resources.h to cloud_print/service/resources.h to match where the source file is.
Cloud print does some messy things to get the content switches constants, including the file directly in its sources and manually setting LINK_CONTENT_STATICALLY for all targets. In GN, this adds a static_switches target in content that does this in an official way.
Reland of https://codereview.chromium.org/1393123003/ with warning fixes
TBR=dpranke
Review URL: https://codereview.chromium.org/1397433004
Cr-Commit-Position: refs/heads/master@{#354089}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1393123003/ )
Reason for revert:
Broke http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/14017
Original issue's description:
> Add cloud_print to the GN build.
>
> There were some existing cloud_print targets that were hooked up only on Linux, but most of the code was Windows-only. This adds the missing targets and should bring us up to GYP parity.
>
> Fix the cloud print size_t to int warnings and remove the warning disable from GYP.
>
> Move generated resources file from cloud_print/resources.h to cloud_print/service/resources.h to match where the source file is.
>
> Cloud print does some messy things to get the content switches constants, including the file directly in its sources and manually setting LINK_CONTENT_STATICALLY for all targets. In GN, this adds a static_switches target in content that does this in an official way.
>
> Committed: https://crrev.com/53eae14bacb401632d4f2045ed8715705dcd8d1d
> Cr-Commit-Position: refs/heads/master@{#353928}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1407623003
Cr-Commit-Position: refs/heads/master@{#353938}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were some existing cloud_print targets that were hooked up only on Linux, but most of the code was Windows-only. This adds the missing targets and should bring us up to GYP parity.
Fix the cloud print size_t to int warnings and remove the warning disable from GYP.
Move generated resources file from cloud_print/resources.h to cloud_print/service/resources.h to match where the source file is.
Cloud print does some messy things to get the content switches constants, including the file directly in its sources and manually setting LINK_CONTENT_STATICALLY for all targets. In GN, this adds a static_switches target in content that does this in an official way.
Review URL: https://codereview.chromium.org/1393123003
Cr-Commit-Position: refs/heads/master@{#353928}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GCAPI is a Windows-specific API for distributors of Chrome.
This adds all chrome/installer targets to "gn check" and fixes many associated issues. The result codes targets are also added to "gn check" to make sure people don't accidentally add stuff to those headers.
Rather than add a disable for the size_t to int warning for this target, I just fixed the warning and removed the disable flag from GYP.
Merged //chrome/common:result_codes into //chrome/common:constants. This is basically a constant and everybody that needed the result codes already depended on the constants target.
Fix google_update build file. The midl template already did everything this file was trying to do. I clarified the template documentation a bit.
BUG=539428
Review URL: https://codereview.chromium.org/1388943004
Cr-Commit-Position: refs/heads/master@{#352869}
|
|
|
|
|
|
|
|
|
|
| |
Nobody actually needs to remove these, so I merged them with the runtime library configs that don't need to be referenced by the BUILDCONFIG.gn file.
This adds a posix BUILD.gn file. More stuff from the compiler config can go here in the future. For now, it just has the sysroot setup for Posix.
Review URL: https://codereview.chromium.org/1367403002
Cr-Commit-Position: refs/heads/master@{#352077}
|
|
|
|
|
|
|
|
|
| |
BUG=491209
TBR=brettw
Review URL: https://codereview.chromium.org/1373803002 .
Cr-Commit-Position: refs/heads/master@{#351047}
|