| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6368002
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/6351004
git-svn-id: svn://svn.chromium.org/chrome/branches/642/src@71686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/642/src@71640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/642/src@71638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6348005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dataType has been required for <select pref=...> since
http://src.chromium.org/viewvc/chrome?view=rev&revision=71284
BUG=to be filed
TEST=confirmed that the punctuation style setting worked for mozc.
also confirmed that all <select> elements with 'pref' attribute have dataType:
% perl -n0e 's/(<select[^>]*pref.*?>)/print "$ARGV:$1\n"/gse' *.html > all_select_prefs
% perl -n0e 's/(<select[^>]*dataType.*?>)/print "$ARGV:$1\n"/gse' *.html > select_prefs_with_datatype
% diff all_select_prefs select_prefs_with_datatype
Review URL: http://codereview.chromium.org/6286002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue was probably introduced by
http://src.chromium.org/viewvc/chrome?view=rev&revision=71284
that made undefined dataType to be an error.
BUG=chromium-os:10878
TEST=manually on the netbook
Review URL: http://codereview.chromium.org/6246005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=bulach
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6307005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix PRESUBMIT.py to exclude Makefile.
BUG=none
TEST=presubmit check is less noisy
Review URL: http://codereview.chromium.org/5976009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NO CODE CHANGE.
TBR=abarth
TEST=
BUG=
Review URL: http://codereview.chromium.org/6310010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since C++ supports covariant return types, a subclass of Value can return its
own pointer type for Value::DeepCopy().
Also made signatures of Value::Create*Value() more specific.
Removed now-unnecessary casts.
Added test for covariant return types.
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6324004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Manager.
BUG=69145
TEST=manual
Review URL: http://codereview.chromium.org/6307004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(This was a TODO for jhawkins).
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/6344004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the default yellow one.
BUG=69704
TEST=bookmark folder icons are blue in the WEBUI bookmark manager
Review URL: http://codereview.chromium.org/6331003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the comments to reflect this.
I'll clean up when I hear back from dmaclach and the Nacl team.
BUG= None
TEST= None
Review URL: http://codereview.chromium.org/6266005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
motivated by a discussion with Ben and Scott in the process of fixing a z-order
issue in http://codereview.chromium.org/5700003/
BUG=none
TEST=manually on both touch and non-touch builds, trybots
Review URL: http://codereview.chromium.org/6024007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
r692 fixes a valgrind error. r691 brings in optional gradient dithering code for 32bit pixels. Disable this in chrome for now.
BUG=41756,69531,69452
TEST=none
TBR=reed
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The http method is broken, and having this in here means `git try` takes 60 seconds just to discover that it should retry using svn.
Removing this == developer_productivity++
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6312005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=satish
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/6269009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the process, added a generic AudioEncoder interface which could create the requested codec.
Right now the codec is set to FLAC. In a future CL, we'll determine the codec to use dynamically
based on bandwidth considerations.
This CL depends on http://codereview.chromium.org/6205006/ going in first.
BUG=61677
TEST=none
Review URL: http://codereview.chromium.org/6111009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=finnur
BUG=69882
TEST=interactive_ui_tests
Review URL: http://codereview.chromium.org/6350004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=69881
TEST=ui_tests
Review URL: http://codereview.chromium.org/6347003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Always present "password changed" dialog when user homedir exists.
BUG=chromium-os:10623
TEST=Manual
Review URL: http://codereview.chromium.org/6350003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8172
TEST=N/A
Review URL: http://codereview.chromium.org/6303008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:10958
TEST=manual
Review URL: http://codereview.chromium.org/6355007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
list.
I have also set the svn:ignore property for the 'flac' subdir under third_party
directory, though I guess it can't be seen in the review.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6205006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should prevent ui_tests from crashing under Valgrind on Linux.
This fix was suggested by kcc (see the discussion of issue 28439)
BUG=28439
Review URL: http://codereview.chromium.org/6331002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This test seems to fail because history.19.sql migrates very old pages, i.e. pages whose last_visit_time is >90 days before now, and our history service filters them out. This change just replaces the time-sensitive values (i.e. 'last_visit_time', 'visit_time', and 'time_slot') with the current time to prevent migrating expired pages.
BUG=none
TEST=TopSitesMigrationTest.Migrate
Review URL: http://codereview.chromium.org/6371001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It already is in the upstream test_expectations file.
TBR=senorblanco
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=senorblanco
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bar accessibility
object name had changed a bit in the IE9 update. Updated the text expectations to account for
this.
BUG=none
TEST=Existing ChromeFrame TypeUrl tests.
TBR=amit
Review URL: http://codereview.chromium.org/6248007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add an [- infoBarWillClose] selector to InfoBarController to give the translate infobar a chance to dismiss the options menu when the infobar is detached from a window.
BUG=67594
TEST=See bug
Review URL: http://codereview.chromium.org/6296003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also bring about_credits.html up to date.
1. licenses.py was failing on Windows because of path separators, so I
changed remaining path strings to use os.path.join.
2. I wasn't seeing all DEPS on my system, so I modified DEPS locally to
ignore os_deps. That led to several changes to make sure os-specific
libraries (pdfsqueeze, GTM, for example) get attribution in about_credits.
3. Some of the code we pull in doesn't need attribution in our about_credits
(windows SDK), so I added new ignore rules.
BUG=none
TEST= dunno. about:credits credits everything we include?
R= evan@chromium.org
Review URL: http://codereview.chromium.org/6263006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The two license attributions are taken from Firefox's about:license page
and correspond to the license headers in the source files.
This change makes licenses.py happy.
R=abarth,evanm
TEST= about:credits includes a qcms section crediting Marti Maria and SunSoft.
Review URL: http://codereview.chromium.org/6262004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
before accessing them.
BUG=64813
TEST=see bug
Review URL: http://codereview.chromium.org/6273006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6282003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Affects files that include from chrome/browser/ui/views
BUG=69082
TEST=none
Review URL: http://codereview.chromium.org/6299008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hayato
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6334005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=69757
TEST=Mac Valgrind goes green
TBR=thestig
Review URL: http://codereview.chromium.org/6297005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(This was a TODO for phajdan.jr).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6282002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
They were moved to ui/base/animation. Remove them now, since no one is including these files.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71557 0039d316-1c4b-4281-b951-d872f2087c98
|