summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Enable and implement last 2 items in bookmark bar context menu: "Openjrg@chromium.org2009-11-128-155/+626
| | | | | | | | | | | | | | | | | | | | | | | All In New Window" and "Open All In Incognito Window" (17616). Bookmark Folders have the bar context menu, not the bookmark context menu (26748). Disable bookmark manager item on bookmark contextual menus (26944). BUG=http://crbug.com/17616, http://crbug.com/26748, http://crbug.com/26944 TEST=Add some bookmarks. Make sure "Open All In New Window" and "Open All In Incognito Window" work from the bar context menu. Add a bookmark folder. Make sure the context menu of the folder is the bar conetxt menu, not the 'mark context menu. Make sure Bookmark Manager item is DISabled in both context menus. nib change: hook up actions in the "Open All Blah" items just like the normal "Open All". Review URL: http://codereview.chromium.org/373022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31748 0039d316-1c4b-4281-b951-d872f2087c98
* Add a RWH_TabSwitchPaintDuration histogram.chase@chromium.org2009-11-126-0/+42
| | | | | | | | | | | | | | | | | | | | | | | The RWH_TabSwitchPaintDuration histogram calculates the amount of time it took after a particular view was selected for it to be fully painted. Previous versions of this patch included modifications to the tab switching test. Those are blocked on setting up a new builder for accurate measurement and are now removed from this CL. BUG=4104 TEST=none Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=31632 Revert: http://src.chromium.org/viewvc/chrome?view=rev&revision=31645 Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=31679 Revert: http://src.chromium.org/viewvc/chrome?view=rev&revision=31683 Review URL: http://codereview.chromium.org/378038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31747 0039d316-1c4b-4281-b951-d872f2087c98
* Compile fix for linux.estade@chromium.org2009-11-121-6/+5
| | | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/386011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31746 0039d316-1c4b-4281-b951-d872f2087c98
* Adding implementation of AutocompleteEditViewMac::IsSelectAll().jcampan@chromium.org2009-11-122-7/+9
| | | | | | | | | | | Also makes the SetUserText behavior similar to the Windows/Linux versions (by calling SetWindowTextAndCaretPos() that also deals with the selection). R=shess BUG=None TEST=Make sure the location bar still works as expected on Mac. Review URL: http://codereview.chromium.org/329024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31745 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix null dereference in bookmark manager.estade@chromium.org2009-11-121-11/+18
| | | | | | | | BUG=27436 Review URL: http://codereview.chromium.org/391023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31744 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use bookmark bar text color for show all downloads... link when not ↵estade@chromium.org2009-11-124-46/+92
| | | | | | | | | | using GTK theme or Classic theme. BUG=27075 Review URL: http://codereview.chromium.org/384060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31743 0039d316-1c4b-4281-b951-d872f2087c98
* Delete some empty directories that I missed with the previous CL.erikkay@chromium.org2009-11-120-0/+0
| | | | | | | | | BUG=26106 TEST=none TBR=finnur git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31742 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of the TableView so it uses NativeViewControl.jcampan@chromium.org2009-11-1212-3/+2249
| | | | | | | | | | | | | At this point it does not support grouping or sorting. Mostly refactoring things from TableView to TableView2 and NativeTableWin. BUG=None TEST=Unit-tests and view examples for now. R=sky Review URL: http://codereview.chromium.org/387021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31741 0039d316-1c4b-4281-b951-d872f2087c98
* Roll deps for gyp. Make build fix to enable serializing linking.thestig@chromium.org2009-11-121-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31740 0039d316-1c4b-4281-b951-d872f2087c98
* Map a return value of 0 to ERR_CONNECTION_CLOSED forwtc@chromium.org2009-11-121-19/+16
| | | | | | | | | | | | | connection_->socket()->Read() in DoReadHeadersComplete and DoReadBodyComplete so that we catch both synchronous and asynchronous completion of Read. R=vandebo BUG=13289 TEST=none Review URL: http://codereview.chromium.org/384047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31739 0039d316-1c4b-4281-b951-d872f2087c98
* More moving samples into docs/examples. erikkay@chromium.org2009-11-1245-2961/+0
| | | | | | | | | | | | | | Also did a little cleanup of a few of the samples. More cleanup still to go... BUG=26106 TEST=none TBR=finnur Review URL: http://codereview.chromium.org/387032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31738 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 50820:50840.japhet@chromium.org2009-11-122-3/+1
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/385050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31737 0039d316-1c4b-4281-b951-d872f2087c98
* Removes TabStrip::CanUpdateDisplay as it lead to crashes on thesky@chromium.org2009-11-122-37/+16
| | | | | | | | | | | windows side. BUG=24132 TEST=none Review URL: http://codereview.chromium.org/372068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31736 0039d316-1c4b-4281-b951-d872f2087c98
* Update ICU to r31724 to fix a crash in dictbe.cpp used by sqlite and history ↵jshin@chromium.org2009-11-111-1/+1
| | | | | | | | | | | full text search. BUG=27115 TEST=None for now. Will add one to word_iterator_unittest TBR=cevans Review URL: http://codereview.chromium.org/386010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31735 0039d316-1c4b-4281-b951-d872f2087c98
* linux: work around "flash does not register any clicks" bugevan@chromium.org2009-11-111-0/+6
| | | | | | | | | | | | | | | | | | I had a flash of inspiration! Setting GDK_NATIVE_WINDOWS in the environment doesn't work because we don't propagate the setting down into the plugin subprocess. I confirmed that setting it manually fixes it. That is, on this computer I previously had the no-clicks bug and with this change the problem is solved. Note: there are multiple confusing levels to this bug; if nspluginwrapper gets involved I still encounter the problem. But this definitely fixes the problem for me. BUG=20654 Review URL: http://codereview.chromium.org/384059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31734 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionResource::GetFilePath returns empty path if itfinnur@chromium.org2009-11-111-4/+6
| | | | | | | | | | | | | | | fails to resolve the css and js script files specified in the manifest. We shouldn't rely on the results of GetFilePath in the error, but show the relative path instead. BUG=27423 TEST=Create an extension with a content script, but specify a css and a js file that doesn't exist. The error message should be descriptive and make sense. Review URL: http://codereview.chromium.org/385052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31733 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Convert Cookies options page from a list into a tree.mattm@chromium.org2009-11-119-538/+526
| | | | | | | | | | | Add gtk_tree::TreeAdapter class. BUG=26713 TEST=compare behavior to windows impl Review URL: http://codereview.chromium.org/371079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31732 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame HTTP requests would randomly fail if we navigated to multiple ↵ananta@chromium.org2009-11-1110-41/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HTTP sites. This was because the automation resource message filter tracked HTTP requests based on the request ids which are generated by the renderer process. As a result a new request would get created say with id 0, while an existing request would end in ChromeFrame causing the new request to incorrectly shutdown. Fix is to revert back to the original way of tracking requests with an auto incrementing id. The automation url job maintains both ids now, i.e. the automation request id and the chrome request id. The download notification receives the automation id and basically looks up the associated automation request id and sends the notification back to ChromeFrame. This fixes bug http://code.google.com/p/chromium/issues/detail?id=27401 Other fixes in this CL include the following:- 1. The active document instance would never get destroyed. This was because we call ShowUI on the doc host which maintains a reference. We need to call HideUI in Setsite of NULL, which releases the reference. 2. When the active x instance is shutting down we try to shutdown all running requests in the OnDestroy handler. To ensure that the request is deleted from the request map and released in the same thread which created it we post a task back to the ui thread which never runs as the window is being destroyed. Fix is to create a message only window with every urlmonrequest instance which supports task marshaling. Tests in a future CL. Bug=27401 Review URL: http://codereview.chromium.org/386008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31731 0039d316-1c4b-4281-b951-d872f2087c98
* Change store group and newest cache API so that storage failure does not ↵jennb@chromium.org2009-11-118-45/+18
| | | | | | | | require storage clients to revert changes to group and so it's not racey.TEST=existing tests updatedBUG=none Review URL: http://codereview.chromium.org/384029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31730 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of implementing captcha for sync dialog. tim@chromium.org2009-11-1114-127/+190
| | | | | | | | | | | | Added GoogleServiceAuthError, which is the same as the incumbent AuthErrorState but can support captcha information too. I moved it because it just had nothing specific to sync about it. This CL is mostly a rename and basic plumbing CaptchaRequired error state from browser_sync::AuthWatcher through to UI thread. Ben, I added a .h to chrome/browser/ alongside other google_* stuff. I'm just looking for your blessing here, or suggestion of alternate location. BUG=19738 Review URL: http://codereview.chromium.org/384040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31729 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use themed background images in toolbar buttons.erg@google.com2009-11-118-18/+42
| | | | | | | | | | | | | | When a chrome theme asks to use a background image on a toolbar button, use it. Oddly enough, all of the graphics drawing was written but the plumbing of actually setting the background wasn't... TEST=Good Smile, Chuck Anderson, etc. should have button backgrounds which are very different from the toolbar background in the GTK port. BUG=NONE Review URL: http://codereview.chromium.org/384057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31728 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent accidental animations if we haven't yet done a full layout. Stab in ↵pinkerton@chromium.org2009-11-111-1/+1
| | | | | | | | | | the dark at a fix for some crashes. BUG=26979 TEST=dragging tabs over an existing window should still animate as the placeholder shifts around. Review URL: http://codereview.chromium.org/385048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31727 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix infobubble placement in non-debug builds.derat@chromium.org2009-11-111-4/+10
| | | | | | | | | | | I'd put an important function call inside of a DCHECK(). BUG=27099 TEST=checked that they're placed correctly in release builds now Review URL: http://codereview.chromium.org/389014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31726 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac expectations for LayoutTests/fast/inline/dirtyLinesForInline.htmljaphet@chromium.org2009-11-111-1/+1
| | | | | | | | | BUG=none TEST=none TBR=dglazkov git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31725 0039d316-1c4b-4281-b951-d872f2087c98
* Enable async IO completions on MockSockets through thembelshe@google.com2009-11-112-22/+108
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | SocketDataProvider. This makes a few changes: - The SocketDataProvider::GetNextRead() is now allowed to return a result of ERR_IO_PENDING. Previously, this was just an error. Now, this informs the MockClientSocket using the SocketDataProvider that the Mock IO will be completely asynchronously. - MockClientSocket implements a new method called OnReadComplete(). This method is used to asynchronously complete a Read from the SocketDataProvider. The MockClientSocket, after receiving ERR_IO_PENDING from SocketDataProvider::GetNextRead will be blocked until this call is made. The rest of the patch is just refactoring the MockTCPClientSocket to implement a true async-io simulation. It needs to record the user buffer from the initial read, and then fill it when the data is provided. BUG=none TEST=<this is for better testing> Review URL: http://codereview.chromium.org/392003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31723 0039d316-1c4b-4281-b951-d872f2087c98
* Remove valgrind suppression for 24936asargent@chromium.org2009-11-111-9/+0
| | | | | | | | | | | | | | | From looking at the recent valgrind results, it looks like this bug isn't happening anymore (the suppression isn't mentioned as being used in the output, at least). BUG=24936 TEST=none TBR=mpcomplete git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31722 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the memory leak annotations for heap leak checker.willchan@chromium.org2009-11-114-1/+467
| | | | | | | | | | | | | leak_annotations.h provides the ANNOTATE_SCOPED_MEMORY_LEAK macro that can be used for annotating known memory leaks in the tests. Those will be ignored by the heap leak checker. Patch contributed by ramosian.glider@gmail.com. Original review at http://codereview.chromium.org/346038/show Review URL: http://codereview.chromium.org/385049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31721 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable resource fallback for ExtensionResource::GetFilePath. We ↵cira@chromium.org2009-11-112-20/+6
| | | | | | | | | | | | need to figure out how to make it faster. We'll use chrome.extension.getURL(chrome.i18n.getMessage("resource")) for now to implement fallback. BUG=27359 Review URL: http://codereview.chromium.org/385045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31720 0039d316-1c4b-4281-b951-d872f2087c98
* BookmarkBubble.xib - Change control from combobox to popup button. The ↵dmaclach@chromium.org2009-11-114-292/+1036
| | | | | | | | | | | | | | massive changes due to the xib are due to editing the xib on SnowLeopard. Changes internals of bookmark bubble controller so that it will work correctly with items with the same name. BUG=27330 TEST=Create several bookmark folders and items using the bookmark bubble and verify that it is still working correctly. Review URL: http://codereview.chromium.org/384025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31719 0039d316-1c4b-4281-b951-d872f2087c98
* Rename unused "SSL" related automation methods to be generic, since that's ↵johnnyg@chromium.org2009-11-115-34/+33
| | | | | | | | | | | | what these methods actually do, and so I can repurpose them for a different info-bar test. BUG=none TEST=none Review URL: http://codereview.chromium.org/385029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31718 0039d316-1c4b-4281-b951-d872f2087c98
* Landing georgey CL.jcampan@chromium.org2009-11-112-5/+46
| | | | | | | | See http://codereview.chromium.org/384012 Review URL: http://codereview.chromium.org/387028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31717 0039d316-1c4b-4281-b951-d872f2087c98
* Retry of http://codereview.chromium.org/372025 with additional changes toamanda@chromium.org2009-11-113-142/+63
| | | | | | | | | | Quickdraw plugin shutdown, and a better match to Apple's code for all plugins. BUG=23868,25694 TEST=plugins should not crash when the page is closed, layout tests involving plugins should not crash either. Review URL: http://codereview.chromium.org/385022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31716 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 50756:50820.japhet@chromium.org2009-11-1113-86/+49
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/391019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31715 0039d316-1c4b-4281-b951-d872f2087c98
* Moving samples into docs/examples.erikkay@chromium.org2009-11-1156-866/+450
| | | | | | | | | | | | | | Also did a little cleanup of a few of the samples. More cleanup still to go... BUG=26106 TEST=none Review URL: http://codereview.chromium.org/390013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31714 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to the new extensions default icon.finnur@chromium.org2009-11-114-3/+4
| | | | | | | | | | | BUG=27399 TEST=Extensions without an icon now have a light-blue puzzle-piece icon when installing/uninstalling them and when listing them on chrome://extensions. Review URL: http://codereview.chromium.org/384055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31713 0039d316-1c4b-4281-b951-d872f2087c98
* Update zoom/close/miniaturize button based on cursor location after the windowdmaclach@chromium.org2009-11-111-0/+12
| | | | | | | | | | | has been moved. BUG=27388 TEST=Click the zoom button on a browser window. Make sure the '+' disappears. Review URL: http://codereview.chromium.org/384054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31712 0039d316-1c4b-4281-b951-d872f2087c98
* A few more heuristic tweaks to missing/extra expectations in the dashboard.ojan@chromium.org2009-11-111-14/+39
| | | | | | | | | | | | | | 1. Ignore results that start with no data. 2. Ignore times for runs that crash/timeout. We shouldn't mark a test slow because it's slow when it crashes or times out. 3. Make the default platform be WIN, not WIN-XP. This matches test_expectations.txt. 4. Remove the outdated code that tried to pretend IMAGE == IMAGE+TEXT. It's been long enough that we've had IMAGE+TEXT that we don't need to care about that. We still support that FAIL == IMAGE || TEXT || IMAGE+TEXT. Review URL: http://codereview.chromium.org/384052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31711 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: pkastingakalin@chromium.org2009-11-113-308/+50
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31710 0039d316-1c4b-4281-b951-d872f2087c98
* Added RemoveGroupFromView().akalin@chromium.org2009-11-111-3/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31709 0039d316-1c4b-4281-b951-d872f2087c98
* Made RemoveViewFromView() handle top-most subviews.akalin@chromium.org2009-11-111-3/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31708 0039d316-1c4b-4281-b951-d872f2087c98
* Added vertical shift for sync stuff.akalin@chromium.org2009-11-111-5/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31707 0039d316-1c4b-4281-b951-d872f2087c98
* Grouped sync controls and remove them properly.akalin@chromium.org2009-11-113-179/+119
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31706 0039d316-1c4b-4281-b951-d872f2087c98
* Redid sync prefs.akalin@chromium.org2009-11-111-6/+192
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31705 0039d316-1c4b-4281-b951-d872f2087c98
* Moved pref stuff to the right place.akalin@chromium.org2009-11-111-10/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31704 0039d316-1c4b-4281-b951-d872f2087c98
* Added bookmark sync stuff to UI.akalin@chromium.org2009-11-111-21/+42
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31703 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented sync button action.akalin@chromium.org2009-11-112-0/+26
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31702 0039d316-1c4b-4281-b951-d872f2087c98
* Hooked up sync service to preferences dialog.akalin@chromium.org2009-11-112-2/+78
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31701 0039d316-1c4b-4281-b951-d872f2087c98
* Dep roll for gyp to r750.thestig@chromium.org2009-11-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31700 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak in BackingStore as shown by valgrind. XFree doesn't freesky@chromium.org2009-11-111-2/+2
| | | | | | | | | | | the data of the image, where as XDestroyImage does. BUG=none TEST=none Review URL: http://codereview.chromium.org/386003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31699 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplicate test expectation.mpcomplete@chromium.org2009-11-111-1/+0
| | | | | | | | TBR=dpranke Review URL: http://codereview.chromium.org/387029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31698 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 10:18:53 +0000