| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added support for anchor (url fragments). this involves
mainly implementing IPersistHistory. The rest of the stuff
is a song and dance to get called in IPersistHistory in the
first place and then behave correctly when we do.
BUG=23981
TEst=unit tests added and back forward with '#' URLs, sub frames etc.
Review URL: http://codereview.chromium.org/371004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The seccomp sandbox is conditional on ARCH_CPU_X86_FAMILY. When
building for !ARCH_CPU_X86_FAMILY the variable g_proc_fd is
unused, leading to a build error when -Werror is turned on.
Review URL: http://codereview.chromium.org/397040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the purposes of computing statistics at the end and for the sake
of the layout test dashboard.
Flaky tests are listed as follow:
Flaky: Unexpected image failures (1):
LayoutTests/media/video-transformed.html = IMAGE PASS
For now, they won't turn the bot red or yellow. I'll submit
a following change to the log parser to turn the bot yellow
when there is unexpected flakiness.
Also, removed an extraneous commandline flag and a couple
extraneous logging statements.
Review URL: http://codereview.chromium.org/402058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
XP bots were failing on directory Delete. Removing ASSERT_TRUE for deletes solves the problem.
Review URL: http://codereview.chromium.org/408009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=no CRLFs
BUG=none
TBR=jam
Review URL: http://codereview.chromium.org/407009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Don't go off end of screen. push_in doesn't actually work as well as one might hope.
BUG=27800
Review URL: http://codereview.chromium.org/408017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upstream changes are:
fix a few compiler warnings and make the code more exception safe.
correctly support decomposed forms of two or three part matras
fix shaping of assamese ra
fix bug with Malayalam Samvruthokaram.
add N'Ko support to the arabic shaper
Post substitutions should apply to the whole indic syllable
Review URL: http://codereview.chromium.org/408013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
little (helpeful to make it use ChildProcessLauncher). Note that the test isn't needed anymore as a unit test because since it was written, there have been a couple of tests that exercise this code path through browser_tests. They use sandboxed utility processes so it's more equivalent to what the user experiences.
Review URL: http://codereview.chromium.org/402074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed some style violations.
Made HtmlDialogWindowDelegateBridge stop doing anything after it receives a close notification.
This fixes the crash described in issue 28039.
BUG=28039
TEST=trybots,manual
Review URL: http://codereview.chromium.org/402065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/404033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=541
TEST=None
Review URL: http://codereview.chromium.org/399094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/51088.
You can see the proof at: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=char-encoding&showExpectations=true&showLargeExpectations=true&maxResults=500
TBR=ojan
BUG=9798
TEST=layout test try servers
Review URL: http://codereview.chromium.org/404037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tabs dialogs to a tree view.
Nib changes: Removed the NSBrowser and added an NSOutlineView.
BUG=26647,26643,26718,27634
TEST=Bring up the bookmark editor by control-clicking in the bookmarks bar and selecting Add Page... or by selecting the Bookmark this Page... menu item found in the Bookmarks menu. Observe that the folder presentation is now a tree view. Select any folder and click New Folder to verify that new folders can be added. Double-click on the newly created folder to change its name. Added folders will not commit until OK is pressed, which will require that a bookmark actually be added. Also bring up the Bookmark All Tabs dialog by control-clicking in the tab bar with more than one tab open and verify that the folder structure is shown in a tree view.
Review URL: http://codereview.chromium.org/393006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it easy to defend changing a test because you have the numeric evidence of "this test was flaky 43% of the time before".
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jparent
TEST=good eye
BUG=21510
Review URL: http://codereview.chromium.org/403021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but we don't care.
BUG=28179
TEST=none
Review URL: http://codereview.chromium.org/404036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10342
TEST=none
Review URL: http://codereview.chromium.org/399091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
Some crashers on window close have been fixed so let's try running this again. I was unable to repro from running the test in a loop for a few hours.
TBR=erikkay
Review URL: http://codereview.chromium.org/408016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/404035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28179
TEST=valgrind bot goes green.
TBR=tony
Review URL: http://codereview.chromium.org/406008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Enable bookmarks on Linux. The dialog should no longer be too large.
Review URL: http://codereview.chromium.org/402070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and fix includes so service side and compile
with system GL and client side can compile
with Command Buffer GL.
Review URL: http://codereview.chromium.org/407006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/373001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequestContext it was using for downloads is destroyed.
This avoids the possibility of accessing freed memory when sharing ProxyService amongst request context, and the main context is destroyed first.
BUG=25338
Review URL: http://codereview.chromium.org/387065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/405022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also mostly fix the placement of the "For quick access, place your bookmarks here [...]" message (when there are no bookmarks). It's not quite right in the new animation (detached <-> normal).
BUG=25600, 27692, 27693
TEST=Go to NTP and press Cmd-Shift-B a few times while watching closely. The detached bar should "morph" smoothly to the normal bar and vice versa. Switch themes and repeat; please test at least the default theme and the Brushed theme.
Review URL: http://codereview.chromium.org/400020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
when you lstrcat a NULL string (in the case where there are no
additional parameters).
BUG=none
TEST=windbg mini_installer.exe, should see no first-chance access violation
Review URL: http://codereview.chromium.org/408012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28179
TEST=none
Review URL: http://codereview.chromium.org/406007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r32410. Stupid tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/402067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to send an NPN_SetException back to the correct renderer if necessary. BUG=26764 TEST=none
Review URL: http://codereview.chromium.org/375005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
newest cache.
TEST=test added to catch bug
BUG=none
Review URL: http://codereview.chromium.org/399078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27103
TEST=Use xfce-stellar theme. There shouldn't be an inner box in the location bar and typing shouldn't cause text to move up and down.
Review URL: http://codereview.chromium.org/399087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently throw an error when loading the extension,
which is overly aggressive.
BUG=28158
TEST=Specify matches=file://* in the manifest for a
content script and make sure the extension still loads.
Review URL: http://codereview.chromium.org/402069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* SplitUrlAndTitle() can't fail, so it doesn't need to return a bool.
* assign() can do substrings in one shot
* Half the code used "*str =" and half "str->assign()", often right next to each other; pick one for consistency
* No need to calculate array sizes when we're the ones declaring them
* Use early return in a few places
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/405023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.
BUG= 27814, 25258, 27815
TEST= see various bugs.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32176
Review URL: http://codereview.chromium.org/385135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/403020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want to ever go out to disk when looking for data after
startup, since they can be changed by an update.
We *should* just be using the zygote, but the zygote is sandboxed-only
for now, and fixing that has a lengthy dependency graph. In the
interim, /proc/self/exe is the correct executable and exec'ing it should
work as long as the subprocess doesn't need any other files from the
Chrome directory.
BUG=22703
TEST=Start Chrome. Move away the entire Chrome directory; plugins
should still work.
Review URL: http://codereview.chromium.org/403018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
given the current design and triggers a crash. I'm also effectively
disabling DockInfo for ChromeOS as that triggers a crash. I don't
believe we'll hit the code after my first change, but I'm going for
completeness.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
How did this happen?
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/402068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Forward exceptions in child processes to Apple's Crash Reporter
BUG=22659
TEST=none
Review URL: http://codereview.chromium.org/406006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involves implementing row-at-a-time and line-at-a-time repainting of the backing store.
R=darin
BUG=21510
TEST=LayoutTests/fast/repaint/shadow-multiple*
Review URL: http://codereview.chromium.org/397027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/405021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=28159
TEST=Flash 10.1 pre-release should use Cocoa event model (which currently means playback stalls when there are no mouse events coming in).
Review URL: http://codereview.chromium.org/399079
TBR=amanda@chromium.org
Review URL: http://codereview.chromium.org/402064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28159
TEST=Flash 10.1 preview should work reasonably well.
Review URL: http://codereview.chromium.org/399079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22210 (this is not a partial mitigation, not a fix)
Review URL: http://codereview.chromium.org/399043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on out of memory.
BUG=27222
TEST=new base unittests
Review URL: http://codereview.chromium.org/391044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference in upstream repaint areas as compared to upstream results is due the difference in repaint logic.
Safari/Mac port uses NSView's native rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/400024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Change your password after logging into bookmark sync, then restart your browser. There should be a warning button on the bookmark bar now.
Review URL: http://codereview.chromium.org/387054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32391 0039d316-1c4b-4281-b951-d872f2087c98
|