| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on 'using namespace icu'.
This is Chrome's counterpart to the ICU header change that disables
'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece.
The webkit change (which is minor) will be dealt with in the webkit bugzilla.
This can go in before the ICU change/upgrade without affecting anything.
BUG=8198
TEST=All the targets are built without an error on all platforms.
Review URL: http://codereview.chromium.org/171012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary since ProxyService is getting shared between chrome's url request contexts (off the record, media), and the current way it is being shared could result in free memory read/writes during shutdown.
This is a step towards fixing http://crbug.com/15289.
BUG=http://crbug.com/15289
TEST=The existing tests should continue to pass following this refactor.
Review URL: http://codereview.chromium.org/165430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
also change the interface for SimulateOSKeyPress()/SendKeyPress() to take a VKEY_ value (defined in base/keyboard_codes.h) rather than a VK_ value.
BUG=19076
Review URL: http://codereview.chromium.org/171079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19546
TEST=green
Review URL: http://codereview.chromium.org/172079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19433
TEST=obvious
Review URL: http://codereview.chromium.org/171077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to http://trac.webkit.org/changeset/47229
LayoutTests/css1/font_properties/font_family.html
Due to http://trac.webkit.org/changeset/47173
LayoutTests/fast/canvas/canvas-zoom.html
Due to http://trac.webkit.org/changeset/47255
LayoutTests/fast/block/float/avoidance-percent-width-compat.html
LayoutTests/fast/block/float/avoidance-percent-width-strict.html
LayoutTests/fast/block/float/035.html
LayoutTests/fast/block/float/float-avoidance.html
LayoutTests/tables/mozilla/bugs/bug106158-1.html
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/172065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recursion overflow).
I used https://bugzilla.redhat.com/attachment.cgi?id=356032 and fixed the issue with lint vs. tabs.
BUG=19158
TEST=http://cevans-app.appspot.com/static/CVE-2009-2416.xml
Review URL: http://codereview.chromium.org/172025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/171088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ben
Review URL: http://codereview.chromium.org/171092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes the Combobox* source arg from the Model methods, which wasn't really used by anything.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
MemoryDetails::StartFetch() isn't implemented, thus it was never signalling that it was done fetching memory details. Now it does.
BUG=15418
Review URL: http://codereview.chromium.org/172052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Now we can serve byte range requests from cached 200s.
* When we receive 304 we make sure that we were expecting it.
* A range request that doesn't fit the currently stored entry
only deletes the entry if the server confirms that it has
changed.
* Make sure that LOAD_ONLY_FROM_CACHE causes cache misses for
byte range requests.
BUG=12258
TEST=unittests
Review URL: http://codereview.chromium.org/165479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18672
TEST=run videos in debug mode and watch for DCHECK.
Review URL: http://codereview.chromium.org/170019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19521
TEST=Go to http://htmlfive.appspot.com/static/video.html and it will play.
r23255 introduced a regression that causes an extra seek in the
beginning of playing a video file. This extra seek causes FFmpeg
to look for index at the end of file which issue a range request
at the end of the file.
Review URL: http://codereview.chromium.org/171084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
sending us paths with .. in them.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/171025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings us in line with Firefox's behavior. Ctrl-L highlights
the URL but doesn't update the PRIMARY selection, so Ctrl-C is a
common* way to get the current location into PRIMARY so you can
middle-click somewhere else to paste it.
* I use it and a user mentioned that they do too. :-P
Tested as follows:
- highlight some text on the page to make it PRIMARY
- hit Ctrl-L and confirm that text on page is still PRIMARY
- hit Ctrl-C and confirm that location is now PRIMARY
- repeat, but this time hit the right arrow key between Ctrl-L
and Ctrl-C to unhighlight the text first. the text on the
page should remain the PRIMARY selection
BUG=18403
TESTED=see above
Review URL: http://codereview.chromium.org/164539
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also makes the label look native. I can't get the label inside the entry,
though.
http://crbug.com/17962
Review URL: http://codereview.chromium.org/172069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=michaeln@chromium.org
TEST=none
BUG=19544
Review URL: http://codereview.chromium.org/172076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/171078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=michaeln
BUG=19544
TEST=none
Review URL: http://codereview.chromium.org/172073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There are no significant logic changes except the addition of a link which points to the web ui.
BUG=none
Review URL: http://codereview.chromium.org/172007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Hopefully this will fix issue 12711.
R=eroman,mark
BUG=http://crbug.com/12711
TEST=covered by existing unit tests and normal browsing on Mac
Review URL: http://codereview.chromium.org/172061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=eroman
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=eroman
Review URL: http://codereview.chromium.org/171083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=interactive ui tests builds and runs and BrowserFocusTest.TabInitialFocus passes
Review URL: http://codereview.chromium.org/172059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19353
TEST=None
Review URL: http://codereview.chromium.org/165538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Command:
awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' *.cc *.h
# recursive
find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) >
80 ) { print FILENAME, FNR, $0 } }' {} \;
Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>
BUG=None
TEST=None
Code review URL: http://codereview.chromium.org/164566
Review URL: http://codereview.chromium.org/171066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=19440
Review URL: http://codereview.chromium.org/171069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
work on actually fleshing out some tests in the next CL.
Review URL: http://codereview.chromium.org/171032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EV checks must fail because EV requires revocation checking. (We aren't
downloading CRLs yet.)
R=willchan
BUG=18907,10911
TEST=Visit EV websites such as https://www.paypal.com/ and
https://www.verisign.com/. Chromium must not show the EV status because
it is not doing OCSP checks.
Review URL: http://codereview.chromium.org/172050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I gained at least 30s by doing that, and there is still room for improvement!
I'm doing changes step-by-step to make sure it won't break mysteriously.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/172057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14478
Review URL: http://codereview.chromium.org/172020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by unit_tests and other automated tests.
http://crbug.com/19202
Review URL: http://codereview.chromium.org/164518
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
progress and we'll pick up the other countries eventually.
Added some temporary comments on the Bing entry since the way it's coexisting with the Live entries right now makes for a few slightly unusual bits.
BUG=13065
TEST=Search providers should show Bing and not Live Search, setting Bing to default should result in working Suggest and search functionality.
Review URL: http://codereview.chromium.org/171065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TCPClientSocketPool.
Tracks the number of each socket type returned by the TCPClientSocketPool.
Also tracks the number of recoverable IO errors (resets, aborts, closes) per socket type.
Also tracks the idle time of a socket before a recoverable IO happens.
Review URL: http://codereview.chromium.org/171048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Fixes a simple trace.
BUG=none
Review URL: http://codereview.chromium.org/171053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
can be called when we don't have a URLContext from which to return cookies.
Previously we crashed, this patch just logs an error and returns an empty string instead.
BUG=http://crbug.com/10706
Review URL: http://codereview.chromium.org/171050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
border-radius change is http://trac.webkit.org/changeset/46508
webkit-animation-play-state change is http://trac.webkit.org/changeset/46547
I'm deleting the linux baselines because they match the
windows baselines (so we don't need them because of our
fallback logic).
BUG=17974
Review URL: http://codereview.chromium.org/171008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
be connected to navigator.getStorageUpdates() once an upstream change goes
through.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/171009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory.
Note: There is the issue that the scons build does not
have the correct dependencies to make sure the samples
get copied to the artifacts before selenium runs.
If that's a 1 line fix then let's add it. Otherwise
we can fix that in the gyp build?
Review URL: http://codereview.chromium.org/172008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing a patch for Thiago Farina, original CL:
http://codereview.chromium.org/171026
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/172048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to get the IO thread's message loop when it was going away. Do the same acrobatics as in BufferedResourceHandler by going to the UI thread first, and doing refcounting manually.
Also fix an issue I saw by inspection in BufferedResourceHandler, where Release should be called at the end of the function.
BUG=19415
Review URL: http://codereview.chromium.org/171055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and instead accesses the attributes directly.
BUG=none
TEST=none
TBR=jparent
Review URL: http://codereview.chromium.org/172053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When building with use_system_libpng, the build will end up using the
png.h from third_party because I put the defines stanza in the wrong
place.
(reported by fta)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/172056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
causes a build breakage.
Review URL: http://codereview.chromium.org/172051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These targets include from third_party/bzip2 but list it in
dependencies. This means that they don't get the
direct_dependents_settings and this is breaking the Ubuntu package
building with use_system_bzip2.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23556 0039d316-1c4b-4281-b951-d872f2087c98
|