summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix a crash when a moust observer got a mouse event on a wnidow that has ↵oshima@chromium.org2010-03-171-2/+3
| | | | | | | | | | | | already been destroyed. BUG=chromium-os:1697 TEST=manual: switch to compact nav bar mode (ctrl-shift-c), move mouse to a tab to open compact location bar, then open app launcher. Type in something in the address bar and select from suggestion list. Review URL: http://codereview.chromium.org/1048003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41788 0039d316-1c4b-4281-b951-d872f2087c98
* Spruced up the warning dialog for when you enable an extension in incognito.mpcomplete@chromium.org2010-03-179-88/+140
| | | | | | | | | | | I hijacked the extension install/uninstall dialog, and added another type that it can transmogrify into. BUG=32365 Review URL: http://codereview.chromium.org/1041002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41787 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations of mouse-events now that I took out the console ↵jam@chromium.org2010-03-161-5/+0
| | | | | | | | | logging of "adjustCursorEvent". This matches DRT. TBR=stuartmorgan Review URL: http://codereview.chromium.org/1002007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41785 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41781 - Revert 41769 Fix test_shell so that eventSender works for ↵jam@chromium.org2010-03-1613-41/+73
| | | | | | | | | | | | | | | | opened windows. I've also made focus go to the webview, just like what happens in Chrome. This is needed for https://bugs.webkit.org/show_bug.cgi?id=36147 and also fixes plugins/keyboardevents.html on Windows. Review URL: http://codereview.chromium.org/1011005 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/997008 TBR=stuartmorgan@chromium.org Review URL: http://codereview.chromium.org/990005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41784 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for new Mac UI valgrind failurestuartmorgan@chromium.org2010-03-161-0/+14
| | | | | | | | | | | TBR=thestig BUG=38357 TEST=Mac UI valgrind bots Review URL: http://codereview.chromium.org/1002006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41783 0039d316-1c4b-4281-b951-d872f2087c98
* Finish porting FindInPageControllerTest to linux.estade@chromium.org2010-03-165-50/+62
| | | | | | | | | BUG=37809,268629 TEST=test passes Review URL: http://codereview.chromium.org/997004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41782 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41769 - Fix test_shell so that eventSender works for opened windows. ↵stuartmorgan@chromium.org2010-03-1613-73/+41
| | | | | | | | | | | | | I've also made focus go to the webview, just like what happens in Chrome. This is needed for https://bugs.webkit.org/show_bug.cgi?id=36147 and also fixes plugins/keyboardevents.html on Windows. Review URL: http://codereview.chromium.org/1011005 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/997008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41781 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes first and third points in the bug "Autofill profile dialog box polish ↵georgey@chromium.org2010-03-1612-79/+131
| | | | | | | | | | | | | items". Adds correct expand icons to the AutoFill dialog. The icons were added in a separate CL. Moves asynchronous access to the database inside the dialog (it now shows "Loading..." while db is being connected) Also fixes memory leak. BUG=36601 TEST=in the bug Review URL: http://codereview.chromium.org/669076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41780 0039d316-1c4b-4281-b951-d872f2087c98
* Remove eval/new Function from file browser.arv@chromium.org2010-03-161-27/+63
| | | | | | Review URL: http://codereview.chromium.org/969005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41779 0039d316-1c4b-4281-b951-d872f2087c98
* Use the full URL of the icon in the notification, not just the string passed ↵johnnyg@chromium.org2010-03-161-1/+1
| | | | | | | | | | | in -- so that that string doesn't have to be absolute. BUG=32840 TEST=use a relative icon URL. Review URL: http://codereview.chromium.org/1050001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41778 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline a another passing test and remove errant baselines.dglazkov@chromium.org2010-03-169-44/+7
| | | | | | | | | | TBR=dpranke TEST=none BUG=none Review URL: http://codereview.chromium.org/1040004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41777 0039d316-1c4b-4281-b951-d872f2087c98
* IE6 would not switch to ChromeFrame if the url being navigated to contained ↵ananta@chromium.org2010-03-164-3/+39
| | | | | | | | | | | | | | | | | | | | | an anchor. This is presumably because from IE6's perspecive nothing changed. To workaround this issue, we stash the complete url away in the navigation manager and remove it from the URL being navigated to. When the Chrome active document loads we read the actual url from the navigation manager and initiate a navigation to this URL. There is one issue with this approach though. The actual URL in the address bar in IE6 does not contain the anchor tag. Will address that in a follow up CL. This fixes bug http://code.google.com/p/chromium/issues/detail?id=38265 Bug=38265 Test=Covered by existing ChromeFrame anchor URL navigation tests. Review URL: http://codereview.chromium.org/1022003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41776 0039d316-1c4b-4281-b951-d872f2087c98
* Add new worker-map-gc.html layout test to worker's ui_tests suite.dimich@chromium.org2010-03-161-0/+12
| | | | | | | | | BUG=none TEST=the added one Review URL: http://codereview.chromium.org/989005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41775 0039d316-1c4b-4281-b951-d872f2087c98
* This patch strips out the http auth credentials before storing it in History DB.inferno@chromium.org2010-03-164-6/+32
| | | | | | | | BUG=20318 TEST=Visit a url having auth credentials. Check history db to see url stored without credentials. Review URL: http://codereview.chromium.org/1012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41773 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple more drop targets to the render view.estade@chromium.org2010-03-161-0/+16
| | | | | | | | | BUG=35063 TEST=see bug Review URL: http://codereview.chromium.org/1030001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41772 0039d316-1c4b-4281-b951-d872f2087c98
* Changing filebrowse html to delete pause when file is finished.dhg@chromium.org2010-03-162-3/+11
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/845003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41770 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test_shell so that eventSender works for opened windows. I've also made ↵jam@chromium.org2010-03-1613-40/+72
| | | | | | | | | | focus go to the webview, just like what happens in Chrome. This is needed for https://bugs.webkit.org/show_bug.cgi?id=36147 and also fixes plugins/keyboard-events.html on Windows. Review URL: http://codereview.chromium.org/1011005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41769 0039d316-1c4b-4281-b951-d872f2087c98
* Move over another legacy "LoadLog-style" event generator to routing its ↵eroman@chromium.org2010-03-169-57/+129
| | | | | | | | | | messages through the NetLog. BUG=37421 Review URL: http://codereview.chromium.org/1052002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41768 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes changing the size of the icon on hover, and instead changessky@chromium.org2010-03-161-13/+10
| | | | | | | | | | | | the size of the icon when the tab is in the background and the title changes. BUG=37333 TEST=none Review URL: http://codereview.chromium.org/974003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41767 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline a large chunk of tests whose failures had gone unnoticed while ↵dglazkov@chromium.org2010-03-1636-579/+202
| | | | | | | | | | | | the build bot was borked. TBR=dpranke TEST=none BUG=37896 Review URL: http://codereview.chromium.org/1015007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41766 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Load the imported form data into the AutoFill dialog when the user ↵jhawkins@chromium.org2010-03-166-11/+77
| | | | | | | | | | accepts the AutoFill InfoBar. Save a one-time initial profile to the WebDB if the user dismisses the InfoBar or the InfoBar closes. BUG=38104,38096 TEST=AutoFillInfoBarDelegateTest Review URL: http://codereview.chromium.org/974004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41765 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 issues with incognito extensions on linux:mpcomplete@chromium.org2010-03-162-4/+9
| | | | | | | | | | - Drag and drop of browser actions wouldn't work properly from an incognito window. - Installing an extension from an incognito window raised a DCHECK. Review URL: http://codereview.chromium.org/983004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41764 0039d316-1c4b-4281-b951-d872f2087c98
* Mark fast/events/touch tests as flaky on WINgdk@chromium.org2010-03-161-0/+3
| | | | | | | | | BUG=38347 TEST=fast/events/touch Review URL: http://codereview.chromium.org/1053001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41763 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to r56073.darin@chromium.org2010-03-161-1/+1
| | | | | | | | | | TBR=yutak BUG=none TEST=none Review URL: http://codereview.chromium.org/1026004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41762 0039d316-1c4b-4281-b951-d872f2087c98
* Split up PreXmppAuth and SaslHandler.akalin@chromium.org2010-03-169-84/+122
| | | | | | | | | | | Created a X-GOOGLE-TOKEN-only SaslHandler class for use by sync. BUG=38034 TEST=manual Review URL: http://codereview.chromium.org/904006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41761 0039d316-1c4b-4281-b951-d872f2087c98
* Unify LocalStrings.arv@chromium.org2010-03-166-38/+57
| | | | | | | | | | | The main difference is that we are now using $1 - $9 instead of %s. This is more consistent with the C++ code as well. BUG=None TEST=None Review URL: http://codereview.chromium.org/1045003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41760 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] First run dialog cleanupthomasvl@chromium.org2010-03-163-213/+386
| | | | | | | | | | | | | | | | - coding style fixes for ivars - fixed some 10.6 toolchain warnings from the xib - provide custom getters for two properties to always return false when the matching controls are hidden. - Autosize the window to handle any possible l10n now - Make headers, buttons, and all by the stats/breakpad checkbox force the window to grow as needed. - Wrap the stats/breakpad checkbox to the resulting width (it will never fit otherwise). - Layout/shuffling things based on the views that get hidden (no other browsers to import from, not stats pref). BUG=37743 TEST=text isn't clipped in any language Review URL: http://codereview.chromium.org/995002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41758 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to AutoFill sql Crash Reportdhollowa@chromium.org2010-03-161-1/+1
| | | | | | | | | | | | | Fix for Crash Report: http://go/crash/reportdetail?reportid=7ea9ff0f4697aa57 The AutoFill sql assertion logic was constructing an std::string from 0 when invalid data was encountered. This caused a c++ exception and then program termination. Correct logic is to return empty string. Note, this fix does not address the underlying database corruption, only the crash. BUG=38241 TEST=none Review URL: http://codereview.chromium.org/1016004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41757 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an issue where the schema for the callback parameters to onInportBegan ↵arv@chromium.org2010-03-161-8/+3
| | | | | | | | | | | and onImportEnded was invalid. BUG=None TEST=Import or export from the bookmark manager and notice that you no longer ger an exception Review URL: http://codereview.chromium.org/896002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41756 0039d316-1c4b-4281-b951-d872f2087c98
* The plugin channel host in the renderer process should not initialize IPCmark@chromium.org2010-03-163-1/+27
| | | | | | | | | | | | | | | | | | | | | using a known-closed channel name. Instead, when the channel name is known to be closed, initialization should fail. On POSIX systems, the channel is created by the plugin channel in the plugin process and shared with the renderer process over IPC. If the channel closes, the renderer process must not attempt to reestablish it; the plugin process must do that. This serves as early detection for and an escape from the assertion that causes renderers to die and be replaced by a sad tab when attempting to open multiple pages with plugins simultaneously. This resolves the Mac renderer top crash. BUG=26754 TEST=Test case from bug 26754 comment 9 (affected Macs only): a. Have lots of bookmarks (import Safari defaults) b. Right-click on bookmark bar, and choose "Open All Bookmarks" Expect: no crash, no sad tabs. This test should be repeated many times. Review URL: http://codereview.chromium.org/984004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41755 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome frame should use "parentNode" instead of "parentElement" to get the DOMrogerta@chromium.org2010-03-161-1/+1
| | | | | | | | | | | | parent of the plugin, since this is more compatible. Also, "parentElement" no longer works in FF3.6. BUG=0 TEST=n/a Review URL: http://codereview.chromium.org/1033001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41754 0039d316-1c4b-4281-b951-d872f2087c98
* Obj-C readability review for thakis.thakis@chromium.org2010-03-163-19/+23
| | | | | | Review URL: http://codereview.chromium.org/790006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41753 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed problem with Pepper 3D plugins not rendering on Mac OS X if theykbr@google.com2010-03-162-8/+14
| | | | | | | | | | | only expect to repaint once. BUG=37961 TEST=OS X: ran Pepper test plugin, GLES2 book demos as trusted Pepper plugins Review URL: http://codereview.chromium.org/1023001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41751 0039d316-1c4b-4281-b951-d872f2087c98
* Dom access checker test for Mac, Linuxnirnimesh@chromium.org2010-03-164-1/+41
| | | | | | | | | | BUG=35530 TEST=dom_checker should work and pass on mac & linux ui_tests --gtest_filter=DomCheckerTest.* --run-dom-checker-test Review URL: http://codereview.chromium.org/898002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41750 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Use the default favicon until chrome://favicon/ works for ↵arv@chromium.org2010-03-162-2/+7
| | | | | | | | | | | extensions. BUG=None TEST=None Review URL: http://codereview.chromium.org/898004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41749 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bubbles (bookmark, status, blocked content, both extension ones) in ↵avi@chromium.org2010-03-167-36/+51
| | | | | | | | | | | resolution independence. BUG=http://crbug.com/19476, http://crbug.com/36366 TEST=click the star in RI and the bubble should position itself correctly; status bubble should have adequate height for text Review URL: http://codereview.chromium.org/851009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41748 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41739 - Factoring duplicate code from platformspecific LoginHandlers ↵erg@chromium.org2010-03-165-305/+618
| | | | | | | | | | | | | | | | | | | | into a base LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. TBR=erg@chromium.org Review URL: http://codereview.chromium.org/989004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41746 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the touch events tests.gdk@chromium.org2010-03-161-3/+4
| | | | | | | | | BUG=36415 TEST=fast/events/touch Review URL: http://codereview.chromium.org/887001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41745 0039d316-1c4b-4281-b951-d872f2087c98
* [accessibility] Bookmarks bar is missing some MSAA informationctguil@chromium.org2010-03-166-34/+65
| | | | | | | | | | | | | | | | | | | | | | | Return the link role for the Link view. Return the grouping role for BookmarkBarInstructionsView. Support the link role in views accessibility types. Updated browser views accessibility tests. - Verify BrowserRootView accessibility info. - Verify BrowserView accessibility info. - Verify BookmarkBarView accessibility info. - In TestViewAccessibilityObject don't SetAccessible name, we should be testing that this name is correctly set. Set the accessible name for the application in BrowserRootView instead of OpaqueBrowserFrameView BUG=36281 TEST=Verify bookmarks bar tree in AccExplorer32.exe Review URL: http://codereview.chromium.org/652156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41744 0039d316-1c4b-4281-b951-d872f2087c98
* Refine IPv6 probe to require that the client has an IPv6 address on an interfacejar@chromium.org2010-03-164-49/+238
| | | | | | | | | | | | | | | | | | | | This currently only works on Posix, not windows. Network changes are monitored, and the test is repeated each time interfaces change (which is a subset of any IP addresses changing). The test performed is performed on a worker thread, so latency should not be an issue (even if we created much slower tests). The current test appears to takes in the raneg of 50-100ms, and probably (under the covers) does some reading from files). BUG=25680 BUG=12754 r=wtc,eroman Review URL: http://codereview.chromium.org/1006001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41743 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Ignoring optional client-cert requests from serversnej@chromium.org2010-03-161-24/+76
| | | | | | | | | BUG=37765 TEST=none Review URL: http://codereview.chromium.org/746002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41742 0039d316-1c4b-4281-b951-d872f2087c98
* Update flakiness dashboard to load dashboard_base.js from current and sub ↵victorw@chromium.org2010-03-161-0/+4
| | | | | | | | | | | | | | directory. This is a temporary solution for migrating flakiness dashboard to AE. R=ojan BUG=none TEST=flakiness dashboard Review URL: http://codereview.chromium.org/1048001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41740 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring duplicate code from platform-specific LoginHandlers into a baseerg@chromium.org2010-03-165-618/+305
| | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41739 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix test crash expectations for MetricsServiceTest.CrashRenderers.thestig@chromium.org2010-03-161-2/+3
| | | | | | | | BUG=none TEST=MetricsServiceTest.CrashRenderers passes on Linux with and without breakpad. Review URL: http://codereview.chromium.org/1010001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41738 0039d316-1c4b-4281-b951-d872f2087c98
* Infer caps lock state to set for Mac plugin eventsstuartmorgan@chromium.org2010-03-161-0/+24
| | | | | | | | | BUG=38098 TEST=Plugins should know when caps lock is active. Review URL: http://codereview.chromium.org/989002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41737 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41728 - Fix of the initial locale set.glotov@chromium.org2010-03-161-7/+0
| | | | | | | | | | | | | | | BUG=35248 TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard. Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"): out/Debug/chrome loginmanager loginscreen=network Check that the next time you start chromium, the selected language will be the default. Review URL: http://codereview.chromium.org/985001 TBR=glotov@google.com Review URL: http://codereview.chromium.org/1015006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41736 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Chrome Frame product name to the localized .grd files.robertshield@chromium.org2010-03-164-5/+17
| | | | | | | | BUG=24305 Review URL: http://codereview.chromium.org/996005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41735 0039d316-1c4b-4281-b951-d872f2087c98
* Send cross frame accesses which WebKit reports to UMA.johnnyg@chromium.org2010-03-162-1/+32
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/668129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41733 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use the empty string to try to match against an empty text field. Add ↵jhawkins@chromium.org2010-03-167-10/+111
| | | | | | | | | | FormField::ParseEmptyText which encapsulates matching an empty text field. BUG=38264 TEST=FormStructureTest.HeuristicsSample6 Review URL: http://codereview.chromium.org/994002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41732 0039d316-1c4b-4281-b951-d872f2087c98
* ssl_SecureSend should not do handshake when the handshake wait state iswtc@chromium.org2010-03-163-62/+104
| | | | | | | | | | | wait_finished and we are false starting. R=agl BUG=38103 TEST=SSLClientSocketTest.Read_FullDuplex should not hang on Ubuntu Karmic. Review URL: http://codereview.chromium.org/850008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41731 0039d316-1c4b-4281-b951-d872f2087c98