| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
longer accurate.
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/972003
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/1002001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/972003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So we will know which of the buttons the user clicked on.
BUG=23643
TEST=none
Patch from Thiago Farina <thiago.farina@gmail.com>
TBR=ben
Review URL: http://codereview.chromium.org/975002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I can't repro it locally :-(
TBR=ananta
BUG=none
Review URL: http://codereview.chromium.org/999001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/973002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
Review URL: http://codereview.chromium.org/899006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rolled back MainMenu.xib to before r40905
<http://codereview.chromium.org/660438> and re-did the changes.
BUG=none
TEST=Open MainMenu.xib in Interface Builder; should be able to open Chrome main; should be able to save and re-open MainMenu.xib successfully. Show Full History menu should appear as after r40905 (at bottom of History menu, with favicon) and work properly.
Review URL: http://codereview.chromium.org/990001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added some more logging.
TBR=sra
Review URL: http://codereview.chromium.org/988002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes all tests/adjusts expectations for tests that have passed for the last 750 runs.
BUG=27418,29167,25889,25977,31026,16240,9798,24930,10351,10861,31363,27334,26195,32690,16675,32691,32666,32306
TEST=none
Review URL: http://codereview.chromium.org/907003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38080
Review URL: http://codereview.chromium.org/982001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=34823
Review URL: http://codereview.chromium.org/907005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38206
TBR=joth,jhawkins
Review URL: http://codereview.chromium.org/987001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/986001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(due to workqueue thread problem)
Review URL: http://codereview.chromium.org/981001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change blocks https://bugs.webkit.org/show_bug.cgi?id=36012
A follow-up will:
+ Remove the overloaded method (once WebKit lands).
+ Actually use the host.
Review URL: http://codereview.chromium.org/848003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
second invalid rect.
BUG=http://crbug.com/24779
TEST=See test case in bug. Gmail should paint correctly when returning from fullscreen.
Review URL: http://codereview.chromium.org/335029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37271,37433,37937
TEST=Go fullscreen on the NTP with the bookmark bar detached. Drag a bookmark around. Overlay should not open.
TEST=Go fullscreen on the NTP with the bookmark bar detached. Open a bookmark folder. Overlay should not open.
Review URL: http://codereview.chromium.org/881003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This should fix the ARM compile.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/974001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=37069
TEST=build works
Checking in patch from Thiago Farina <thiago.farina@gmail.com>, reviewed as:
http://codereview.chromium.org/945001/show
Review URL: http://codereview.chromium.org/970001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test has been flaky on Linux for some time, seems that the same issue have hit the Mac. It shows the same assertion failed as on Linux.
ASSERTION FAILED: item->documentSequenceNumber() == history()->currentItem()->documentSequenceNumber()
BUG=37962
TEST=Disabling tests
TBR=dglazkov@chromium.org
Review URL: http://codereview.chromium.org/949003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38192
TEST=Run chrome with --login-manager --login-screen=oobe should always trigger full OOBE flow (including network selection and update screens). Once user is signed in OOBE flow is not shown.
Review URL: http://codereview.chromium.org/964001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/945004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/661371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Launch with --login-manager --login-screen=update and verify that
progress bar shows increasing progress and login screen is shown at the
end.
Review URL: http://codereview.chromium.org/945003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
back at r41284).
BUG=None
TEST=New unit tests, tree should stay green after this checkin.
Revert "Reland translate toolbar unit tests (originally landed as r41274, rolled back at r41284)."
Revert r41569 - 10.6 unit tests not passing.
Review URL: http://codereview.chromium.org/962001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Change in xib file disables "avoid empty selection" which leads to an item in the tree already being selected when the dialog opens.
BUG=http://crbug/38069
TEST=manual testing and existing flaky unit test FLAKY_RemoveButtonEnabled
Review URL: http://codereview.chromium.org/841004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=37533,36280
TEST=In RTL layout drop down menues should be within Chrome window.
Review URL: http://codereview.chromium.org/782006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35596
TEST=export LANGUAGE=he. Launch chrome and enable compact nav bar. Location bar should appear under tabs.
Review URL: http://codereview.chromium.org/594059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
rolled back at r41284)."
Revert r41569 - 10.6 unit tests not passing.
Review URL: http://codereview.chromium.org/959001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
back at r41284).
BUG=None
TEST=New unit tests, tree should stay green after this checkin.
Review URL: http://codereview.chromium.org/938001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=phajdan.jr
Review URL: http://codereview.chromium.org/957001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37049
TEST=websocket/tests/httponly-cookie.pl passes
Review URL: http://codereview.chromium.org/801004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We'll have a separate dialog for each input method that has settings.
Review URL: http://codereview.chromium.org/889002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/951001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20703
TBR=jam
Review URL: http://codereview.chromium.org/950001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We include these new gypi files from webkit.gyp (used when building
within a chromium checkout) and from webkit_support.gyp (used when
building from within a webkit checkout).
TEST=everything still compiles
Review URL: http://codereview.chromium.org/840003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change enables Chromium users to use the new spellchecker dictionaries added by r39400, r40614, and r41000. This change also adds a unit test for Hungarian and rebaselines the unit test for Romanian. As written in Issue 33024, the correct Romanian characters are U+0219 and U+021B even though our old Romanian dictionary uses U+015F and U+0163. So, this change rebaselined to use the correct Romanian characters.
BUG=8397,15558,33024
TEST=unit_test.exe --gtest_filter=SpellCheckTest.SpellCheckText
Review URL: http://codereview.chromium.org/661460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Default/User StyleSheets/Custom.css instantly change layout in
all your tabs.
BUG=2393
Review URL: http://codereview.chromium.org/799005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it from using MessageLoop to post tasks to using
ChromeThread::PostTask, which is safer.
Review URL: http://codereview.chromium.org/864001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dependency.
TBR=darin
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
stuff, which is not yet available for OS X. While this is not commented out, first run dialog will *always* be bypassed.
BUG= none
TEST= you can get the 1st run dialog on Mac again.
Review URL: http://codereview.chromium.org/929001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/846008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closing out classes created on the IO Thread on the IO Thread. This didn't
cause problems before by luck; but now it does.
Have the cleanup run on a task on the IO Thread.
TBR=michaeln
BUG=none
TEST=AppCacheUpdateJobTest.
Review URL: http://codereview.chromium.org/934002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
backup socket request to retry the connect. This reduces latency in the
presence of packet loss.
BUG=36629
TEST=TCPClientSocketPoolTest.BackupSocket*
Review URL: http://codereview.chromium.org/842004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/851010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These locks can cause the IO thread to block on the FILE thread writing to
disk, which is bad news bears.
BUG=21518
TEST=No behavior change.
Review URL: http://codereview.chromium.org/904005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
modying some suppressions, and duplicating some others with
small differences.
BUG:38138
Review URL: http://codereview.chromium.org/926001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41536 0039d316-1c4b-4281-b951-d872f2087c98
|