summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* posix: stat() uses errno, not its return value, for errorsevan@chromium.org2010-03-251-1/+1
| | | | | | | | | | | | | l/stat() always return -1 on error, so we must examine errno if we want to handle errors specially. (This is only used for judging whether to print an error message, so it's not too harmful.) TEST=symlink to nowhere in a dir; Chrome should not complain about that symlink when enumerating files in the directory Review URL: http://codereview.chromium.org/1352001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42647 0039d316-1c4b-4281-b951-d872f2087c98
* Register internal plugins.viettrungluu@chromium.org2010-03-251-3/+7
| | | | | | | | | BUG=none TEST=none (but Gears should continue working on Windows) Review URL: http://codereview.chromium.org/1336002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42646 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: hide the current grab widget when showing an info bubble.estade@chromium.org2010-03-252-97/+54
| | | | | | | | | | | | | | | | | | Problem: Extension popups can take a while to appear after the user clicks the icon. If the user clicks something else that causes a grab (like a context or dropdown menu, or another info bubble), then that grab is shadowed and the widget behaves oddly (having two info bubbles open simultaneously, having an unclosable menu, etc.) Solution: Hide any widget that has a grab when the info bubble is being created. Delete info bubbles that get hidden. Etc.: You can still pretty easily get into a weird trapped state when the delayed info bubble interacts with tab dragging. BUG=none TEST=left click then quickly right click a browser action with extension popup Review URL: http://codereview.chromium.org/1317001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42645 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42631 as it seems to have broken browser tests on linux_views.aa@chromium.org2010-03-2518-172/+26
| | | | | | TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42644 0039d316-1c4b-4281-b951-d872f2087c98
* fix forgotton release that upsets valgrind on the mac unit testsdanno@chromium.org2010-03-251-0/+24
| | | | | | | | | BUG=none TEST=manual step-through of code Review URL: http://codereview.chromium.org/1344001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42643 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing valgrind issue temporarily. Introduced in r42586.dhollowa@chromium.org2010-03-252-13/+14
| | | | | | | | | BUG=39325 TEST=none Review URL: http://codereview.chromium.org/1241008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42642 0039d316-1c4b-4281-b951-d872f2087c98
* Added paths for internal plugins.viettrungluu@chromium.org2010-03-252-2/+36
| | | | | | | | | BUG=none TEST=none (but Gears should continue to work on Windows) Review URL: http://codereview.chromium.org/1340001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42641 0039d316-1c4b-4281-b951-d872f2087c98
* Add incognito guidelines to the overview.kathyw@chromium.org2010-03-252-3/+119
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/1324001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42640 0039d316-1c4b-4281-b951-d872f2087c98
* First part of new install dialog on Windows. Later changes willaa@chromium.org2010-03-255-30/+434
| | | | | | | | | | add tooltips and implementations on other platforms. BUG=29633 Review URL: http://codereview.chromium.org/1299002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42639 0039d316-1c4b-4281-b951-d872f2087c98
* Add info about favicons.kathyw@chromium.org2010-03-252-8/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1323001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42638 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the offical build by passing local state to the initialize metrics function.brettw@chromium.org2010-03-251-2/+3
| | | | | | | | | TEST=none BUG=none TBR=mmoss Review URL: http://codereview.chromium.org/1341001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42637 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserActionsContainerTest.Visibility for chromeos and reenable it.mpcomplete@chromium.org2010-03-255-9/+16
| | | | | | | | BUG=38992 Review URL: http://codereview.chromium.org/1310001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42636 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the exclusions from dom_checker tests that pass on the bots.nirnimesh@chromium.org2010-03-253-8/+0
| | | | | | | | | | | These are the tests that have been passing on the tests for quite some time. BUG=38018 TEST=dom_checker tests on the full release builders remain green. Review URL: http://codereview.chromium.org/1324002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42635 0039d316-1c4b-4281-b951-d872f2087c98
* Reenabling some unit-tests on Linux, they seem to work fine now,jcivelli@chromium.org2010-03-251-6/+0
| | | | | | | | | | | even with the screen locked. BUG=23394 TEST=Run the tests. Review URL: http://codereview.chromium.org/1286005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42634 0039d316-1c4b-4281-b951-d872f2087c98
* Add Geolocation to the content types. This adds several special case guards ↵joth@chromium.org2010-03-256-2/+16
| | | | | | | | | | | | | so we can still build & run whilst the full implementation is being worked on (in parallel) (Some code taken from http://codereview.chromium.org/650180) BUG=11246 TEST=Built & ran on all three platforms. Used geolocation & open content setting dialog. Review URL: http://codereview.chromium.org/1241006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42633 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:arv@chromium.org2010-03-252-46/+63
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42632 0039d316-1c4b-4281-b951-d872f2087c98
* Finish wiring up notifications in extensions.aa@chromium.org2010-03-2518-26/+172
| | | | | | Review URL: http://codereview.chromium.org/1076004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42631 0039d316-1c4b-4281-b951-d872f2087c98
* Undo Windows gyp split from r42397, and update for new gyp changes.mmoss@google.com2010-03-251-10/+3
| | | | | | Review URL: http://codereview.chromium.org/1239007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42630 0039d316-1c4b-4281-b951-d872f2087c98
* Move some stuff from BrowserMain into helper functions.brettw@chromium.org2010-03-252-55/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch changes the behavior slightly. We used to skip creation of the metrics service at all if it was disabled on the command line. But this was pretty confusing because it was still possible for it to be disabled by way of not uploading any data. And there were two places in the rest of the function that would crash if the metrics service was NULL (because you used the command line switch). After some archaeology, I discovered the command line switch was from before we had preferences and was then the only way to disable the metrics. Since we have prefs now and it defaults to off, I think the command line switch isn't useful, and the fact that it crashes sometimes further indicates this. So I just removed it. This does not remove the actual constant since that's used by ChromeFrame: once to make sure it's passed through when Chrome is spawend, and once in a test that command line switches are passed through. We'll have to remove these in a separate patch before removing the constant declaration. This also moves the WebSocketExperimentRunner starting from outside the "disable metrics" block. I think the intent was that it wouldn't be enabled if we weren't collecting metrics, but it wasn't actually working that way, so I just pulled it out to the top level of BrowserMain. TEST=none BUG=none Review URL: http://codereview.chromium.org/1251007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42629 0039d316-1c4b-4281-b951-d872f2087c98
* Makes adding a new folder from the bookmark context menu add thesky@chromium.org2010-03-256-53/+85
| | | | | | | | | | | | folder right after the selected item (when possible) rather than as the last element. BUG=9240 TEST=see bug Review URL: http://codereview.chromium.org/1253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42628 0039d316-1c4b-4281-b951-d872f2087c98
* Enable FtpNetworkTransactionTest.* and HttpNetworkTransactionTest.* underglider@chromium.org2010-03-251-2/+0
| | | | | | | | | | ThreadSanitizer on Mac. TBR=timurrrr Review URL: http://codereview.chromium.org/1237006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42627 0039d316-1c4b-4281-b951-d872f2087c98
* LanguageSwitch test.glotov@google.com2010-03-253-0/+61
| | | | | | | | | BUG=2039 TEST=out/Debug/browser_tests --gtest_filter=WizardControllerTest.SwitchLanguage Review URL: http://codereview.chromium.org/1239005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42626 0039d316-1c4b-4281-b951-d872f2087c98
* Update to current gtest/gmock.evan@chromium.org2010-03-2523-892/+1391
| | | | | | | | | | Synced in new gmock, twiddled DEPS for new gtest, updated README. BUG=34160 Review URL: http://codereview.chromium.org/1151006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42625 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling tests because failures are leading to zombie processes that aredmazzoni@chromium.org2010-03-251-2/+2
| | | | | | | | | | | | | disrupting other tests. BUG=http://crbug.com/39320 BUG=http://crbug.com/39213 TEST=hopefully makes the Interactive Tests bot (Windows) green. TBR=maruel Review URL: http://codereview.chromium.org/1313006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42624 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Fix devtools crasher related to unsuccessful extensions reload ↵pfeldman@chromium.org2010-03-252-29/+56
| | | | | | | | | | with opened devtools window. BUG=31081 Review URL: http://codereview.chromium.org/1328003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42623 0039d316-1c4b-4281-b951-d872f2087c98
* Enable URLRequestTest.*, URLRequestTestHTTP.*, URLRequestTestFTP.* underglider@chromium.org2010-03-251-3/+0
| | | | | | | | | | ThreadSanitizer on Mac OS. TBR=timurrrr Review URL: http://codereview.chromium.org/1336001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42622 0039d316-1c4b-4281-b951-d872f2087c98
* Round the size of shared memory regions up to 64K. This allowssehr@google.com2010-03-251-1/+8
| | | | | | | | | native client modules to map these regions. With this fix, Pepper audio works on all three platforms. Review URL: http://codereview.chromium.org/1242006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42621 0039d316-1c4b-4281-b951-d872f2087c98
* Sidestep a race in GoogleUrl by forcing initialization of the offending ↵siggi@chromium.org2010-03-251-0/+17
| | | | | | | | | | | pointer during DLL loading. BUG=38484 TEST=none Review URL: http://codereview.chromium.org/1233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42619 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor network selection screen.nkostylev@google.com2010-03-2518-219/+417
| | | | | | | | | | | | | | Move model and controller logic to NetworkScreen class. Move Refresh() method out of view to controller. Make network selection obligatory on OOBE even if Ethernet is connected. BUG=37070 TEST=Running with --login-manager --login-screen=oobe should initiate normal out of box flow. After selecting network from combobox update is initiated. Review URL: http://codereview.chromium.org/1058004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42618 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AccountScreenTest.TestBasic as flaky.skerner@chromium.org2010-03-251-2/+1
| | | | | | | TBR=avayvod git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42617 0039d316-1c4b-4281-b951-d872f2087c98
* Remove conflicting files.maruel@chromium.org2010-03-252-33/+0
| | | | | | | TBR=evanm Review URL: http://codereview.chromium.org/1305003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42616 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ProxyScriptFetcherTest.*, SOCKS5ClientSocketTest.*,glider@chromium.org2010-03-251-4/+0
| | | | | | | | | | | SOCKSClientSocketTest.*, TCPClientSocketPoolTest.* under ThreadSanitizer on Mac OS TBR=timurrrr Review URL: http://codereview.chromium.org/1223007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42615 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual LocaleChanged() callback added to views hierarchy to notifyglotov@google.com2010-03-252-2/+12
| | | | | | | | | | | views of the locale change so they could reload relevant data. BUG=none TEST=none Review URL: http://codereview.chromium.org/1145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42614 0039d316-1c4b-4281-b951-d872f2087c98
* Possible fix / workaround for geolocation wifi hanging bugjoth@chromium.org2010-03-251-3/+19
| | | | | | | | | | | Also pre-emptively fixes a reported issue with NULL bss list being returned from WlanGetNetworkBssList BUG=39300 TEST=run browser on desktop with dodgy wifi adapter.... Review URL: http://codereview.chromium.org/1256005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42613 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add a NonHintedSans font to test_shellagl@chromium.org2010-03-252-3/+18
| | | | | | | | This is used by an upcoming layout test. http://codereview.chromium.org/1303001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42612 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r42467. Clear cookies, local storage and databases when an extension ↵jochen@chromium.org2010-03-2516-52/+375
| | | | | | | | | | | | gets uninstalled. BUG=27938,39177 TEST=Unittest in extension_service_unitttest.cc Review URL: http://codereview.chromium.org/1257005 Patch from Mattias Nissler. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42611 0039d316-1c4b-4281-b951-d872f2087c98
* silence false valgrind alarms due to ChromeCookieMonsterDelegate changesdanno@chromium.org2010-03-251-0/+1
| | | | | | | | | BUG=none TEST=less redness on valgrind trybots Review URL: http://codereview.chromium.org/1251010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42610 0039d316-1c4b-4281-b951-d872f2087c98
* Be consistent about Text Encoding menu names on OS X - use "Encoding" in all ↵jeremy@chromium.org2010-03-252-909/+111
| | | | | | | | | | | instances. BUG=37883 TEST=View->Encoding & page menu (in toolbar)->Encoding menus should exist and have the same title. Review URL: http://codereview.chromium.org/1273001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42609 0039d316-1c4b-4281-b951-d872f2087c98
* Enable FileStreamTest.*Async*, HostResolverImplTest.*, ↵glider@chromium.org2010-03-251-3/+0
| | | | | | | | | | | | TestCompletionCallbackTest.Simple under ThreadSanitizer on Mac. TBR=timurrrr Review URL: http://codereview.chromium.org/1333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42608 0039d316-1c4b-4281-b951-d872f2087c98
* OOBE screens stroke should on pixel boundary to looks less blurry.dpolukhin@chromium.org2010-03-251-7/+10
| | | | | | | | | BUG=none TEST=On Chrome OS login screen edge is sharp and blue. Review URL: http://codereview.chromium.org/1278002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42607 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore the CFBag* stuff on Mac.glider@chromium.org2010-03-251-0/+5
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/1333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42606 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore threadLockingTest from sqllitetimurrrr@chromium.org2010-03-251-0/+3
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1333001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42605 0039d316-1c4b-4281-b951-d872f2087c98
* Update to the current Dromaeo ToT.antonm@chromium.org2010-03-2557-136/+195
| | | | | | | BUG=37993 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42604 0039d316-1c4b-4281-b951-d872f2087c98
* Preparatory step for implementing http://crbug.com/39171joth@chromium.org2010-03-254-25/+55
| | | | | | | | | | | Refactor the way the location arbitrator is obtained by the dispatched host, so that it is co-ordinated by the permission context. BUG=39171 TEST=none Review URL: http://codereview.chromium.org/1283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42603 0039d316-1c4b-4281-b951-d872f2087c98
* HttpAuthFilterWhitelist is now getting entries from the Windowsahendrickson@google.com2010-03-259-51/+655
| | | | | | | | | | | | | | | | | | registry, and adding them to whatever is in the command line. Added a basic IsIntranetHost() member function to HttpNetworkTransaction. Removed it until we figure out what to do with it. Added unit tests. Refactored SetFilters() to be less confusing. Unit tests now use a dummy registry key. BUG=29596 TEST=net_unittests.exe --gtest_filter=HttpAuthFilterTest.* Review URL: http://codereview.chromium.org/669068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42600 0039d316-1c4b-4281-b951-d872f2087c98
* Add all the strings required for the geolocation bubble, location bar icon, ↵joth@chromium.org2010-03-251-4/+32
| | | | | | | | | | | and inforbar BUG=11246 TEST=none Review URL: http://codereview.chromium.org/1301001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42599 0039d316-1c4b-4281-b951-d872f2087c98
* Join two suppressions for -[NSObject release] by removing an odd stack frame.glider@chromium.org2010-03-251-10/+0
| | | | | | Review URL: http://codereview.chromium.org/1216009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42598 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make cookie prompt dialog more Mac-likedanno@chromium.org2010-03-256-178/+392
| | | | | | | | | | | | | | | | | | | | | | | As per Alcor's recommendations, customize the Mac cookie prompt so that it is a less like windows/linux but more "maccy": add application icon for modal dialog, change layout and make radio buttons in "remember" choice small rather than regular. Also added unit tests. xib changes: - Add application icon to cookie prompt dialog, shifting all other elements to the right accordingly. - Change the size of the radio buttons in the "remember" choice to be small rather than regular. - Change the default text in in the information NSTextField to "Label" rather than a really long nonsensical debug string - Move the details view to be below the accept/block buttons. - Change the style of the disclosure control to be a button rather than triangle. Before: http://img257.yfrog.com/img257/3066/picture3fx.png After: http://img214.imageshack.us/img214/5553/picture9es.png and http://img200.imageshack.us/img200/1558/picture10pm.png BUG=38208 TEST=manual testing, added unit test for remember/block/accept controls Review URL: http://codereview.chromium.org/1102005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42597 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that caused candidate_window to crash at startup time.satorux@chromium.org2010-03-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | The problem was that CommandLine::ForCurrentProcess() was called despite candidate_window did not parse the command line flags. StackTrace::StackTrace() [0x45a312] logging::LogMessage::~LogMessage() [0x40abb7] CommandLine::ForCurrentProcess() [0x40b3b5] l10n_util::GetApplicationLocale() [0x4cd3f7] ResourceBundle::LoadResources() [0x4c935d] ResourceBundle::InitSharedInstance() [0x4c5ed7] main [0x402a5f] 0x7ffff2aa6abd 0x4002a9 BUG=crosbug.com/2254 TEST=manually Review URL: http://codereview.chromium.org/1238008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42596 0039d316-1c4b-4281-b951-d872f2087c98
* Initial unittest for AccountScreen.avayvod@google.com2010-03-252-0/+49
| | | | | | | | BUG=None TEST=Run browser_tests with --gtest_filter=AccountScreenTest.* Review URL: http://codereview.chromium.org/1123008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42595 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 05:15:46 +0000