summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* This change fixes the issue that if you usegman@google.com2009-07-2498-168/+194
| | | | | | | | | | | | | | | | | | | | | | o3djs.util.setMainEngine(...V8) in any sample and you use scripts that you don't want run in V8, for example Adsense, Google Analyitics, Wave, Google WebElements then the o3djs would attempt to pull in that javascript and execute it in V8. Specifically this refers to inline <script> tags instead HTML. Not <script src="url"> tags. The solution is we add an id to the tags we want o3djs to pull in. Any script with an id that starts with "o3d" will get pulled in. This CL changes our samples to have that id on their script tags. Review URL: http://codereview.chromium.org/159339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21585 0039d316-1c4b-4281-b951-d872f2087c98
* re-do CL 2136 - move image_diff to tools/imagediff, add deps to test_shelldpranke@google.com2009-07-245-13/+28
| | | | | | | | | | | | | | | | | moving image_diff from chrome/tools/test/image_diff to tools/imagediff (not moving to tools/image_diff to avoid some svn unpleasantness with that directory having been created in CL 21366). Also change test_shell.gyp to depend on everything needed to run the layout tests. R=darin@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/159361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21584 0039d316-1c4b-4281-b951-d872f2087c98
* Update to WebKit 46369.darin@chromium.org2009-07-242-4/+4
| | | | | | | | | | | | | | | | This includes Drew Wilson's patch here: http://codereview.chromium.org/159066 That CL was already reviewed by Dmitry Titov, so the only thing to review here is the DEPS file change. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/159369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21583 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 bugs in extensions autoupdate request parameters.asargent@chromium.org2009-07-242-17/+116
| | | | | | | | | | | | | -Separator that should be between id and version parameters was at the end of version -Missing the "uc" parameter which the gallery server code was expecting as indication of an update check BUG=http://crbug.com/17469 TEST=extensions auto-update should work Review URL: http://codereview.chromium.org/159224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21582 0039d316-1c4b-4281-b951-d872f2087c98
* Implement feature where tabs don't resize when using the close box until the ↵pinkerton@chromium.org2009-07-242-8/+95
| | | | | | | | | | mouse leaves the tab strip. Also turn off zordering fix from before, it regressed things. BUG=14912 TEST=creating a bunch of tabs and making sure that after you close them and mouse away, they return to the correct sizes. Creating new tabs after that should all be the correct size as well. Review URL: http://codereview.chromium.org/160116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21581 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to 46368.darin@chromium.org2009-07-241-1/+1
| | | | | | | | | | TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/159368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21580 0039d316-1c4b-4281-b951-d872f2087c98
* fix toolkit_views compile due to AutocompleteEditViewGtk change.tc@google.com2009-07-241-0/+1
| | | | | | | | | TBR=estade Review URL: http://codereview.chromium.org/159367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21579 0039d316-1c4b-4281-b951-d872f2087c98
* Implement location only display mode (used by popup windows).tc@google.com2009-07-246-35/+96
| | | | | | | | | | | | This matches the pixel sizes on Windows. The location bar is a couple pixels shorter and the font is a little smaller. BUG=17580 Review URL: http://codereview.chromium.org/159303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21578 0039d316-1c4b-4281-b951-d872f2087c98
* Adds code to select which frame of an .ico best matches the desired size.pkasting@chromium.org2009-07-242-5/+29
| | | | | | | | | | | | This doesn't actually do anything yet, since right now the ICO decoder still takes the desired size as an argument to setData(), and returns exactly one frame. However, I will be changing that upstream soon. I didn't add the same code to the CG decoder because I haven't tested to see what order the CG decoder returns frames in. BUG=none TEST=Covered by existing unittests. Review URL: http://codereview.chromium.org/160121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21577 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't close info bubbles based on which toplevel is active.estade@chromium.org2009-07-242-21/+12
| | | | | | | | | | | | | | | This fixes the behavior for active toplevel windows and focus follows mouse that moving the mouse onto and then off of the bookmark bubble will close it. This also fixes that we might paint the tab strip active while the system title bar is painted inactive. Unfortunately we can't stop the browser window from painting inactive when using the system frame. This reverts us to the old bad behavior that you could drag around the browser window and the bookmark bubble will stay in place. It also reverts us to allowing the info bubble to being able to persist even if it doesnt have focus. This doesn't match windows, but I'm not convinced windows is all that great. BUG=none TEST=see above Review URL: http://codereview.chromium.org/159288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21576 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Let custom draw buttons specify their stock size as well as their stock ↵estade@chromium.org2009-07-248-20/+23
| | | | | | | | | | | | | image. I tried to also make the tab strip use stock gtk close button but that is gonna require a lot more work to get layout right so leave it alone for now. BUG=none TEST=close button on download shelf is sanely sized Review URL: http://codereview.chromium.org/159325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21575 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass FilePaths and strings by reference.jhawkins@chromium.org2009-07-242-7/+8
| | | | | | | | | CID=2716,4565,5054 BUG=none TEST=none Review URL: http://codereview.chromium.org/160120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21574 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher from the field indicates that the focus manager can be NULL when ↵jcampan@chromium.org2009-07-241-4/+11
| | | | | | | | | | | | the FindBarWin is instanciated. It is not clear how this can happen. BUG=17056 TEST=None Review URL: http://codereview.chromium.org/161001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21573 0039d316-1c4b-4281-b951-d872f2087c98
* Roll for recent gyp changes.mmoss@chromium.org2009-07-241-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/159363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21572 0039d316-1c4b-4281-b951-d872f2087c98
* Change the background color of the NNTP lower sections.arv@google.com2009-07-241-1/+1
| | | | | | | | | | | BUG=None TEST=The background color of the lower sections on the NNTP should be light blue. Review URL: http://codereview.chromium.org/159350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21571 0039d316-1c4b-4281-b951-d872f2087c98
* redo CL 21368 - work around a race in python 2.4's popen() calldpranke@google.com2009-07-241-0/+4
| | | | | | | | | | | this was causing diffs to show up in layout tests on vista BUG=none TEST=none R=maruel@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21569 0039d316-1c4b-4281-b951-d872f2087c98
* Modify change in CL 21434 - allow standard font smoothing as well as nonedpranke@google.com2009-07-241-7/+10
| | | | | | | | | | | | | | | | | Prior to CL 21434 test_shell did not actually check if ClearType was disabled. I had thought that the requirement for the layout tests was that *all* font smoothing was disabled (both ClearType and standard). Turns out that standard is okay, so I am reenabling it here. Note that CL 21434 was really just a re-reverting of 21368. TEST=none BUG=none R=tony@chromium.org Review URL: http://codereview.chromium.org/160082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21568 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass FilePaths by reference.jhawkins@chromium.org2009-07-242-3/+4
| | | | | | | | | CID=2696 BUG=none TEST=none Review URL: http://codereview.chromium.org/159353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21567 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-07-242-6/+7
| | | | | | | | | CID=2714,2715 BUG=none TEST=none Review URL: http://codereview.chromium.org/159351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21566 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor blits to be more cross-platform.piman@chromium.org2009-07-246-119/+160
| | | | | | | Review URL: http://codereview.chromium.org/159190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21565 0039d316-1c4b-4281-b951-d872f2087c98
* Mark tests as flaky.darin@chromium.org2009-07-241-6/+7
| | | | | | | | | | TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/160119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21564 0039d316-1c4b-4281-b951-d872f2087c98
* A couple more failures popped up on Windows.darin@chromium.org2009-07-241-0/+2
| | | | | | | | | | TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/160118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21562 0039d316-1c4b-4281-b951-d872f2087c98
* More post merge (46288:46363) cleanup.darin@chromium.org2009-07-241-5/+8
| | | | | | | | | | TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/160117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21560 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a test_shell crash caused by attempting to cancel the plugin stream ↵ananta@chromium.org2009-07-241-1/+1
| | | | | | | | | | | | request after it has been deleted. TBR=jam Review URL: http://codereview.chromium.org/159358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21559 0039d316-1c4b-4281-b951-d872f2087c98
* Add back some expected failures.darin@chromium.org2009-07-241-1/+4
| | | | | | | | | | R=senorblanco BUG=none TEST=none Review URL: http://codereview.chromium.org/160114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21557 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some duplicate lines in up test_expectations.txt.senorblanco@chromium.org2009-07-241-5/+0
| | | | | | | | | BUG=None TEST=None TBR=fishd git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21556 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where an ongoing find operation would re-appear eventc@google.com2009-07-242-1/+5
| | | | | | | | | | | | | | | | | | though we already changed the find text. On Linux, we would continue doing a find operation. On Windows, the find operation would stop, but the find box would not be cleared. TEST=Go to a long page (like the html 5 spec). Do a find for a very common string (e.g., any single letter). Press backspace to clear the find box while results are still populating. The find box should be cleared and the find stopped. Review URL: http://codereview.chromium.org/159321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21555 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit from 46288 to 46363.darin@chromium.org2009-07-242-10/+121
| | | | | | | | | | | | | | | | | | | | | | | This appears to fix http://crbug.com/17326 since the last test that was failing in that set is now passing. LayoutTests/editing/selection/move-begin-end.html is also passing now. I'm not sure which WebKit patch to attribute that to. http://trac.webkit.org/changeset/46363 caused a boat-load of tests to need to be re-baselined, but that is expected and probably a temporary condition. Stephen wanted to revert his WebCore change to see if it would resolve the reliability test failure. Otherwise, it looks like we picked up some media related crashers :-( TBR=pkasting BUG=17326 TEST=none Review URL: http://codereview.chromium.org/160110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21554 0039d316-1c4b-4281-b951-d872f2087c98
* Paste at the beginning of a middle click rather than after letting the page ↵estade@chromium.org2009-07-241-19/+18
| | | | | | | | | | | | | | | handle it. The problem is that the page changes the focused area in the mouse release handler. Even after this fix, it is possible to paste into the wrong place. The place that gets the text is whichever text input is focused when the browser sends back the clipboard contents, not the text input that is focused when the middle click is handled. This has always been true but seems harmless in most cases. BUG=17504 TEST=open gmail chat. Put something in your PRIMARY. Click in the text entry area. Middle click in the chat display area. The selection shouldn't paste into the text entry. Otherwise, middle click paste should still work. TEST=the reduction in the bug acts as expected Review URL: http://codereview.chromium.org/160065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21553 0039d316-1c4b-4281-b951-d872f2087c98
* Add a search box to all pages. (Well, most of them. But eventuallykathyw@google.com2009-07-246-1/+86
| | | | | | | | it should be all.) Review URL: http://codereview.chromium.org/160107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21552 0039d316-1c4b-4281-b951-d872f2087c98
* Disable HTML5 DataGrid tag support, until the implementation's more complete.snej@chromium.org2009-07-242-1/+7
| | | | | | | | BUG=17567 TEST=LayoutTests/fast/dom/HTMLDataGridElement/* Review URL: http://codereview.chromium.org/159289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21551 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Avoid restarting the cache while it may be in use.rvargas@google.com2009-07-243-5/+19
| | | | | | | | | | | | | | Now the code that releases resources runs from the message loop so that methods can cause the cache to disable itself while still being able to touch internal state. BUG=17604 TEST=unittests. Review URL: http://codereview.chromium.org/159327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21550 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable running worker UI tests.jianli@chromium.org2009-07-241-11/+0
| | | | | | | | | BUG=17572 TEST=none Review URL: http://codereview.chromium.org/159322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21549 0039d316-1c4b-4281-b951-d872f2087c98
* The IPCs for carrying data requested by plugins have been changed from ↵ananta@chromium.org2009-07-2412-40/+116
| | | | | | | | | | | | | | | | synchronous IPCs to asynchronous IPCs. This fixes bug http://code.google.com/p/chromium/issues/detail?id=14323, where the Flash plugin would not render content on the page if these IPCs were processed while the plugin waited for sync calls like NPN_Evaluate to return. Test=covered by UI tests. Bug=14323 Review URL: http://codereview.chromium.org/159296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21548 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the win build. path is being modified and returned, so it can't be a ↵jhawkins@chromium.org2009-07-241-1/+1
| | | | | | | | const ref. TBR=finnur git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21547 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for linux againgman@google.com2009-07-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21546 0039d316-1c4b-4281-b951-d872f2087c98
* Fix frame overlay display in incognito mode, make location bar background ↵glen@chromium.org2009-07-242-2/+9
| | | | | | | | | | | follow theme tinting. BUG=none TEST=none Review URL: http://codereview.chromium.org/159340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21545 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for an error reported by Coverity.jcampan@chromium.org2009-07-242-8/+10
| | | | | | | | BUG=http://crbug.com/17409 TEST=None Review URL: http://codereview.chromium.org/160063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21544 0039d316-1c4b-4281-b951-d872f2087c98
* More (temporary) cleanup for theme installation:aa@chromium.org2009-07-243-28/+52
| | | | | | | | | | | - Modify the gallery URL to only allow SSL. - Remove the special case that allowed theme installation without --enable-extension. Now that we have the gallery special case this is not necessary anymore. - Modify the dialog language to be a little less lame. Review URL: http://codereview.chromium.org/159301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21543 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Theme the tab close button.jhawkins@chromium.org2009-07-244-6/+62
| | | | | | | | BUG=none TEST=Open a browser window. The close button should be visible. Apply a theme with a colored close button. The close button color should match the theme. Review URL: http://codereview.chromium.org/159338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21542 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings and GURLs by reference.jhawkins@chromium.org2009-07-243-6/+11
| | | | | | | | | CID=5051,5052,5053 BUG=none TEST=none Review URL: http://codereview.chromium.org/159343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21541 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-07-248-24/+28
| | | | | | | | | CID=4459,4563,4564,4566,4567,4569,4570,4571,4803 BUG=none TEST=none Review URL: http://codereview.chromium.org/159342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21540 0039d316-1c4b-4281-b951-d872f2087c98
* Some fixes to make NNTP themes work again.glen@chromium.org2009-07-242-7/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21539 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using strings for NTP logo inversionglen@chromium.org2009-07-241-3/+3
| | | | | | | | | BUG=14578 TEST=none Review URL: http://codereview.chromium.org/160105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21538 0039d316-1c4b-4281-b951-d872f2087c98
* linux: swap buttons on first run dialogevan@chromium.org2009-07-241-2/+2
| | | | | | | | Cancel goes on the left. Review URL: http://codereview.chromium.org/160103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21537 0039d316-1c4b-4281-b951-d872f2087c98
* Return Error Status Upon Blocking Requestsidanan@chromium.org2009-07-244-9/+34
| | | | | | | | | | | | | | | Blocked requests now return an error status so that the Chrome throbber does not spin indefinitely when blocking URL requests. This code shall be replaced with resource substitution next but gives a better experience until then. Same goes for the added type-based interception. TEST=none BUG=16932 Review URL: http://codereview.chromium.org/159214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21536 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Theme the bookmark bubble. (And first run bubble).erg@google.com2009-07-249-32/+148
| | | | | | | | http://crbug.com/16783 Review URL: http://codereview.chromium.org/160025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21535 0039d316-1c4b-4281-b951-d872f2087c98
* Layout was entirely the wrong place to be updating the button - it gets ↵glen@chromium.org2009-07-241-14/+9
| | | | | | | | | | | called too early. This moves it near the other user of the color values. BUG=none TEST=none Review URL: http://codereview.chromium.org/160094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21534 0039d316-1c4b-4281-b951-d872f2087c98
* Adding last modified time to file_utilbrettw@chromium.org2009-07-243-0/+7
| | | | | | | | | Original review: http://codereview.chromium.org/160050 Patch by dhg@google.com Review URL: http://codereview.chromium.org/159347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21533 0039d316-1c4b-4281-b951-d872f2087c98
* Live resize of tabs as the window resizes.pinkerton@chromium.org2009-07-242-8/+36
| | | | | | | | BUG=13713 TEST=dragging tabs still animates, new tabs still animate, resizing window live-resizes tabs. Review URL: http://codereview.chromium.org/159346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21532 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-03 13:49:49 +0000