| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Crashing on the mac webkit release bot.
BUG=45664
TEST=tree goes green
TBR=thakis
Review URL: http://codereview.chromium.org/2471007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some generated files changed (cookies, extension, history),
but those seem to be random reordering by the API generator.
TBR=aa
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2498002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows. This
code needs to be move to Interactive Ui Tests.
BUG:45581
Review URL: http://codereview.chromium.org/2428003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Hook up button to new outlet and action, bind its "enabled" property to fileHandlerUIEnabled.
BUG=41794
TEST=Download a pdf and a doc file, open prefs in second window. In the download shelf, check pdf files to auto-open. Button in prefs should become active. Let doc files auto-open. Button should stay active. Disable auto-opening for both types in shelf, button should become inactive. Let pdfs auto-open, click button. Button should become inactive, pdfs should show up as non-autoopening in shelf.
Review URL: http://codereview.chromium.org/2473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new user screen). If user takes snapshot and hits OK on image screen, the
snapshot becomes user image. If user presses Cancel, his image is downloaded
via Contacts API.
BUG=cros:3175
TEST=Login via new user login window. Verify that both use cases work if you logout after the browser is shown.
Review URL: http://codereview.chromium.org/2118002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to Hungarian and Bulgarian
BUG=45006
TEST=Start Hungarian / Bulgarian Chrome with a clean profile and see the
default spellcheck language matches the UI language.
Review URL: http://codereview.chromium.org/2333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2090008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builder will have everything for packaging so the final signing/dmg creation is self contained instead of having to live in both places.
- Move all the installer related bits into the installer folder
- Add the collection of these bits into a specific target
- Collect the internal bits also during the installer target
BUG=42635
TEST=none
Review URL: http://codereview.chromium.org/2417007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes a dependency cycle and should also make life easier for DRT.
Revert http://codereview.chromium.org/1658012
Review URL: http://codereview.chromium.org/2358001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2486004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm making an educated guess that the TemplateURLModel wasn't loaded by the
time we needed a keyword, so let's just wait for it to load.
BUG=45588
Review URL: http://codereview.chromium.org/2485004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(this is a follow up on r48704 and r48703)
Review URL: http://codereview.chromium.org/2457002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
container view.
TEST=BrowserActionsContainerViewTest
BUG=none
Review URL: http://codereview.chromium.org/2426002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
loaded when a delay is reached (which is doubled with time) or after a
tab finishes loading.
BUG=none
TEST=make sure session restore still works.
Review URL: http://codereview.chromium.org/2470003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes two types of changes
- More int* -> int*_t transitions, since npapi.h switched over
- Replace TRUE/FALSE, which have been removed from the upstream npapi.h. Since all our usage is C++, true/false seemed cleaner than 1/0.
BUG=42645
TEST=Compiling still works
Review URL: http://codereview.chromium.org/2484002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35036
TEST=Check chrome_launcher.exe properties, check that it has version information.
Review URL: http://codereview.chromium.org/2497001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=44549
Review URL: http://codereview.chromium.org/2484001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/3289
TEST=Connect to the network that requires web base login and open "Create account". It should timeout after 10 secs or earlier.
Review URL: http://codereview.chromium.org/2465001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
canonicalization of non-standard urls in CanonicalizeUrl function. Add CanCheckUrl to a more central location. Added the null check in GeneratePathsToCheck. Remove redundant checks from resource dispatcher host.
BUG=40605
TEST=SafeBrowsingUtilTest.CanonicalizeUrl
Review URL: http://codereview.chromium.org/2471002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(this is a follow up on http://codereview.chromium.org/2474002/show)
BUG=29424
TEST=GeolocationBrowserTest.*
Review URL: http://codereview.chromium.org/2459005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MockLocationProvider::OnPermissionGranted.
(this generated an extra alert, which is closed when test finishes on gtk/win, but hangs on mac).
BUG=29424
TEST=GeolocationBrowserTest.*
Review URL: http://codereview.chromium.org/2474002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=compiles.
Review URL: http://codereview.chromium.org/1640003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
used therein.
BUG=http://crbug.com/45344
TEST=no change
Review URL: http://codereview.chromium.org/2387003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2481004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added alpha channel for spinner.
BUG= http://crosbug.com/3299
TEST=If the Sign in is longer than 500ms spinner will be shown.
Review URL: http://codereview.chromium.org/2438001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=pkasting
Review URL: http://codereview.chromium.org/2423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- InformListenersOfMovement not required as WebKit has no way to trigger timeouts when movement is detected but cannot be resolved to a location.
- Error message in gps_open() does not have any additional information
Review URL: http://codereview.chromium.org/2450002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=patches containing this file work on the trybots
Review URL: http://codereview.chromium.org/2494002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=42238
TEST=none
Review URL: http://codereview.chromium.org/2475001
TBR=fbarchard@chromium.org
Review URL: http://codereview.chromium.org/2447003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42238
TEST=none
Review URL: http://codereview.chromium.org/2475001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2436005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
application. Currently the application just hangs without doing anything if an audio only file is given as input to it.
Patch by sashinde@nvidia.com:
http://codereview.chromium.org/2075018
BUG=none
TEST=Try playing an audio only file before and after this change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
into SVG and raw XML documents as well.
Injecting into SVG could conceivably be a feature, but I expect it would count as a "bug" more often than that, so I'm starting conservative.
BUG=39845
Review URL: http://codereview.chromium.org/2389004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tkent
Review URL: http://codereview.chromium.org/2467003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
especially helps when the scheme has also been stripped, as it makes the hostname look less unbalanced. We're careful to avoid stripping the slash when doing so would confuse the omnibox.
This also moves to more aggressive stripping and/or unescaping in several places. In general, it seems like we should be as aggressive as is feasible.
BUG=43587
TEST=Visit google.com. There should be no slash in the address bar.
Review URL: http://codereview.chromium.org/2389002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2760
TEST=Use any IME, and examine the candidate window.
Review URL: http://codereview.chromium.org/2450001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots and manually
Review URL: http://codereview.chromium.org/2448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The new AutoFill dialog mocks eliminate the need for a "default" address and credit card. Removing code related to UI for these defaults. Nib changes: Removed the "Default" radio button from each of the Nibs.
BUG=44621
TEST=AutoFillDialogControllerTest.*:-AutoFillDialogControllerTest.DefaultsChangingLogic
Review URL: http://codereview.chromium.org/2466002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use new WM parameter to control initial focus of the panel window. (see http://codereview.chromium.org/2474001)
BUG=chromium-os:3408
TEST=none. This requires WM change to function properly.
Review URL: http://codereview.chromium.org/2254005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
occassionally, but when it does, FLAKY prefix does not help because it
turns the tree red. By disabling this test, we lose the coverage for this
test on Mac. Until we have a better way to handle flaky crashes, it's better
to disable it.
BUG=45079
TEST=Mac bots don't turn red due to this test crashing.
TBR=jrg
Review URL: http://codereview.chromium.org/2485003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionApiTest.Bookmarks on Windows
BUG=45594,45595
TEST=Windows bot don't turn red with browser_test failure
TBR=jrg
Review URL: http://codereview.chromium.org/2433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2439003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed now-unused SignalThreadTask class.
BUG=none
TEST=unittests
Review URL: http://codereview.chromium.org/2436004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
core thread only.
BUG=none
TEST=unit tests, manual testing of notifications
Review URL: http://codereview.chromium.org/2326001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45562
TEST=tree green
TBR=jshin
Review URL: http://codereview.chromium.org/2449007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45142
TEST=FormManagerTest.FillForm
Review URL: http://codereview.chromium.org/2453004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48672 0039d316-1c4b-4281-b951-d872f2087c98
|