summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Isolated bug fixes from CL 385104 to address the following:jennb@chromium.org2009-11-184-28/+97
| | | | | | | | | | | | | | - using references for collections - only getting request response code if request was successful - writing response info for URL fetches that do not contain any data - only bothering with reading/writing response if response code is 2xx TEST=added test and data files to verify empty file still gets response written to storage BUG=none Review URL: http://codereview.chromium.org/385141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32337 0039d316-1c4b-4281-b951-d872f2087c98
* Add various tests for chrome.tabs/windows.kkania@chromium.org2009-11-186-120/+373
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/355029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32336 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes several focus issue with popup in the extensions' browser actions:jcampan@chromium.org2009-11-185-2/+41
| | | | | | | | | | | | | | | | - when opening a browser action popup, it gets the focus. - tab traversal now works in the popup - pressing esc closes the popup (if the keyboard event is not processed by the page) BUG=22654, 28087, 28086 TEST=Create an extension with a browser extension that shows a popup. Make the popup so that it has a textfield (that gets focused when the popup show) and a button. Install the extension. Open the popup, the textfield should have focus. Press tab, the focus should go to the button. Press Esc, the popup should be closed. Review URL: http://codereview.chromium.org/402036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32335 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option to tree_view for whether to show lines from the root nodeian@chromium.org2009-11-183-4/+35
| | | | | | | | | | | | | to children nodes (sets TVS_LINESATROOT). Set this to false by default (maintaining existing behaviour by default), except for cookies_view where we set it to true. BUG=27657 TEST=open cookies dialog, make sure the origins have a + box next to them, and that expanding these also expands the cookies folder beneath them. Review URL: http://codereview.chromium.org/399030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32334 0039d316-1c4b-4281-b951-d872f2087c98
* Add memory commit charge reporting to the page_cycler tests.sgk@google.com2009-11-181-0/+13
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/401015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32332 0039d316-1c4b-4281-b951-d872f2087c98
* linux: pass --gc-sections in link lineevan@chromium.org2009-11-181-0/+3
| | | | | | | | | | | | | | We have compile flags set up to support using --gc-sections, but apparently we aren't using it for the actual link! It was probably lost during the gyp conversion. This has a few-megabyte difference on binary size. (Trying submit again, hopefully thestig successfully converted bots...) Review URL: http://codereview.chromium.org/399048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32330 0039d316-1c4b-4281-b951-d872f2087c98
* Disable tcmalloc sampling by default.jar@chromium.org2009-11-181-0/+3
| | | | | | | | | | | | | | | It's not performance critical, but it allocates some additional amount of memory on sampled allocations which we probably do not want. [This is really http://codereview.chromium.org/385105 written by antonm, and I'm just landing it.] r=antonm,willchan Review URL: http://codereview.chromium.org/401012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32329 0039d316-1c4b-4281-b951-d872f2087c98
* Get more precise count of commited bytes in statsjar@chromium.org2009-11-181-1/+1
| | | | | | | | | | | | | | | | Account for bytes allocated for meta info when calculating the number of committed bytes. [This is partly CL http://codereview.chromium.org/384086 by Antonm, and I'm just landing it for him.] Also changed mechanism of gathering commited bytes to be sure we are under a lock (via ExtractStats) while fetching data. r=antonm,sgk Review URL: http://codereview.chromium.org/385098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32328 0039d316-1c4b-4281-b951-d872f2087c98
* Revert V8 update. Causes ui_test failures.ager@chromium.org2009-11-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/402051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32327 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.0.0.ager@chromium.org2009-11-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/404027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32323 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my last...jorlow@chromium.org2009-11-184-38/+68
| | | | | | Review URL: http://codereview.chromium.org/402049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32320 0039d316-1c4b-4281-b951-d872f2087c98
* Make the WebKitThread object start the WebKit thread on construction (not ↵jorlow@chromium.org2009-11-184-68/+38
| | | | | | | | | | | | | | | lazily). NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing. TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread. TEST=The WebKit thread gets spun up early in the initialization process. BUG=24144 Review URL: http://codereview.chromium.org/405007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32319 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 251.0 to 252.0chrome-bot@google.com2009-11-181-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32318 0039d316-1c4b-4281-b951-d872f2087c98
* Do not overwrite ld.orig in install-build-deps.sh.thestig@chromium.org2009-11-181-1/+2
| | | | | | | | | TBR=dank BUG=none TEST=Install gold through install-build-deps.sh twice. /usr/bin/ld.orig should still be GNU ld. Review URL: http://codereview.chromium.org/402047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32317 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run TabRestoreUITest.* under ThreadSanitizertimurrrr@chromium.org2009-11-181-0/+3
| | | | | | | | BUG=28115 TBR=dank Review URL: http://codereview.chromium.org/405015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32316 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: update install-build-deps.sh to build gold from binutils 2.20.thestig@chromium.org2009-11-181-77/+35
| | | | | | | | BUG=none TEST=builds gold that supports --gc-sections. Review URL: http://codereview.chromium.org/400029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32315 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Make sure the suid sandbox is owned by root.thestig@chromium.org2009-11-181-1/+2
| | | | | | | | | | If chrome-sandbox is mode 4755 but not owned by root, Chrome doesn't start up. We should abort instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/372008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32314 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add more manual Profiles tab tests.mnaganov@chromium.org2009-11-184-0/+179
| | | | | | Review URL: http://codereview.chromium.org/404002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32313 0039d316-1c4b-4281-b951-d872f2087c98
* Hold histograms in static variables instead of allocating heap.ukai@chromium.org2009-11-182-112/+94
| | | | | | | | | | | | | | | | | If instance variables holding pointers to Histograms, it would cause crash bug when the instance is torn down and the metrics services use and recording of their contents. The current "standard" patten for using Histograms includes making sure that the Histogram instances are not destroyed prematurely, held in static variables. BUG=28096 TEST=none Review URL: http://codereview.chromium.org/404022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32311 0039d316-1c4b-4281-b951-d872f2087c98
* rebaseliningyaar@chromium.org2009-11-1831-12/+180
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32309 0039d316-1c4b-4281-b951-d872f2087c98
* A fix for Issue 18994.hbono@chromium.org2009-11-181-7/+29
| | | | | | | | | | | | | | This change retrieves the number of slots available for custom JumpList items to calculate the items for "Most Visited" items and for "Recently Closed" items. As written in the MSDN doc, Windows 7 changes the number of JumpList slots at run time and it truncates the items from the bottom (i.e. "Recently Closed" items) if we add more items than available ones. To fix this issue, this change assigned 60% of available JumpList slots to the "Most Visited" category and 40% to the "Recently Closed" category, respectively. (If there are not so many "Recently Closed" Items, this change increases the number of "Most Visited" items.) Also, this change sets the AppID since <http://codereview.chromium.org/385120> changes it. BUG=18994 TEST=Open a JumpList and see there are two or more "Recently Closed" items in it. Review URL: http://codereview.chromium.org/399031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32308 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call CancelURLRequest if request_is already NULL.ukai@chromium.org2009-11-181-8/+8
| | | | | | | | | | | | | | | | Fix DCHECK when io_loop_ is NULL http://code.google.com/p/chromium/issues/detail?id=23437#c8 hits DCHECK at nss_ocsp.cc:281 in CancelURLRequest(). CancelURLRequest() is called from Cancel() if io_loop_ is not NULL. Maybe, we don't need to call CancelURLRequest if request_ is already NULL, which happens when request is completed in OnReadCompleted(). BUG=23437 TEST=none Review URL: http://codereview.chromium.org/405013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32306 0039d316-1c4b-4281-b951-d872f2087c98
* Make extension popups shrink when their contents shrink.aa@chromium.org2009-11-182-5/+5
| | | | | | | | | BUG=26471 TEST=Load news example extension, see resizing goodness. Review URL: http://codereview.chromium.org/400028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32305 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tabs introduced by r31197.mark@chromium.org2009-11-181-22/+22
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/402045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32304 0039d316-1c4b-4281-b951-d872f2087c98
* More removal of config.h and glue_util.h dependencies.darin@chromium.org2009-11-188-63/+32
| | | | | | | | | | | | | | I killed the #if ENABLE(WORKERS) defines in favor of always compiling that code because it is harmless to compile it when the underlying WebCore implementation is not compiled, thanks to the WebKit API. R=yaar BUG=none TEST=none Review URL: http://codereview.chromium.org/404023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32303 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 51075:51100yaar@chromium.org2009-11-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/402044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32302 0039d316-1c4b-4281-b951-d872f2087c98
* [LTTF] Remove three layout tests from test expectations.yutak@chromium.org2009-11-183-24/+0
| | | | | | | | | | These tests were modified in WebKit r51070 so that they don't rely on behavior of submitting a form to <about:blank> URL. Now outputs of these tests should be same as WebKit's baselines. BUG=20570 TEST=none Review URL: http://codereview.chromium.org/400030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32299 0039d316-1c4b-4281-b951-d872f2087c98
* New tests did not have correct test expectations.yaar@chromium.org2009-11-181-9/+8
| | | | | | Review URL: http://codereview.chromium.org/399061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32298 0039d316-1c4b-4281-b951-d872f2087c98
* Mark fast/dom/Geolocation as DEFER SKIP since we don't implement it yet.dpranke@google.com2009-11-181-1/+1
| | | | | | | | | | R=dglazkov@chromium.org BUG=11246 TEST=LayoutTests/fast/dom/Geolocation Review URL: http://codereview.chromium.org/405012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32296 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Valgring suppressions for sync since the bug is fixed now.munjal@chromium.org2009-11-181-25/+0
| | | | | | Review URL: http://codereview.chromium.org/401019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32292 0039d316-1c4b-4281-b951-d872f2087c98
* Some easy cleanup to remove unnecessary config.h and glue_util.h dependencies.darin@chromium.org2009-11-187-41/+18
| | | | | | | | | | R=yaar BUG=none TEST=none Review URL: http://codereview.chromium.org/402032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32287 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for BookmarkManager Test Crash test.oshima@chromium.org2009-11-182-1/+15
| | | | | | | | | | | | | | | * Test was failing because the key events were sent even after the window has been destroyed. * Make sure browser window is closed before the end of test. Test fails in BookmarkBarView without this. I think this requires a fix on browser side. Filed a bug 28046. BUG=None Test=run browser_tests --gtest_filter=*Bookmark* Review URL: http://codereview.chromium.org/397034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32286 0039d316-1c4b-4281-b951-d872f2087c98
* Fix find bar scrolling with the page after switching back to tab.simonrad@chromium.org2009-11-181-8/+7
| | | | | | | | | | | | We need to do a BrowserView::Layout() (which updates things like the bookmarks bar and the find bar) both in between the TabContents detach/attach AND after the final attach. This way, we toggle the bookmarks bar at the right time, but we still end up setting the find bar properly. R=beng BUG=27960 TEST=Navigate to a page where you can see the vertical scroll bar. Press Ctrl+F to open the find bar. Switch to another tab and then back to the original tab. Scroll down/up the page. The find bar should stay in place, not scroll with the page or disappear. Review URL: http://codereview.chromium.org/397036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32284 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the About ChromeFrame test as this is consistently failing on the ↵ananta@chromium.org2009-11-181-1/+3
| | | | | | | | | | | | | buildbot. Reopened bug http://code.google.com/p/chromium/issues/detail?id=26549 Bug=26549 TBR=amit Review URL: http://codereview.chromium.org/400031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32281 0039d316-1c4b-4281-b951-d872f2087c98
* Hide seccomp sandbox calls from non-x86 machinesjoel@chromium.org2009-11-181-0/+7
| | | | | | | | | | | | The seccomp sandbox is not built on ARM as it contains x86 specific code. However, there are a pair of calls to seccomp sandbox functions in the zygote initialisation, this hides those calls behind the ARCH_CPU_X86_FAMILY define. Without this the ARM build does not link. Review URL: http://codereview.chromium.org/402009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32278 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when activating a select element inside a pageaa@chromium.org2009-11-183-12/+69
| | | | | | | | | | | | | | | | action popup. With this change, select elements still don't work correctly with page actions: when you try to use them, the page action popup disappears. However, at least now, it doesn't crash. BUG=27576 TEST=Install extension in related bug. Navigate to any site and click page action. Browser should not crash. Review URL: http://codereview.chromium.org/399032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32277 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to BookmarkBubble.xib.dmaclach@chromium.org2009-11-182-764/+41
| | | | | | | | | | | | Removed explicitly set first responder that was causing autocalculate not to work. Changes to Preferences.xib Turned on the autorecalculate flag. BUG=27781 TEST=repro steps in bug Review URL: http://codereview.chromium.org/402041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32274 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the O3D changes from 32206 and 32266, due to MacOS build problems ↵senorblanco@chromium.org2009-11-181-7/+4
| | | | | | | | | | | | | | | | with Chrome base. (Sorry for the trouble. I didn't realize that O3D had a separate DEPS entry for chromium, so none of this was actually necessary ... sigh). Note: when you do roll forward chromium past 32206, you'll have to roll skia to 428 at the same time. BUG=none TEST=please be green TBR=gspencer Review URL: http://codereview.chromium.org/404018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32273 0039d316-1c4b-4281-b951-d872f2087c98
* Update Chromium menu button images.derat@chromium.org2009-11-182-0/+0
| | | | | | Review URL: http://codereview.chromium.org/402038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32272 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow content scripts to execute on file:// urls.finnur@chromium.org2009-11-1833-209/+230
| | | | | | | | | | | | This requires a command line flag for the page cycler tests, since those load file:// urls. BUG=27877 TEST=Bunch of tests affected. Review URL: http://codereview.chromium.org/402029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32271 0039d316-1c4b-4281-b951-d872f2087c98
* Only request full-screen once per plugin windowstuartmorgan@chromium.org2009-11-181-1/+5
| | | | | | | | | BUG=28019 TEST=Make Silverlight full screen on the Mac, then shrink it back to in-page mode; the dock should re-appear. Review URL: http://codereview.chromium.org/402028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32270 0039d316-1c4b-4281-b951-d872f2087c98
* Interpose one more Carbon function for Window disposingstuartmorgan@chromium.org2009-11-181-0/+10
| | | | | | | | | BUG=27820 TEST=Focus should return to browser window in test case from bug. Review URL: http://codereview.chromium.org/402037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32269 0039d316-1c4b-4281-b951-d872f2087c98
* Replace hard-coded media_format() methods with Google Mock methods declared ↵scherkus@chromium.org2009-11-186-52/+97
| | | | | | | | | | | | | | | | in mock_filters.h. Updated unit tests accordingly. Patch by Dominic Jodoin <dominic.jodoin@gmail.com> BUG=21040 TEST=Run the media_unittests and AudioRendererImplTest test suite in unit_tests. Ensure there is no Google Mock failures and that all tests are passing. Review URL: http://codereview.chromium.org/404016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32267 0039d316-1c4b-4281-b951-d872f2087c98
* Roll O3D's DEPS for Chromium 28829:32206.senorblanco@chromium.org2009-11-181-1/+1
| | | | | | | | | BUG=none TEST=does it build? Review URL: http://codereview.chromium.org/397033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32266 0039d316-1c4b-4281-b951-d872f2087c98
* Launch processes asynchronously so as not to block the UI thread. For now, ↵jam@chromium.org2009-11-1819-336/+488
| | | | | | | | | renderer only, I'll take care of plugin/worker/utility processes in a followup change. (relanding 32203) BUG=6844 Review URL: http://codereview.chromium.org/397031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32264 0039d316-1c4b-4281-b951-d872f2087c98
* Stop top-crasher regression by disabling WebSocketExperimentRunnerjar@chromium.org2009-11-181-0/+4
| | | | | | | | | | | | | | There was a race to destroy histograms held by an instance within WebSocketExperimentRunner, and this was causing the crash when histograms were being recorded at shutdown. See bug 28096 for re-enabling this feature. BUG=27856 r=wtc,ukai Review URL: http://codereview.chromium.org/404017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32263 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash source in test_shell when running DB tests.dumi@chromium.org2009-11-182-7/+46
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/404013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32262 0039d316-1c4b-4281-b951-d872f2087c98
* Use an explicit boolean has_new_first_party_for_cookies insteadwtc@chromium.org2009-11-1816-22/+52
| | | | | | | | | | | | of an empty, invalid URL to indicate whether the first party for cookies URL needs changing when following a redirect. R=eroman BUG=25133 TEST=none Review URL: http://codereview.chromium.org/405011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32260 0039d316-1c4b-4281-b951-d872f2087c98
* Added 2 more flakes. Removed one flake that was already there.yaar@chromium.org2009-11-181-3/+4
| | | | | | TBR: idana,erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32258 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser tests for the BLOCK_THIRD_PARTY_COOKIES policywtc@chromium.org2009-11-182-0/+88
| | | | | | | | | | | | to verify we allow first-party cookies in the regular and redirected cases. R=abarth,eroman BUG=25133 TEST=new browser tests are added Review URL: http://codereview.chromium.org/401009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32257 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 08:13:27 +0000