| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
accessors to the singleton for more values that various code wants, then convert almost everyone using OSVERSIONINFO or SYSTEM_INFO structs to calling these accessors. Declare an AtExitManager in the out-of-process test runner since it didn't have one and that breaks singleton-using code in the test executable (as opposed to in chrome.dll).
A few other minor cleanups along the way (binding of "*", shorter code, etc.). Because I ran into problems with it while modifying gcapi.cc, I cleaned up our usage of strsafe.h a bit, so that files that don't need it don't include it and files that do use STRSAFE_NO_DEPRECATE instead of a modified #include order.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6713107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76795
TEST=none
Review URL: http://codereview.chromium.org/6750018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6632012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the event that an extension uninstall is skipped (not allowed)
because that extension is not user-manageable, a new notification is
sent. The automation hook UninstallExtensionById is revised to handle
this case, and a new PyAuto test is written to exercise this new
functionality (the test attempts to uninstall the WebStore and verifies that
this extension cannot be uninstalled).
BUG=76598
TEST=None.
Review URL: http://codereview.chromium.org/6794040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for the client to fetch the server's version. If the server's version is
newer than the client's, warn the client and quit.
Additional small changes:
-Add /healthz callback that sends a 200 status, for checking if the server is up.
-Fix shutdown crash where the AutomationProxy is deleted on the wrong thread.
-Initialize logging correctly.
-Disable mongoose file serving capabilities by default
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6690060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6814019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tiling should:
- offer 6-wide and 3-wide tile grids to the user
- in the 6-wide format, icons will grow to use the available space (within reason)
- animate between these two states
- not animate when not switching between these two states (keeping mouse-drag window resizing smooth)
- always be smooth; not flicker or jump around
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6793033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6799022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK can restore focus if the native widget has a focus, and views always remembers the focused_view, so there is no need to store/restore on linux for this case. Opening it (like wrench menu) was causing the issues in bugs because it changes window activation.
BUG=70032,chromium-os:8829
TEST=see bugs
TEST=
Review URL: http://codereview.chromium.org/6691052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame IE6 builder. These tests
randomly fail as IE6 caches the response as per the directive passed back by the python webserver.
Proposed fix is to send back the no-cache header for all echoheader requests. The URLRequestTestHTTP.VaryHeader
test expects the response to be cached. Added a new url substring /echoheadercache which returns back the
expected cache header.
Removed the echoheaderoverride url handling from the test server.
BUG=none
TEST=ChromeFrame net tests should pass on IE6. Net tests should continue to pass everywhere else.
Review URL: http://codereview.chromium.org/6810001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
match recent libcros changes around Store/RetrievePolicy
BUG=None
TEST=unit tests
R=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/6815001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on ChromeOS.
After this change, on ChromeOS we will use the TPM to generate keys
for keygen tags in forms. NSS will also have opencryptoki loaded so
it can talk to the TPM.
BUG=chromium-os:12416, chromium-os:12417
TEST=Generated keys on a ChromeOS device.
Review URL: http://codereview.chromium.org/6667020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
track of changes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6759038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a download error occurs, we now mark it as "Interrupted", and display the new status on the Download Shelf.
This is handled through the OnResponseCompleted() method, from:
DownloadResourceHandler ->
DownloadFileManager ->
DownloadManager
The latter checks the error value, and if not zero calls DownloadError().
DownloadError() marks the download as interrupted (stopping the progress timer), updates the download history, and updates its Observers.
DownloadItem::DownloadState now has a new state, INTERRUPTED.
There are also new display strings that show up on interrupted downloads in the download shelf and download page.
BUG=35278
TEST=Pass unit and browser tests. Also, run a python server that behaves as described below, connect to it, and observe that "Interrupted" shows up in the item on the download shelf. Check that the item behaves as if it were cancelled.
The Python server should respond to a GET request with a content length that is large, then provide several chunks of data (but less than the specified length) and then send a 'No file' response (code 204) and close the connection.
Review URL: http://codereview.chromium.org/6613024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tkent@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
It hung the TSAN bot, although I don't know why:
http://build.chromium.org/p/chromium.memory/builders/Windows%20Tests%20%28tsan%29/builds/3531/steps/memory%20test%3A%20net/logs/stdio
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests were failing with Release builds because ASSERT() was used
instead of ASSERT_TRUE(), and so the code in ASSERT() wasn't executing.
Also fixed a bug in IPEndPoint::GetFamily() which caused the crash in unittests.
BUG=78663
TEST=Unittests
Review URL: http://codereview.chromium.org/6816002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some web servers reportedly send header parameters that aren't
quoted properly. So we end up with headers like:
Content-Disposition: attachment; filename="Foo.bar
Rather than discarding the filename parameter in this case, we
now treat it as if there was a closing quote at the end of the
line.
BUG=58840
TEST=net_unittests --gtest_filter=NetUtilTest.GetFileNameFromCD
Review URL: http://codereview.chromium.org/6802019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6801046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on the UI thread.
Review URL: http://codereview.chromium.org/6720051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=still builds...
Review URL: http://codereview.chromium.org/6812016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
RenderView for a TabContents changed (i.e. in this case, when navigation causes new renderer process for a tab). TabContentsWrapper should always use the current RV to get the routing_id, and not cache it.
BUG=78509
Review URL: http://codereview.chromium.org/6813011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6803016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PPB_Graphics3D.
The original API was designed to be similar to EGL a couple of reasons:
- EGL is a standard API that developers are familiar with and serves their purpose
- It would be relatively easy to write an EGL implementation on top of Pepper3D implementation to facilitate porting of existing EGL apps
However the restrictions in Pepper API do not allow certain use cases. The separation of context and surface allows using a single context to render to multiple instance or offscreen surfaces. But since each context is implicitly tied to a particular instance it is infeasible or confusing to draw to other instace surfaces. The offscreen use-case can be easily handled using Framebuffer objects (FBO). Writing an EGL wrapper for the new API should not be too difficult either.
Combining context and surface has advantages:
- Less complex API and implementation
- Convinient versioning
Please note that this is not ready to submit. I am only sending the proposed API. Once approved I will delete PPB_Surface3D and PPB_Context3D, and make other necessary changes to make sure everything compiles and works.
Review URL: http://codereview.chromium.org/6745010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6813017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6792061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20781
TEST=see bug
R=arv@chromium.org
Review URL: http://codereview.chromium.org/6801017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up callers to use the new location and namespace.
BUG=None
TEST=None
R=brettw@chromium.org,avi@chromium.org
Review URL: http://codereview.chromium.org/6816004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=30572
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6793052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
being called here is going away anyway.
TEST=None
BUG=None
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6801025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reasoning is described in the comment above the global_tracker_ member.
TEST=manual
BUG=none
Review URL: http://codereview.chromium.org/6804031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for non-TCP transports. This helps because the alternative
is to either use non-TCP protocols (like SCTP) in classes which are called
"TCPClientSocketPool", or to clone the code as "SCTPClientSocketPool", both
of which are less than ideal.
For now, we're just testing transports, so the TransportSocketPool classes
will determine a single type of transport and just use them. In the future
we'll likely need to figure out how to deal with runtime selection of
transports, and probably support use of multiple transports either within
the same pools or within subpools. But that is for the future.
Note that the histograms have some "tcp" references to them. I didn't change
these to "transport" yet, because it will effect existing histograms.
Renames include:
classes:
TCPClientSocketPool -> TransportClientSocketPool
MockTCPClientSocketPool -> MockTransportClientSocketPool
TCPSocketParams -> TransportSocketParams
methods (not the exhaustive list):
CreateTCPClientSocket() -> CreateTransportClientSocket()
DoTCPConnect() -> DoTransportConnect()
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6804028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove redundant code from a conditional block.
BUG=78636
TEST=Double click to close neighboring tabs via (x)
Review URL: http://codereview.chromium.org/6813014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have several places where a need to distinguish `real' root CAs from
user-added root CAs will be useful:
1) Monoscope wants to inspect correctly signed, but unknown certificates, but
doesn't want to deal with proxy MITM certificates.
2) HSTS is likely to add a method for pinning to a certificate, but we don't
want to break every proxy MITM with it.
This change adds several lists of known, `real' roots. These lists present an
ongoing maintainance issue. However, in the event that the lists are incomplete
in the future, we fail open. This is because roots not in these lists are
treated as user-added and user-added roots have more authority than `real'
roots.
In some sense, this is a problem because it might be a security issue that new
roots are given too much authority. On the other hand, we're not breaking
things when we're behind on updating the lists so the maintainance issue isn't
too pressing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6793041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=chrome_frame_tests
Review URL: http://codereview.chromium.org/6806020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Plumb TabContentsWrapper through the AppleScript code.
BUG=71097
TEST=none
Review URL: http://codereview.chromium.org/6815002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=vsevik
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=57957
We are migrating the protocol to JSON-RPC-2.0 spec.
TEST=none
BUG=none
TBR=yurys, pfeldman
Review URL: http://codereview.chromium.org/6816013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also simplifies the PrerenderBrowserTest framework quite a bit. The main message loop is only run once, and is quit only if the correct number of loads have been seen for FINAL_STATUS_USED, or after the TestPrerenderContents are destroyed for all other final statuses.
BUG=73580
TEST=browser_tests --gtest_filter="PrerenderBrowserTest.*"
Review URL: http://codereview.chromium.org/6793018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "DNS Prefetch" option currently controls DNS prefetching, TCP preconnection,
and prerendering of pages. This modifies the text string to replace
this, and changes variable names to reflect it.
The underlying preference name remains the same so settings are not
lost. However, I changed the policy name to make name changes
consistent. If this does not migrate well, I will retain the old
policy name.
BUG=77783
TEST=Existing tests, make sure text is correct in browser.
Review URL: http://codereview.chromium.org/6793045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When opening DevTools window there is an exception in the console: "Uncaught ReferenceError: WebInspector is not defined" because some commands are sent to the front-end before it's loaded.
BUG=None
TEST=Open DevTools window, you should see no exceptions in the console
Review URL: http://codereview.chromium.org/6801044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tkent
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files are part of [1], but I need to submit them first in order for
try server runs to be effective.
This change does not affect the build.
[1] http://codereview.chromium.org/6793041/
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=enne
Review URL: http://codereview.chromium.org/6813016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=v8:1252
TEST=none
Review URL: http://codereview.chromium.org/6812014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77914
TEST=none, trybots remain green
Review URL: http://codereview.chromium.org/6720013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77914
TEST=none, trybots remain green
Review URL: http://codereview.chromium.org/6693068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(enable HttpNetworkTransactionTest.*, HttpNetworkLayerTest.* and
ProxyResolverV8Test.* back)
TBR=eroman
BUG=78303,78536
Review URL: http://codereview.chromium.org/6801041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
during OOBE. Otherwise it will be lost if Chrome restarts.
BUG=chromium-os:13696
TEST=manual
Review URL: http://codereview.chromium.org/6812013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=eroman
BUG=78536
Review URL: http://codereview.chromium.org/6813015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80758 0039d316-1c4b-4281-b951-d872f2087c98
|