| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1058005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
downloaded from. Added machinery to be able to switch this
behavior off, so that in the future, we can turn it off for
the gallery.
BUG=32361
Review URL: http://codereview.chromium.org/890002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that the URL in the address bar is really the one loaded
in chrome under different types of navigations.
Part 1 of the checkin covering following cases:
- Basic switch
- Back/forward
- URL fragment navigation
- New window (with different protocols about: view-source etc.)
BUG=34676
TEST=modified a bunch of existing full tab mode tests
Review URL: http://codereview.chromium.org/1044003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=37880
Review URL: http://codereview.chromium.org/1117002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Addressing review comments that were submitted after I checked in.
BUG=26463
TEST=None
Review URL: http://codereview.chromium.org/1097002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
leaks.
BUG=38481
TEST=none
Review URL: http://codereview.chromium.org/1109005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=windows slaves update successfully
Review URL: http://codereview.chromium.org/1109003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
BUG=38532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=38532
TEST=none
Review URL: http://codereview.chromium.org/1130001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35157
TEST=Run chrome with --login-manager and press button create an account.
Review URL: http://codereview.chromium.org/910003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/873003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=2844
TEST=none
Review URL: http://codereview.chromium.org/1111002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
last session, which means my test doesn't test what I want it to. I
could make the test exercise the paths I want on chromeos by changing
what to do on startup, but it didn't seem worth it given the default.
BUG=NONE
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/1079002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35031
TEST=see steps to reproduce in bug report
Review URL: http://codereview.chromium.org/1023009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=35858
TEST=none
Review URL: http://codereview.chromium.org/1079003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I unpacked libpng 1.2.43 and did:
cd third_party/libpng
for x in $(ls -1) ; do cp /tmp/libpng-1.2.43/$x .; done
The diffs appear to all be safe. The Chromium specific config is in pngusr.h
and isn't touched by this change.
1.2.43 fixes http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-0205
c7013d773eb45b8ed6a864e419e544106a0dd95d /tmp/libpng-1.2.43.tar.xz
BUG=38512
TEST=none
http://codereview.chromium.org/1118002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
dbg bot.
BUG=38497
TEST=Vista dbg ui tests go green 100% of the time.
Review URL: http://codereview.chromium.org/1072003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Removes overload now that we rolled http://trac.webkit.org/changeset/56011
Review URL: http://codereview.chromium.org/1045001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36480
TEST=none
Review URL: http://codereview.chromium.org/1026007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=36955
TEST=\
Drop some bookmarks onto folders; make sure they go in (at the end).
Try both bookmark bar folders and sub-sub-folders.
Try marks from a folder onto a bar folder.
Drop a mark onto it's own parent folder.
Go both quick (before hover-open) and slow (after).
Review URL: http://codereview.chromium.org/1002012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bug unrelated to my cl.
TBR=erikkay@chromium.org
BUG=38522
Review URL: http://codereview.chromium.org/1118003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=andybons
BUG=38525
TEST=none
Review URL: http://codereview.chromium.org/1128001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
save each file before downloading" option is checked.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1050006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes the call to SetWindow(NULL) in the Core Animation case, since that causes the delegate to enable the TransportDIB drawing mode. Removes the early return in Paint, since now we don't call it (and if we do later, it'll be to get snapshots using the existing Cocoa event model path, per the ammended CA drawing model spec).
Also renames windowless_ in WebPluginDelegateProxy to make it clear that it's just about drawing.
BUG=37974
TEST=In a build with Core Animation plugin enabled, there should be no flash of black when the plugin is first drawn.
Review URL: http://codereview.chromium.org/982010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, cross-platform: eschew RenderViewHostDelegate:BookmarkDrag::DragData type in favor of BookmarkDragData.
BUG=37702
TEST=manual
Review URL: http://codereview.chromium.org/1029004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
restore.
BUG=23613
TEST=turn off session restore, pin a tab, restart chrome and make sure
you get back the pinned tab.
Review URL: http://codereview.chromium.org/1026005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer process. Wait until the renderer has proved that it has access to
its end of the socket before closing it manually.
BUG=38459
TEST=Test case from bug 26754 comment 9 (affected Macs only):
1. Have lots of bookmarks (import Safari defaults)
2. Right-click on bookmark bar, and choose "Open All Bookmarks"
Expect: no crash, no sad tabs, none of the following messages logged:
a. LOG(ERROR) << "Refusing use of missing IPC channel " ...
b. LOG(FATAL) << "Denying attempt to reuse initial IPC channel for " ...
This test should be repeated many times.
Review URL: http://codereview.chromium.org/1066001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(sigh)
BUG=none
TEST=unit_tests
TBR=bulach
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/3821/steps/valgrind%20test:%20unit/logs/stdio
BUG=none
TEST=unit_tests (Mac valgrind)
TBR=bulach
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Check against the correct color field when validating the colors loaded from GTK.
BUG=http://crbug.com/38420
TEST=verified with unit tests
Review URL: http://codereview.chromium.org/985008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basic DragImage implementation.
Only the chromium part is for review. The webkit part shows how that will look when I create the patch for webkit later. This can be landed without the change to webkit.
TODO later:
- use the image on windows, mac
- implement the other DragImageRef functions
TEST=drag an image from the render view in GTK
BUG=11457
Review URL: http://codereview.chromium.org/668125
The problem was an incorrect method signature in RenderView.
Review URL: http://codereview.chromium.org/1037008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixes a crash bug in the code generator.
Review URL: http://codereview.chromium.org/1109002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the (placeholder) help center page.
This extends ConfirmInfoBar to support to have optional link support (simple support, i.e. not the inserted mid-label link that LinkInfoBar sports)
Note 1: this does not exactly match the mock; the allow/deny buttons and link are swapped. I think this looks nicer, is more consistent with other confirm infobars, and happens to be easier to code
Note 2: linux & mac will need follow-up CLs, but will simply ignore the link in the meantime
BUG=11246
TEST=browser_tests.exe --gtest_filter=Geol*
Review URL: http://codereview.chromium.org/1037006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
third_party/tcmalloc/chromium/src.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41938
Review URL: http://codereview.chromium.org/576001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored code so that the class that encapsulates cookies details
is shared between the cookie tree and cookie prompt on the mac.
xib changes: Fixed the bindings in all of the subviews in the details view to use the new shared details class. Also added a currently hidden popup menu for selecting the cookie expiration time in the prompt details view--this needs to be wired up in a separate CL.
BUG=http://crbug.com/38348
TEST=added unit tests for the new class, manual testing of cookie tree and cookie prompt dialog
Review URL: http://codereview.chromium.org/1025003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1089002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we have more and more proper grd dependencies in place,
this script may just do more harm than good by causing spurious rebuilds.
Additionally, it horked the build today.
TEST=none
BUG=17706
Review URL: http://codereview.chromium.org/1019007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1111001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this changes, users can add and remove preferred languages using the
table on the left, that used to be just saying "Not yet implemented".
TEST=manually
BUG=crosbug.com/1688
Review URL: http://codereview.chromium.org/1104001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
third_party/tcmalloc/chromium/src.
Review URL: http://codereview.chromium.org/576001
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/1076002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1110001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
than duplicate its logic
This is a follow up to http://codereview.chromium.org/668075 which made the corresponding changes in win & linux
BUG=none
TEST=chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
Review URL: http://codereview.chromium.org/1018003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Valgrind UI tests go green.
TBR=jhawkins
Review URL: http://codereview.chromium.org/1112001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
third_party/tcmalloc/chromium/src.
Review URL: http://codereview.chromium.org/576001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/838008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as URLRequest::set_context() does.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1000006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1099001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41932 0039d316-1c4b-4281-b951-d872f2087c98
|