| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
hellotriangle example in OpenGL ES book to use the application framework.
BUG=26099
TEST=Try running hello_triangle executable, you should see a red triangle.
Review URL: http://codereview.chromium.org/465051
TBR=alokp@chromium.org
Review URL: http://codereview.chromium.org/525019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
erroneously removed.
got overzealous deleting code in r35389
BUG=31391
TEST=see bug
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
bug=test=none
tbr=pink
Review URL: http://codereview.chromium.org/526006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
OpenGL ES book to use the application framework.
BUG=26099
TEST=Try running hello_triangle executable, you should see a red triangle.
Review URL: http://codereview.chromium.org/465051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=16380
TEST=manual
Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/518028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29334
Review URL: http://codereview.chromium.org/523045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=made sure this doesn't trigger with normal sync operations
Review URL: http://codereview.chromium.org/523041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/521018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
result in a sticky popup from the original click.
BUG=31097
TEST=Click on a browser action button (with a popup) twice very quickly. A popup should show up, but once you click outside of it, it should not remain.
Review URL: http://codereview.chromium.org/524023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the user an infobar on all kinds of searches.
BUG=31043
TEST=Legit intranet sites should still produce infobars. Search terms which previously generated infobars on Comcast/Verizon should not.
Review URL: http://codereview.chromium.org/523043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Original patch by Thiago Farina (see http://codereview.chromium.org/522031), r=finnur,me.
BUG=29092
TEST=Select some text in a popup window omnibox, then right-click it. "Copy" should be enabled.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30361
TEST=see bug
Review URL: http://codereview.chromium.org/512002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
by that job.
TEST=existing tests apply
BUG=none
Review URL: http://codereview.chromium.org/523039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/517028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Transform layout tests results moved to a separate '3d' subdir upstream reflecting the move.
Also, there are 2 new tests that will need a baseline.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/524021
TBR=dimich@google.com
Review URL: http://codereview.chromium.org/521023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=ncarter
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/526004
TBR=dimich@google.com
Review URL: http://codereview.chromium.org/517030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
adds unhandled enums in switch statements.
BUG=26104
Review URL: http://codereview.chromium.org/515051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ncarter
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/526004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was in gtk impl, but missing in toolkit_view impl.
BUG=None
TEST=None
test
Review URL: http://codereview.chromium.org/517024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Transform layout tests results moved to a separate '3d' subdir upstream - reflecting the move.
Also, there are 2 new tests that will need a baseline.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/524021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when enabling the extension through the Extensions Management UI.
TBR=mpcomplete
BUG=http://crbug.com/30752
TEST=This requires an extension that autoupdates _and_ increases its
permissions. If you ignore the infobar that says it has been disabled, you
should still get the Install Warning dialog when you try to enable the
extension.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
|documentElement.innerHTML| would cause ExtensionHost::DocumentAvailableInMainFrame to be called more than once for a single RenderViewHost. Since setup is performed within that function that does not need to be done more than once (and cannot be since it registers for notifications from all sources), we check to see if setup has been performed and bail if so.
BUG=31170
TEST=Install the eBay extension (id khhckppjhonfmcpegdjdibmngahahhck ) and click on the browser action button in Debug mode. It should not hit the DCHECK from registering redundant notifications.
Review URL: http://codereview.chromium.org/519036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
We think that r466 of Skia might be triggering valgrind errors. This is to
confirm that.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/525010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=StringUtilTest.Tokenizer
Review URL: http://codereview.chromium.org/502103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/515019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should only actually affect ExtensionPopups as other infobubbles never resize.
BUG=30294
TEST=chromed bird extension resizes after reverting http://trac.webkit.org/changeset/51492
Review URL: http://codereview.chromium.org/526003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jorlow
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as flaky.
Bug=31532
TBR=amit
Review URL: http://codereview.chromium.org/525007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run sync_unit_tests
Review URL: http://codereview.chromium.org/518026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
render if the target
also was rendered in ChromeFrame. This was because we were not marshaling the IMoniker and IBindCtx
interfaces over to the ChromeFrame worker thread. The problem would only occur when we reused the
existing IMoniker.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=30013
We need to post the OnWorkerStop message after we finish stopping the urlmon request object to
prevent a race condition. We also need to pump messages in OnDestroy to ensure that CoUninitialize and
calls like IBinding::Abort which callback into this thread complete correctly.
Bug=30013
Review URL: http://codereview.chromium.org/523018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31300
TEST=yes, layout test
Review URL: http://codereview.chromium.org/524014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
To be marked verified after a green cycle.
BUG=28279
TEST=Verify green unit_tests. Verify this bug.
Review URL: http://codereview.chromium.org/523022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is a second try of cl 524003 -- the previous version caused a leak. The only change in this patch is the addition of the ui_thread_ member in TemplateURLModelTest and the corresponding initializer. This allows the DeleteOnUIThread trait of the WebDataService to do its job.
Review URL: http://codereview.chromium.org/522025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had historically hit meta-refresh loops, and the code appeared
to be too careful to avoid such a loop. This change avoids the
infinite loop, and does at least an SDCH backoff of support
when an infinite loop might otherwise be induced.
BUG=31271
r=kmixter
Review URL: http://codereview.chromium.org/518029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to do so when I deleted the corresponding code (in http://codereview.chromium.org/495004).
BUG=30178
TEST=Trybots (to make sure it builds).
Review URL: http://codereview.chromium.org/521020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(I screwed up and committed in the wrong terminal.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=31511
TEST=reliability_tests shows up in the snapshots dir on mac (will be copied in archive_build of Chromium Mac)
Review URL: http://codereview.chromium.org/525006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes two bugs:
- the output buffer for the ps command being run could be too small (fix: buffer
enlargened); and
- if the output buffer was too small, waitpid() wouldn't be called (fix: always
call waitpid(), obviously).
BUG=31378
TEST=On a big, long-running Chrome/Chromium (with many processes, e.g., renderers), check that there are no zombie ps processes (with PPID the browser process); looking at about:memory may help speed up the creation of such zombies. Also, run the new test, ProcessUtilTest.GetAppOutputRestrictedNoZombies.
Review URL: http://codereview.chromium.org/523033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are actually two problems, with two fixes:
- Remove TabStripController as observer when removing a tab. (Otherwise, there's a race condition which can result in a stale observation.)
- Make sure the TabController (and its TabView) aren't deleted while handling a torn-off tab.
BUG=31138
TEST=Attach/re-attach/move/close tabs under a variety of circumstances (see in particular the situation described in the bug). Do so till the cows come home. It should hopefully not crash. (Perhaps also check a debug build, and make sure no assertions fail.)
Review URL: http://codereview.chromium.org/515066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also pulling in a newer nacl version.
Switching to use AdditionalOptions in list form.
BUG=None
TEST=None
TBR=mmentovai
Review URL: http://codereview.chromium.org/523027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sandbox path mismatches.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/519033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
process listings.
BUG=29118
TEST=none
Review URL: http://codereview.chromium.org/490028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29804
TEST=surf around, hold cmd, three-finger-swipe to the left. previous page should open in new tab. switch to new tab, hold cmd, three-finger-swipe to the right. original page should open in yet another tab.
Review URL: http://codereview.chromium.org/525002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flagging
pages running in IE as running in Chrome. This was because the function was checking
for the presence of the string chrome in the user agent. In ChromeFrame with host networking
enabled the IE user agent contains the string chromeframe, which causes this function to
fail.
This caused the chromeframe unit tests to fail randomly on my machine.
TBR=slightlyoff
Review URL: http://codereview.chromium.org/519027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35439 0039d316-1c4b-4281-b951-d872f2087c98
|