| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
In the sandbox, reading shmmax from proc always fails. Thus, we move
the function into base and call it before starting the sandbox. The
value is then cached.
http://codereview.chromium.org/159843
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using the sandbox, the renderer cannot load the ffmpeg shared
objects from disk. So we load them in the zygote before the sandbox is
started.
(Note that this doesn't get media working, but it's a start.)
BUG=18329
http://codereview.chromium.org/159841
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15952,18385
Review URL: http://codereview.chromium.org/159859
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original author: noel.gordon@gmail.com
Original review: http://codereview.chromium.org/159761
BUG=none
TEST=none
r=me
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involved adding a new method on WebViewDelegate to allow the embedder to
intercept data being loaded for a document.
I also had to plumb a few more FrameLoaderClient notifications through
WebViewDelegate. See DidReceiveResponse and DidFinishLoading.
R=tony
BUG=15648
TEST=covered by errorpage_uitest.cc
Review URL: http://codereview.chromium.org/160578
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the "Google chrome" logo.
BUG=17944
TEST=None
Review URL: http://codereview.chromium.org/159828
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NO CODE CHANGE
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam
BUG=18409
TEST=none
Review URL: http://codereview.chromium.org/159860
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, Flash seems to only start executing script actions after it received an NPP_SetWindow with a
non-NULL NPWindow.window (HDC). It is possible that Flash then invokes JS to modify DOM of the page.
If Flash movie's widget is on-screen at page load, this call is made during layout and before even the NPP_Write is called,
which is the desired sequence of events.
However, if it is off-screen, this call occurs during painting, which leads to re-entrancy issues (layout while painting)
and bizarre crashes.
As a solution, we remove calls to NPP_SetWindow during painting and instead opt to never provide a null HDC to the plugin.
If no valid HDC is available, we feed it a disposable monochrome 1x1 context to have at least something to draw on.
R=ananta,darin,jam
BUG=16114
TEST=LayoutTests/plugins/flash-setwindow-paint-crash.html (bug reduction).
Review URL: http://codereview.chromium.org/159717
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
originally reviewed / committed as http://codereview.chromium.org/160276
TBR=mpcomplete,phadjan.jr
Review URL: http://codereview.chromium.org/159854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senobrlanco
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/160585
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Coverity finds a condition where this leaks. We are at the moment not using it in such a way that it leaks, but that might of course change. It looks to me like the API is not intended to be used in such a way anyway, so we can just check for it and return false.
BUG=15350
TEST=Decoding bookmarks should work as before.
Review URL: http://codereview.chromium.org/159075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/15760
TEST=slight visual change
Review URL: http://codereview.chromium.org/159810
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change enables our custom JumpList by default, i.e. enables our custom JumpList when Chromium is launched without a "--disable-custom-jumplist" option.
BUG=8037
TEST=Right-click the taskbar icon of Chromium on Windows 7.
Review URL: http://codereview.chromium.org/159398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currently.
The bug to track this issue is http://code.google.com/p/chromium/issues/detail?id=18392
Bug=18392
TBR=nsylvain
Review URL: http://codereview.chromium.org/160581
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
22369 to change stream
IPCs from sync to async and introduced deferred stream loads in the process.
Updating the test expectations to get the webkit tests green while I debug this issue.
The bug to track this issue is http://code.google.com/p/chromium/issues/detail?id=18392
Bug=18392
TBR=nsylvain
Review URL: http://codereview.chromium.org/160579
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mnaganov
Review URL: http://codereview.chromium.org/159851
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159849
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18378
Review URL: http://codereview.chromium.org/159850
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reliability tests regressions caused by this patch have been addressed by the upstream bug fix https://bugs.webkit.org/show_bug.cgi?id=27769
The IPCs for carrying data requested by plugins have been changed from synchronous IPCs to asynchronous IPCs.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=14323,
where the Flash plugin would not render content on the page if these IPCs were processed while the plugin waited for sync calls like NPN_Evaluate to return.
This CL also fixes the following bugs, which were crashes in reliability test runs when this patch was landed last time.
http://code.google.com/p/chromium/issues/detail?id=18058
http://code.google.com/p/chromium/issues/detail?id=18059
The crash happens because of NPP_Write calls issued to the plugin while it is waiting for an NPN_Invoke call to return in the context of NPP_NewStream. Inspecting the safari plugin implementation revealed that they defer the resource load before calling the plugin and restore it on return.
We emulate this behavior via an IPC sent from the plugin which serves as an acknowledgement.
Test=covered by UI tests.
Bug=14323,18058,18059
Review URL: http://codereview.chromium.org/159746
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Had to move set_path() earlier in the unpack process so that we would have real paths for the resources, so that we could load and display the icon in the ui.
This exposed a problem where page actions had absolute paths and other images in extensions had relative paths. Extension::GetBrowserImages() was expecting relative paths, and it just happened to work because in both cases Extension was initialized without a path.
Modified page actions to use relative paths to be consistent with other images.
Review URL: http://codereview.chromium.org/160516
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18070
TEST=none
Review URL: http://codereview.chromium.org/160509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=pfeldman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
valgrind test failure.
This CL implements the second TODO item of issue 12343:
2) We should send back an ACK to the second process. If the second process doesn't get an ACK in the given timeout, it should kill the first process and go ahead and start.
The approach of this CL is to append process id to the singleton's socket filename, such as "SingletonSocket-12345", and creates a symbol link "SingletonSocket" to the real socket file. In ProcessSingleton::NotifyOtherProcess() if it's successfully connected to "SingletonSocket" but no ACK received, then the original process can be killed by its process id retrieved from the symbol link.
BUG=12343 ProcessSingleton Linux cleanups
TEST=In one terminal, launch chrome and stop the process by pressing ctrl-z, then launch chrome again in another terminal. The second chrome shall be started in 5 seconds, and the first one shall be killed.
Review URL: http://codereview.chromium.org/160436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
figure out how to get chrome_dll to use a different PlatformMessagePortChannel implementation from test_shell (see http://codereview.chromium.org/160570 for what I tried). I gave up afterwards, since anyways they test that the default WebKit implementation works, which we know from the WebKit buildbot. Our multi-process implementation is tested using ui_tests.
Review URL: http://codereview.chromium.org/160574
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This was a TODO, since that function is useful outside of HTTP.
In the process, I uncovered some test cases in proxy_service that are passing in invalid URLs (by virtue of the extra DCHECK). This doesn't make much sense to me to support that, so I have changed them.
Review URL: http://codereview.chromium.org/160558
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromiumBridge (as a result of the roll).
The bots were good up until my change and this is breaking them now, so I think I might just commit TBR.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160564
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'm sending this first, then I'll add support to workers in another changelist to avoid making this change larger.
TEST=running message port related layout tests in ui_tests
Review URL: http://codereview.chromium.org/159372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Download something and notice the nice download arrow animation.
BUG=14661 (http://crbug.com/14661)
Review URL: http://codereview.chromium.org/159623
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Everything is better than cmd-f11.
BUG=17218
TEST=obvious
Review URL: http://codereview.chromium.org/159781
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
different error for this webarchive test. Add the new baselines.
TBR=brettw
Review URL: http://codereview.chromium.org/160561
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added tests to gyp build
Review URL: http://codereview.chromium.org/159835
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160557
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
needed.
Review URL: http://codereview.chromium.org/159831
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and docs building to the GYP build.
Review URL: http://codereview.chromium.org/159825
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix minor issues in new ftp code.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/160541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
net/url_request/url_request_status.h
Review URL: http://codereview.chromium.org/159818
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http/tests/misc/favicon-loads-with-images-disabled.html.
Implement layoutTestController.disableImageLoading() and put
in a placeholder for layoutTestController.setIconDatabaseEnabled()
(because we don't use the icon database).
These methods are used by
http/tests/misc/favicon-loads-with-images-disabled.html, but the
test still fails because our resource loader output is different.
Go ahead and rebaseline for the difference.
BUG=18355
Review URL: http://codereview.chromium.org/159820
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that on Windows the path-splitting function will always preserve the drive part (c:\).
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159827
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pointer.
This was crashing for me with the theme I had installed.
Review URL: http://codereview.chromium.org/160550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Downloads.
BUG=15899
TEST=A dialog asking the user if they want to quit when there are downloads
in progress will be displayed when the user tries to exit under that
condition.
Review URL: http://codereview.chromium.org/159424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tracking it.
BUG=http://crbug.com/18373
Review URL: http://codereview.chromium.org/160552
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160545
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Requests per group + 1.
In the histograms for Net.SocketRequestTime, late binding has a much longer tail. This is presumably because I didn't implement timeouts and CancelRequest() never cancelled jobs. I'm limiting TCPConnectJobs to 60 seconds and cancelling jobs if there are too many more than there are requests.
Review URL: http://codereview.chromium.org/160499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
leaking through.
BUG=18172
TEST=Look at the lower left and right corners of the thumbnails on the
new new tab page. There should bot be any dark pixels there.
Review URL: http://codereview.chromium.org/160549
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I tried to be clever before, but I turned out needing brute force.
BUG=17647
Review URL: http://codereview.chromium.org/159822
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22336 0039d316-1c4b-4281-b951-d872f2087c98
|