| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/40189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make them get destructed after browser shutdown, make them a member variable of BrowserRenderProcessHost.
Review URL: http://codereview.chromium.org/39218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
have already impacted Window itself, but a NULL check was already inserted in that code.
http://crbug.com/4355
Review URL: http://codereview.chromium.org/40183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
HTTP version in the http_version_ member. Pass NULL to
EnumerateHeader.
R=eroman
Review URL: http://codereview.chromium.org/40137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/39216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This means we will no longer get "missing expected output".
The tests are surely still failing.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The FileDescriptor API is clearly too hard to use. It's the only IPC
data type which is non-POD and serialising an invalid file descriptor
is fatal to Chrome on POSIX. The use of Maybe is possibly non-obvious
to non-functional programmers.
This patch merges Maybe and FileDescriptor so that serialising invalid
file descriptors is permitted and results in -1 at the other end.
(Serialising /closed/ a file descriptor is still fatal.) Also, it adds
a pointer in base/file_descriptor.h to instructions for its use with
IPC. Although it's generally bad practice to mention IPC in base, in
this case I cannot find another suitable location.
Review URL: http://codereview.chromium.org/39208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
call functions in the rest of Chromium code without having to go through ChromiumBridge (which now lives upstream in the WebKit repository).
R=darin,mbelshe
Review URL: http://codereview.chromium.org/40132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFont::GetExpectedTextWidth to use dlu_base_x _or_ average
character width (depending on which one is smaller).
BUG=8331
TEST=Open About box in all languages and make sure it is roughly
the same size as it was in 1.0.
Review URL: http://codereview.chromium.org/39214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
deleted.
BUG=8217
R=kuchhal
Review URL: http://codereview.chromium.org/27307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and actually looked better than the baseline.
Review URL: http://codereview.chromium.org/40181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
would not focus the location bar.
DOM UI now by default focus the page.
The NTP one focus the location bar.
Also removed some unused fields from the history and download DOM UI.
BUG=8356
TEST=Open NTP, focus should be on location bar
Review URL: http://codereview.chromium.org/39173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Split the lines >80 cols. (Part 1)
Review URL: http://codereview.chromium.org/39206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
between Windows and Mac.
Review URL: http://codereview.chromium.org/40180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
different - the diagonal lines are anti-aliased in a slightly different shade, and the text is drawn differently.
Review URL: http://codereview.chromium.org/39053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not the enclosing frame." The diffrence between this one and the previous version
of this patch is the addition of test_webview_delegate.
BUG=1686837
Review URL: http://codereview.chromium.org/39163
Review URL: http://codereview.chromium.org/40175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=24299
This is everything up to "not supposed to be using STL container classes."
Review URL: http://codereview.chromium.org/40122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
now, so everytime this appears was dead code.
Review URL: http://codereview.chromium.org/39200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
several layout tests that required these strings. We need to rebaseline them because the strings Chromium uses differ from the strings WebKit.org uses.
Review URL: http://codereview.chromium.org/40170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
scrolled. Basically, when a spell check language changes, it is added to the accept languages list so that it is remembered later. However, when the list gets scrolled, it keeps adding all the languages it scrolled. So, I decided to fix this by adding only the latest language selected as the spell check dictionary language in the drop down.
Issue=8374
Review URL: http://codereview.chromium.org/40145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
RenderWidget, since that could lead to the terminateworker message being dropped.
Review URL: http://codereview.chromium.org/39176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
all platforms. Also, we sort dictionary keys by value so
the path moved.
BUG=8339
Review URL: http://codereview.chromium.org/39174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I changed two instances of kUnrelatedControlLargeVerticalSpacing to
the shorter kUnrelatedControlVerticalSpacing.
Tested on XP (Luna, no theme) and Vista Aero.
BUG= 5511
R= ben
Review URL: http://codereview.chromium.org/40148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Committed on behalf of Craig Schlenter.
http://codereview.chromium.org/40158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/39210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=eroman
Review URL: http://codereview.chromium.org/39198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
enclosing frame.
BUG=1686837
Review URL: http://codereview.chromium.org/39163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
../third_party/WebKit/WebCore/dom/Document.cpp don't stop the build.
Review URL: http://codereview.chromium.org/39155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
needed rebaseline in the mean time. the original baselines where taken
with the wrong scrollbar, font, etc. settings. So both the image and the text
expects were wrong.
Review URL: http://codereview.chromium.org/39195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/39197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8338
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/39175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
that trigger this rule at the moment.
Review URL: http://codereview.chromium.org/39192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10992 0039d316-1c4b-4281-b951-d872f2087c98
|