| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=msw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, skia rolls are guaranteed to get an "update failed" from the trybots, because webkit changes so often and lkgr is unpredictable. It's annoying having to pass -r to git try every time.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
necessarily the underlying issue.
BUG=66962
TEST=manually open n copies of print.html as described in the bug entry.
Review URL: http://codereview.chromium.org/6121003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hclam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
sending the crash reports and UMA to Google.
BUG=64677
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Metrics
Review URL: http://codereview.chromium.org/5319006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69414
TEST=None
Review URL: http://codereview.chromium.org/6226007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5972007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes excess calls to Layout by ensuring that the View is visible
before the call to SetBounds.
BUG=none
TEST=keyboard still displays the first time a text field is focused
Review URL: http://codereview.chromium.org/6238001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Rerun RenderWidgetHostUnitTest.*
Review URL: http://codereview.chromium.org/6010004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
definitions to match declarations. Use STL util function. Eliminate pointless comment.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6224005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=67345,67939,66718
Review URL: http://codereview.chromium.org/6110008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=it compiles
Review URL: http://codereview.chromium.org/6166008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the mechanism to take a screenshot over to CG; we now just take a direct bit dump of the window into an image and convert that to a png.
BUG=69160
TEST=Tested with sending feedback from a Mac; screenshot appeared on screen and on the report correctly.
Review URL: http://codereview.chromium.org/6121005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also make the thumbnails left-aligned. The reason for this is that when thumbnails are closed, the reshuffling algorithm looks a bit busy. We want to eventually slide thumbs out on the left side on the window and then slide them back in from the right.
BUG=50307
TEST=
* Hover a thumb. It should show a close button.
* Press opt. All thumbs should show a close button.
* Press a close button. Thumb should close, the rest of the tabs should reshuffle.
Review URL: http://codereview.chromium.org/5960008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Module->Instance CL missed this file.
BUG= code.google.com/p/nativeclient/issues/detail?id=901
TEST=this one
Review URL: http://codereview.chromium.org/6222003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify SingleSplitView to calculate its children view's bounds, but do not actually resize them
and change BrowserViewLayout accordingly (BrowserViewLayout resizes all views now).
Do all reserved contents rect calculations before resizing TabContents views.
Rationale: to do all BrowserView layout related actions in the context of
BrowserViewLayout::Layout call and to minimize actual contents re-layouts.
BUG=51084
TEST=All tests should pass
Review URL: http://codereview.chromium.org/5606012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:10843
TEST=Verify fix for chromium-os:10843 and chrome://settings/internet etc work as expected.
Review URL: http://codereview.chromium.org/6138008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69436,12525
TEST=Less random red on Mac valgrind bots
Review URL: http://codereview.chromium.org/6208006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
prompts are displayed when the user browses to GCF-enabled sites, allowing the user to permanently activate, permanently decline, or temporarily decline Chrome Frame.
BUG=None
TEST=chrome_frame_unittests --gtest_filter=Ready* && chrome_frame_unittests --gtest_filter=Infobar* && setup.exe --chrome-frame --ready-mode --multi-install --system--level --chrome
Review URL: http://codereview.chromium.org/6040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69433
TEST=none
Review URL: http://codereview.chromium.org/6152006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The binhash will be in this format for add-data ans sub-data:
ADD-DATA = (PREFIX)+
PREFIX = <HASHLEN unsigned bytes>
SUB-DATA = (ADDCHUNKNUM PREFIX)+
ADDCHUNKNUM = <4 byte unsigned integer in network byte order>
PREFIX = <HASHLEN unsigned bytes>
BUG=60822
TEST=safe_browsing_database_unittest.cc,protocol_parser_unittest.cc
Review URL: http://codereview.chromium.org/6025002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
... per review at <http://codereview.chromium.org/6228004>.
BUG=none
TEST=builds
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/6157009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69195
TEST=play Z-Type for hours :)
Review URL: http://codereview.chromium.org/6157007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
can send that patch to the tryservers.
TBR=viettrungluu
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6157006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The color space was hardcoded as "generic rgb" in skia. This is not always correct, also skia is changing this color space around a lot currently. To protect us from their unreliable default, hardcode "generic rgb" as default on our side for now, but make it possible for clients to provide their own color space.
Use this to let tabpose and the favicon code pass in the device colorspace.
BUG=24267,50307
TEST=Open tabpose. Delayed thumbnails should look like backing-store backed thumbnails. The colors of favicons should now match other browsers.
Review URL: http://codereview.chromium.org/6117006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DNS pre-resolution.
BUG=64356
TEST=see bug
Review URL: http://codereview.chromium.org/6145005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69248
TEST=Manual: open find bar and hit alt on debug build.
Review URL: http://codereview.chromium.org/6156009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6200005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes
This CL fixes two problems with CAPTCHA handling in the case where we
are attempting to re-auth with a new password. First, in cases where
repeated auth attempts triggered a CAPTCHA, we were not reporting this
to the UI correctly. Second, in cases where the user was re-prompted
for her password AND was in the CAPTCHA state, we weren't keeping
track of the captcha token properly, and so we were not actually able
to clear the CAPTCHA at all.
BUG=chromium-os:10155
TEST=unit tests, install on device and try it
Review URL: http://codereview.chromium.org/6190004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
libgnome-keyring.
BUG=69295
TEST=on some distributions, under certain conditions, we don't crash any more
Review URL: http://codereview.chromium.org/6160008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=cbentzel
BUG=69414
TEST=Greener valgrind/heapcheck bots
Review URL: http://codereview.chromium.org/6221006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* disable Clipboard
* TraveralTest wasn't correctly disabled. This CL fixes it.
BUG=none
TEST=views_unittests, unittests on Win should cycle green.
Review URL: http://codereview.chromium.org/6198006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stronger gyp warnings
with the fixes needed so we everything will stay green.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6128009
TBR=bradnelson@google.com
Review URL: http://codereview.chromium.org/6189007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6220005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=68516
TEST=none
Review URL: http://codereview.chromium.org/6231005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
print_web_view_helper.cc
BUG=none
TEST=printing works after code changes.
Review URL: http://codereview.chromium.org/6165004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Created common test base class for views.
Note: Textfield::RequestFocus is failing because Windows' FocusManager::ClearNativeFocus resets the focused view to NULL for some reason. I don't have win at hand and am now requesting win7. I will look into it once I've got win7.
BUG=none
TEST=native_textfield_views_unittest and textfield_views_model_unittest have been enabled for win.
Review URL: http://codereview.chromium.org/6102003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running a nested mesage loop in request_info->peer->OnReceivedRedirect() call. The loop might kill the instance of PendingRequestInfo what caused this crash. The fix simply checks for validity of PendingRequestInfo one more time within this OnReceivedRedirect() method.
BUG=chromium:65345, chromium-os:10721
TEST=sign up with gmail, try to switch account to another one - there should be no crash. see http://crosbug.com/10721 for more detailed repro steps
Review URL: http://codereview.chromium.org/6211005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/test/data/import/firefox/linux.zip
Revert 71180 - Fixed crash caused by ResourceDispatcher::OnReceivedRedirect() indirectly running a nested mesage loop in request_info->peer->OnReceivedRedirect() call. The loop might kill the instance of PendingRequestInfo what caused this crash. The fix simply checks for validity of PendingRequestInfo one more time within this OnReceivedRedirect() method.
BUG=chromium:65345, chromium-os:10721
TEST=sign up with gmail, try to switch account to another one - there should be no crash. see http://crosbug.com/10721 for more detailed repro steps
Review URL: http://codereview.chromium.org/6211005
TBR=zelidrag@chromium.org
Review URL: http://codereview.chromium.org/6100012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running a nested mesage loop in request_info->peer->OnReceivedRedirect() call. The loop might kill the instance of PendingRequestInfo what caused this crash. The fix simply checks for validity of PendingRequestInfo one more time within this OnReceivedRedirect() method.
BUG=chromium:65345, chromium-os:10721
TEST=sign up with gmail, try to switch account to another one - there should be no crash. see http://crosbug.com/10721 for more detailed repro steps
Review URL: http://codereview.chromium.org/6211005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=13943, 13746, 13749, 13597, 13249, 13145, 12875, 12874, 12871, 12438, 12436, 12431
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6076006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support alpha blending, post-process the
metafile to replace the AlphaBlend calls with BitBlts from a software-composited rendering of the page so far.
BUG=7434
TEST=see bug
Review URL: http://codereview.chromium.org/5362002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=68882
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6121004
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6134010
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/6130008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mark PrintPreviewUITest.PrintCommandDisabled flaky.
BUG=69389,69390
TEST=none
Review URL: http://codereview.chromium.org/6184003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=leak 000000002551055A goes away
Review URL: http://codereview.chromium.org/6173009
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/6128010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64870 64922
TEST=none
Review URL: http://codereview.chromium.org/6174002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no log parser errors on heapcheck bot
Review URL: http://codereview.chromium.org/6220004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=leak 000000002551055A goes away
Review URL: http://codereview.chromium.org/6173009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71170 0039d316-1c4b-4281-b951-d872f2087c98
|