summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Eliminate a lot of duplicated implementations of Get/SetAccessibleName() by ↵pkasting@chromium.org2010-04-0339-310/+32
| | | | | | | | | | just putting it on the base class. Also cleans up a couple other misc. accessibility functions in view.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/1512012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43558 0039d316-1c4b-4281-b951-d872f2087c98
* Change ui_tests to pull the directories it needs from the upstream webkitdpranke@chromium.org2010-04-034-11/+35
| | | | | | | | | | | | | | | | | | tree directly rather than relying on webkit/data/layout_tests for the baselines. This requires us to change a few spots in the source code because the directory naming conventions for platform-specific baselines is different upstream (it's platform/chromium-win/foo rather than platform/chromium-win/LayoutTests/foo). Once this test lands we can (in theory) remove the downstream layout test baselines. BUG=none TEST=none R=dimich@chromium.org Review URL: http://codereview.chromium.org/1547009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43557 0039d316-1c4b-4281-b951-d872f2087c98
* Revert.evan@chromium.org2010-04-038-181/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43556 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Use the FormManager cache to send forms to the AutoFillManager.jhawkins@chromium.org2010-04-0327-531/+448
| | | | | | | | | | | Remove the FormFieldValues class and replace its usage with FormData. BUG=38325,33032 TEST=none Review URL: http://codereview.chromium.org/1606005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43555 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.evan@chromium.org2010-04-031-2/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43554 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Implement status icons on linux.evan@chromium.org2010-04-038-1/+178
| | | | | | | | | | | BUG=37375 TEST=out/Debug/unit_tests --gtest_filter=StatusTrayGtkTest.* Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1421001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43553 0039d316-1c4b-4281-b951-d872f2087c98
* Added themes to CustomizeSyncWindowGtkdantasse@chromium.org2010-04-031-1/+17
| | | | | | Review URL: http://codereview.chromium.org/1589014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43552 0039d316-1c4b-4281-b951-d872f2087c98
* Move the 'activate' part out of list and add an activate-command with ↵arv@chromium.org2010-04-032-32/+34
| | | | | | | | | | | keyboard shortcuts set on the command. This solves the issue of having platform specific activation keyboard shortcuts and move that to the command. BUG=39715 TEST=Try double clicking on bookmarks and folders in the list. Also try selecting one or multiple items (including folders). If a single folder is selected we should navigate to the folder instead of opening the items in the folder. Review URL: http://codereview.chromium.org/1569019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43551 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the change that was checked in by accident.oshima@chromium.org2010-04-032-17/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1560014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43550 0039d316-1c4b-4281-b951-d872f2087c98
* Removing crashing test that should not crash, at least until fix is found.dhg@chromium.org2010-04-021-1/+0
| | | | | | Review URL: http://codereview.chromium.org/1530018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43549 0039d316-1c4b-4281-b951-d872f2087c98
* mac translate infobar: fix incorrect language selectedkuan@chromium.org2010-04-021-9/+21
| | | | | | | | | | | | - mac was using index of menu item to manipulate languages; this was broken when i sorted the languages by application locale - this cl fixes the problem by manipulating languages with command ids which directly map into the languages arrays in translate delegate. BUG=40271 TEST=verify per bug report Review URL: http://codereview.chromium.org/1585016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43548 0039d316-1c4b-4281-b951-d872f2087c98
* Advance string changes for bugs 29332 and 31778.johnnyg@chromium.org2010-04-021-2/+26
| | | | | | | | | BUG=29332,31778 TEST=none, just strings Review URL: http://codereview.chromium.org/1549017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43547 0039d316-1c4b-4281-b951-d872f2087c98
* Audio cut off ~500ms too earlyhclam@chromium.org2010-04-022-3/+5
| | | | | | | | | | | | | | | | BUG=23055 TEST=layout tests and audio won't cut off too early with this file: http://commons.wikimedia.org/wiki/File:Montreal2.ogg This patch fix the problem by adding an extra condition to determine the end of playback by using the information of buffered audio data in the browser process. If both the renderer process and browser process don't have any more audio data then end of playback is resulted. Review URL: http://codereview.chromium.org/1581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43546 0039d316-1c4b-4281-b951-d872f2087c98
* Add Flash EULA to about box on Windows/Views (for branded builds).viettrungluu@chromium.org2010-04-022-5/+50
| | | | | | | | | BUG=none TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Te rms of Service, with "License Agreement" an appropriate link. Review URL: http://codereview.chromium.org/1561010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43545 0039d316-1c4b-4281-b951-d872f2087c98
* updating testdhg@chromium.org2010-04-021-2/+2
| | | | | | Review URL: http://codereview.chromium.org/1551015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43544 0039d316-1c4b-4281-b951-d872f2087c98
* Add batchAdd functions to JS Listfeldstein@chromium.org2010-04-022-4/+41
| | | | | | | | | | | | | | BMM can be really slow to render when there are hundreds of bookmarks in the bookmark bar. This will hide the list while it's rendering the new elements which increases performance by a lot since it doesn't have to do any measurements while it's adding all the elements. BUG=39865 TEST=Load BMM with over 500 bookmarks in the bookmark bar Review URL: http://codereview.chromium.org/1540014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43543 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some Sync stringsdantasse@chromium.org2010-04-025-17/+22
| | | | | | Review URL: http://codereview.chromium.org/1600004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43542 0039d316-1c4b-4281-b951-d872f2087c98
* CHanging the mount library to mount the drives explicitly. Adding the notion ↵dhg@chromium.org2010-04-024-10/+42
| | | | | | | | of parent devices as well. Review URL: http://codereview.chromium.org/1608004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43541 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Magnifying glass in keyword-search bubble.shess@chromium.org2010-04-023-23/+69
| | | | | | | | | | | | | | | Abstract the image-in-attributed-string code into a helper function so everyone makes the same mistakes. The keyword-search string's baseline became wrong at some point, adjust it to match the rest of the field. BUG=37865 TEST=Type "google.com" until "press tab to search" appears, hit TAB. "Search Google:" bubble should have a magnifying glass on the LHS. TEST=Add a bunch of text to search. Resizing smaller should first remove the image, then change to shorter text ("Search Go..." or somesuch). Review URL: http://codereview.chromium.org/1581011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43540 0039d316-1c4b-4281-b951-d872f2087c98
* Implement protocol definitions for the SPDY SETTINGS frame (previouslymbelshe@chromium.org2010-04-025-22/+200
| | | | | | | | | | | | labeled the HELLO frame). BUG=none TEST=SpdyProtocolTest. Review URL: http://codereview.chromium.org/1569018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43535 0039d316-1c4b-4281-b951-d872f2087c98
* Include the appcache and database tracker databases into the sql diagnostics ↵michaeln@chromium.org2010-04-0211-78/+154
| | | | | | | | | | | | fold. TEST=manual BUG=none Review URL: http://codereview.chromium.org/1508016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43534 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate unnecessary dependencies on OpenGL.framework.mark@chromium.org2010-04-021-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | I'm only making this change for the Mac because I can't test it for other platforms right now, but as a general rule, libraries belong inside link_settings sections, not all_dependent_settings (or both). all_dependent_settings says that anyone that depends on a given target, even transitively through a long chain, inherits the enclsoed settings. In this case, chrome_exe and helper_app would inappropriately be linked against OpenGL.framework, even though they did not need to be. It is enough for chrome_dll to link against OpenGL.framework. For that matter, the non-library uses of all_dependent_settings in this file are probably wrong, too. Generally, they should be replaced with direct_dependent_settings. Inappropriate use of all_dependent_settings results in -Defines and -Includes leaking, and can cause problems for remote downstream targets. BUG=none TEST=otool -L GC.app/Contents/MacOS/GC should not show OpenGL.framework Review URL: http://codereview.chromium.org/1604009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43533 0039d316-1c4b-4281-b951-d872f2087c98
* #include what you use: <Security/Security.h> for SecKeychainAddCallback andmark@chromium.org2010-04-021-0/+1
| | | | | | | | | | friends following r43492. BUG=none TEST=none Review URL: http://codereview.chromium.org/1570010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43532 0039d316-1c4b-4281-b951-d872f2087c98
* Behaving nice with AutoFill servers: Adjusting upload rate, processing 500, ↵georgey@chromium.org2010-04-0211-42/+384
| | | | | | | | | | 502 and 503 responses, etc. TEST=Unit-tested + by setting up the response from AutoFill server. BUG=39921 Review URL: http://codereview.chromium.org/1535011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when an extension bg page calls alert(). Add regression tests thismpcomplete@chromium.org2010-04-025-3/+48
| | | | | | | | | | time. BUG=37567 Review URL: http://codereview.chromium.org/1602005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43530 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add geolocation exceptions window.mattm@chromium.org2010-04-025-13/+292
| | | | | | | | | BUG=39820 TEST=manual Review URL: http://codereview.chromium.org/1518010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43529 0039d316-1c4b-4281-b951-d872f2087c98
* New tab perfbot didn't like this.jrg@chromium.org2010-04-021-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting to confirm this was the cause. Even if proven the cause my plan is to re-land since this fixes a visible bug but fix perf in a different way. BUG=40225 Revert 43419 - Fix floating bookmark bar on windows. IsBookmarkBarVisible() continues to have a consistent meaning across platforms, but extra logic has been added to windows to be smarter about when to show the bar. Such extra logic also is consistent across platforms (e.g. see browser_window_gtk.cc and bookmark_bar_gtk.cc). Problem introduced with http://codereview.chromium.org/1461001 BUG=http://crbug.com/39559 Review URL: http://codereview.chromium.org/1594009 TBR=jrg@chromium.org Review URL: http://codereview.chromium.org/1539017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43528 0039d316-1c4b-4281-b951-d872f2087c98
* In-app installation when running from a disk image.mark@chromium.org2010-04-026-0/+511
| | | | | | | | | BUG=28986 TEST=Launch from a disk image without having a copy already installed in /Applications, and with permission to write to /Applications. Review URL: http://codereview.chromium.org/1599011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43527 0039d316-1c4b-4281-b951-d872f2087c98
* Extension Docs (No building or testable files).rafaelw@chromium.org2010-04-023-121/+32
| | | | | | | | | | | This changes adds documentation for the recently-landed right-click to inspect popup behavior for page and browser actions. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/1226002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43526 0039d316-1c4b-4281-b951-d872f2087c98
* Change the inactive window for notification from 3000 to 30 days.mal@google.com2010-04-021-1/+1
| | | | | | | | | BUG= 39906 R= cpu TEST= see manual test plan Review URL: http://codereview.chromium.org/1575014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43525 0039d316-1c4b-4281-b951-d872f2087c98
* We should delete the underlying persistent public key onlywtc@chromium.org2010-04-023-9/+9
| | | | | | | | | | | | | | when we cannot sign the challenge. This matches what Mozilla does. Fix nits. R=snej BUG=148 TEST=No compilation errors. Review URL: http://codereview.chromium.org/1535016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43524 0039d316-1c4b-4281-b951-d872f2087c98
* Add calling frame's source_url to extension and dom ui requests.rafaelw@chromium.org2010-04-0223-59/+149
| | | | | | | | Additionally, in the extension and tabs api, compute & report UMA histogram data for relative URL use in API calls so we can decide if it's possible to change the behavior of relative url resolution to use the calling frame's url rather than the extension's base url. Review URL: http://codereview.chromium.org/1605005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43523 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HMAC-SHA-256.wtc@chromium.org2010-04-024-20/+178
| | | | | | | | | R=albertb BUG=none TEST=added new HMAC unit tests Review URL: http://codereview.chromium.org/1513012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43522 0039d316-1c4b-4281-b951-d872f2087c98
* fix product name gooferikkay@chromium.org2010-04-021-1/+1
| | | | | | | | TBR=mirandac Review URL: http://codereview.chromium.org/1530016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43520 0039d316-1c4b-4281-b951-d872f2087c98
* Insure that the bookmark bubble comes up properly aligned when the browser ↵mrossetti@chromium.org2010-04-026-16/+32
| | | | | | | | | | | | is in full-screen mode and the floating bar is not showing by having the floating bar come up. BUG=39428 TEST=1) Enter full-screen mode. Press Cmd-D and verify that the floating bar appears and that the bubble is properly aligned. Press 'Remove' and verify that the floating bar goes away. Repeat but this time press 'Done'. Repeat once again and this time press 'Edit' and verify that the bubble goes away but the floating bar remains until the bookmark editor is dismissed with the editor pane appearsing off the bottom of the floating bar. 2) Exit full-screen mode and perform the above exercises to insure that the bookmark bubble and bookmark edit window are still presented as expected: Press Cmd-D and verify that the bubble is properly aligned. Press 'Remove' and verify that the bubble goes away. Repeat but this time press 'Done'. Repeat once again and this time press 'Edit' and verify that the bubble goes and that the bookmark editor pane is presented off the bottom of the Chrome toolbar. Review URL: http://codereview.chromium.org/1539011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43519 0039d316-1c4b-4281-b951-d872f2087c98
* Make plugin descriptions, etc. in chrome://plugins display as LTR.viettrungluu@chromium.org2010-04-021-14/+9
| | | | | | | | | | | | | | Otherwise parentheses, periods, etc. look wrong with RTL languages. Note that for RTL languages, tables should still be layed out right-to-left (and cells should be aligned to the right). BUG=34306 TEST=Set your language to your favourite RTL language. Go to chrome://plugins/. Everything should look correct. Expand Details -- everything should look correct. Everything should still look correct in LTR languages as well. Review URL: http://codereview.chromium.org/1593010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43518 0039d316-1c4b-4281-b951-d872f2087c98
* GTK browser actions toolbar fiddling:estade@chromium.org2010-04-029-64/+148
| | | | | | | | | | | | - make the toolbar size restore properly when the toolbar is created before the model is loaded - allow the user to right click menu items in the overflow menu BUG=40068 (sorta) TEST=manual Review URL: http://codereview.chromium.org/1602003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43515 0039d316-1c4b-4281-b951-d872f2087c98
* Add more tests to bookmark manager apifeldstein@chromium.org2010-04-021-74/+157
| | | | | | | | | | | | Add Subtree and folders only tests, enable copy/paste tests on mac, and add test for copying empty folders. BUG=none TEST=browser_tests --gtest_filter=ExtensionApiTest.BookmarkManager Review URL: http://codereview.chromium.org/1594011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43514 0039d316-1c4b-4281-b951-d872f2087c98
* Use -[NSString UTF8String] to form a char* from an NSException.mark@chromium.org2010-04-021-1/+1
| | | | | | | | | BUG=none TEST=If this exception is ever caught, it should log a message, not the NSException pointer's address. Review URL: http://codereview.chromium.org/1518015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43513 0039d316-1c4b-4281-b951-d872f2087c98
* Mention the "unlimited_storage" permission in the extensions docs.dumi@chromium.org2010-04-021-1/+6
| | | | | | | | | | BUG=27688 TEST=none Review URL: http://codereview.chromium.org/1556016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43512 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the themeing from the folder menu background, text in the folder menu ↵mrossetti@chromium.org2010-04-0217-92/+191
| | | | | | | | | | | items, and no longer needed calls. Changed the menu button stroke color to a lighter shade of black. Did a bit of refactoring of how bookmark buttons are created. BUG=39428 TEST=Pop up a folder menu and insure that the background does not adopt any theme settings. Review URL: http://codereview.chromium.org/1589005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43511 0039d316-1c4b-4281-b951-d872f2087c98
* Fix copying/dragging of empty folders in BMM on macfeldstein@chromium.org2010-04-021-0/+4
| | | | | | | | | | | | | The code was assuming there was at least one url. There is still a js error in the BMM on all platforms that I've run into a couple of times, but I want to check this in while I look into that. BUG=39229 TEST=Copy or drag an empty bookmarks folder Review URL: http://codereview.chromium.org/1456003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43510 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: avoid double-conversion of URL string.viettrungluu@chromium.org2010-04-021-6/+5
| | | | | | | | | BUG=none TEST=home page text field in prefs continues to work as before Review URL: http://codereview.chromium.org/1529011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43509 0039d316-1c4b-4281-b951-d872f2087c98
* Polish new user login screen:dpolukhin@chromium.org2010-04-023-38/+29
| | | | | | | | | | | | | - create new account should looks like link - removed username and password labels, they should be visible as background text in input fields if user hasn't typed anything yet. BUG=none TEST=Create new account should be link on Chromium OS login screen. Review URL: http://codereview.chromium.org/1593005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43508 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed GPU process startup crash on Linux. Because there was no currentkbr@google.com2010-04-024-66/+85
| | | | | | | | | | | | | | | | OpenGL context, glXGetCurrentDisplay() was returning NULL, leading to crashes in glXQueryVersion. Exposed a new glxewContextInitWithDisplay from GLEW allowing the caller to supply the display connection. Built both with and without GLEW_MX to ensure GLEW changes compile in both scenarios. BUG=40148 TEST=ran WebGL demos in debugger, verified Display* passed to glXQueryVersion Review URL: http://codereview.chromium.org/1556015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43507 0039d316-1c4b-4281-b951-d872f2087c98
* * WidgetGtk::OnKeyPressed never called on window because the signal handleroshima@chromium.org2010-04-023-12/+76
| | | | | | | | | | | | was connected to the content, but the focus was set to GtkWindow by FocusManager. * Enable IgnoreKeyupForAccelerators for linux. BUG=40140 TEST=IgnoreKeyupForAccelerators shoud pass now on linux. Review URL: http://codereview.chromium.org/1575001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43506 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a data race in WebDataServicetimurrrr@chromium.org2010-04-021-0/+7
| | | | | | | | | | Please not that a suppression is NOT a fix for the race! BUG=40244 TBR=glider,tim Review URL: http://codereview.chromium.org/1585015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43505 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that we go to existing open bookmark manager when pressing ↵arv@chromium.org2010-04-022-1/+58
| | | | | | | | | | | Shift+Ctrl+B BUG=37354 TEST=ui_test.exe --gtest_filter=BookmarksUITest.* Review URL: http://codereview.chromium.org/1519015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43503 0039d316-1c4b-4281-b951-d872f2087c98
* Add extra views to the new net internals page. This adds tabs along the top ↵eroman@chromium.org2010-04-0212-242/+737
| | | | | | | | | for proxy, dns, sockets, requests, and http cache subsections. The actual subviews are placeholders. BUG=37421 Review URL: http://codereview.chromium.org/1593009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43502 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the way setup gets the system locale by getting the user's default ↵gwilson@google.com2010-04-021-1/+1
| | | | | | | | | | | | locale ID instead of the thread Locale. R=cpu,kuchhal BUG=39986 TEST=Shortcuts created on install should be in the user's default language, not system language, also see bug Review URL: http://codereview.chromium.org/1597002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43501 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 08:08:26 +0000