| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/23436
TEST= Run startup tests with complex theme; note that complex theme is correctly displayed.
Review URL: http://codereview.chromium.org/242075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to show/hide the "off the side" button on the right of the bookmark
bar.
BUG=http://crbug.com/21887
TEST=Get a bunch of bookmarks with icons. Shrink the window width
until the icon JUST BARELY appears. Quit and relaunch Chrome. Make
sure "iff the side" button is visible.
Review URL: http://codereview.chromium.org/249037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/22825
TEST=rename bookmarks to the following names; make sure the full name shows up (and not "t...").
test, FBL, Moma, SFGate
Now rename a bookmark to "banana whamma fo famma me mi mo mamma banana"
and make sure it is trimmed.
Review URL: http://codereview.chromium.org/249038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=pinkerton
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/256005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23402
TEST=On a clean install, make sure Chrome has Homepage button enabled. Use master_preferences to disable homapage button and make sure it works.
Review URL: http://codereview.chromium.org/255025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18896
TEST=green is good.
Review URL: http://codereview.chromium.org/244046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We previously disabled it it to see if it was involved with the double
free... but the cause has been shown to be a thread-unsafe reference
count (not a party to this change).
r=brettw
Review URL: http://codereview.chromium.org/246036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=atwilson
Review URL: http://codereview.chromium.org/243046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This version contains updated code for retainers heap profile, which is needed for DevTools Heap profiler.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Belongs to http://codereview.chromium.org/254002
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/244044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the support for the LANGUAGE environment variable, which is supported by gettext based applications for specifying a priority list of user prefered locales for UI messages translation.
Unlike gettext based applications, which support using different locales for messages translation and other locale categories, like LC_CTYPE, LC_COLLATE, LC_TIME, etc., chromium supports only one application locale for all localization operations.
This CL adds the support of specifying the application locale by LANGUAGE env variable, but doesn't make chromium to support above mentioned behavior of gettext based applications.
BUG=21080: chromium doesn't honor locale fallbacks
TEST=Launch chrome with LANGUAGE=br:fr_FR:fr, French locale shall be used by chrome, as br is not supported by chrome yet.
Review URL: http://codereview.chromium.org/236001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BrowsingDataRemover deletes itself (see browsing_data_remover.cc:
MessageLoop::current()->DeleteSoon(FROM_HERE, this)).
BUG=22068
Review URL: http://codereview.chromium.org/218001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window would crash. Be more specific about when the window will be closed/deleted during dragging in hopes of making future crashes a little more clear.
BUG=none
TEST=dragging tabs between windows should work. tabs closed via window.close() on a timer should work.
Review URL: http://codereview.chromium.org/246035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This version contains a fix for a V8 bug (actually in version 1.3.13.3) and adds some missing handle scopes in the API.
BUG=22913
TEST=none
Review URL: http://codereview.chromium.org/243044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pfeldman
Review URL: http://codereview.chromium.org/256009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows/Linux.
The current rendering is different from the baseline image from upstream (text position in 7th column), but this is because the image is wrong. Since the current rendering is same as that of upstream, we can safely rebaseline this test.
BUG=10412
TEST=none
Review URL: http://codereview.chromium.org/244045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/248040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
actions always show up in a submenu of the wrench menu, and
if they have an icon, they also show up in the toolbar area.
BUG=23380,22883
TEST=Added new automated tests for the command handling, but we need to test that the menu items show up manually. To do that, run with no extension installed, you should see "extensions" in the wrench menu. Add an extension that adds a browser action, you should now see an "extensions" submenu with "manage extensions" and the browser action(s) in the submenu.
Review URL: http://codereview.chromium.org/246037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23416
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/251040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The failures must be caused by timing issue. This CL tries to fix the issue by initializing all necessary components before running tests.
BUG=23213 AutocompleteEditViewTest tests are failing
TEST=none
Review URL: http://codereview.chromium.org/242047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fiona Chong.
Review URL: http://codereview.chromium.org/243041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement a readsize throttle within the TCP socket.
Add a fieldgroup trial for testing it.
BUG=none
TEST=none
Original Review URL: http://codereview.chromium.org/173259
Review URL: http://codereview.chromium.org/243038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/246027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=4839
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/242064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23411
TEST=None
Review URL: http://codereview.chromium.org/246045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=scherkus
Review URL: http://codereview.chromium.org/246044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=scherkus
Review URL: http://codereview.chromium.org/246043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=16013
TEST=Playing a video should still work with the flag in incognito mode or not.
Allow <video> to use cache if running with experimental byte range support.
Review URL: http://codereview.chromium.org/253001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
add better logging about the amount of parallelism we're getting.
Now, if you add the flags --fully-parallel we will shard the test files at
the granularity of single files (i.e., all the files will be dumped into
a single shared Queue and each thread will pull one file out at a time).
This appears to produce a 2x - 3x speedup over the default behavior but isn't
100% stable yet.
Also, add the --no-log-errors flag to shut off error logging every time a
test fails.
R=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/214004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=16013
TEST=test_shell_tests --gtest_filter=Buffered*
Also video on a server that doesn't support range request will still work.
How <video> used to fetch a resource:
1. Fetch the whole file to get the header
2. Fetch a small range (1, 1) to determine if server supports range request
3. If [2] was successful, then fetch the file with range request if necessary
If [2] failed, prevent range request by telling ffmpeg this is streaming
New way of fetching a resource for <video>:
1. Fetch (0, 1023) to get the header (This needs more experiment).
2. If [1] was successful, then request later on will be made partial
If [1] failed, prevent range request by telling ffmpeg this is streaming
By doing this change we can eliminate one request before we can start the
file. And with the help of sparse cache, we would be able to reuse the first
1KB fetched even we need to fetch the index at the end of file.
Review URL: http://codereview.chromium.org/248012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't fix anything, it just prevents asserting (and consequently crashing) when the leak is observed, restoring the earlier behavior.
There are already a couple of know leaks, so crashing during shutdown isn't real useful until the known issues are fixed.
BUG=18372,23284
TBR=darin
Review URL: http://codereview.chromium.org/255017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=tc@chromium.org (TBR)
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/256008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Formerly, the HTTP server sent an SVG file as application/octet-stream, which caused the following layout test failures. This change fixes them.
- LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg (issue 10387)
- LayoutTests/http/tests/security/canvas-remote-read-svg-image.html (issue 18978)
- LayoutTests/http/tests/misc/SVGFont-delayed-load.html (issue 20505)
BUG=10387,18978,20505
TEST=none
Review URL: http://codereview.chromium.org/235053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23396
TEST=None
Review URL: http://codereview.chromium.org/256007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=tc@chromium.org
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
assumes that the build output is in src/chrome/{Debug,Release}. Update
the clobber script to look in both places.
Review URL: http://codereview.chromium.org/255015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23391
TEST=None
Review URL: http://codereview.chromium.org/255014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it work correctly in ion3 and other window managers that don't expect clients to try to move top-level windows themselves.
This implementation grabs the pointer and keyboard. By doing this and using an override-redirect window, we should be able to avoid worrying about interactions with different window managers. The only downside (alluded to in the previous code) is that window manager keybindings don't make it through until the user dismisses the bubble by clicking outside of it or hitting Enter or Escape. I don't think this will be a problem; it's no different from what happens when you open a context menu in an app.
BUG=20523
TEST=tested first-run and bookmark bubbles in Metacity, ion3, Fluxbox, KDE4, and the WM that I'm working on
Review URL: http://codereview.chromium.org/198016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This was only needed so that we could compile the sync glue code
without access to a syncapi binary. Now that syncapi can be built from
source, it's obsolete.
Review URL: http://codereview.chromium.org/242060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
separate for the layout test task force reporting. We can now build out the
full expecatations list by calling functions in layout_package/test_files
and layout_package/test_expectations (previously you needed to call private
routines in run_webkit_tests).
BUG=none
TEST=none
R=ojan@chromium.org
Review URL: http://codereview.chromium.org/254011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Split so it's not a 2 sided patch.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/242056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23396
TEST=None
Review URL: http://codereview.chromium.org/244043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
investigate.
BUG=23394
TBR=huanr
Review URL: http://codereview.chromium.org/251039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/255012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The implementation was dependent on webkit_glue::image_resource_fetcher and had to be removed if we want to upstream WebView.
DownloadImage has been moved into RenderView::DownloadImage. WebViewImpl's set of ImageResourceFetchers has been ripped off and moved into RenderView.
Review URL: http://codereview.chromium.org/255006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view.
See original review:
http://codereview.chromium.org/235011/show
BUG=None
TEST=Run all tests. Make sure focus is stored/restored properly in Chrome.
TBR=ben
Review URL: http://codereview.chromium.org/246032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=See browser tests.
Review URL: http://codereview.chromium.org/242055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27562 0039d316-1c4b-4281-b951-d872f2087c98
|