| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change processor
If we failed to startup, Stop() doesn't get called, so ensure we cleanup up
properly in StartDoneImpl.
BUG=102009
TEST=unit_tests
Review URL: http://codereview.chromium.org/8341091
TBR=zea@chromium.org
Review URL: http://codereview.chromium.org/8481017
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug where in case of a newly enabled datatype we would end up adding all the datatypes to the config request.
With this change Nigori would not be part of the requested types unless it has progress marker token to be empty. So we should not get migration error on config requests at all. In case we do it would be a unrecoverable error which is fine.
BUG=102557
TEST=
Review URL: http://codereview.chromium.org/8439057
TBR=lipalani@chromium.org
Review URL: http://codereview.chromium.org/8477016
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Require that one non-getstatefast message be processed in between, to prevent starvation.
BUG=102214
TEST=
Review URL: http://codereview.chromium.org/8440061
TBR=jbauman@chromium.org
Review URL: http://codereview.chromium.org/8480019
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows.
BUG=102406
TEST=Copy a long, complex document from docs.google.com and paste into a Gmail compose window.
Review URL: http://codereview.chromium.org/8429022
TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/8479018
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This won't go out until next week so this patch blocks both intermediate
certificates held by Digicert Sdn. Bhd.
BUG=102530
TEST=Check that https://mmail.esyariah.gov.my fails with a revocation error (until the site updates)
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
certificates
issued by a VeriSign intermediate CA.
Change the CertVerifier cache to identify a certificate chain by the
hash of the entire chain rather than just the server certificate.
This requires adding X509Certificate::chain_fingerprint(), and the
X509Certificate::CalculateChainFingerprint() method to compute the
chain fingerprint.
R=agl@chromium.org,rsleevi@chromium.org
BUG=101555
TEST=X509CertificateTest.ChainFingerprints and
CertVerifierTest.DifferentCACerts in net_unittests
Review URL: http://codereview.chromium.org/8400075
TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/8378006
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=102526
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/8438015
TBR=zea@chromium.org
Review URL: http://codereview.chromium.org/8436005
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
encryption keys.
BUG=102526
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/8438015
TBR=zea@chromium.org
Review URL: http://codereview.chromium.org/8417052
TBR=zea@chromium.org
Review URL: http://codereview.chromium.org/8430044
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
navigating it
Turns out that a precondition for NavigateToURL is that the tab is currently not navigating. While about:blank loads very quickly, on slow machines it might take to long, so NavigateToURL fails
BUG=101078
TEST=ExtensionApiTest.WebNavigationUserAction doesn't time out on official mac builders
Review URL: http://codereview.chromium.org/8334023
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/8443003
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=102526
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/8438015
TBR=zea@chromium.org
Review URL: http://codereview.chromium.org/8417052
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=102893
Review URL: http://codereview.chromium.org/8447011
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces the NOTREACHED() calls with DLOG(WARNING), avoids creating
frames when invalid pixel formats are detected, and finally calls
OnInitializeComplete(false) in FFmpegVideoDecodeEngine::Initialize.
BUG=101803
TEST=Ran unittests. Ran test video.
Review URL: http://codereview.chromium.org/8437021
TBR=dalecurtis@chromium.org
Review URL: http://codereview.chromium.org/8436003
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces the NOTREACHED() calls with DLOG(WARNING), avoids creating
frames when invalid pixel formats are detected, and finally calls
OnInitializeComplete(false) in FFmpegVideoDecodeEngine::Initialize.
BUG=101803
TEST=Ran unittests. Ran test video.
Review URL: http://codereview.chromium.org/8437021
TBR=dalecurtis@chromium.org
Review URL: http://codereview.chromium.org/8437101
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces the NOTREACHED() calls with DLOG(WARNING), avoids creating
frames when invalid pixel formats are detected, and finally calls
OnInitializeComplete(false) in FFmpegVideoDecodeEngine::Initialize.
BUG=101803
TEST=Ran unittests. Ran test video.
Review URL: http://codereview.chromium.org/8437021
TBR=dalecurtis@chromium.org
Review URL: http://codereview.chromium.org/8437097
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:21585
TEST=On ChromeOS, ctrl-j for the downloads page, click on Open Downloads Folder to have a new tab open with the filemanager extension positioned in the Downloads folder.
Review URL: http://codereview.chromium.org/8439018
TBR=achuith@chromium.org
Review URL: http://codereview.chromium.org/8372091
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=97820
TEST=We start getting advanced clicks in Sync Promo's UMA.
R=sail@chromium.org
Review URL: http://codereview.chromium.org/8386058
TBR=dbeam@chromium.org
Review URL: http://codereview.chromium.org/8423070
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clicks the "Exit full screen" button.
The crash was due to the fact that Browser::OnDenyFullscreenPermission causes BrowserWindow::ExitFullscreen to be called, which causes the FullscreenExitBubbleController to be destroyed. [FullscreenExitBubbleController deny:] was sending a -hideSoon message to its zombie self following the call to Browser::OnDenyFullscreenPermission.
BUG=101835
TEST=The browser doesn't crash when you click "Exit full screen" on a fullscreened page.
Review URL: http://codereview.chromium.org/8399017
TBR=jeremya@chromium.org
Review URL: http://codereview.chromium.org/8351086
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=102710,102456
Review URL: http://codereview.chromium.org/8440054
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
authentication.
Add a "bool client_cert_sent" member to SSLInfo to extract this info
from SSLClientSocket.
R=rtenneti@chromium.org
BUG=101778
TEST=new unit test
Review URL: http://codereview.chromium.org/8401024
TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/8438055
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DownloadManager creation. Replace GetNextIdThunkType with DownloadIdFactory (RefCountedThreadSafe, created by DownloadService).
DownloadService uses the same DownloadIdFactory for an OTR profile as its original profile.
DownloadService passes the DownloadIdFactory into the DownloadManager so that the DownloadManager can allocate new valid ids for items loaded from the history or downloads started on the ui thread.
Since the DownloadService precedes and outlives its DownloadManager, DownloadManager does not have a scoped_refptr<DownloadIdFactory>. Objects that do have a scoped_refptr<DownloadIdFactory>: DownloadService, ProfileIOData, ShellBrowserContext, ShellResourceContext.
The DownloadIdFactory must be RefCountedThreadSafe because ProfileIOData outlives Profile and because it's used in both the OTR and original profiles.
Longer term, the import process should strictly precede profile initialization, and the next_download_id counter should be loaded from the History db strictly before DownloadService is created and creates a DownloadIdFactory.
BUG=98966
Review URL: http://codereview.chromium.org/8372073
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a ChromeFrame crash which occurs in the background worker thread while
dereferencing a NULL automation client.
This crash occurs when the active document is in the process of shutting down
while there are active background
requests still pending.
Fix is to ensure that the background thread has been stopped before returning
from the UrlmonUrlRequestManager::StopAll
function which gets called during CF shutdown.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393
BUG=102393
TBR=robertshield
Review URL: http://codereview.chromium.org/8384019
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/8439052
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The NAT traversal default for all platforms is now true.
BUG=97689
TEST=None
Review URL: http://codereview.chromium.org/8423020
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/8386050
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=101251
TEST=
TBR=dbeam@chromium.org
Review URL: http://codereview.chromium.org/8404015
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/8402013
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/8386046
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Screenshot: http://imgur.com/QToj7
BUG=101057
TEST=
Review URL: http://codereview.chromium.org/8372031
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/8437061
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make it clear what's happening we want to show a "signed into sync" confirmation bubble in NTP. We only show this bubble for users who signed in using the sync promo page.
Screenshots of the bubble:
http://www.dropmocks.com/mbiqd
BUG=101057
TEST=
Review URL: http://codereview.chromium.org/8396024
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/8386045
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've tested this using all combinations of field trials (both naturally
selected as well as forced through the --instant-field-trial commandline
switch), and everything works as expected.
BUG=101930
TEST=Clicking on the label text should turn the checkbox on/off.
Review URL: http://codereview.chromium.org/8400044
TBR=sreeram@chromium.org
Review URL: http://codereview.chromium.org/8438044
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't overlap the button.
BUG=101080
TEST=Download shelf drop down menu is positioned above or below the item view area, but not over it.
Review URL: http://codereview.chromium.org/8392029
TBR=asanka@chromium.org
Review URL: http://codereview.chromium.org/8437054
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the user clicks the "Exit full screen" button.
The crash was due to the fact that Browser::OnDenyFullscreenPermission causes BrowserWindow::ExitFullscreen to be called, which causes the FullscreenExitBubbleController to be destroyed. [FullscreenExitBubbleController deny:] was sending a -hideSoon message to its zombie self following the call to Browser::OnDenyFullscreenPermission.
BUG=101835
TEST=The browser doesn't crash when you click "Exit full screen" on a fullscreened page.
Review URL: http://codereview.chromium.org/8399017
TBR=jeremya@chromium.org
Review URL: http://codereview.chromium.org/8439030
TBR=cevans@chromium.org
Review URL: http://codereview.chromium.org/8440041
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
profile is selected. Prevents a profile from editing the avatar and profile name of another profile in the Personal Options page. These changes got overwritten due to revision 107894. Bringing them back.
BUG=87658
TEST=NONE
Review URL: http://codereview.chromium.org/8341139
TBR=qghc36@motorola.com
Review URL: http://codereview.chromium.org/8386035
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
selected in personal settings.
According to this change, Delete button will be disabled when there are multiple profiles and none of the profiles is selected. If profile list is hidden i.e if there is only one default profile then Delete Button is also disabled.
BUG=100625
TEST='Delete...' button should be disabled when no profile is selected in chrome://settings/personal page.
Review URL: http://codereview.chromium.org/8339014
TBR=qghc36@motorola.com
Review URL: http://codereview.chromium.org/8386034
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:22001
TEST=Manual: title of the OOBE image selection screen should offer to choose, not to change, a picture.
Review URL: http://codereview.chromium.org/8433002
TBR=ivankr@chromium.org
Review URL: http://codereview.chromium.org/8423036
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The external webpage used by this test is throwing 500.
TBR=dennisjeffrey@chromium.org
R=dennisjeffrey@chromium.org
BUG=102517
TEST=
Review URL: http://codereview.chromium.org/8423012
TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/8372054
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixed signing and verification of signature.
BUG=101815,102480
TEST=Check that corresponding histograms are updated as intended.
Review URL: http://codereview.chromium.org/8386004
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRange::fromDocumentRange() can return a null range. I don't
know when this happens in practice, but there are crash reports
for it.
BUG=100884
TEST=none
Review URL: http://codereview.chromium.org/8423022
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8438029
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clicks the "Exit full screen" button.
The crash was due to the fact that Browser::OnDenyFullscreenPermission causes BrowserWindow::ExitFullscreen to be called, which causes the FullscreenExitBubbleController to be destroyed. [FullscreenExitBubbleController deny:] was sending a -hideSoon message to its zombie self following the call to Browser::OnDenyFullscreenPermission.
BUG=101835
TEST=The browser doesn't crash when you click "Exit full screen" on a fullscreened page.
Review URL: http://codereview.chromium.org/8399017
TBR=jeremya@chromium.org
Review URL: http://codereview.chromium.org/8439030
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=100423
TEST=manual
Review URL: http://codereview.chromium.org/8353024
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/8437037
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81293
Review URL: http://codereview.chromium.org/8440010
TBR=cevans@chromium.org
Review URL: http://codereview.chromium.org/8423032
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=102461
Review URL: http://codereview.chromium.org/8428011
TBR=cevans@chromium.org
Review URL: http://codereview.chromium.org/8439027
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=87632
TEST=Check official build logs
Review URL: http://codereview.chromium.org/8394064
TBR=lambroslambrou@google.com
Review URL: http://codereview.chromium.org/8423030
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add GYP target for building Breakpad symbols for Remoting Host plugin on Linux.
BUG=87632
TEST=Manual: "build/gyp_chromium --check", and build new target.
Review URL: http://codereview.chromium.org/8390015
TBR=lambroslambrou@chromium.org
Review URL: http://codereview.chromium.org/8438027
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reverse order of all (in views).
BUG=102303
TEST=Run views chrome. Go to chrome://settings/personal. Sign in to sync. Click "Advanced". OK button should be on left. In non-views chrome (mac, linux), OK button should be on right.
Review URL: http://codereview.chromium.org/8387033
TBR=binji@chromium.org
Review URL: http://codereview.chromium.org/8351061
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through the underlying keychain.
BUG=102176
TEST=on Mac, with more than one profile existing, a warning is shown on the settings/personal page about profile password sharing.
Review URL: http://codereview.chromium.org/8430017
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/8438026
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it doesn't flicker when scrubbing.
BUG=100856
TEST=Quickly mouse through the avatar menu. The edit link doesn't flicker.
Review URL: http://codereview.chromium.org/8344048
TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/8437031
git-svn-id: svn://svn.chromium.org/chrome/branches/912/src@108215 0039d316-1c4b-4281-b951-d872f2087c98
|