| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The "chrome_url_overrides" manifest key is now accessible by packaged apps.
BUG=101992, 104103
TEST=existing, ManifestTest
Review URL: http://codereview.chromium.org/8654001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
They caused http://crbug.com/106304
BUG=99629
TEST=none
TBR=dmazzoni
Review URL: http://codereview.chromium.org/8793001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Do not assume that the history_info_map_ will always contain entries for keys.
BUG=106192
TEST=With a big History database, type a single 'w' and verify that a crash does not occur. 'w' is chosen since it occurs in the bulk of URLs ('www'). Other common characters to test singly are 'c', 'h', 'm', 'o', 'p' and 't'.
Review URL: http://codereview.chromium.org/8785021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. In aura, before a window is focused, ask the delegate if it can be focused.
. Make a popup RWHVA non-focusable.
This is to prevent the focus from moving from the main web-page to the combobox (which causes the combobox to get destroyed). This fixes an issue where comboboxes in the login screen could not be used properly.
BUG=105786
TEST=manually
Review URL: http://codereview.chromium.org/8770011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
omnibox drawing from GdkGC interface to cairo.
GdkGC is deprecated and will be removed in gtk3 and cairo should be faster anyway. This uses the new CairoCachedSurface in gfx::Image.
BUG=79722
TEST=none
Review URL: http://codereview.chromium.org/8781001
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/8789016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/mac-release/sizes/report.html?history=150&rev=-1&graph=chrome-si
http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=112878&graph=chrome-si
http://build.chromium.org/f/chromium/perf/linux-release-64/sizes/report.html?history=150&rev=112878&graph=chrome-si
BUG=94925
TEST=none
TBR=cmp
Review URL: http://codereview.chromium.org/8784014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8784003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105028
TEST=none (browser side still missing, does nothing yet)
Review URL: http://codereview.chromium.org/8774050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
show a node, so we need it. *SIGH*
For the most part this is a revert of
http://codereview.chromium.org/8759017/, so don't feel you need to
review it that deeply.
BUG=102714
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8772064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104757
TEST=manual
Review URL: http://codereview.chromium.org/8745020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compositor_unittests
Review URL: http://codereview.chromium.org/8772072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dtseng@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8789011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/8775059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=94447
TEST=Verify that migration to this build of Chrome goes smoothly and changing any search engine in Web Data file triggers the bubble.
Review URL: http://codereview.chromium.org/8567004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=62897
TBR=aa
Review URL: http://codereview.chromium.org/8784009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
related methods. Scrolling currently only handles the main frame, though
it's designed to be extended to support scrolling any scrollable container
shortly. Setting the text selection is only implemented for <input>
elements, pending WebKit enhancements.
BUG=104468,104469
TEST=Adds new test for scrolling logic, manual testing with accProbe.
Review URL: http://codereview.chromium.org/8770021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103851
TEST=tree
R=kbr
Review URL: http://codereview.chromium.org/8758003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
instead of by inheritence.
BUG=98716
Review URL: http://codereview.chromium.org/8787004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
consumers embed it in their class instead of deriving from it. The GetChildTerminationStatus override in NaclProcessHost seemed unnecessary since that's what the default implementation does. NaClProcessHost::OnChildDied can be done in the destructor.
BUG=98716
Review URL: http://codereview.chromium.org/8771041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Screenshots: http://imgur.com/6owxK
BUG=91241
TEST=
Review URL: http://codereview.chromium.org/8680033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the folder is non-empty.
Also, a bit of style cleanup in the related file.
BUG=102714
TEST=Bookmark a page and add it to the "Mobile bookmarks" folder. Make sure the bookmark is now accessible from the system and wrench bookmark menus on Mac (but not from the Bookmarks bar). Then remove the bookmark, and make sure the empty "Mobile bookmarks" folder is no longer visible in either menu.
Review URL: http://codereview.chromium.org/8786015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WillProcessXEvent returns false to indicate continue normal dispatch. The check worked because EVENT_CONTINUE happens to be 0.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8769049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
spdy_stream_ was used when NULL. We now copy the peer address
and local address from spdy_stream_ when we connect.
BUG=106073
TEST=SpdyProxyClientSocket.GetPeerAddressReturnsCorrectValue
Review URL: http://codereview.chromium.org/8771012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Exposes several new states and attributes and fires new notifications
when the selection changes. Adds general-purpose implementations of
IUnknown and IEnumVARIANT to base/win/, which will be used in the future
as we remote ATL from accessibility code.
BUG=5027,98984
TEST=manual testing with JAWS and NVDA
Review URL: http://codereview.chromium.org/8588036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are better ways to handle this, but I want a really
simple patch for merge.
BUG=106201
TEST=http://code.google.com/p/chromium/issues/detail?id=100401#c18
Review URL: http://codereview.chromium.org/8786008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
organic brand code. Also added unit tests for reactivation since none
existed.
BUG=b/5683002
TEST=See unit tests. Pings should only be sent out for non-organic brand
codes, and not for organic brand codes. Should test will all four combinations
(main is either organic or not, and reactivation is either organic or not).
This only works with google chrome builds. Chromium builds never send pings
regardless of brand codes.
Review URL: http://codereview.chromium.org/8726041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=aa
Review URL: http://codereview.chromium.org/8788007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
revision=112305
The difference is the phone library pulled is version 407 instead of 403, it includes fixes, including missing licenses.
Original description: Pull the phone library directly. Delete old version.
TEST=unit-tests
BUG=105577
Review URL: http://codereview.chromium.org/8790002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
press when there is only one default profile. Incorporated necessary condition check before launching avatar bubble.
BUG=105700
TEST=None
Review URL: http://codereview.chromium.org/8664028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8771030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23472
TEST=NONE
Review URL: http://codereview.chromium.org/8770040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23658
TEST=See issue
Review URL: http://codereview.chromium.org/8771019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Minor Windows-only code cleanup. That also fixes broken sound on Windows Server 2003.
BUG=none
Review URL: http://codereview.chromium.org/8777003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds XInput redist DLL which is a new dependency of recently added gamepad code,
and is required on Win XP. laforge has OK'd the size addition to the final
package (~100K).
BUG=79050
Review URL: http://codereview.chromium.org/8774023
TBR=scottmg@google.com
Review URL: http://codereview.chromium.org/8788009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87658
TEST=Have two machines with chrome, both with multiple profiles and each with one profile signed in to the same account. Change avatar/name on one, and it will change on the other.
Review URL: http://codereview.chromium.org/8771024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with no work to do
Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand.
Use that to figure out which worker threads to post work on (instead of
posting on all of them).
Implement GetGroupsToChange() for each ModelChangingSyncerCommand.
Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession.
Key unapplied updates index by type for ApplyUpdatesCommand.
Make the abstract methods of ModelChangingSyncerCommand protected.
This patch includes a speculative fix for the perf regression introduced by the last time this was landed (112178).
BUG=97832
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112178
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112743
Review URL: http://codereview.chromium.org/8637006
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/8785015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=90898
TEST=none
Review URL: http://codereview.chromium.org/8744002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
exist. This is a regression from
http://codereview.chromium.org/8759017
BUG=106238
TEST=none
R=akalin@chromium.org,yfriedman@chromium.org
Review URL: http://codereview.chromium.org/8790008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=106248
TEST=browser_tests on aura should cycle green
Review URL: http://codereview.chromium.org/8772066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8771046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The preference is controlled by the command line and enterprise policy.
R=mattm@chromium.org,mnissler@chromium.org
BUG=106077
TEST=Existing policy unit tests are updated.
Review URL: http://codereview.chromium.org/8772014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79520
TEST=
Review URL: http://codereview.chromium.org/8669014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- both BookmarkBubble and BookmarkEditor now use single-line input for their names
- update nib to use IBOutlet to call the NSCell off of the NSTextField
BUG=100618
Review URL: http://codereview.chromium.org/8775042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ie6ee3ec84c126f46cdc34aea17bafa43cd49245c
BUG=chromium-os:23709
TEST=Chrome starts + VMTests pass
Review URL: http://codereview.chromium.org/8785011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:104530
TEST=PyAuto tests
Review URL: http://codereview.chromium.org/8772068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112844 0039d316-1c4b-4281-b951-d872f2087c98
|