| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They should own Bus as scoped_refptr, rather than raw pointer.
Otherwise, they may reference |bus_| after Bus is deleted.
I know this is convoluted. I'm planning to minimize use of
scoped_refptr from dbus/* but this change is necessary until then.
TEST=run dbus_unittest under valgrind and confirm no memory leaks
BUG=chromium-os:21379
Review URL: http://codereview.chromium.org/8201023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8229040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=92803
http://code.google.com/p/chromium-os/issues/detail?id=21399
TEST=
Review URL: http://codereview.chromium.org/8228011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
this check was always returning true.
BUG=100079
TEST=Visit http://popuptest.com/popuptest1.html, should not see any popups. This is also covered by existing python tests which I've re-enabled.
Review URL: http://codereview.chromium.org/8248003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a new pref that can be set in the master preferences file to suppress the sync promo.
BUG=99745
TEST=
Review URL: http://codereview.chromium.org/8232021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
printer ppd/schema info.
Show/Hide the color options based on printer ppd/schema information. Some printers does not provide sufficient information in the printer schema/ppd regarding the color settings and they use custom advance settings to print in black & white/greyscale. In those cases, users need to print using native dialog in order to set these advance color settings.
BUG=93811, 93490, 87344, 96658, 98768
TEST= Please refer to bug description.
Review URL: http://codereview.chromium.org/8138020
Review URL: http://codereview.chromium.org/8226024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch doesn't move web_drag_dest_gtk.cc into content/, but does remove all
dependencies on chrome/ code.
- Split out a delegate interface and move it
- cross platform code from chrome/.../bookmark_node_data.cc is moved to
ui/.../bookmark_format.h
- gtk_util.cc has some layers split into gtk_screen_utils.cc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8196001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended for the 15.0.874 branch.
BUG=97296
TEST=none
TBR=gavinp@chromium.org
Review URL: http://codereview.chromium.org/8233019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As it turns out, '#' repeated a hundred times doesn't trigger results from
Google (verified by issuing the same query on www.google.com). Instead, use
'abcd...', which seems to work, for now.
BUG=99866
TEST=python pyauto_functional.py instant.InstantTest.testInstantLoadsFor100CharsLongQuery
Review URL: http://codereview.chromium.org/8244010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cloud print should now be enabled on all platforms and not appear in about:flags.
BUG=
TEST=Cloud Print should now always be enabled and not appear in about:flags.
Review URL: http://codereview.chromium.org/8229036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=nkostylev@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8242019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r105203.
TBR=msw@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8260002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Cache all the gpu-related commandline switches and apply switch dependencies in one place.
2) Cleanup the data reporting for about:gpu page
3) besides allowed/blacklisted, we add a new state of disabled in the histogram to check how many users select to opt out of GPU acceleration.
BUG=none
TEST=tree green
Review URL: http://codereview.chromium.org/8168004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Webkit compositor in Chrome.
Review URL: http://codereview.chromium.org/8228025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clients of the library cannot tell if a match rule has been already added or
not (we could expose such a function but not so useful). Hence LOG(ERROR)
is irrelevant here. Also update the comment in bus.h.
TEST=dbus_unittests
BUG=none
Review URL: http://codereview.chromium.org/8223021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:16558
TEST=none
Signed-off-by: Simon Que <sque@chromium.org>
R=satorux@chromium.org
Review URL: http://codereview.chromium.org/8242018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that we get the glue statics linked into content.dll when we enable
the content component build.
R=jam@chromium.org
BUG=90422
TEST=
Review URL: http://codereview.chromium.org/8234013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98594
TEST=
Review URL: http://codereview.chromium.org/8226031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
r6905: (bsy) fast syscall path for get_tls syscall on x86-64.
r6906: (bsy) allow the NACLVERBOSITY environment variable to be passed to untrusted code.
r6907: (mcgrathr) Update x86 toolchain DEPS to 6899
r6908: (ncbray) Revert 6899, broke ARM bots - but the breakage was masked by other failiures.
r6909: (pdox) Some adjustments to the driver and SCons to make the scons glibc tests work with PNaCl.
BUG=none
TEST=nacl_integration
Review URL: http://codereview.chromium.org/8242020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebDataService
BUG=96922,96363
TEST=sh tools/valgrind/chrome_tests.sh -t unit_tests --gtest_filter=ProfileSyncServiceAutofillTest.HasProfileEmptySync
Review URL: http://codereview.chromium.org/8184001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ExtensionApiTest.WindowOpenPanelNotEnabled
Review URL: http://codereview.chromium.org/8247008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68267
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8245013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
swapping or resizing.
Also, it now restores whichever FBO was previously bound.
Tested accelerated and OSX 10.5 unaccelerated compositor paths.
This might be related to the bug referenced below.
BUG=97775
Review URL: http://codereview.chromium.org/8229025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
avatar bubble menu.
Previous review http://codereview.chromium.org/8226014
BUG=83169
TEST=Run chrome with the multi-profile flag. Create at least two users (on chrome://settings/personal). A profile button should be available in the upper left or right.
Review URL: http://codereview.chromium.org/8244014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
And wire it to the browser.
BUG=98735
TEST=see bug
Review URL: http://codereview.chromium.org/8251005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=91560
TEST=added ProfileManagerTest.AutoloadProfilesWithBackgroundApps
Review URL: http://codereview.chromium.org/8080011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The protocol for connecting to the out-of-process Breakpad crash
reporter is different for x86-32 and x86-64 (the message sizes are
different because the message struct contains a pointer), so we use
different pipe names for the two crash reporters.
Appending "-x64" is the simplest way of doing this. It allows two
crash handlers to coexist even when using the env var
CHROME_BREAKPAD_PIPE_NAME for testing.
Google Update (Omaha) does not yet launch an x86-64 crash handler for
this to connect to -- that is a work-in-progress.
BUG=89730
TEST=compile-tested; will be covered by nacl_integration later
Review URL: http://codereview.chromium.org/8231036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
their background color. Unfortunately since they can't automatically determine what that backgruond color is it has to be manually set. (I suppose I could try to add some crazy hierarchy-walking code looking for views::Background objects, but that seems like a bad move.) There is also a disable switch, which I use in a few places where I couldn't figure out what the background color actually is, or where updating it is really annoying.
In theory, we might want to apply this to other controls like text buttons, but since those are usually rendered with explicit background images there's probably not a ton of win there.
This also makes some other cleanup changes like converting a few wstrings to string16s, de-inlining some class member functions, etc. Some of these were mandated by the presubmitter :/
BUG=92
TEST=Things still look OK
Review URL: http://codereview.chromium.org/8221027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome/test/data/extensions/manifest_tests/content_script_yahoo.json
Review URL: http://codereview.chromium.org/8252007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=wtc@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8243001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Small refactor to move a class into an anonymous namespace. Small change to preserve the active FBO when resizing the EGLImageTransportSurface.
BUG=none
TEST=open and close 3D CSS tabs on TOUCH_UI
Review URL: http://codereview.chromium.org/8241006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
also fixes the wrong argument order in one of the ResolveHelper calls.
This bug was introduced in http://codereview.chromium.org/7492059/.
R=cbentzel@chromium.org,eroman@chromium.org
BUG=100080
TEST=net_unittests
Review URL: http://codereview.chromium.org/8220028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=tkent
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/8252004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
this the page doesn't know the real placement.
BUG=100065
TEST=see bug
R=tonyg@chromium.org
Review URL: http://codereview.chromium.org/8244008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99000
TEST=no
Review URL: http://codereview.chromium.org/8198016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=94494
TEST=manual.
Review URL: http://codereview.chromium.org/8216032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There doesn't seem to be a strong need for the fade, so remove it, eliminating
some complexity and potential bugs. I've verified that it fixes bug 99755. I'm
not able to reproduce bug 99789 yet, but presumably, it will be fixed as well
(since there won't be any fades any more).
BUG=99755,99789
TEST=See bugs and description above.
Review URL: http://codereview.chromium.org/8232028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=94693
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/8194014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it should always be turned on. Since auto-login is still behind a command
line flag, make sure the UI is too.
Tim: please look at sign in manager
Chris: please look at webui
BUG=None
TEST=Make sure pre-login is enabled and that the checkbox for auto-login
in the sign in section of the personal stuff section is not visible unless the
auto-login about flag is turned on.
Review URL: http://codereview.chromium.org/8231027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part one of a two part change to adjust how we show the sync promo at startup.
Currently, at startup, we show the sync promo and the welcome page. When the user completes the promo (or skips it) we navigate to the new tab page.
We want to adjust the start up flow so that instead of replacing the standard first tab with the sync promo we show it along side the promo.
For example, if the standard startup tabs would be:
Google.com, Welcome
Then the new startup tabs will be:
Sync Promo, Google.com, Welcome
Once the user completes (or skips) the sync promo we want to leave them with the same set of tabs that they would normally have. To do this we want to close the sync promo tab.
This CL is simply the first part of that work. If the promo page was displayed at startup then we close the browser tab once the user completes the sync setup. To detect that the promo was displayed at startup we just check the back history for the tab. There's no back history only when the promo page was displayed at startup.
BUG=99743
TEST=
Review URL: http://codereview.chromium.org/8227038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99322
TEST=none
R=brettw@chromium.org,mirandac@chromium.org
Review URL: http://codereview.chromium.org/8172008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=86536
TEST=None
Review URL: http://codereview.chromium.org/8240008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8226025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There is a bit of hackery. Most of this will be superseded by bubble and webui work.
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8231032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since two major releases of Flash (10.3 and 11) now handle QuickDraw negotiation correctly, remove the hack per the comment--it's no longer important that 10.2 and earlier are performant, since nobody should be running them.
BUG=None
TEST=The current version of Flash should continue to work normally.
Review URL: http://codereview.chromium.org/8245005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Requires that permissions.request is called from within a user gesture, and this moves the permissions API constants from extension_permissions_api_constants to an anonymous namespace within extension_permissions_api.cc.
BUG=99196
TEST=*OptionalPermissions*
Review URL: http://codereview.chromium.org/8216010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105168 0039d316-1c4b-4281-b951-d872f2087c98
|