summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix the release channel switching UI for Chrome OS.satorux@chromium.org2010-11-244-7/+26
| | | | | | | | | | | | Remove "canary" as it's not yet supported as of now. Add warning text on the channel swtiching UI. BUG=chromium-os:9597 TEST=confirmed that the canary is gone and the warning text appears. Review URL: http://codereview.chromium.org/5256003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67228 0039d316-1c4b-4281-b951-d872f2087c98
* cleaning up drover mess up.lipalani@chromium.org2010-11-241-199/+0
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/5289003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67227 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in SearchProvider.sky@chromium.org2010-11-241-3/+1
| | | | | | | | | | BUG=none TEST=none TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/5331004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67226 0039d316-1c4b-4281-b951-d872f2087c98
* reland 66893.dtseng@chromium.org2010-11-242-0/+199
| | | | | | | TBR=dtseng Review URL: http://codereview.chromium.org/5281007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67223 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression introduced in r67027 which broke the acceleratedkbr@google.com2010-11-241-0/+1
| | | | | | | | | | | | compositor on Mac OS X. BUG=64295 TEST=none (ran CSS 3D and WebGL content) TBR=stuartmorgan Review URL: http://codereview.chromium.org/5314006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67220 0039d316-1c4b-4281-b951-d872f2087c98
* Fix jankiness in Chrome OS's proxy options.satorux@chromium.org2010-11-245-3/+19
| | | | | | | | | | | | The advanced config section looked empty before the fix. The change is to make it visible and add explanatory text. TEST=confirmed that the UI was shown as intended. See crosbug.com/9190 for before/after screenshots. BUG=chromium-os:9190 Review URL: http://codereview.chromium.org/5115008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67219 0039d316-1c4b-4281-b951-d872f2087c98
* Makes committing the suggested text only update the default searchsky@chromium.org2010-11-2419-66/+114
| | | | | | | | | | | provider and nothing else. BUG=none TEST=none Review URL: http://codereview.chromium.org/5270001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67218 0039d316-1c4b-4281-b951-d872f2087c98
* Add the views unittests to the windows buildbot target to make surensylvain@chromium.org2010-11-241-0/+1
| | | | | | | | it is available on the slaves. Review URL: http://codereview.chromium.org/5361001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67217 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented RtcpWriter for sending RTCP Receiver Reports.sergeyu@chromium.org2010-11-2412-17/+298
| | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/5122008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67215 0039d316-1c4b-4281-b951-d872f2087c98
* Fix in BrowserTest.PosixSessionEnd in ui_tests failure on dbg build for ↵satorux@chromium.org2010-11-241-8/+0
| | | | | | | | | | | | | | | | | | | | Chrome OS The test failed as use of Singleton is not allowed in non-joinable threads since http://src.chromium.org/viewvc/chrome?view=rev&revision=66719 We could make BootTimesLoader a leaky singoeton to fix the failure, but instead, the change removes the use of BootTimesLoader in the shutdown detector thread. The time spent from the previous check point (LogoutStarted) is negligible as shown in http://codereview.chromium.org/4973002/ hence it should be fine. BUG=chromium-os:9592 TEST=out/Debug/ui_tests --gtest_filter='BrowserTest.PosixSessionEnd' Review URL: http://codereview.chromium.org/5339007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67214 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 72622: 72637.jparent@chromium.org2010-11-241-1/+1
| | | | | | | | | | | TEST=none BUG=none TBR=loislo Review URL: http://codereview.chromium.org/5331002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67213 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring in RTP reader code: sequence number wrapping logic moved tosergeyu@chromium.org2010-11-249-35/+114
| | | | | | | | | | | RtpReader BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/5110008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67212 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67208 - Reland 66893.dtseng@chromium.org2010-11-242-203/+0
| | | | | | | | | | TBR=dtseng Review URL: http://codereview.chromium.org/5326003 TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/5311004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67211 0039d316-1c4b-4281-b951-d872f2087c98
* Determine the theme for a widget in gtk from its parent,zork@chromium.org2010-11-245-14/+54
| | | | | | | | | | | instead of just using the defaul BUG=chromium-os:4890 TEST=On ChromeOS, enable a theme, and open the find box. Check that the theme is applied. Review URL: http://codereview.chromium.org/4705005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67210 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 66893.dtseng@chromium.org2010-11-242-0/+203
| | | | | | | TBR=dtseng Review URL: http://codereview.chromium.org/5326003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67208 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Fix two issues related to gtk im context support.suzhe@chromium.org2010-11-242-1/+10
| | | | | | | | | | | | | | | BUG=chromium-os:9208 BUG=chromium-os:9575 TEST=See bug reports. Issue 9208 is due to ibus's async nature: some ibus engines may update preedit string when getting reset. It may happen after calling GtkIMContextWrapper::CancelComposition() method, which then cause this method being called recursively. So we need to suppress any preedit string signals triggered by GtkIMContextWrapper::CancelComposition() method, just like what we have done for commit signal (http://crbug.com/50485 and issue http://crosbug.com/4792). Issue 9575 is caused by improper handling of "grab-notify" signal in RWHVGtk, which should not focus in the input context again when the window has been focused out. Review URL: http://codereview.chromium.org/5372001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67207 0039d316-1c4b-4281-b951-d872f2087c98
* Instant: refactor code intended to prevent extra work.estade@chromium.org2010-11-243-22/+27
| | | | | | | | | | | | | | | | current symptoms: - when you send two OnChanges in a row, the second one will get the a blank |suggested_text|. - if you type alaska, the suggestion is "alaska air". Pressing space returns a blank |suggested_text|. fix: - return last suggestion. Also consolidate two points in the code where we tried to prevent Update from doing extra work. BUG=64245 TEST=manual (see bug and above) Review URL: http://codereview.chromium.org/5330003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67206 0039d316-1c4b-4281-b951-d872f2087c98
* Remove background mode preferences UI.atwilson@chromium.org2010-11-2418-642/+50
| | | | | | | | | BUG=64267 TEST=Existing tests suffice. Review URL: http://codereview.chromium.org/5361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67205 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill infobar doesn't come up when security code is filleddhollowa@chromium.org2010-11-243-1/+81
| | | | | | | | | | | Adds back in the notion of credit card cvc for heuristics purposes. The additional logic filters out cvc numbers from the forms. They were getting interpreted, in some cases, as card numbers. BUG=64131 TEST=FormStructureTest.CVCCodeClash Review URL: http://codereview.chromium.org/5268004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67204 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67201 - Revert 67191 - chrome_paths: refactor and sanitize cache ↵viettrungluu@chromium.org2010-11-2413-66/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | directory handling [Checking to see if this build failures on Windows.] [[Nope. Failure was a flake.]] Previously we had a bunch of logic in profile_impl.cc that computed where the cache directory lives. This change relocates it to chrome_paths.cc. Some background on cache directories. There are two possible places to store cache files: 1) in the user data directory 2) in an OS-specific user cache directory On Windows, we always pick (1). On Mac and Linux, we currently use (2) in some circumstances. This patch changes both Mac and Linux to have the same behavior with respect to (2). The Mac/Linux shared behavior is that if the profile directory is in the standard location for profiles, we put the cache files into a matching directory name in the standard system cache directory (e.g. on Linux if you're using ~/.config/google-chrome, your cache ends up in ~/.cache/google-chrome; on Mac, the directories are ~/Library/Application Support versus ~/Library/Caches). If your user data directory is not in the standard location, we use behavior (1). The semantic changes of this patch should be: - On Mac, previously we checked whether the (2) directory had some particular subdirectories already when picking which one to use. This was removed; which directory is used is solely a question of whether the profile directory is in the standard location. I think the previous behavior was unpredictable. - On Linux, previously we only used behavior (2) if you hadn't changed your user-data-directory at all. Now, to match Mac, as long as your user-data-dir is in the standard place, you use the system cache dir. So e.g. using ~/.config/foobar puts your cache in ~/.cache/foobar. - On Linux, previously the default cache would end up as directories under ~/.cache/google-chrome/; now it ends up as directories under ~/.cache/google-chrome/Default/. (In all instances above, on Linux we continue to obey $XDG_CACHE_HOME.) BUG=59824 TEST=New test ChromePaths.UserCacheDir Review URL: http://codereview.chromium.org/5123004 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/5344003 TBR=viettrungluu@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67202 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67191 - chrome_paths: refactor and sanitize cache directory handlingviettrungluu@chromium.org2010-11-2413-123/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Checking to see if this build failures on Windows.] Previously we had a bunch of logic in profile_impl.cc that computed where the cache directory lives. This change relocates it to chrome_paths.cc. Some background on cache directories. There are two possible places to store cache files: 1) in the user data directory 2) in an OS-specific user cache directory On Windows, we always pick (1). On Mac and Linux, we currently use (2) in some circumstances. This patch changes both Mac and Linux to have the same behavior with respect to (2). The Mac/Linux shared behavior is that if the profile directory is in the standard location for profiles, we put the cache files into a matching directory name in the standard system cache directory (e.g. on Linux if you're using ~/.config/google-chrome, your cache ends up in ~/.cache/google-chrome; on Mac, the directories are ~/Library/Application Support versus ~/Library/Caches). If your user data directory is not in the standard location, we use behavior (1). The semantic changes of this patch should be: - On Mac, previously we checked whether the (2) directory had some particular subdirectories already when picking which one to use. This was removed; which directory is used is solely a question of whether the profile directory is in the standard location. I think the previous behavior was unpredictable. - On Linux, previously we only used behavior (2) if you hadn't changed your user-data-directory at all. Now, to match Mac, as long as your user-data-dir is in the standard place, you use the system cache dir. So e.g. using ~/.config/foobar puts your cache in ~/.cache/foobar. - On Linux, previously the default cache would end up as directories under ~/.cache/google-chrome/; now it ends up as directories under ~/.cache/google-chrome/Default/. (In all instances above, on Linux we continue to obey $XDG_CACHE_HOME.) BUG=59824 TEST=New test ChromePaths.UserCacheDir Review URL: http://codereview.chromium.org/5123004 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/5344003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67201 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67189 - Autofill work:lipalani@chromium.org2010-11-2426-2521/+358
| | | | | | | | | | | | | 1. Added a command line swithc to facilitate incremental checking in of autofill code. 2. Autofill profile model associator. 3. Part of the upgrade code.(The part to take the latest changes from server on the legacy type) Review URL: http://codereview.chromium.org/5126001 TBR=lipalani@chromium.org Review URL: http://codereview.chromium.org/5315002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67199 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] prevent MenuBarHelper from referencing stale widget.estade@chromium.org2010-11-243-4/+8
| | | | | | | | | | | | | Menus can be destroyed without being hidden, so connect to the "destroy" signal as well as "hide". This fixes the crash, and makes the class more robust in the future. Also, manually hide the bookmark menu widget when destroyed it in BookmarkMenuController. This gets the bbar button paint state correct. BUG=63294 TEST=manual (see bug) Review URL: http://codereview.chromium.org/5298002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67194 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pyauto fetch script to fetch .pyd instead of .dll on winnirnimesh@chromium.org2010-11-241-2/+2
| | | | | | Review URL: http://codereview.chromium.org/5342005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67193 0039d316-1c4b-4281-b951-d872f2087c98
* Always include nonzero unique ID with autofill suggestions.isherman@chromium.org2010-11-248-63/+212
| | | | | | | | | | | In particular, include the ID when correcting a form field. BUG=62416 TEST=unit_tests --gtest_filter=AutoFillManagerTest.* Review URL: http://codereview.chromium.org/5265002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67192 0039d316-1c4b-4281-b951-d872f2087c98
* chrome_paths: refactor and sanitize cache directory handlingevan@chromium.org2010-11-2413-66/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we had a bunch of logic in profile_impl.cc that computed where the cache directory lives. This change relocates it to chrome_paths.cc. Some background on cache directories. There are two possible places to store cache files: 1) in the user data directory 2) in an OS-specific user cache directory On Windows, we always pick (1). On Mac and Linux, we currently use (2) in some circumstances. This patch changes both Mac and Linux to have the same behavior with respect to (2). The Mac/Linux shared behavior is that if the profile directory is in the standard location for profiles, we put the cache files into a matching directory name in the standard system cache directory (e.g. on Linux if you're using ~/.config/google-chrome, your cache ends up in ~/.cache/google-chrome; on Mac, the directories are ~/Library/Application Support versus ~/Library/Caches). If your user data directory is not in the standard location, we use behavior (1). The semantic changes of this patch should be: - On Mac, previously we checked whether the (2) directory had some particular subdirectories already when picking which one to use. This was removed; which directory is used is solely a question of whether the profile directory is in the standard location. I think the previous behavior was unpredictable. - On Linux, previously we only used behavior (2) if you hadn't changed your user-data-directory at all. Now, to match Mac, as long as your user-data-dir is in the standard place, you use the system cache dir. So e.g. using ~/.config/foobar puts your cache in ~/.cache/foobar. - On Linux, previously the default cache would end up as directories under ~/.cache/google-chrome/; now it ends up as directories under ~/.cache/google-chrome/Default/. (In all instances above, on Linux we continue to obey $XDG_CACHE_HOME.) BUG=59824 TEST=New test ChromePaths.UserCacheDir Review URL: http://codereview.chromium.org/5123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67191 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill work:lipalani@chromium.org2010-11-2427-358/+2720
| | | | | | | | | | 1. Added a command line swithc to facilitate incremental checking in of autofill code. 2. Autofill profile model associator. 3. Part of the upgrade code.(The part to take the latest changes from server on the legacy type) Review URL: http://codereview.chromium.org/5126001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67189 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pyauto bustage on mac.nirnimesh@chromium.org2010-11-241-2/+6
| | | | | | Review URL: http://codereview.chromium.org/5322004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67188 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: fix location of search box on CrOS.csilv@chromium.org2010-11-241-1/+1
| | | | | | | | BUG=64261 TEST=Search box should appear above all page tabs on CrOS. Review URL: http://codereview.chromium.org/5313004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67187 0039d316-1c4b-4281-b951-d872f2087c98
* Disable testDisplayAndSavePasswordInfobar pyauto testnirnimesh@chromium.org2010-11-242-1/+4
| | | | | | | | BUG=64269 Review URL: http://codereview.chromium.org/5369001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67186 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the pyauto testsnirnimesh@chromium.org2010-11-241-2/+3
| | | | | | Review URL: http://codereview.chromium.org/5367001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67185 0039d316-1c4b-4281-b951-d872f2087c98
* GPU thread acknowledges an armed watchdog every time it returns to the ↵apatrick@chromium.org2010-11-242-14/+89
| | | | | | | | | | | | | message loop. It used to only acknowledge upon receiving a particular kind of Task from the watchdog, which could potentially be delayed by other Tasks. TEST=WebGL locally, check recovery from about:gpuhang locally, try BUG=none Review URL: http://codereview.chromium.org/5278006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67184 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67175 - This change implements OOM priority management for ChromeOSviettrungluu@chromium.org2010-11-2310-279/+12
| | | | | | | | | | | | | | | | (Build failure, probably debug/release warning difference.) This adds periodic OOM score adjustment, based on the last access time of the tab, whether or not it is pinned, and (of course) how much memory it is using. BUG=http://crosbug.com/8990 TEST=Ran some ui_tests, ran on device. Review URL: http://codereview.chromium.org/4498001 TBR=gspencer@chromium.org Review URL: http://codereview.chromium.org/5284003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67183 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Finish wiring up chrome.app.install()."aa@chromium.org2010-11-2336-470/+73
| | | | | | | | This reverts commit c0ddb28cf383462655b52aa79396ea695c0ffb3c. TBR=aa@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67182 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent re-entrancy into ProxyScriptFetcherImpl from ~URLRequestContext.willchan@chromium.org2010-11-231-0/+3
| | | | | | | | | | | | | | | The problem is that ProxyScriptFetcherImpl::OnFetchComplete() will delete the URLRequest, which may hold the last reference to the URLRequestContext, which will destroy the ProxyScriptFetcherImpl, which still thinks the URLRequest is alive, although we are in its destructor. Furthermore, even if we dodge that bullet, ProxyScriptFetcherImpl::OnFetchComplete() will invoke the user callback after deleting the URLRequest. This callback is to the InitProxyResolver object, which got deleted in ~URLRequestContext. So, we work around both of these problems by extending the lifetime of the URLRequestContext by acquiring a reference, which we release after deleting the URLRequest and invoking the user callback. The real solution is to stop refcounting URLRequestContext and do explicit destruction ordering. That's beyond the scope of this changelist. BUG=64253 TEST=none Review URL: http://codereview.chromium.org/5256002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67181 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using Hard Coded copies of GUID strings in RGS files.mad@google.com2010-11-2314-28/+141
| | | | | | | | | BUG=0 TEST=Make sure everything works after unregistration and re-registration. Review URL: http://codereview.chromium.org/5113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67180 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS so that the new py2exe addon to Python_26 is available...mad@google.com2010-11-231-1/+1
| | | | | | | | BUG=0 TEST=None Review URL: http://codereview.chromium.org/5306005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67177 0039d316-1c4b-4281-b951-d872f2087c98
* Use TimeFormat::TimeRemaining for CellularDataPlan::GetUsageInfo.xiyuan@chromium.org2010-11-233-50/+27
| | | | | | | | | | | | CellularDataPlan::GetUsageInfo is used for network menu's expiration label and TimeFormat::TimeRemaining is prefered per chromium-os:9331. BUG=chromium-os:9331 TEST=Verify fix for chromium-os:9331 Review URL: http://codereview.chromium.org/5221004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67176 0039d316-1c4b-4281-b951-d872f2087c98
* This change implements OOM priority management for ChromeOSgspencer@chromium.org2010-11-2310-12/+279
| | | | | | | | | | | This adds periodic OOM score adjustment, based on the last access time of the tab, whether or not it is pinned, and (of course) how much memory it is using. BUG=http://crosbug.com/8990 TEST=Ran some ui_tests, ran on device. Review URL: http://codereview.chromium.org/4498001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67175 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 72609:72622.jparent@chromium.org2010-11-232-4/+1
| | | | | | | | | | | | | Also remove temporary supression of failing test, since new baselines are included in this roll. TEST=none BUG=none TBR=loislo Review URL: http://codereview.chromium.org/5296002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67174 0039d316-1c4b-4281-b951-d872f2087c98
* Some tests were exiting so quickly after PulseAudioMixer::Init() was called, ↵davej@chromium.org2010-11-232-19/+30
| | | | | | | | | | | | | the object was being freed before initialization was complete. Now initialization will stop cleanly if asked PulseAudioFree() is called early on. This should also fix http://code.google.com/p/chromium/issues/detail?id=64080 . BUG=chromium-os:9303 TEST=ScreenLockerTest.TestBasic should not error in pulse_audio_mixer.cc Review URL: http://codereview.chromium.org/5229003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67173 0039d316-1c4b-4281-b951-d872f2087c98
* Fix shutdown crash in CertVerifier by using a MessageLoopProxy.willchan@chromium.org2010-11-233-17/+26
| | | | | | | | | | | The CertVerifier is not getting Cancel()'d because something which owns it is getting leaked, most likely a URLRequestJob. Therefore, we can end up accessing a deleted MessageLoop on shutdown. MessageLoopProxy prevents accessing a deleted MessageLoop on shutdown, instead it just deletes the task, which isn't great, but it's better than crashing. We should fix the root cause eventually, which is a leak of the URLRequestJob. BUG=42275,chromium-os:8179 TEST=none Review URL: http://codereview.chromium.org/5347001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67172 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "chrome_paths: refactor and sanitize cache directory handling"evan@chromium.org2010-11-2313-121/+70
| | | | | | This reverts commit r67160, test failures. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67171 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clock update behavior at the end of stream.acolwell@chromium.org2010-11-237-22/+122
| | | | | | | | | | | | | | | | | | | | | | | | Sometimes the audio stream is slightly shorter than the video stream. This can result in no audio data being written to the audio device if you seek close to the end of the clip. This causes the pipeline to hang because the video stream hasn't ended, but the clock hasn't been started because no audio data is written to the device. This change makes sure that the clock gets started if the audio stream has ended and we are still waiting for a clock update. I've also included a fix for a related problem where all of the audio data gets written to the device, but clock updates don't occur on playback_delay changes. This was contributing to the issue mentioned above because up to a second worth of audio data can be covered by the playback_delay. If this happens while seeking to within a second of the clip end you won't get clock updates for the audio data. BUG=52887 TEST=PipelineImplTest.AudioStreamShorterThanVideo Review URL: http://codereview.chromium.org/5182008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67170 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 552d build break.xiyuan@chromium.org2010-11-231-3/+3
| | | | | | | | | BUG=none TEST=Verify 552d branch builds. Review URL: http://codereview.chromium.org/5361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67168 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to recommit r67153 with successful tries.hansl@google.com2010-11-238-43/+87
| | | | | | | | | | Review here: http://codereview.chromium.org/5257003 BUG=None TEST=None Review URL: http://codereview.chromium.org/5356002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67167 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a test for UpdateState messages after repeated back/forward navs.creis@google.com2010-11-234-7/+96
| | | | | | | | | | | | | Ensures that the fix for WebKit bug 48809 works in Chrome. Also re-enables a UI test that failed after a partial fix. BUG=58082, 62156 TEST=RenderViewTest.LastCommittedUpdateState TEST=SessionHistoryTest.FragmentBackForward Review URL: http://codereview.chromium.org/4444001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67166 0039d316-1c4b-4281-b951-d872f2087c98
* A couple changes for network settings UI.xiyuan@chromium.org2010-11-236-20/+75
| | | | | | | | | | | | | - Put back "connect" button; - Disable connect for clicking on network item; - Use views dialog for wifi networks options/login; BUG=chromium-os:9507 TEST=Verify fix for chromium-os:9507 Review URL: http://codereview.chromium.org/5282003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67165 0039d316-1c4b-4281-b951-d872f2087c98
* Use VP8 over PseudoTCP by default.sergeyu@chromium.org2010-11-2318-124/+206
| | | | | | | | | | | Added option in simple_host to choose video codec. Removed ugly ifdefs from chromoting_host.cc. BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/5298001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67164 0039d316-1c4b-4281-b951-d872f2087c98
* Finish wiring up chrome.app.install().aa@chromium.org2010-11-2336-73/+470
| | | | | | | | | | | | There is a UI issue (noted in the code) that I need to figure out before I can turn it on by default. BUG=49233 TEST=n/a Review URL: http://codereview.chromium.org/4995001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67163 0039d316-1c4b-4281-b951-d872f2087c98