summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Register the RenderViewHost instance created when a desktop notification ↵ananta@chromium.org2011-10-281-25/+34
| | | | | | | | | | | | | | bubble is displayed in CF with the AutomationResourceMessagefilter. This ensures that any HTTP requests issued by this bubble go through the host network stack implemenation. Fixes bug http://code.google.com/p/chromium/issues/detail?id=64251 BUG=64251 Review URL: http://codereview.chromium.org/8414005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107669 0039d316-1c4b-4281-b951-d872f2087c98
* Fix checkdeps.py to check all the source directories in git checkouts.kinaba@chromium.org2011-10-281-1/+4
| | | | | | | | | | | BUG=33165 TEST=Manual: add an invalid #include in ppapi/examples/ime/ime.cc and verify it to be correctly warned. Review URL: http://codereview.chromium.org/8416016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107668 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem where app notification sync tests sometimes cant't delete temp dirasargent@chromium.org2011-10-281-1/+3
| | | | | | | | | | | | | BUG=101963 TEST=Running unit_tests --gtest_filter=AppNotificationManagerSyncTest.* should not leave around any empty temp directories (and there should be no error log messages from ScopedTempDir's desctructor about being unable to delete the underlying temp dir). Review URL: http://codereview.chromium.org/8415004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107667 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent extension and bookmark popups from interfering with close window/tab ↵isherman@chromium.org2011-10-282-41/+27
| | | | | | | | | | | | | | shortcuts. When a balloon popup is open, the target of the close window/tab keyboard shortcut is still the main browser window. Update our custom menu item rejiggering code to pay attention to the main window, rather than to the popup window, when a popup is open. BUG=95169 TEST=(see bug) Review URL: http://codereview.chromium.org/8302021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107666 0039d316-1c4b-4281-b951-d872f2087c98
* Handle additional feedback from http://codereview.chromium.org/8395038/.jam@chromium.org2011-10-2839-136/+119
| | | | | | | | | | | -rename URLFetcherFactory to URLFetcherImplFactory -rename GetUrl to GetURL and GetOriginalUrl to GetOriginalURL -get rid of request_type in TestURLFetcher's constructor BUG=98716 Review URL: http://codereview.chromium.org/8416020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107665 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix for win_auravarunjain@chromium.org2011-10-283-1/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8343040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107661 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress addr4/leak error in WebCore::PlatformSupport::decodeAudioFileDataoshima@google.com2011-10-271-0/+25
| | | | | | | | | | TBR=yurys@chromium.org BUG=102016 TEST=none Review URL: http://codereview.chromium.org/8341096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107660 0039d316-1c4b-4281-b951-d872f2087c98
* Change string16 to std::string in the gfx::Font() interface.erg@chromium.org2011-10-2721-84/+84
| | | | | | | | | | | | Most consumers on all platforms (including windows!) were converting the font family/GetFontName() result to UTF8. (Windows was still having to convert for the SkTypeface calls.) On Linux, we're performing a UTF16ToUTF8 on each string print (and this is showing up in pprof output.) BUG=100803 TEST=none Review URL: http://codereview.chromium.org/8392017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107659 0039d316-1c4b-4281-b951-d872f2087c98
* HistoryBackend: Fix a crash in BroadcastNotification.jhawkins@chromium.org2011-10-271-2/+4
| | | | | | | | | | | | | | This happens when the HistoryService starts closing the backend, and the ExpireHistoryBackend then tries to notify HistoryBackend of a deletion. BUG=101999 TEST=none R=brettw@chromium.org Review URL: http://codereview.chromium.org/8341087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107658 0039d316-1c4b-4281-b951-d872f2087c98
* Make Background pages highlightedyoshiki@chromium.org2011-10-271-1/+1
| | | | | | | | | | BUG=chromium-os:21732 TEST=manual Review URL: http://codereview.chromium.org/8341046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107657 0039d316-1c4b-4281-b951-d872f2087c98
* Update suppression for 70599oshima@google.com2011-10-271-3/+3
| | | | | | | | | | TBR=toyoshim@chromium.org BUG=70599 TEST=none Review URL: http://codereview.chromium.org/8418011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107656 0039d316-1c4b-4281-b951-d872f2087c98
* Instant: Fix a crash where the tab is closing and Instant 'hides' thejhawkins@chromium.org2011-10-271-1/+2
| | | | | | | | | | | | | | underlying TabContents. |render_widget_host_| is NULL as RenderWidgetHostViewWin is being destroyed. BUG=101948 TEST=none R=sky@chromium.org Review URL: http://codereview.chromium.org/8418005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107655 0039d316-1c4b-4281-b951-d872f2087c98
* Update suppression for 79654oshima@google.com2011-10-271-3/+6
| | | | | | | | | | TBR=sky@chromium.org BUG=79654 TEST=none Review URL: http://codereview.chromium.org/8416021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107651 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fix dcheck when setting sync encryption.zea@chromium.org2011-10-271-2/+3
| | | | | | | | | | | | | It's valid to call SetEncryptEverything after turning on encryption as long as you're not trying to turn it off. BUG=none TEST=set a custom passphrase after turning on encryption Review URL: http://codereview.chromium.org/8416008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107650 0039d316-1c4b-4281-b951-d872f2087c98
* Enable BookmarkContextMenuControllerTest.CutCopyPasteNode for aura builds.jennyz@chromium.org2011-10-271-8/+1
| | | | | | | | | | BUG=100347 TEST=NONE Review URL: http://codereview.chromium.org/8416009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107649 0039d316-1c4b-4281-b951-d872f2087c98
* Enable BookmarkUtilsTest.CopyPaste() test case for aura builds.jennyz@chromium.org2011-10-271-3/+0
| | | | | | | | | | BUG=100348 TEST=NONE Review URL: http://codereview.chromium.org/8343034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107648 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107645 (To see if it was responsible for increase in static ↵eroman@chromium.org2011-10-2713-293/+218
| | | | | | | | | | | | | | | | initializers) - Fix test snapshotting on linux by creating a separate automation path for snapshots outside of the thumbnail generator. BUG=69370,66371,63022 TEST=none Review URL: http://codereview.chromium.org/8294030 TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/8416022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107647 0039d316-1c4b-4281-b951-d872f2087c98
* Fix fullscreen API event delivery to be delayed until the state change hasdarin@chromium.org2011-10-274-41/+77
| | | | | | | | | | | | occured. This is done by observing ViewMsg_Resize. Adapt to new API from https://bugs.webkit.org/show_bug.cgi?id=70477 BUG=100264 R=jam@chromium.org Review URL: http://codereview.chromium.org/8366032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107646 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test snapshotting on linux by creating a separate automation path forkkania@chromium.org2011-10-2713-218/+293
| | | | | | | | | | | snapshots outside of the thumbnail generator. BUG=69370,66371,63022 TEST=none Review URL: http://codereview.chromium.org/8294030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107645 0039d316-1c4b-4281-b951-d872f2087c98
* Flipping the order of BackgroundModeManager and StatusTray members so that ↵rlp@chromium.org2011-10-271-2/+2
| | | | | | | | | | | the StatusTray is not deleted before the BackgroundModeManager. Technically this should not be an issue, but it can occur if the NOTIFICATION_APP_TERMINATING notification is not sent. BUG=101082 TEST=passes existing, but there are no repro steps for the crash to test Review URL: http://codereview.chromium.org/8393028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107644 0039d316-1c4b-4281-b951-d872f2087c98
* Drag and rotate windows between/within workspacesoshima@google.com2011-10-278-73/+599
| | | | | | | | | BUG=none TEST=new tests in workspace_manager_unittests Review URL: http://codereview.chromium.org/8391035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107643 0039d316-1c4b-4281-b951-d872f2087c98
* Adding input and output delay estimation for mac. xians@chromium.org2011-10-275-25/+287
| | | | | | Review URL: http://codereview.chromium.org/8234009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107642 0039d316-1c4b-4281-b951-d872f2087c98
* Add license check suppression for EGL extension headerskyostil@google.com2011-10-271-0/+3
| | | | | | | | | | | | | | | Add a license check suppression for gpu/EGL/eglext.h which got added in a recent commit. This is temporary fix and will be remedied by moving all the Khronos headers under gpu to third_party -- See http://code.google.com/p/chromium/issues/detail?id=98097. BUG=98097 TEST= Review URL: http://codereview.chromium.org/8343028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107641 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome OS: Attach bluetooth UI to device discovery APIvlaviano@chromium.org2011-10-273-9/+162
| | | | | | | | | | | | BUG=chromium-os:22140 TEST=Visit system settings page, click "Find devices" button, observe UI and read chrome logs. Change-Id: Idb0aa1650663f9c95d4c44194d6fa3b7e660d668 Review URL: http://codereview.chromium.org/8233042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107640 0039d316-1c4b-4281-b951-d872f2087c98
* Mark Worker ui layout tests flaky.dmichael@chromium.org2011-10-271-7/+31
| | | | | | | | | BUG=101996 TEST=N/A Review URL: http://codereview.chromium.org/8343038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107639 0039d316-1c4b-4281-b951-d872f2087c98
* LocationBarView: Add a CHECK to help debug a crash.jhawkins@chromium.org2011-10-271-0/+3
| | | | | | | | | | | BUG=101994 TEST=none R=sky@chromium.org Review URL: http://codereview.chromium.org/8418010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107637 0039d316-1c4b-4281-b951-d872f2087c98
* Compile fix for linux_aura.backer@chromium.org2011-10-271-1/+1
| | | | | | | | | | TBR=sadrul BUG=none TEST=linux_aura goes green Review URL: http://codereview.chromium.org/8416017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107636 0039d316-1c4b-4281-b951-d872f2087c98
* Update native_textfield_win.cc to parallel previous changes to ↵pkasting@chromium.org2011-10-271-7/+8
| | | | | | | | | | omnibox_view_win.cc. BUG=101938 TEST=none Review URL: http://codereview.chromium.org/8343036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107635 0039d316-1c4b-4281-b951-d872f2087c98
* Hack to fix Panel focus issues on Mac.dcheng@chromium.org2011-10-271-0/+11
| | | | | | | | | | | | This is just a temporary workaround for dogfood. BUG=97831 TEST=test app on crbug.com/101413 Review URL: http://codereview.chromium.org/8393014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107634 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to NewRunnableFunction.atwilson@chromium.org2011-10-272-6/+7
| | | | | | | | | BUG=98347 TEST=none Review URL: http://codereview.chromium.org/8400032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107633 0039d316-1c4b-4281-b951-d872f2087c98
* Adding flag for turning on the Media Source APIacolwell@chromium.org2011-10-278-13/+37
| | | | | | | | | | BUG=86536 TEST=None Review URL: http://codereview.chromium.org/8395053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107632 0039d316-1c4b-4281-b951-d872f2087c98
* Strip comments from shader before checking for invalid charactersgman@chromium.org2011-10-275-1/+223
| | | | | | | | | | BUG=101870 TEST=unit tests Review URL: http://codereview.chromium.org/8404029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107631 0039d316-1c4b-4281-b951-d872f2087c98
* Enable tooltips for aura.varunjain@chromium.org2011-10-277-31/+80
| | | | | | | | | | BUG=97249 TEST=none Review URL: http://codereview.chromium.org/8371024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107630 0039d316-1c4b-4281-b951-d872f2087c98
* Enhance and refactor ChromeDriver's capability handling. Log warning forkkania@chromium.org2011-10-278-177/+632
| | | | | | | | | | | | | | | non-recognized capabilities, return errors on incorrect input types, and allow new format where all options are placed under a chromeOptions dictionary. The latter is needed to simplify handling capabilities on the WebDriver client side. See http://codereview.appspot.com/5307047/. BUG=82895,94721 TEST=none Review URL: http://codereview.chromium.org/8341044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107629 0039d316-1c4b-4281-b951-d872f2087c98
* Mark CrossPlatformWebpageAccessibility as flaky, since it has been failing ↵eroman@chromium.org2011-10-271-1/+2
| | | | | | | | | on the Vista Debug bot. BUG=101984 Review URL: http://codereview.chromium.org/8400042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107628 0039d316-1c4b-4281-b951-d872f2087c98
* Fix visibility on WebLayerpiman@chromium.org2011-10-272-4/+18
| | | | | | | | | | | | | A change in the UI code exposed this bug where we were not setting the opacity properly on the web layer in certain cases. BUG=None TEST=chrome/aura Review URL: http://codereview.chromium.org/8400014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107627 0039d316-1c4b-4281-b951-d872f2087c98
* Move cloud_print_class_mac files from content/common to ↵jam@chromium.org2011-10-277-23/+22
| | | | | | | | | chrome/common/cloud_print. They don't belong in content. TBR=abodenha Review URL: http://codereview.chromium.org/8341079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107626 0039d316-1c4b-4281-b951-d872f2087c98
* Correct text y position calculation in RenderTextWin.asvitkine@chromium.org2011-10-271-6/+10
| | | | | | | | | | | | | | | | | | The previous calculation had a problem due to the following logic: SkPoint point(SkPoint::Make(SkIntToScalar(offset.x()), SkIntToScalar(display_rect().height() - offset.y()))); If display_rect().y() was large and height was the height for e.g. one line of text, then when the code subtracted offset.y() (which was based on display_rect().y()), the result was a negative y position (offscreen) for the text. This CL changes the logic to correctly center the text vertically regardless of the y position, which I believe was the intention of the code. BUG=none TEST=Open Chrome with --use-pure-views. Type something into omnibox. Text should be centered in omnibox. Review URL: http://codereview.chromium.org/8401032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107625 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Use scoped_ptr for CrosDBusService.satorux@chromium.org2011-10-272-11/+7
| | | | | | | | | | | | This was just an oversight. Along the way, update comments in dbus_thread_manager.h about callbacks. TEST=none BUG=none Review URL: http://codereview.chromium.org/8341073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107624 0039d316-1c4b-4281-b951-d872f2087c98
* Unnecessary file.backer@chromium.org2011-10-271-397/+0
| | | | | | | | | | | | | r107262 nuked it. r107433 reintroduced it (presumably a bad merge). R=apatrick BUG=none TEST=none Review URL: http://codereview.chromium.org/8414001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107623 0039d316-1c4b-4281-b951-d872f2087c98
* Call VerifyCleanExit in TerminateBrowser.achuith@chromium.org2011-10-274-30/+21
| | | | | | | | BUG=101390 TEST=ui tests continue to pass. Review URL: http://codereview.chromium.org/8390041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107622 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Fix keyevents from the numpad.sadrul@chromium.org2011-10-271-12/+18
| | | | | | | | | | | | It turns out XLookupKeysym does not take into account the status of the lock/shift etc. keys. So we need to use XLookupString instead (which does). BUG=101831 TEST=manually Review URL: http://codereview.chromium.org/8416005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107621 0039d316-1c4b-4281-b951-d872f2087c98
* OmniboxView: Attempt to fix a crash in GetSelectedText().jhawkins@chromium.org2011-10-271-0/+5
| | | | | | | | | | | BUG=101938 TEST=none R=pkasting@chromium.org Review URL: http://codereview.chromium.org/8417004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107620 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Add a stub implementation for SensorsSource.satorux@chromium.org2011-10-2710-135/+164
| | | | | | | | | | | | Along the way, rename the class to SensorsClient, to be consistent with other classes in the directory, and do some minor cleanup. BUG=none TEST=none Review URL: http://codereview.chromium.org/8400034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107619 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a smart pointer leak.backer@chromium.org2011-10-272-2/+2
| | | | | | | | | | R=ben BUG=run out of VRAM TEST=open and close many tabs on touch device; VRAM should remain roughly constant Review URL: http://codereview.chromium.org/8411002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107618 0039d316-1c4b-4281-b951-d872f2087c98
* Update chromium tests for new IDBDatabase.transaction() restrictions. The ↵jsbell@chromium.org2011-10-274-9/+11
| | | | | | | | | | | | | | | transaction([]) shortcut is no longer supported, stores must be listed explicitly. WebKit change is https://bugs.webkit.org/show_bug.cgi?id=70251 Discussion of change: https://groups.google.com/a/chromium.org/group/chromium-html5/browse_thread/thread/f667458ca6455d33/1496ad2d1a67b53f#1496ad2d1a67b53f BUG=101927 TEST=content_unittests --gtest_filter='*IndexedDB*' Review URL: http://codereview.chromium.org/8414002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107617 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IndexedDB test to explicitly list transactions. Required by WebKit changejsbell@chromium.org2011-10-271-1/+1
| | | | | | | | | | | | | in https://bugs.webkit.org/show_bug.cgi?id=70251 See thread: https://groups.google.com/a/chromium.org/group/chromium-html5/browse_thread/thread/f667458ca6455d33/1496ad2d1a67b53f#1496ad2d1a67b53f BUG=101973 TEST=performance_ui_tests --gtest_filter='*IndexedDB*' Review URL: http://codereview.chromium.org/8341080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107616 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce that chrome/common doesn't depend on content/common through DEPS. ↵jam@chromium.org2011-10-272-0/+9
| | | | | | | | | Also add a comment in the public dir of content. BUG=98716 Review URL: http://codereview.chromium.org/8417001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107614 0039d316-1c4b-4281-b951-d872f2087c98
* Added logic that will retry to reload+reconnect the mobile payment portal ↵zelidrag@chromium.org2011-10-279-102/+294
| | | | | | | | | | | | page 5 times before it eventually gives up and shows service unavailable error. Expanded frame sniffer to send an event when a frame which is being watched gets finally loaded. From the sent error (or its absence) and this new event, we can finally reconstruct on the browser side if a given iframe was loaded successfully or not. BUG=chromium-os:20525, chromium-os:21738 TEST=tricky one to test since it repros on 3g network flakyness. one can edit /usr/lib/cromo/config/madison.ini and put a bad value for olp_root there to trigger this. Review URL: http://codereview.chromium.org/8341037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107613 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Launcher remove itself as an observer from any windows it'ssky@chromium.org2011-10-271-0/+4
| | | | | | | | | | | | observing in its destructor. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/8417002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107612 0039d316-1c4b-4281-b951-d872f2087c98