| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=95492
TEST=crash reports do not reappear in canary
Review URL: http://codereview.chromium.org/7847016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7846020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SafeBrowsing phishing detection.
We'll be modifying the page_words field in ClientSideModel with murmurhash3's of the words, rather than SHA-256 hashes, since SHA-256 is fairly expensive to compute. Note that on a murmurhash3 hit, we'll still do a SHA-256 check against page_terms, so this will not introduce term collisions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7848010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were about to remove base/values.h include from chromeos_network.h
in libcros: http://gerrit.chromium.org/gerrit/#change,7429
It should be easy, right? No.
It turned out network_library.h etc. in Chrome are indirectly including
base/values.h via chromeos_network.h. We should include base/values.h
explicitly instead.
BUG=chromium-os:19576
TEST=chrome builds.
Review URL: http://codereview.chromium.org/7831064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
setup dialogs.
BUG=94065
TEST=manual
Review URL: http://codereview.chromium.org/7730005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=atwilson@chromium.org
BUG=95614
TEST=sign into sync on a new client with a two-factor account
Review URL: http://codereview.chromium.org/7859015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=53990
TEST=ExtensionApiTest.TabMove
Review URL: http://codereview.chromium.org/7787004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32624
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7858023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=95963
TEST=waterfall
Review URL: http://codereview.chromium.org/7859027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
detaches the loading of cookies from the IO thread.
They are now loaded on the DB thread. Cookie operations received in the meantime are queued and executed, on the IO thread, in the order they were received, when loading completes.
A few straggler clients are updated to use the asynchronous CookieStore/CookieMonster API as part of this CL, as the synchronous API is removed.
BUG=68657
TEST=net_unittests / DeferredCookieTaskTest.* and CookieMonsterTest.*
Review URL: http://codereview.chromium.org/7833042
TBR=erikwright@chromium.org
Review URL: http://codereview.chromium.org/7860026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
r6642: (mcgrathr) Update Chrome revision
r6643: (halyavin) Enable browser tests with glibc, part 3
r6644: (sehr) Update utman to get read sandboxing changes.
r6645: (robertm) Make prerequisite building a seperate step in the spec script.
r6646: (ncbray) Clean up build output on the Chrome bots.
r6647: (mcgrathr) Support --whole-archive/--no-whole-archive in pnacl-ld
r6648: (kschimpf) `Move the segment based decoder table generator to its own directory.
r6649: (jasonwkim) Add enum NaClSBKind argument to trusted code for selecting validator kind
r6650: (jasonwkim) commit
r6651: (jasonwkim) Add enum NaClSBKind argument to trusted code for selecting validator kind.
r6652: (jasonwkim) revert 6651
r6653: (pdox) Comment change to trigger rebuild.
r6654: (khim) Remove hack which converted symlinks to hardlinks on Windows.
r6655: (pdox) Give utman the ability to download the subversion LLVM and LLVM-GCC repositories.
r6656: (kschimpf) Turn on using the partial decoder tables for the x86-64 validator. Shrinks
r6657: (jvoung) Pull in newer version of chrome (99948).
r6658: (sehr) Separate ARM trusted toolchain verion from pnacl.
r6659: (mcgrathr) Update toolchain DEPS to 6655
r6660: (mcgrathr) Fix find_toolchain_revisions.py for linux-arm_trusted changes
r6661: (dspringer) Add tar manifest creation to caching logic.
r6662: (bradnelson) Move trybots archive to a separate bucket.
r6663: (robertm) Fixed some string matching bugs in the spec2k run script.
r6664: (jvoung) Update llvm rev for cleanup patch: http://codereview.chromium.org/7841019/
r6665: (pdox) Update merge-tool.sh and other scripts to get new LLVM merging buildbot working.
r6666: (mcgrathr) Fix dependencies in run_whole_archive_test, enable for PNaCl
r6667: (elijahtaylor) Change oprofile processor to allow events from nacl_helper_bootstrap.
r6668: (ncbray) Split building from testing in nacl_integration.
BUG=none
TEST=nacl_integration
Review URL: http://codereview.chromium.org/7841055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the DeferredDeleteCanonicalCookie test, we were using an existing helper method that initialized a CanonicalCookie on the heap and put a pointer to it in a list. This makes sense for other tests because they provide that list to the CookieMonster, which takes ownership of the list.
In this case, we only needed one cookie, which we pass by reference to the CookieMonster via a method that does not take ownership. Yet, it's enough of a hassle to create the cookie that I used this method.
The result is that no-one deletes the cookie from the heap.
I extracted the existing code that prepared the cookie, so that one can create either a single cookie or a list of them.
BUG=68657
TEST=net_unittests / DeferredDeleteCanonicalCookie
Review URL: http://codereview.chromium.org/7831056
TBR=erikwright@chromium.org
Review URL: http://codereview.chromium.org/7857023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r100231 was: add bubble views files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7720001
TBR=alicet@chromium.org
Review URL: http://codereview.chromium.org/7860025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and source is pdf.
Always set |display_header_footer| to false if it is a first print preview request and the initiator tab contents are not modifiable.
BUG=95225
TEST=On Mac, print preview a pdf file. The preview data should not dispaly any header and footer text.
Review URL: http://codereview.chromium.org/7787011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A version of Microsoft Office launches chrome under a virtual
environment, and this virtual environment does not allow us
to reduce the integrity level on the renderer. Since it returns
a fake error (ERROR_INVALID_HANDLE), we can trap it and continue
execution anyway... until we find a better fix.
BUG=95888
Review URL: http://codereview.chromium.org/7857022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the text entered into the password field has 16 lowercase alphabetical characters, or is 4 clusters of 4 lowercase alphabetical characters separated by spaces, add a second confirmation step to reduce the chance users encrypt their data with an ASP.
BUG=none
TEST=enter an ASP into the password field on sync signin, notice warning message.
Review URL: http://codereview.chromium.org/7859011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Plus some other cleanups around.
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/7858007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now only fetch a maximum of 1000 visits from the history DB, in an attempt
to avoid hitting OOM errors for URLs with millions of visits.
BUG=89793
TEST=New unit tests added. Don't have a repro for the crash itself, though.
Review URL: http://codereview.chromium.org/7795041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=95881
Review URL: http://codereview.chromium.org/7838040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=95957
TEST=none
TBR=vrk
Review URL: http://codereview.chromium.org/7831069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TSAN: Slightly widen a suppression.
BUG=20504,87062
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/7831067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=95951,95953,95954
TEST=None
TBR=huanr
Review URL: http://codereview.chromium.org/7787019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the DeferredDeleteCanonicalCookie test, we were using an existing helper method that initialized a CanonicalCookie on the heap and put a pointer to it in a list. This makes sense for other tests because they provide that list to the CookieMonster, which takes ownership of the list.
In this case, we only needed one cookie, which we pass by reference to the CookieMonster via a method that does not take ownership. Yet, it's enough of a hassle to create the cookie that I used this method.
The result is that no-one deletes the cookie from the heap.
I extracted the existing code that prepared the cookie, so that one can create either a single cookie or a list of them.
BUG=68657
TEST=net_unittests / DeferredDeleteCanonicalCookie
Review URL: http://codereview.chromium.org/7831056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=japhet
Review URL: http://codereview.chromium.org/7841058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
corresponding tests.
BUG=none
TEST=unit_tests
Review URL: http://codereview.chromium.org/7825005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To get these tests working, I added code to implement a local performance
test server in autotest wrapper desktopui_PyAutoPerfTests. The download
and upload tests make use of this local test server.
BUG=chromium-os:18185
TEST=None
Review URL: http://codereview.chromium.org/7846008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and push the asynchronous component (running on the FILE thread) up the stack
to ExtensionSettingsApi.
BUG=
TEST=existing unit tests
Review URL: http://codereview.chromium.org/7838007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
duplicate suppression.
BUG=29675
TEST=none
TBR=willchan
Review URL: http://codereview.chromium.org/7787018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jam@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7782013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instance while destroying the
form repost warning dialog. The crash occurs as the focus manager has a pointer to a stale focused
view. When the view is being destroyed we look up the corresponding focus manager instance and
clear out the focus or restore it to the previous value. However this fails in CF instances as
the logic to retrieve the focus manager first finds the root widget which in CF is an IE window.
Fix is to also look for the parent window for the widget being destroyed if we fail to find
the widget corresponding to the root.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=90809
BUG=90809
TEST=Chrome should not crash in ChromeFrame pages while destroying the form repost warning dialog.
Review URL: http://codereview.chromium.org/7787015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=lipalani@chromium.org
BUG=80150
TEST=none
Review URL: http://codereview.chromium.org/7831066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=lipalani@chromium.org
BUG=79568
TEST=none
Review URL: http://codereview.chromium.org/7859020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
UpdateLibrary.
R=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/7841051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open some panels and switch between panels and other windows.
Review URL: http://codereview.chromium.org/7856002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74383
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7858017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
waterfall bots.
Requires tests to be re-enabled (will re-disable them if I can't track down
the cause of the timeouts soon).
BUG=95246
R=aa@chromium.org
Review URL: http://codereview.chromium.org/7858010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43914,95931
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7859019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
testPostalCodeAndStateLabelsBasedOnCountry.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7860019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
be needed anymore. I suspect we took care for this issue by fixing releated memory issues around this code (crashes).
BUG=91179
TEST=make sure ParallelAuthenticatorTest.* pass without errors
Review URL: http://codereview.chromium.org/7859008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm not 100% sure running the same valgrind binaries for 32- and 64-bit installs is safe, but it seems to work.
BUG=95875
TEST=run valgrind scripts; have them succeed
Review URL: http://codereview.chromium.org/7860003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No sharing, nice UI and animations. No save reminders and feedback.
Most effects have preview on the whole image and so are little slow.
BUG=chromium-os:19534
TEST=Try out 'Gallery' action for images.
Review URL: http://codereview.chromium.org/7828044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before the call completes
This manifested itself as WebstoreInlineInstallTest.ArgumentValidation test
crashes because the test would make several chrome.webstore.install() calls
and not wait for responses before the test completed.
The fix was to make WebstoreInlineInstaller subclass TabContentsObserver and
check if the tab is still alive before trying to send responses back to it.
BUG=95713
Review URL: http://codereview.chromium.org/7861008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OomPriorityManager was being deleted during shutdown while a task was pending on the IO thread. Convert it to a singleton and explicitly start and stop it in the main loop.
BUG=chromium-os:18375
TEST=Open 3 tabs and navigate to web pages, wait 10 seconds, then open a tab to "about:discards". It should list 3 tabs and itself. Order is unimportant for now. Also, valgrind less red.
Review URL: http://codereview.chromium.org/7859006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
separate class so that it can be shared by all platforms.
BUG=none
TEST=existing browser tests
Review URL: http://codereview.chromium.org/7845025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ukai
Review URL: http://codereview.chromium.org/7859010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AFAICT, this suppression isn't used on the bots and it passes locally
for me.
BUG=79377
Review URL: http://codereview.chromium.org/7859017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100290 0039d316-1c4b-4281-b951-d872f2087c98
|