| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/522004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installed on the machine.
Based on my debugging it looks like AdBlock gets confused because we report the mime type initally as
text/html and then swich to application/chromepage.
Fix is to attempt to determine the mime type in our IInternetProtocolSink::ReportProgress implementation.
If we fail we continue to determine the mime type in IInternetProtocolSink::ReportData.
Added a helper function CheckAndReportChromeMimeTypeForRequest which is invoked from both places.
Fixes http://code.google.com/p/chromium/issues/detail?id=31031
Bug=31031
Review URL: http://codereview.chromium.org/501181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13156
TEST=Hook up task manager. Open it, double-click tabs. They should become active.
Review URL: http://codereview.chromium.org/521005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30681
TBR=stoyan
Review URL: http://codereview.chromium.org/522002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30508
r=ananta
Review URL: http://codereview.chromium.org/502019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
test to fail.
BUG=30990
TEST=nacl_ui_test
Review URL: http://codereview.chromium.org/519001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* There are two path to NativeViewDetaching and we need to handle them differently.
1) Via gtk destroy signal. In this case, we should not try to remove the native view from parent because it's being deleted.
2) Through NativeViewHost::Detach(). In this case we need to remove the native view from parent because we added it to parent in NativeViewAttached().
* Fix NativeControlGtk not to destroy the native view because it's now destoryed by NativeViewHostGtk.
* Fixed TabContentViewGtk so that it owns the nativew view. The native view was destroyed when Detached.
* Added more checks so that test can catch regression.
BUG=26154
TEST=The same procedure in bug should now pass. I added several checks that lead tests to fail if this problem exists.
Review URL: http://codereview.chromium.org/510004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to increase the cycle speed of the Tsan buildbot on Mac OS.
Review URL: http://codereview.chromium.org/490003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
See corresponding changes in webkit here: https://bugs.webkit.org/show_bug.cgi?id=31737
Review URL: http://codereview.chromium.org/434087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=hamaji@chromium.org
TEST=layout tests
BUG=None
Review URL: http://codereview.chromium.org/520002
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/515011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=hamaji@chromium.org
BUG=None
TEST=layout test on OSX (debug)
Review URL: http://codereview.chromium.org/516006
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/515010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=hamaji@chromium.org
TEST=debug layout test on OSX
BUG=None
Review URL: http://codereview.chromium.org/521002
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/522001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hamaji@chromium.org
TEST=debug layout test on OSX
BUG=None
Review URL: http://codereview.chromium.org/521002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly calling GL
Rather than make a GLBase with all virtual functions
I made it compile twice, once for shipping code where
it includes the local platform's gl.h and again for
unit tests where it includes gl_mock.h.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/511001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per the style guide, function overloading like this is allowed.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Overloading#Function_Overloading
I wanted this API so I could define and use a constant like:
const gfx::Insets kSomeInsets(1, 2, 3, 4);
layout->SetInsets(kSomeInsets);
BUG=none
TEST=try
Review URL: http://codereview.chromium.org/509027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hamaji@chromium.org
BUG=None
TEST=layout test on OSX (debug)
Review URL: http://codereview.chromium.org/516006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hamaji@chromium.org
TEST=layout tests
BUG=None
Review URL: http://codereview.chromium.org/520002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch prevents content scripts from being injected into incognito profile tabs by only injecting into the same profile in which the extension is running.
BUG=21392
TEST=Load chrome/test/data/extensions/api/incognito_no_script and open any url in incognito browser. No page titles should be modified to "modified".
Review URL: http://codereview.chromium.org/502079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland Disallow chrome.tabs.executeScript from injecting code into gallery
TBR=aa
BUG=30146
TEST=browertest is pending: http://codereview.chromium.org/506066
Original review: http://codereview.chromium.org/501098/
Review URL: http://codereview.chromium.org/518005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 699f771db23a92c9966fd9af92f0c69886d58136.
TBR=rvargas
Review URL: http://codereview.chromium.org/516005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30146
TEST=browertest is pending: http://codereview.chromium.org/506066
Review URL: http://codereview.chromium.org/501098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/515008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
parameters to gperf, which supresses adding the struct to the generated file for the second unit test hash.
TBR=brettw
Review URL: http://codereview.chromium.org/518002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29538
TEST=Extensions with utf8 encoded names should appear correctly named in the context menu.
Review URL: http://codereview.chromium.org/520001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
On my very fast machine, building the std::set in release mode on startup and blocks the UI thread for 15ms (there are > 3300 entries). It also uses 275KB of memory, not including 50KB of data in the dll. Using a perfect hash map, there's no startup cost. The dll's size increases by 135KB but there's no extra memory consumption, leading to a memory reduction of 140KB.
Review URL: http://codereview.chromium.org/515001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=esiedel@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/515004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
layout tests have been upstreamed to webkit.org; there are a few chromium-
specific tests under LayoutTests/platform/chromium.
Note that this removes some test expectations that will need to be put back
in when the tests show up with the next WebKit roll.
BUG=30503
TEST=many...
R=eseidel@chromium.org
Review URL: http://codereview.chromium.org/511002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Take 2: Reenable TCMalloc on Linux and make POSIX signal handling async signal safe.
Reinstates r34096 and r34036, which were reverted by r34632 due to hanging ui_tests and browser_tests on bots.
I've been unable to repro on the trybots despite hitting them with a ton of try jobs, so I'm trying on the buildbots again.
BUG=http://crbug.com/30501
Review URL: http://codereview.chromium.org/505068
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/517001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/516002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30990
TEST= NaCl integration test should succeed
Review URL: http://codereview.chromium.org/510002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
signal safe.
Reinstates r34096 and r34036, which were reverted by r34632 due to hanging ui_tests and browser_tests on bots.
I've been unable to repro on the trybots despite hitting them with a ton of try jobs, so I'm trying on the buildbots again.
BUG=http://crbug.com/30501
Review URL: http://codereview.chromium.org/505068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30358
TEST=see bug
Review URL: http://codereview.chromium.org/501179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to fail.
TBR=finnur@chromium.org
TEST=BlacklistedExtensionWillNotInstall
Review URL: http://codereview.chromium.org/514001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/508025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commands to it via a command buffer.
Added API for managing buffers to Pepper 3D device.
Removed DCHECK from WebPluginImpl::SetWindow that checks against a windowless plugin being given a window handle. Please check this! Now an initially windowless plugin instance gets a handle when it requests a Pepper 3D context. Perhaps the window handle should be concealed from the underlying plugin isntance.
Removed enable_gpu gyp variable and C macro. GPU code is always built on windows but not mac or linux. It is enabled at runtime with the --enable-gpu-plugin switch.
Redesigned CommandBuffer interface so it exposes shared memory through a Buffer. This was necessary because Pepper has no notion of shared memory handles. The Buffer exposes the shared memory as both a handle (through base::SharedMemory) and the mapped address and size.
Refactored CommandBufferEngine so mapped shared memory addresses and sizes are returned with a single call rather than two separate calls.
Added 3D demo to pepper test plugin.
TEST=try servers
BUG=none
Review URL: http://codereview.chromium.org/367002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
warning when enabling the extension through the Extensions Management UI.
BUG=30752
TEST=This requires an extension that autoupdates _and_ increases its permissions. If you ignore the infobar that says it has been disabled, you should still get the Install Warning dialog when you try to enable the extension.
Review URL: http://codereview.chromium.org/501137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31026,31028
TEST=layout tests: crash-when-navigating-away-then-back.html and feDisplacementMap-01.svg
Review URL: http://codereview.chromium.org/501180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/501127/show
Review URL: http://codereview.chromium.org/507074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/504084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28808
TEST=Run ui_tests
Review URL: http://codereview.chromium.org/502071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=valgrind test_shell_tests
BUG=none
Review URL: http://codereview.chromium.org/501175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
successfully run watchlist.py on my box either before or after making the change.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/504067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
renderer just before injection to avoid races.
BUG=30937
Review URL: http://codereview.chromium.org/509032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
indented too much. When a tab is removed we don't actually remove the
tab until the animation is done. This means the value returned by
GetTabHOffset isn't correct until after the tab is removed. I'm fixing
by forcing layout when done, which triggers calling GetTabHOffset.
The bug exists on both gtk and views, this fixes both.
BUG=22934
TEST=see bug
Review URL: http://codereview.chromium.org/505071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/507057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- make sure the handle is valid before doing anything with the fd.
- make sure the fstat works before mapping.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/509036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nib changes: Connect "End process" button to action and outlet, allow multiple selection on the table, make TaskManagerWindowController the delegate of the table view.
BUG=13156
TEST=Hook up task manager in menu, open it. Button should be enabled if at least one task is selected, clicking the button should terminate the selected processes.
Review URL: http://codereview.chromium.org/505073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves FFmpegVideoDecodeEngine FFmpegVideoDecoder, OmxVideoDecoder, and VideoDecoderImpl into their own files.
Refactors FFmpegDemuxerTest to be less of a characterization test, and to hopefully be less fragile.
Creates a set of utilities for handling Callbacks versus Tasks, and resource management related to Callbacks.
Re-enables the annexb filters for the chrome build of FFmpeg.
Added a BitstreamConverter class that abstracts the bitstream filter code.
Cleans up a few gyp mistakes with flag exporting.
Review URL: http://codereview.chromium.org/492023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CHROMEOS_BUG=1008
TEST=none
Review URL: http://codereview.chromium.org/509033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35170 0039d316-1c4b-4281-b951-d872f2087c98
|