| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Also change NavigateToURLLogResult to take a std::string for its URL argument.
Also prepend g_ on all the file-global static variables. This should help prevent future mistakes of a similar nature. This is not really within style but sort of matches the g_ for global variables. Anyway this file is pretty far out of style to begin with.
Review URL: http://codereview.chromium.org/169009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NEW_FOREGROUND_TAB and NEW_BACKGROUND_TAB dispositions in its implementation of TabContents::AddNewContents. These dispositions are handled by creating a new ExternalTabContainer instance, attaching it to the automation provider and sending off the AutomationMsg_AttachExternalTab IPC to the automation client requesting it to attach to the newly created tab.
This fixes bug http://b/issue?id=2050347
Bug=2050347
Review URL: http://codereview.chromium.org/164530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
meaningful errors appear in the logs.
This will help fight the test flakiness.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164564
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On POSIX it makes the server fork a separate process for each request for better
test isolation.
Starting with just few tests to limit impact of an eventual breakage. The results are promising.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
permissions then before, and prompt the user to re-enable.
Incidentally, this required adding support for disabling extensions.
BUG=12140
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/165414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These are only Windows baselines, Linux can also be rebaselined, but
that's for later.
Review URL: http://codereview.chromium.org/170010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is for the trunk. The previous CL was for the
release branch.
Review URL: http://codereview.chromium.org/170009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=992321,14061,14771,15460
TEST=none
Review URL: http://codereview.chromium.org/169016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/47039
TEST=LayoutTests/fast/harness will be enabled
BUG=19064
Review URL: http://codereview.chromium.org/164532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is not an extension.
BUG=19340
TEST=See bug for details.
Review URL: http://codereview.chromium.org/170007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=tony@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/170012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/169004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=17973
When a WebCore::Document is loaded, a resource request
for the document is made. In case of MediaDocument the
request for the media file is made separately through
<video> and so the DocumentLoader should be stopped.
This change mimic what is done in WebHTMLRepresentation
(which is similar to our RenderView) and stops the
resource loading in WebFrameLoaderClient since RenderView
doesn't have access to WebCore types.
Review URL: http://codereview.chromium.org/165286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=aa, kathyw
Review URL: http://codereview.chromium.org/170013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This utility is independent from o3d.
Input and output are all collada files.
Review URL: http://codereview.chromium.org/169007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164488
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=none
TEST=none.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17795
TEST=green
Review URL: http://codereview.chromium.org/170006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
That makes windowless transparent flash much better.
BUG=19157
Review URL: http://codereview.chromium.org/165522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify the find bar so that in GTK theme mode we:
- ...set the dialog shape to a series of points instead of an image.
- ...use the global border color.
- ...use GTK icons.
This does not draw the GtkEntry border around the GtkEntry though. That will be a follow up patch.
http://crbug.com/17962
Review URL: http://codereview.chromium.org/165497
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16089,16583,18984,19369,19371,19377,19385
TEST=valgrind tests green for a week
Review URL: http://codereview.chromium.org/170001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8635, 10290, 10303, 10463, 10998
TEST=none
Review URL: http://codereview.chromium.org/164534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165545
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16020
TEST=test with all media types and ensure there are no memory leaks are functional differences from previous version.
Review URL: http://codereview.chromium.org/160529
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to
reduce a dependency on ATL.
BUG=5023
TEST=Uninstall flash. Visit hulu.com and install the flash plugin.
Original review: http://codereview.chromium.org/165469
TBR=levin
Review URL: http://codereview.chromium.org/165543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19305 (http://crbug.com/19305)
TEST=Click and drag on the toolbar background and ensure that the window isn't moved.
Review URL: http://codereview.chromium.org/164528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
activation state of the window is changing to active. The
signal gets sent even when windows are going inactive (to make
the frame light blue), but we only want to do anything if
the window is trying to become active.
This seems fvwm specific in that gtk_window_present actually
changes focus in fvwm (in compiz/metacity, it just causes the
window to throb in the taskbar).
BUG=19292
Review URL: http://codereview.chromium.org/165502
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/170002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and real bugs filed.
TEST=None
BUG=None
TBR=mbleshe@chromium.org
Review URL: http://codereview.chromium.org/169005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/165547
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165537
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16089,16579
TEST=green
Review URL: http://codereview.chromium.org/165544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed "Status" sections (since this isn't a design doc
any more), ... Also added a few styles.
No meaningful changes to anything except packaging.html.
I did an editing pass on that page but didn't change the
content significantly.
TBR=aa, rafaelw
Review URL: http://codereview.chromium.org/165535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
consumers use executeCommand.
Patch by Marshall Greenblatt
R=darin
BUG=19270
TEST=covered by unit tests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This purify filter is already in the unit_tests.exe_UMR_flakey.txt file, so this is just bringing that hack to base.
BUG=http://crbug.com/18795
Review URL: http://codereview.chromium.org/165540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bundle names we use for the helpers.
TEST=page cycler tests should show memory for the renderers again.
BUG=19021
Review URL: http://codereview.chromium.org/165531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/8895
and http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/8896
The culprit is either 23407 or 23408. I'm trying 23408 first.
TBR=estage
TEST=webkit linux webkit_tests
BUG=none
Review URL: http://codereview.chromium.org/165534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam
BUG=none
TEST=reliability
Review URL: http://codereview.chromium.org/165532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164557
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164556
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Sorry I forgot removing a fprint() call used for debug.
TBR=brettw
BUG=18184
TEST=run unit_test on Mac
Review URL: http://codereview.chromium.org/164554
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fixes my new unit-test "SpellCheckTest.SpellCheckTest" breaks on Mac.
The system dictionaries of Mac spellchecker don't have the following words included in hunspell:
* en-AU (Australia): "organize" (which is a typo of "organise");
* en-GB (United Kingdom): "organize" (which is a typo of "organise");
* pt-BT (Brazil): "Google";
* pt-PT (Portugal): "Google".
This change removed "Google" from a couple of texts and fixed a couple of typos. Also, this change adds a language for Spanish (Spain), which I forgot adding.
TBR=brettw
BUG=18184
TEST=run unit_tests on Mac
Review URL: http://codereview.chromium.org/164553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change adds a new unit test "SpllCheckTest.SpellCheckText" for testing our spellchecker with all available dictionaries.
BUG=18184 "Add more spellcheck tests with languages other than en-US"
TEST=run unit_test.exe
Review URL: http://codereview.chromium.org/159906
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165526
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23429 0039d316-1c4b-4281-b951-d872f2087c98
|