summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* WebKit merge from r44699 to r44726.tc@google.com2009-06-163-3/+8
| | | | | | | | | Compile fix for new files in r44726 and a test changed in r44712. Review URL: http://codereview.chromium.org/125207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18529 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some files from third_party\cld which are not required.sidchat@google.com2009-06-167-2249/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18528 0039d316-1c4b-4281-b951-d872f2087c98
* Fix StatsTable::RegisterThread so that it doesn't crash if shared memoryevan@chromium.org2009-06-162-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | couldn't be allocated. Instead, it just returns 0. Also, fix StatsTable::AddCounter so that it's not a fatal error if shared memory couldn't be allocated. Instead, it just returns 0. In StatsTableTest::StatsCounter, we now assert that the counter could be created, rather than just expecting it. Much of the remainder of the test relies on the fact that foo.Pointer() is non-NULL, and would crash if it were NULL. TEST= StatsTableTest.* RenderViewTest.* Didn't test on Linux (still figuring out how to build on that plaform). Instead, tested on Mac OS X by modifying StatsTablePrivate::New to return NULL, and then ran: unit_tests --gtest_filter='Render*' base_unittests --gtest_filter='StatsTableTest.*' Both tests tests crashed. Then, I applied the changes in this CL, reran the tests, and verified the crashing no longer occured. BUG=13193 BUG=13196 Review URL: http://codereview.chromium.org/126100 Patch from Neil Rhodes <nrhodes@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18527 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing headers to gyp files.jam@chromium.org2009-06-162-0/+3
| | | | | | Review URL: http://codereview.chromium.org/125204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18526 0039d316-1c4b-4281-b951-d872f2087c98
* Initial stub for the support library, gyp file and targets. Chrome.exe and ↵slightlyoff@chromium.org2009-06-162-0/+25
| | | | | | | | chrome.dll will depend on them. Review URL: http://codereview.chromium.org/125155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18525 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a test as failing on linux/debug.tc@google.com2009-06-161-0/+3
| | | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/126225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18524 0039d316-1c4b-4281-b951-d872f2087c98
* Improved tab overview animations with better animation and wiring tosky@chromium.org2009-06-1616-57/+376
| | | | | | | | | | | message loop. BUG=none TEST=none Review URL: http://codereview.chromium.org/126185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18523 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18512 - Revert 18373 Consider a redirect following user gesture as ↵laforge@chromium.org2009-06-1618-33/+317
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | userinitiated in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 TBR=laforge@chromium.org Review URL: http://codereview.chromium.org/126221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18522 0039d316-1c4b-4281-b951-d872f2087c98
* Remove type from page action manifest, since we are ignoring that value ↵finnur@chromium.org2009-06-161-2/+1
| | | | | | | | | | | | anyway at the moment. TBR=aa BUG=None TEST=None (RSS page action should work as before) Review URL: http://codereview.chromium.org/126214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18521 0039d316-1c4b-4281-b951-d872f2087c98
* * Add an OnCancelResolution() notifier to HostResolver::Observer, so ↵ericroman@google.com2009-06-165-32/+199
| | | | | | | | | | | | | | | observers can tell when a request has been cancelled. * Use OnCancelResolution() in DNS prefetcher observer, to avoid leaking entries in the |resolution| table when requests are cancelled. (BUG=14138) * Fix a bug where completion notification wasn't being sent when the response was cached. (BUG=14188) BUG=14138,14188 TEST=HostResolverTest.CancellationObserver, HostResolverTest.Observer Review URL: http://codereview.chromium.org/125171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18520 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/125205mark@chromium.org2009-06-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18519 0039d316-1c4b-4281-b951-d872f2087c98
* Move TableModel out of views/ and into app/.estade@chromium.org2009-06-1629-222/+179
| | | | | | | | | Remove stub implementation in temp_scaffolding_stubs.h Use l10n_util collator helper function in TableModel::Compare Review URL: http://codereview.chromium.org/126184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18518 0039d316-1c4b-4281-b951-d872f2087c98
* Add file icons to chrome://downloads/ on the Mac. Add Skia helpermark@chromium.org2009-06-168-133/+207
| | | | | | | | | | CGImageToSkBitmap(). Patch by Robert Sesek <rsesek@bluestatic.org> Review URL: http://codereview.chromium.org/118488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that could happen at shutdown or window close due to a double-free.mpcomplete@google.com2009-06-164-26/+7
| | | | | | | | | | | | This is erikkay's patch. I'm landing it while he's away. TBR=erikkay BUG=none TEST=install an extension with a toolstrip and close chrome. It shouldn't crash. Review URL: http://codereview.chromium.org/126219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18516 0039d316-1c4b-4281-b951-d872f2087c98
* Extract load times from WebDataSource. Move them to NavigationState.darin@chromium.org2009-06-1656-305/+342
| | | | | | | | | | | | Move PasswordForm into the webkit_glue namespace. TEST=none BUG=10041 R=brettw Review URL: http://codereview.chromium.org/126190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18515 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit merge from r44682 to r44699.tony@chromium.org2009-06-162-3/+8
| | | | | | | | | | | Not much here, just one layout test that changed expectations. Added some flakey video tests to the list while I'm at it. Review URL: http://codereview.chromium.org/126174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18514 0039d316-1c4b-4281-b951-d872f2087c98
* Access RenderThread::current() only on render threadhclam@chromium.org2009-06-163-47/+80
| | | | | | | | | | Since the renfer to RenderThread is now stored in the thread local storage, we can only access RenderThread::current() from render thread. Change BufferedDataSource accordingly. Review URL: http://codereview.chromium.org/126183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18513 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18373 - Consider a redirect following user gesture as userinitiated ↵laforge@chromium.org2009-06-1618-317/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18512 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporate new Linux deb packaging file.mmoss@chromium.org2009-06-161-0/+1
| | | | | | | Review URL: http://codereview.chromium.org/125199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18511 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18484 - DevTools: Add support for dumping objects into the console.laforge@chromium.org2009-06-169-190/+117
| | | | | | | | | | Review URL: http://codereview.chromium.org/126132 TBR=pfeldman@chromium.org Review URL: http://codereview.chromium.org/126217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18509 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18482, gyp conversion of chrome.exe; first run issues.sgk@google.com2009-06-161-0/+1
| | | | | | | | BUG=14179 TEST=none Review URL: http://codereview.chromium.org/126215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18508 0039d316-1c4b-4281-b951-d872f2087c98
* Restore .pdb file names to chrome_{dll,exe}.pdb (as expected by thesgk@google.com2009-06-161-2/+16
| | | | | | | | | symbol infrastructure), not {product_name}.pdb. BUG=none TEST=none Review URL: http://codereview.chromium.org/125198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18507 0039d316-1c4b-4281-b951-d872f2087c98
* Add better baselines. My previous check-in didn't have the right ones. I ↵dglazkov@google.com2009-06-164-12/+101
| | | | | | | | | | | | blame rebaselining tool! :) TBR=senorblanco BUG=12352 TEST=no sad redness. Review URL: http://codereview.chromium.org/126213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18506 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show tooltips if the window isn't main.pinkerton@chromium.org2009-06-161-1/+4
| | | | | | | | BUG=none TEST=tooltips shouldn't show if the window isn't the frontmost. Review URL: http://codereview.chromium.org/125194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18505 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests, affected by fixes to Skia compositing upstream: ↵dglazkov@google.com2009-06-1611-12/+16
| | | | | | | | | | | | | | http://trac.webkit.org/changeset/43902 We actually had wrong baselines and the fixes broke our layout tests :-\ R=senorblanco BUG=12352 TEST=no layout test regressions. Review URL: http://codereview.chromium.org/125195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18504 0039d316-1c4b-4281-b951-d872f2087c98
* Hack to enable video on mac by creating a blank PlatformContextMac to draw on.ajwong@chromium.org2009-06-167-19/+35
| | | | | | | | This isn't a great solution, but it kinda works. Video renders, and the speed is acceptable even though we're doing an extra copy for each frame. The image shows up upside-down though. :( Review URL: http://codereview.chromium.org/126087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18503 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Windows release compile by adding missing build_config.h include.phajdan.jr@chromium.org2009-06-161-0/+2
| | | | | | | | TBR=deanm Review URL: http://codereview.chromium.org/126211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18502 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing problem where ml, hi, pt-PT and bg first run bubbles were truncated or tojshin@chromium.org2009-06-164-6/+6
| | | | | | | | | | | | | | | | narrow to hold all of text. Increased width of bubble by 4+ chars, and for bg increased the height of bubble by 1. BUG=12208 (http://crbug.com/12208) TEST=Run Chrome with --lang=ml, --lang=hi, --lang=pt-PT, --lang=bg. In 'First Run UI', press button 'Start Google Chrome' and see if there's any truncated string in the FirstRun Bubble. Everytime you run Chrome with different language options, please make sure to delete 'First Run' file in Chrome application folder. Patch by nciric (cira) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18501 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in chrome/browser/phajdan.jr@chromium.org2009-06-1649-71/+93
| | | | | | | | In my scan of headers I got up to browser/gtk/ Review URL: http://codereview.chromium.org/126131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18500 0039d316-1c4b-4281-b951-d872f2087c98
* Make HttpNetworkLayer tests network-independent.phajdan.jr@chromium.org2009-06-164-31/+51
| | | | | | | | | | | | This includes a small refactoring which allows using a different socket factory. TEST=Covered by net_unittests. BUG=http://crbug.com/14107 Review URL: http://codereview.chromium.org/126147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18499 0039d316-1c4b-4281-b951-d872f2087c98
* Removes entirely dead code paths related to ConstrainedWindows.erg@chromium.org2009-06-1615-332/+36
| | | | | | | | | | - Removes parts of the interface that probably made sense at some time, but now only have a DLOG(INFO) as their implementation. Also remove their callers. - Remove all usage of the ConstrainedWindowProxy interface in the automation system. It was *never* used. - Rename constrianed_window_impl_interactive_uitests.cc to blocked_popup_container_interactive_uitest.cc. The test case hasn't tested code in constrained_window_impl.cc since the rewrite of the blocked popup system back last autumn. Review URL: http://codereview.chromium.org/125160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18498 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing cairo_surface_destroy. Fixes a memory leak.phajdan.jr@chromium.org2009-06-161-0/+1
| | | | | | Review URL: http://codereview.chromium.org/126133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18497 0039d316-1c4b-4281-b951-d872f2087c98
* Add purify and extensions to watchlist.erikkay@google.com2009-06-161-0/+8
| | | | | | Review URL: http://codereview.chromium.org/126205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18496 0039d316-1c4b-4281-b951-d872f2087c98
* Adding ap key inclusion to uninstall metrics.robertshield@google.com2009-06-161-0/+9
| | | | | | | | BUG=http://crbug.com/14007 TEST=Uninstall a build with this patch and verify that the uninstall survey window has ap=XXXX in the URL. Review URL: http://codereview.chromium.org/126154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18495 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tests that are now passing from expectations.dglazkov@google.com2009-06-161-9/+1
| | | | | | | | | | TBR=darin BUG=12860 TEST=no layout test regressions. Review URL: http://codereview.chromium.org/125193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18494 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up the sprintf to properly mark the string as a wide string.thomasvl@chromium.org2009-06-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/125191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18493 0039d316-1c4b-4281-b951-d872f2087c98
* Use a pdf instead of a png for incognito badge.pinkerton@chromium.org2009-06-163-2/+255
| | | | | | | | BUG=none TEST=incognito badge should display correctly in incognito windows. Review URL: http://codereview.chromium.org/126204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18491 0039d316-1c4b-4281-b951-d872f2087c98
* Make tooltip loading lazy.pinkerton@chromium.org2009-06-161-2/+3
| | | | | | | | BUG=none TEST=normal tooltip tests Review URL: http://codereview.chromium.org/126203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18490 0039d316-1c4b-4281-b951-d872f2087c98
* InspectorController::Setting::integerValue() returns a long. Fix format ↵craig.schlenter@chromium.org2009-06-161-1/+1
| | | | | | | | string to match. Review URL: http://codereview.chromium.org/126202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18489 0039d316-1c4b-4281-b951-d872f2087c98
* Bring url_fetch_test into compiling shape on mac/linux.thomasvl@chromium.org2009-06-162-35/+42
| | | | | | Review URL: http://codereview.chromium.org/126072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18488 0039d316-1c4b-4281-b951-d872f2087c98
* Solve a strict-aliasing issue in metrics_log.cc to appease gcc 4.4 on Linux.craig.schlenter@chromium.org2009-06-161-5/+9
| | | | | | Review URL: http://codereview.chromium.org/126104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18487 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Fix standalone devtools app mode.pfeldman@chromium.org2009-06-161-2/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18486 0039d316-1c4b-4281-b951-d872f2087c98
* Fix rebaselining of a layout test. Accidentally rebaselines with aager@chromium.org2009-06-162-2/+2
| | | | | | | wrong version of V8. Review URL: http://codereview.chromium.org/125180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18485 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add support for dumping objects into the console.pfeldman@chromium.org2009-06-169-117/+190
| | | | | | Review URL: http://codereview.chromium.org/126132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18484 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.2.8.ager@chromium.org2009-06-163-3/+3
| | | | | | | This version contains a number of performance improvements. Review URL: http://codereview.chromium.org/126194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18483 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome.exe to gyp.sgk@google.com2009-06-161-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18482 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome.dll to gyp generation.sgk@google.com2009-06-161-1/+1
| | | | | | | | | Adds dependency on ffmpeg to pull in av*.dll files. BUG=none TEST=succesfull build Review URL: http://codereview.chromium.org/126187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18481 0039d316-1c4b-4281-b951-d872f2087c98
* Whoops. Actually print out the private key in the unit test,aa@chromium.org2009-06-161-1/+1
| | | | | | | | instead of the crx file. Review URL: http://codereview.chromium.org/125172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18480 0039d316-1c4b-4281-b951-d872f2087c98
* Removed mixed content options. Turns out extremely few users changed the ↵abarth@chromium.org2009-06-163-165/+2
| | | | | | | | | | | | default. R=beng BUG=None TEST=Go to options dialog and notice that the mixed content option is gone. Review URL: http://codereview.chromium.org/126106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18479 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary static_cast in the ctor of TabContents and AsWC helperbrettw@chromium.org2009-06-161-32/+20
| | | | | | | | | | | function. These were leftover from Brett's refactoring of Tab/WebContents. Original review: http://codereview.chromium.org/125040 Patch by tyoshino@google.com Review URL: http://codereview.chromium.org/125138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18478 0039d316-1c4b-4281-b951-d872f2087c98