| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Add some extra error logging.
BUG=85230,88193
TEST=none
Review URL: http://codereview.chromium.org/7292025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7273088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We've been getting various complaints and bug reports by users that don't realize force-compositing-mode is enabled. This change should cause the about:flags option to reset without changing the command-line flag or any text that users see.
Review URL: http://codereview.chromium.org/7300019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set focus on scroll view so that mouse wheel events will be sent to
scroll view.
BUG=chromium-os:14079
TEST=create more than 5 notifications so that notification panel will have scroll bar. 2 finger scroll should work with this patch.
Review URL: http://codereview.chromium.org/7168001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will make sure exit_cleanly is written.
CleanUP: renamed MarkAsCleanShutdown to MarkAsCleanShutdowInUserProfiles to reflect what the method really does.
BUG=85936
TEST=Along with crosbug.com/16458 fix, ChromeOS's UMA crash number will decrease to the level of
other platforms.
Review URL: http://codereview.chromium.org/7273038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=sky@chromium.org
TEST=browser_tests --gtest_filter=PrintPreview*.*
Review URL: http://codereview.chromium.org/7277076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
routed -> control
allowing it to be sent from BrowserRenderProcessHost::OnProcessLaunched
and minimizing the number of required IPCs (since the online state
is a per-WebKit singleton).
In doing so, I've disentangled online state management from TabContents: it now resides off by itself in BrowserOnlineStateObserver, a tiny class owned by BrowserProcessImpl.
BUG=7469,86538
TEST=begin with network disconnected, open new tab, load test page attached to 7469, then re-connect network
Review URL: http://codereview.chromium.org/7259004
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/7300018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
queried from multiple threads. This also moves the functionality into the UserAgentState class itself since that seemed a little more well-scoped.
BUG=87698
TEST=none
Review URL: http://codereview.chromium.org/7277067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allowing it to be sent from BrowserRenderProcessHost::OnProcessLaunched
and minimizing the number of required IPCs (since the online state
is a per-WebKit singleton).
In doing so, I've disentangled online state management from TabContents: it now resides off by itself in BrowserOnlineStateObserver, a tiny class owned by BrowserProcessImpl.
BUG=7469,86538
TEST=begin with network disconnected, open new tab, load test page attached to 7469, then re-connect network
Review URL: http://codereview.chromium.org/7259004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=88257
TEST=none
TBR=erg
Review URL: http://codereview.chromium.org/7289050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/7302002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no
TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/7300013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
some tests.
R=thestig@chromium.org,phajdan.jr@chromium.org
BUG=82437
TEST=Temporarily add assertTrue(false) and then run browser_tests --gtest_filter=PrintPreview*.*
Review URL: http://codereview.chromium.org/7280003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=app_unittests
R=cmp@chromium.org, tony@chromium.org
Review URL: http://codereview.chromium.org/7198030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
feature which uses it is
specific to Chrome. This interface is now part of the BookmarkTabHelper class.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=87682
BUG=87682
TEST=no change in functionality. Existing tests should continue to work.
Review URL: http://codereview.chromium.org/7291018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=georgey@chromium.org
BUG=81782
TEST=none
Review URL: http://codereview.chromium.org/7304007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7304006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=timurrrr@chromium.org,
BUG=88254
TEST=none
Review URL: http://codereview.chromium.org/7302013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
headers. No code change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7198033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7301008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7294001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes some DCHECKs on classes that assert they're on the UI thread.
Also shuffled some code around.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7282040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=84246
TEST=None
Review URL: http://codereview.chromium.org/7283029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NoStartupWindowTest.NoStartupWindowBasicTest
RunInBackgroundTest.RunInBackgroundBasicTest
TBR=evan@chromium.org
BUG=88244
TEST=none
Review URL: http://codereview.chromium.org/7282045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7277072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87951
TEST=Run perf tests, see deletions get faster
Review URL: http://codereview.chromium.org/7294015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is little bit similar to COMPONENT extensions (which are developed by
Google and come pre-installed with Chrome), but lets us decouple them and
serve out of the WebStore with slightly different warning messages.
BUG=b/4946060
TEST=Installing the extension mentioned in the bug report should still work.
Review URL: http://codereview.chromium.org/7248034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13887
TEST=all platforms still compile
Review URL: http://codereview.chromium.org/7273085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=76789
TEST=no
Review URL: http://codereview.chromium.org/7276051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7300012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r91301 was not intended to be used in Valgrind configurations, but the GYP
variable controlling Valgrind builds is named release_valgrind_build, which
makes it seem like the Valgrind builders use the Release configuration. r91301
was only effective in Debug mode. Who would have guessed that the Valgrind
builders actually use the Release configuration, and a separate check for
release_valgrind_build is needed to keep them from using
-fstack-protector-all.
BUG=88238
TEST=none
Review URL: http://codereview.chromium.org/7302010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
BUG=88238
TEST=none
Review URL: http://codereview.chromium.org/7302009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7282044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=67733
TEST=Searching using the built-in mail.ru provider (for Russian locales) should show suggestions.
Review URL: http://codereview.chromium.org/7300007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76997
TEST=none
Review URL: http://codereview.chromium.org/7281018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=75655
TEST=Re-enabled tests should work.
Review URL: http://codereview.chromium.org/7300008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal was to support something as simple as the following, where the tests in the
javascript files would be 1st class GTESTs, supporting FLAKY_, DISABLED_, etc, and
registered at linker_initialization time.
WEB_UI_BROWSER_TEST_JS(WebUIBrowserTest, TestJSPass,
FILE_PATH_LITERAL("sample_passing.js")) {
ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
}
This solution ended up being fairly fragile, and I ended up with a script to parse javascript (with the help of v8_shell) and generate an includable ...-inl.h file with the following for every test in the .js file specified in the |rules| section of tools/js2webui.py
IN_PROC_BROWSER_TEST_F(WebUIBrowserTestPass, testHelper) {
AddLibrary(FilePath(FILE_PATH_LITERAL("sample_pass.js")));
ASSERT_TRUE(RunJavascriptTest("testHelper"));
}
http://www.chromium.org/Home/domui-testing
BUG=82437
R=estade@chromium.org,jhawkins@chromium.org
TEST=browser_tests --gtest_filter=WebUIBrowserTest*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89453
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89605
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89626
Review URL: http://codereview.chromium.org/7087014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is we attempt to show a content menu for a TabContents that is no
longer in the model.
BUG=86713
TEST=see bug
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7232028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=wtc@chromium.org
BUG=88228
TEST=none
Review URL: http://codereview.chromium.org/7277068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r91350.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
CID=8461
Review URL: http://codereview.chromium.org/7237018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables button border for NativeTextButton on Linux/Chromeos.
BUG=chromium-os:17202
TEST=Verify fix for chromium-os:17202.
Review URL: http://codereview.chromium.org/7210033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=agayev@chromium.org
BUG=88225
TEST=none
Review URL: http://codereview.chromium.org/7277066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/7289023
BUG=none
TEST=Thoroughly test all items in the network menu, including during OOBE, login screen, and after logged in.
Review URL: http://codereview.chromium.org/7198037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=crypto_unittests
Review URL: http://codereview.chromium.org/7273080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85247
TEST=None
Review URL: http://codereview.chromium.org/7210059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=88221
TEST=none
Review URL: http://codereview.chromium.org/7289043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Includes some additional class cleanup.
BUG=none
TEST=Thoroughly test all items in the network menu, including during OOBE, login screen, and after logged in.
Review URL: http://codereview.chromium.org/7289023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the last dependencies on history::StarredEntry class
from bookmarks API.
BUG=None
TEST=unit_tests
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7210039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91346 0039d316-1c4b-4281-b951-d872f2087c98
|