summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix some issues found looking at the code.maruel@google.com2008-09-3015-61/+57
| | | | | | | | | | Patch from Gaetano Mendola <mendola@gmail.com> Original review: http://codereview.chromium.org/4273 I added some additions on my part and two unit test fix due to the added DCHECK. Reduced atl header inclusion. Review URL: http://codereview.chromium.org/5009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2730 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to make Gears build on linux.mpcomplete@google.com2008-09-308-89/+241
| | | | | | Review URL: http://codereview.chromium.org/5023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2726 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 3011: Accessibility crash on teardown of HWNDViewContainerfinnur@google.com2008-09-301-0/+7
| | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=3011 Looks like we are trying to access the HWND of a window during teardown of the window. Review URL: http://codereview.chromium.org/6015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2723 0039d316-1c4b-4281-b951-d872f2087c98
* On the Mac, extract the CGContextRef to pass down to WebCore, since a blindamanda@chromium.org2008-09-301-2/+6
| | | | | | | reinterpret_cast will fail miserably. Review URL: http://codereview.chromium.org/5613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2722 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings.tc@google.com2008-09-301-2/+2
| | | | | | | TBR=mal Review URL: http://codereview.chromium.org/6014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2721 0039d316-1c4b-4281-b951-d872f2087c98
* Bring chrome/test/chrome_plugin/ into Linux build.mmoss@google.com2008-09-302-24/+29
| | | | | | | | BUG=2965 Review URL: http://codereview.chromium.org/5035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2717 0039d316-1c4b-4281-b951-d872f2087c98
* Use RandUInt64 instead of going from signed to unsigned.deanm@chromium.org2008-09-301-1/+1
| | | | | | Review URL: http://codereview.chromium.org/6011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2714 0039d316-1c4b-4281-b951-d872f2087c98
* Use open-vcdiff source in its new home on the Mac (follow-up to r2709)mark@chromium.org2008-09-303-9/+9
| | | | | | Review URL: http://codereview.chromium.org/3407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2713 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce RandDouble to one call to ldexp, add one bit of precisionmark@chromium.org2008-09-302-18/+18
| | | | | | Review URL: http://codereview.chromium.org/5801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2712 0039d316-1c4b-4281-b951-d872f2087c98
* Get open-vcdiff building on Linux and Mac (in SCons) usingsgk@google.com2008-09-304-19/+102
| | | | | | | | | | | | | | | | | captured values for generating a config.h file. Builds base/sdch_{filter,manager}.cc on all platforms and links the 'sdch' library. Add sdch to the SCons configuration loaded on Mac and Linux. Removes platform #ifs in net/base/filter.cc initialization code (reverting r2740). B=2662 Review URL: http://codereview.chromium.org/5204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2710 0039d316-1c4b-4281-b951-d872f2087c98
* Transition to pulling open-vcdiff rather than using a private snapshot pulljar@google.com2008-09-305-35/+38
| | | | | | | | | | | | | | I can't include all the svn deletions (all of sdch/open_vcdiff/*) in this change list, as it will break reitveld. I'll do them piecemeal after a get an LGTM. Also, by temporarilly leaving in the old subtree, I can support mac until the move to use this new sub-tree. r=nsylvain,sgk Review URL: http://codereview.chromium.org/5402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2709 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::RandInt() in place of rand(), now that rand_util has been moved ↵ericroman@google.com2008-09-301-2/+2
| | | | | | | | from chrome/ to base/. Review URL: http://codereview.chromium.org/5036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2707 0039d316-1c4b-4281-b951-d872f2087c98
* When an SSL connect is completed, we need to callwtc@google.com2008-09-301-6/+7
| | | | | | | | | | | | | HandleCertificateError first, because it may change 'result' to 'OK' if the load flags say we should ignore that certificate error, and we want to take the 'result == OK' code path when that happens. R=rvargas BUG=2703 Review URL: http://codereview.chromium.org/4340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2705 0039d316-1c4b-4281-b951-d872f2087c98
* Bug 1653: Ctrl+S should bring up save page dialog.finnur@google.com2008-09-301-0/+1
| | | | | | Review URL: http://codereview.chromium.org/4344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2704 0039d316-1c4b-4281-b951-d872f2087c98
* While testing I hit a DCHECK on line 1643 (because of a UMR).finnur@google.com2008-09-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2703 0039d316-1c4b-4281-b951-d872f2087c98
* Sync Mac canvas implementation with Windows version, still a work in progress,jeremy@chromium.org2008-09-296-138/+102
| | | | | | | | not all unit tests pass yet. Review URL: http://codereview.chromium.org/4339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2702 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments to explain the ERR_NAME_NOT_RESOLVED case.darin@google.com2008-09-291-0/+6
| | | | | | | | TBR=wtc Review URL: http://codereview.chromium.org/4343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2701 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring for portability:mark@chromium.org2008-09-2933-200/+370
| | | | | | | | | | | | | - Move chrome/common/env_util to base/sys_info - Move chrome/common/rand_util to base/rand_util (new), simplify its public interface, and fix its implementation Patch by Paweł Hajdan, Jr. <phajdan.jr@gmail.com> http://codereview.chromium.org/4079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2697 0039d316-1c4b-4281-b951-d872f2087c98
* Add code to call ReconsiderProxyAfterError when we encounter a failure to ↵darin@chromium.org2008-09-292-3/+49
| | | | | | | | | | | resolve a hostname or a failure to connect a client socket. BUG=2962 R=wtc Review URL: http://codereview.chromium.org/5033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2695 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanups for gcc warnings:mmoss@google.com2008-09-291-7/+4
| | | | | | | | | | | | | | test/chrome_plugin/test_chrome_plugin.cc:26: warning: comparison between signed and unsigned integer expressions test/chrome_plugin/test_chrome_plugin.cc:73: warning: 'ResponseStream::request_' will be initialized after test/chrome_plugin/test_chrome_plugin.cc:72: warning: 'int ResponseStream::ready_state_' test/chrome_plugin/test_chrome_plugin.cc:77: warning: when initialized here test/chrome_plugin/test_chrome_plugin.cc:105: warning: unused variable 'status' Review URL: http://codereview.chromium.org/5034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2694 0039d316-1c4b-4281-b951-d872f2087c98
* fix mac/linux builddarin@google.com2008-09-291-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2692 0039d316-1c4b-4281-b951-d872f2087c98
* rollback unintended changedarin@google.com2008-09-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2691 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line switch for fastback work.darin@google.com2008-09-295-2/+11
| | | | | | | | | | | patch by abarth@chromium.org R=darin BUG=2879 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2690 0039d316-1c4b-4281-b951-d872f2087c98
* webkit side of adding a command line switch for fastback.darin@google.com2008-09-292-1/+4
| | | | | | | | | | | patch by abarth@chromium.org R=darin BUG=2879 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2689 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in NavigationController that occured on closing tab ifsky@google.com2008-09-291-10/+12
| | | | | | | | | | | only navigation in tab was an interstitial. BUG=2964 TEST=Drag the following URL into Review URL: http://codereview.chromium.org/4337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2688 0039d316-1c4b-4281-b951-d872f2087c98
* Silence this unit test on Windows 2003 until bug 2732 is fixed.maruel@google.com2008-09-291-0/+4
| | | | | | Review URL: http://codereview.chromium.org/4335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2687 0039d316-1c4b-4281-b951-d872f2087c98
* Display the tmp path to help debug an issue with a build bot.maruel@google.com2008-09-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/4336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2686 0039d316-1c4b-4281-b951-d872f2087c98
* Roll icu38 revision in DEPS for SCons build (removesgk@google.com2008-09-291-1/+1
| | | | | | | unnecessary env.Install() call). Review URL: http://codereview.chromium.org/4330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2685 0039d316-1c4b-4281-b951-d872f2087c98
* Disable alternate error pages on frames and iframes. This istc@google.com2008-09-295-3/+36
| | | | | | | | | a request from the link doctor team. Add a UI test that verifies that no link doctor page is loaded. Review URL: http://codereview.chromium.org/5032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2684 0039d316-1c4b-4281-b951-d872f2087c98
* Disable tests because it is leaking memorycpu@google.com2008-09-291-1/+1
| | | | | | | | | | BUG=2954 TBR=erikkay Review URL: http://codereview.chromium.org/4333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2683 0039d316-1c4b-4281-b951-d872f2087c98
* Re-order constructor order to avoid warning on mac build (that causes error).ericroman@google.com2008-09-291-5/+5
| | | | | | | | TBR=darin@chromium.org Review URL: http://codereview.chromium.org/4332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2681 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing header file to net.xcodeprojdarin@google.com2008-09-291-0/+2
| | | | | | | | TBR=avi Review URL: http://codereview.chromium.org/4331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2680 0039d316-1c4b-4281-b951-d872f2087c98
* Style refactoring to make MockRead initializers more readable.ericroman@google.com2008-09-291-63/+70
| | | | | | Review URL: http://codereview.chromium.org/5026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2679 0039d316-1c4b-4281-b951-d872f2087c98
* Enables sorting of cookie views. Also fixes in bug in deletion thatsky@google.com2008-09-291-23/+43
| | | | | | | | | | | | assumed selection was always contiguous. BUG=2949 TEST=Go to options->Under the hood->Cookies and make sure sorting the columns works. Also make sure deleting deletes the appropriate rows. Review URL: http://codereview.chromium.org/4328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2678 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use cert_lock_ as a reentrant lock. RemoveCert iswtc@google.com2008-09-292-15/+14
| | | | | | | | | | | | renamed RemoveCertInternal to stress the fact that it should be called with the lock held. Fix miscellaneous nits complained by cpplint. R=jcampan Review URL: http://codereview.chromium.org/5024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2677 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustage due to missing headerdarin@google.com2008-09-291-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2675 0039d316-1c4b-4281-b951-d872f2087c98
* Need to alphabetize our source files in the build steps.avi@google.com2008-09-291-6/+6
| | | | | | Review URL: http://codereview.chromium.org/4327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2674 0039d316-1c4b-4281-b951-d872f2087c98
* Define FileInputStream and use it to make UpdateDataStream and ↵darin@google.com2008-09-2915-318/+779
| | | | | | | | | | | | URLRequestFileJob portable. file_input_stream_posix.cc is not implemented in this CL. That is saved for a follow-up. R=mark Review URL: http://codereview.chromium.org/4101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2673 0039d316-1c4b-4281-b951-d872f2087c98
* Update unit test to check EV functionality (Windows-only for now).avi@google.com2008-09-291-7/+184
| | | | | | Review URL: http://codereview.chromium.org/4086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2671 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r 2551 since it seems that webcore has a side effect of generating ↵maruel@google.com2008-09-291-2/+1
| | | | | | | | a .h file. :( Review URL: http://codereview.chromium.org/5201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2670 0039d316-1c4b-4281-b951-d872f2087c98
* ICU changessgk@google.com2008-09-293-9/+34
| | | | | | | | | | | | | * Add an ICU_UTIL_DATA_IMPL #defines to control whether we're expecting the ICU data as ICU_UTIL_DATA_{SHARED,STATIC,FILE}. * Set defaults on the platforms to match our current practice: Windows => shared, Linux => file, Mac => static. * On Mac, link the separate icui18n, icuuc and icudata libs (matching how we're building there), instead of the common icu lib. * Roll the icu38 revision in DEPS to get the updated SCons build. Review URL: http://codereview.chromium.org/5022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2669 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect construction environment name.sgk@google.com2008-09-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/4322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2667 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of "using std::string" in http_response_headers.cc.ericroman@google.com2008-09-291-84/+85
| | | | | | Review URL: http://codereview.chromium.org/4316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2666 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid using of interlocked increment to facilitate porting.jar@google.com2008-09-282-21/+13
| | | | | | | | | | | | The code did not end up needing the use of interlocked operations. All the initialization is called on one thread (the main thread). bug=1311434 r=deanm Review URL: http://codereview.chromium.org/4076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2665 0039d316-1c4b-4281-b951-d872f2087c98
* Add os_unix to sqlite. This is from 3.4.2 to match the rest.deanm@google.com2008-09-282-0/+2936
| | | | | | Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2664 0039d316-1c4b-4281-b951-d872f2087c98
* One more header guard fix to trigger the build.nsylvain@chromium.org2008-09-281-3/+3
| | | | | | Review URL: http://codereview.chromium.org/4320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2663 0039d316-1c4b-4281-b951-d872f2087c98
* One more simple change to trigger the buildbots.nsylvain@chromium.org2008-09-281-3/+3
| | | | | | | This is just fixing the header guard Review URL: http://codereview.chromium.org/4319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2662 0039d316-1c4b-4281-b951-d872f2087c98
* I'm testing the buildbots, I needed a small change to triggernsylvain@chromium.org2008-09-281-3/+3
| | | | | | | them. Review URL: http://codereview.chromium.org/4318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2661 0039d316-1c4b-4281-b951-d872f2087c98
* Add the auth unit-tests to SConscript and .pbxprojericroman@google.com2008-09-275-4/+19
| | | | | | Review URL: http://codereview.chromium.org/4315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2660 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling test I wrote for Find to catch crash described in issue 1341577.finnur@google.com2008-09-271-2/+5
| | | | | | Review URL: http://codereview.chromium.org/5018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2659 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 10:23:53 +0000