summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Convert more members to scoped pointers. Move status bubble into browser ↵pinkerton@chromium.org2009-04-1311-72/+60
| | | | | | | | window controller. Move extra window retain into BWC because it's needed for things in there, not the BrowserWindow impl. Be explicit about the ordering and nature of the ownership in BWC, which should be better since it's now all in one place. Clean up a lot of un-used cruft in tab strip and tab contents now that the toolbaris no longer there, preparing for the BookmarkBar to leave as well. Review URL: http://codereview.chromium.org/66047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13589 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 9762 and 9763.hbono@chromium.org2009-04-133-20/+95
| | | | | | | | | | | | | | | | | | | This is caused by my change r12434 that does not check if there are any other keys pressed when a user presses left-control and left-shift keys (or right-control and right-shift keys). To fix this issue, this change does not only add the above check, but also it adds code that cancels updating the text direction if a user presses another key while he/she is pressing control and shift keys. BUG=9762 "Regression: Shift+Ctrl+Arrow selection combination also changes text direction in RTL UIs" BUG=9763 "Ctrl+Shift text alignment depends of the sides of both the Ctrl and the Shift keys" TEST=In a LTR <textarea> element, pressing a control key, pressing a right-shift key, releasing the right-shift key, and verify its text direction is changed to RTL. TEST=In an RTL <textarea> element, pressing a control key, pressing a left-shift key, releasing the left-shift key, and verify its text direction is changed to LTR. TEST=In a LTR <textarea> element, pressing a right-shift key, pressing a control key, releasing the right-shift key, and verify its text direction is still LTR. TEST=In a LTR <textarea> element, pressing a control key, pressing a right-shift key, releasing the control key, and verify its text direction is changed to RTL. TEST=In an RTL <textarea> element, pressing a left-shift key, pressing a control key, releasing the left-shift key, and verify its text direction is still RTL. TEST=In an RTL <textarea> element, pressing a control key, pressing a left-shift key, releasing the control key, and verify its text direction is changed to LTR. TEST=In a LTR <textarea> element, pressing a control key, pressing a right-shift key, pressing an arrow key, releasing the right-shift key, and verify its text direction is still LTR. Review URL: http://codereview.chromium.org/63117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13588 0039d316-1c4b-4281-b951-d872f2087c98
* Add more failing layout tests to the list after the last webkit merge.nsylvain@chromium.org2009-04-131-0/+3
| | | | | | | | | | | Also add back a line that was deleted in 13529. The comment of 13529 does not talk about this, and the rietveld link shows a diff that does not include this change either. It looks like what got submitted is not what was reviewed. Review URL: http://codereview.chromium.org/72001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13576 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 13558 and 13555 because they broke the pluginnsylvain@chromium.org2009-04-139-2080/+2019
| | | | | | | | | | | tests and the test_shell_tests on linux. PLEASE back yourself out when you see you can't fix a bug instead of leaving it red for days. Review URL: http://codereview.chromium.org/67074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13575 0039d316-1c4b-4281-b951-d872f2087c98
* Make ws2_32.dll delay load againcpu@google.com2009-04-122-2/+2
| | | | | | | | | | | | | | - In r13569 I removed it from delay load in using_libxml.vsprops - Here I put it back in a more logical place BUG=10012 TBR=maruel Review URL: http://codereview.chromium.org/67073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13574 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring; switch the |filter| parameter into something that is more ↵avi@chromium.org2009-04-1223-224/+235
| | | | | | | | | | amenable to cross-platform implementation. BUG=9852 Review URL: http://codereview.chromium.org/63093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13573 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my change to purify filter for test_shell_testscpu@google.com2009-04-121-2/+0
| | | | | | | | | | | | | | - The error just happens in the next function that initializes WinSock - grrrrr BUG=10012 TBR=erikkay Review URL: http://codereview.chromium.org/67072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13572 0039d316-1c4b-4281-b951-d872f2087c98
* Add WS_32.dll to the dependenciescpu@google.com2009-04-121-1/+2
| | | | | | | | | | | | - it was on delayload now needs to go to regular early bind - I want to see the perf hit and fix the build :) TBR=maruel Review URL: http://codereview.chromium.org/71008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13571 0039d316-1c4b-4281-b951-d872f2087c98
* Remvoing ws_32.dll from libxml triggered a improvised explosive devicecpu@google.com2009-04-121-2/+1
| | | | | | | | | | | - Now build is busted. TBR=maruel Review URL: http://codereview.chromium.org/71007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13570 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt to fix purify issue in test_shell_testscpu@google.com2009-04-121-1/+0
| | | | | | | | | | | | | | | - Remove delay load directive from the vsprops - Libxml has no network anyway since my friday change I think purify is not handling delay_loaded winsock the right way. BUG=10012 TBR=erikkay Review URL: http://codereview.chromium.org/67071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13569 0039d316-1c4b-4281-b951-d872f2087c98
* Disable MimeTypeTests in the test_shell_test purify runcpu@google.com2009-04-121-0/+2
| | | | | | | | | | | | - Generates a crazy IPR failure in WinSockInit BUG=10012 TBR=erikkay Review URL: http://codereview.chromium.org/71006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13568 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium to version 1.1.8, which contains akasperl@google.com2009-04-111-1/+1
| | | | | | | | | | | workaround for crash bug http://crbug.com/9746 and fixes an issue with stepping into Function.prototype.apply and call in the debugger. BUG=9746 Review URL: http://codereview.chromium.org/67065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13559 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the Activex shim plugin from the list of default plugins caused ↵ananta@chromium.org2009-04-114-11/+33
| | | | | | | | some activex shim tests to fail. This basically fails for pages which instantiate the media player like an activex only. To handle this case we attempt to map the clsid to a NPAPI mime type if possible in the shim. If we succeed then the shim is instantiated as an NPAPI plugin as before. It internally loads the media player activex. Review URL: http://codereview.chromium.org/66072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13558 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce flakiness of condition var unit test by reducing timing dependence.jar@chromium.org2009-04-111-40/+75
| | | | | | | | | | | | | Re-enable test, with hopes that external changes plus my changes reduce flakyness sufficiently. Also switch to using standard sleep method for better readability. bug=3599 r=mark Review URL: http://codereview.chromium.org/19729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13557 0039d316-1c4b-4281-b951-d872f2087c98
* Enable zooming in on Linux.thestig@chromium.org2009-04-111-1/+9
| | | | | | Review URL: http://codereview.chromium.org/66068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13556 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Activex shim registration for generic Activex controls. The ↵ananta@chromium.org2009-04-115-2008/+2047
| | | | | | | | | | | | | | | | | | | | | | | | Activex shim only handles windows media player in the wild and will continue to do so for the forseeable future. This fixes http://code.google.com/p/chromium/issues/detail?id=8584, which is basically related to our NPAPI plugin installer not getting instantiated on pages which instantiated flash using an object tag, which would result in webkit attempting to instantiate the activex shim. The shim only loads the windows media player classid, thus causing this issue. Added a test shell test which tests whether the default plugin loaded correctly. This is done by attempting to instantiate a special mime type application/chromium-test-default-plugin, which serves as an indicator to the default plugin to call a function in the page indicating that the test succeeded. I also made a change to ensure that the default plugin is loaded in test_shell_tests. Removed the activexshim dll project from chrome.sln Bug=8584 Review URL: http://codereview.chromium.org/63151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13555 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing image results. These were moved into Mac platform-specificpam@chromium.org2009-04-114-0/+2
| | | | | | | | | | | | | directories upstream, so our Windows and Linux runs don't see them anymore. We don't pass these tests, so these are just copies of the Mac results for now. TBR=eroman BUG=none TEST=covered by layout tests Review URL: http://codereview.chromium.org/67062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13554 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium side of merge 42364:42403.pam@chromium.org2009-04-114-6/+12
| | | | | | | | Includes change to v8_proxy.cpp to account for addition of MessagePortProxy class. Review URL: http://codereview.chromium.org/66062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13553 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we can handle favicons that are provided as data: URLsarv@chromium.org2009-04-112-1/+30
| | | | | | | | BUG=9881 Review URL: http://codereview.chromium.org/67042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13551 0039d316-1c4b-4281-b951-d872f2087c98
* This adds link[rel=icon] elements to the DOM UI html files for downloads and arv@chromium.org2009-04-103-3/+8
| | | | | | | | | | | | history. It also adds code to inline the resources for <link rel="icon"> elements BUG=9805 Review URL: http://codereview.chromium.org/66041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13550 0039d316-1c4b-4281-b951-d872f2087c98
* Set the svn:eol-style properties of these new files to LF.wtc@chromium.org2009-04-102-10/+10
| | | | | | | | | | | Normalize the CRLF line endings to LF in signature_verifier.h and signature_verifier_unittest.cc. R=erikkay BUG=6305 Review URL: http://codereview.chromium.org/67060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13548 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the "Proxy-Support: Session-Based-Authentication"wtc@chromium.org2009-04-101-12/+6
| | | | | | | | | | | response headers from the NTLMAuth1 and NTLMAuth2 tests because they were inserted by Fiddler 2 (acting as a proxy) rather than from the server. R=eroman Review URL: http://codereview.chromium.org/67057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13547 0039d316-1c4b-4281-b951-d872f2087c98
* Remove built-in network stack from libxmlcpu@google.com2009-04-103-6/+6
| | | | | | | | | | | | | | | - Removes HTTP and FTP - Fixes a crash and other serious problems (see bug) It does not appear to affect us because afaik we don't use it or when we do we pass the no-network flag. BUG=9937 Review URL: http://codereview.chromium.org/67041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13546 0039d316-1c4b-4281-b951-d872f2087c98
* Make linux link buttons pretty.estade@chromium.org2009-04-103-12/+64
| | | | | | | | | - set text to red while button is active - get rid of border spacing Review URL: http://codereview.chromium.org/66058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13545 0039d316-1c4b-4281-b951-d872f2087c98
* Remove histogram connection to base classes in stats_counterjar@chromium.org2009-04-108-14/+17
| | | | | | | | | | | | | | | | Now that histograms move data from renderer to browser, there is less reason to connect to stats counters. Stats counters were using shared memory, and now they may plausibly use the histogram's IPC mechanism instead to move data to the browser. The first step is remove the inheritance, and teh next (plausible/future) step would be to implement counters as histograms with only one bucket. r=mbelshe Review URL: http://codereview.chromium.org/66029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13544 0039d316-1c4b-4281-b951-d872f2087c98
* Use favicons in the bookmark bar under GTK.erg@google.com2009-04-102-11/+34
| | | | | | Review URL: http://codereview.chromium.org/66056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13543 0039d316-1c4b-4281-b951-d872f2087c98
* Removing --enable-video and instead relying on having DLLs present.scherkus@chromium.org2009-04-107-12/+2
| | | | | | | | | | | | I measured a ~10ms startup regression when the DLLs are not present and a ~20ms regression when the DLLs are present and loaded in render_process.cc. Not sure how else to tackle this problem since we need these DLLs loaded before the sandbox is engaged. Review URL: http://codereview.chromium.org/63101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13542 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing virtual GetModel().shess@chromium.org2009-04-102-0/+7
| | | | | | | | | GetModel() was added by http://codereview.chromium.org/67035 which running my change on the trybots, and I trusted the merge. Review URL: http://codereview.chromium.org/66054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13541 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to register AtExitManager due to TimeTicks::HighResNow() singleton.scherkus@chromium.org2009-04-101-0/+3
| | | | | | | | TBR=cpu Review URL: http://codereview.chromium.org/66053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13540 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage - make sure GTK Autocomplete edit/popup implement the ↵ben@chromium.org2009-04-103-4/+7
| | | | | | | | | GetModel interface method. TBR=deanm Review URL: http://codereview.chromium.org/66052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13539 0039d316-1c4b-4281-b951-d872f2087c98
* Allow a different omnibox popup to be enabled via the command line ↵ben@chromium.org2009-04-1015-16/+202
| | | | | | | | | | | | (--enable-omnibox2). This will allow a views-based omnibox popup conforming to the new spec (stub provided) to be brought up without disturbing ToT UX. Also adds new images from Nicholas. Review URL: http://codereview.chromium.org/67035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13538 0039d316-1c4b-4281-b951-d872f2087c98
* Make OSX TestShell able to run workers, using a new test_worker.dylib which ↵dimich@google.com2009-04-106-17/+73
| | | | | | | | is basically a webkit+v8+helpers to simulate separate process with worker v8 threads. This is similar way we do on Win32. Review URL: http://codereview.chromium.org/66043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13537 0039d316-1c4b-4281-b951-d872f2087c98
* Give the filter setup more context so it can figure out whether it's ↵thestig@chromium.org2009-04-108-9/+90
| | | | | | | | | downloading a file or not. Only refuse to gunzip svgz files on download, so we can send an uncompressed svgz file to webkit. BUG=9737 Review URL: http://codereview.chromium.org/62111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13536 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Finish the current experiment.rvargas@google.com2009-04-103-52/+24
| | | | | | Review URL: http://codereview.chromium.org/67046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13535 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implemention of Mac Omnibox.shess@chromium.org2009-04-1012-42/+967
| | | | | | | | | | | | | | | | AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView. AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs). AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner. It works with the popup view to make sure the popup is positioned correctly. AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model). LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views. It is mostly placeholder code stolen from the gtk implementation. --- I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future. So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc. Review URL: http://codereview.chromium.org/50074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13534 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with work area change notifications so that we now ↵pkasting@chromium.org2009-04-102-46/+115
| | | | | | | | | (hopefully) move/resize correctly whenever the work area changes, no matter why. BUG=8873 Review URL: http://codereview.chromium.org/67023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13533 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PCH-related build breakpkasting@chromium.org2009-04-101-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13532 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with the window_sizer code.pkasting@chromium.org2009-04-103-128/+124
| | | | | | | | | | AdjustBoundsToBeVisibleOnMonitorContaining() is somewhat misnamed (but I can't think of a better name, so I just commented to this effect). It tries to ensure each edge is visible on *some* monitor (although it doesn't actually even do that in pathological cases), and adjusts things to be "on the desired monitor" if not. There were various bugs in this, including checking the wrong coordinates for work areas off the right/bottom sides of the primary work area, and adjusting to the wrong top/left coordinates when the desired monitor's work area was not at (0,0). Additionally, PositionIsOffscreen() actually returned whether the position is _onscreen_, which confused me greatly.In addition, this code used a cache of work area sizes, which is unfortunately wrong since work areas can change as the program is running. Now it re-gets the work areas, which is a little slower, but presumably doesn't actually matter. This also simplified the unittest code some (making it more correct in the process) and added a few tests for cases that my original version of this got wrong but which didn't trigger test failures. Review URL: http://codereview.chromium.org/65013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo (LOAD_ENABLE_FILE) in a comment added in r11661.wtc@chromium.org2009-04-101-1/+2
| | | | | | | R=hclam Review URL: http://codereview.chromium.org/67043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13530 0039d316-1c4b-4281-b951-d872f2087c98
* New baselines for tests modified in merge 42324:42364. These were similarlypam@chromium.org2009-04-109-41/+40
| | | | | | | | | | | | rebaselined upstream. Updates to test_expectations for fixes after that merge. BUG=9924 TEST=covered by layout tests Review URL: http://codereview.chromium.org/67047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13529 0039d316-1c4b-4281-b951-d872f2087c98
* Remove auto commit from TestTabContents. This is the thing preventing me frombrettw@chromium.org2009-04-105-39/+41
| | | | | | | replacing it with WebContents. Fortunately, only one test was affected. Review URL: http://codereview.chromium.org/66003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13527 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: implement link info bars (first cut).estade@chromium.org2009-04-102-16/+61
| | | | | | | | Also make GetIcon a function in InfoBarDelegate since all its inheritors have a function of that name, and putting it in InfoBarDelegate allows us to make InfoBar more generic. Review URL: http://codereview.chromium.org/66025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13526 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out MakeLinkButton into its own class.estade@chromium.org2009-04-105-60/+115
| | | | | | | This also gets rid of the event box, which means we can stick it in widgets that are custom painted. Review URL: http://codereview.chromium.org/66023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13525 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a minor spelling typo.ericroman@google.com2009-04-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/67045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13524 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded ASSERT -- this code path is valid and should not be ASSERTing.dglazkov@google.com2009-04-101-1/+0
| | | | | | | | R=mbelshe Review URL: http://codereview.chromium.org/67040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13523 0039d316-1c4b-4281-b951-d872f2087c98
* Take two converting to scoped pointers, without ui_test failures.pinkerton@chromium.org2009-04-104-28/+32
| | | | | | Review URL: http://codereview.chromium.org/67039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13522 0039d316-1c4b-4281-b951-d872f2087c98
* New baselines for new tests with the 42324:42364 merge.pam@chromium.org2009-04-104-0/+48
| | | | | | | | | | | fixed-positioning-scrollbar-bug: minor differences in metrics function-apply-aliased-expected: different JS error messages BUG=9962 TEST=covered by layout tests Review URL: http://codereview.chromium.org/66042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13521 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure one cannot cut or copy from a passwordjcampan@chromium.org2009-04-104-4/+134
| | | | | | | | | | | text-field. And assorted unit-tests. BUG=9425 TEST=Visit a page with basic auth (ex: http://prism.library.cornell.edu/control/authBasic/authTest/). Type some text in the password field. Select the text and try to cut/copy with CTRL-X, CTRL-V and right click menu. You should not be able to cut/copy the text. Review URL: http://codereview.chromium.org/63053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13520 0039d316-1c4b-4281-b951-d872f2087c98
* Re-baseline XFrameOptions tests.pam@chromium.org2009-04-107-0/+76
| | | | | | | | | | | | It looks to me like we could use to modify our willSendRequest implementation to add in a "main document URL" report for greatest parity with WebKit's results, but in the meantime we can use our current message. BUG=9962 TEST=covered by layout tests Review URL: http://codereview.chromium.org/66040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13519 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in NOTIMPLEMENTEDs in BookmarkBarGtk. Can now reorder bookmarks.erg@google.com2009-04-102-51/+198
| | | | | | Review URL: http://codereview.chromium.org/66022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13518 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 22:44:15 +0000