| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Rather than passing the out param process handle via the options,
take it as a function argument. This simplifies many callers.
BUG=88990
Review URL: http://codereview.chromium.org/7377012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hayato@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7384012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
e.g.
http://build.chromium.org/p/chromium/builders/Linux%20Tests%20%28ChromiumOS%20dbg%29%282%29/builds/2565/steps/unit_tests/logs/stdio
TBR=altimofeev
BUG=89421
TEST=no
Review URL: http://codereview.chromium.org/7390009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
download.
Some servers will send a Content-Length which exceeds the number of bytes sent
in the message body.
Although this violates the RFC spec, other major browsers permit it
and treat a download as complete in that case. Chrome did as well
prior to M12, and now some users are unable to access the item that
they downloaded.
We ran an experiment that caused an error in this case, to gather UMA statistics. This reverts that experiment.
BUG=85549
TEST=Go to server which advertises larger Content-Length than number of bytes
sent, confirm that the download is again reported as interrupted.
Review URL: http://codereview.chromium.org/7353023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So while I'm here clean up the other importer types to make them prettier.
BUG=None
TEST=None
R=mirandac@chromium.org
Review URL: http://codereview.chromium.org/7387005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
all trivial file moves.
BUG=82782
Review URL: http://codereview.chromium.org/7388002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7386007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeURLRequestContext members.
ProfileIOData is now always deleted on the IO thread. Replaces a use of ChromeURLRequestContextGetter with a ChromeURLDataManagerBackend getter callback. Also gets rid of ExtensionInfoMap from ChromeURLRequestContext by directly passing it into the places that need it. Gets rid of the HTML5 storage objects from ChromeURLRequestContext too.
Adds a workaround for TranslateManager's Profile::GetDefaultRequestContext() use, since after this refactoring (by not requiring ChromeURLRequestContextGetter for ChromeURLDataManagerBackend), it prevents having to initialize the ChromeURLRequestContextGetter in most tests since they don't actually use it. This means |default_request_context_| doesn't always get initialized in BrowserMain(), which causes TranslateManager to crash on startup since it requires |default_request_context_| to be initialized. So we forcibly initialize |default_request_context_| until TranslateManager stops depending on this.
BUG=89396
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92668
Review URL: http://codereview.chromium.org/7282054
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/7386008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/7388008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added --reorder option to sharding_supervisor to hold each shard's output until all the output from earlier shards has been printed.
BUG=89159
Review URL: http://codereview.chromium.org/7353031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileIOData is now always deleted on the IO thread. Replaces a use of ChromeURLRequestContextGetter with a ChromeURLDataManagerBackend getter callback. Also gets rid of ExtensionInfoMap from ChromeURLRequestContext by directly passing it into the places that need it. Gets rid of the HTML5 storage objects from ChromeURLRequestContext too.
Adds a workaround for TranslateManager's Profile::GetDefaultRequestContext() use, since after this refactoring (by not requiring ChromeURLRequestContextGetter for ChromeURLDataManagerBackend), it prevents having to initialize the ChromeURLRequestContextGetter in most tests since they don't actually use it. This means |default_request_context_| doesn't always get initialized in BrowserMain(), which causes TranslateManager to crash on startup since it requires |default_request_context_| to be initialized. So we forcibly initialize |default_request_context_| until TranslateManager stops depending on this.
BUG=89396
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92668
Review URL: http://codereview.chromium.org/7282054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=89270
TEST=Verified that synching a new profile didn't hit the DCHECK
Review URL: http://codereview.chromium.org/7362009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17339
TEST=Chrome doesn't crash upon startup when libcros is missing or has the wrong version.
Review URL: http://codereview.chromium.org/7355028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally the mapping from input method ID to keyboard overlay ID was written
in ibus_input_methods.txt.
I moved this to gen_keyboard_overlay_data.py and made the deta be generated in
keyboard_overlay_data.js.
I also modified gen_keyboard_overlay_data.py to generate a list of input method
IDs that shouldn't remap the right alt key in xkeyboard.cc instead of a list of
keyboard overlay IDs.
These changes make the two functions related to keyboard overlay ID in
input_method_util.{h,cc} unnecessary.
I also deleted keyboard overlay data for en_fr_hybrid_CA, ar_fr, id and fil, which was unused.
BUG=chromium-os:17592
TEST=Ran unit_tests and manually tested on the chromebook
Review URL: http://codereview.chromium.org/7370001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
splits it into two modules, tts and tts_engine.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7282048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=scheib@chromium.org
BUG=none
TEST=green
Review URL: http://codereview.chromium.org/7383008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We use context sharing in CompositorGL to avoid compiling the same shaders for different compositors. Previously, we kept the shaders around until the program exited. With this change, we keep the shaders around until there are no more compositors.
BUG=89239
TEST=ui_tests on linux_views pass
Review URL: http://codereview.chromium.org/7367005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A RendererWebRtcAudioDeviceImpl instance implements the abstract interface
webrtc::AudioDeviceModule which makes it possible for a user (e.g. webrtc::
VoiceEngine) to register this class as an external AudioDeviceModule.
The user then call RendererWebRtcAudioDeviceImpl::StartPlayout() and
RendererWebRtcAudioDeviceImpl::StartRecording() from the render process
to initiate and start audio rendering and capturing in the browser process.
IPC is utilized to set up the media streams.
This CL is a restart of a closed CL (http://codereview.chromium.org/7010005/).
What has changed since the previous CL was discussed?
1) WebRTC has been added to Chrome (DEPS) => no longer need for controversal dummy header.
2) This implementation has moved from content/renderer to content/renderer/media
BUG=none
TEST=Tested on Windows using a separate test method which is not added to this CL.
Please contact henrika@chromium.org for more details.
Review URL: http://codereview.chromium.org/7353016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tyoshino
Review URL: http://codereview.chromium.org/7384009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
File "/usr/local/google/chrome-commit/src/tools/valgrind/memcheck_analyze.py", line 501, in Report
self.ErrorHash())
AttributeError: MemcheckAnalyzer instance has no attribute 'ErrorHash'
TBR=timurrrr
Review URL: http://codereview.chromium.org/7387009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ojan
Review URL: http://codereview.chromium.org/7386004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Memcheck:/Heapcheck: suppression lines.
BUG=89305
TEST=Run presubmit check on a suppression without a Memcheck:/Heapcheck: line.
Review URL: http://codereview.chromium.org/7373001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileIOData is now always deleted on the IO thread. Replaces a use of ChromeURLRequestContextGetter with a ChromeURLDataManagerBackend getter callback. Also gets rid of ExtensionInfoMap from ChromeURLRequestContext by directly passing it into the places that need it. Gets rid of the HTML5 storage objects from ChromeURLRequestContext too.
Adds a workaround for TranslateManager's Profile::GetDefaultRequestContext() use, since after this refactoring (by not requiring ChromeURLRequestContextGetter for ChromeURLDataManagerBackend), it prevents having to initialize the ChromeURLRequestContextGetter in most tests since they don't actually use it. This means |default_request_context_| doesn't always get initialized in BrowserMain(), which causes TranslateManager to crash on startup since it requires |default_request_context_| to be initialized. So we forcibly initialize |default_request_context_| until TranslateManager stops depending on this.
BUG=89396
TEST=none
Review URL: http://codereview.chromium.org/7282054
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/7384008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's crashing consistently when it's on Linux Tests (Views dbg)(3) bot while
it's passing consistently when it's on other View dbg bots.
BUG=89392
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added C++ code send property name in OnNetworkDeviceChanged to make sure that we got results of scan instead of some other property change.
BUG=chrome-os-partner:4918,chromium-os:14422
TEST=manual
Review URL: http://codereview.chromium.org/7342041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileIOData is now always deleted on the IO thread. Replaces a use of ChromeURLRequestContextGetter with a ChromeURLDataManagerBackend getter callback. Also gets rid of ExtensionInfoMap from ChromeURLRequestContext by directly passing it into the places that need it. Gets rid of the HTML5 storage objects from ChromeURLRequestContext too.
Adds a workaround for TranslateManager's Profile::GetDefaultRequestContext() use, since after this refactoring (by not requiring ChromeURLRequestContextGetter for ChromeURLDataManagerBackend), it prevents having to initialize the ChromeURLRequestContextGetter in most tests since they don't actually use it. This means |default_request_context_| doesn't always get initialized in BrowserMain(), which causes TranslateManager to crash on startup since it requires |default_request_context_| to be initialized. So we forcibly initialize |default_request_context_| until TranslateManager stops depending on this.
BUG=89396
TEST=none
Review URL: http://codereview.chromium.org/7282054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It's failing consistently when it's on Linux Tests (Views dbg)(3) bot while
it's passing consistently when it's on other View dbg bots.
BUG=89392
TEST=none
Review URL: http://codereview.chromium.org/7389006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it's DefaultProviders communicate through an observer interface.
BUG=63656
TEST=host_content_settings_map_unittest.cc,
content_settings_pref_provider_unittests.cc,
content_settings_policy_provider_unittests.cc
Review URL: http://codereview.chromium.org/7368004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PendingTask::post_births could sometimes be left unitialized
No way for user to know if Tracked::GetBirthPlace will hit tracked_births_ NULL pointer exception.
nit: MissingBirthplace has inconsistent capitalization
BUG=None
TEST=base_unittests
Review URL: http://codereview.chromium.org/7375006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=scheib@chromium.org
BUG=none
TEST=green
Review URL: http://codereview.chromium.org/7387004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87295,chromium-os:16138
TEST=launch downloads page (ctrl-j). Right click should bring up a context menu on the body and non-control links. For control links (Show in Finder, Remove From List, Pause, Resume, etc), right click should not bring up a context menu. Right click + Open in New Tab should work correctly on all platforms for files with unicode characters as well as uri special chars +/\@~!'"()#$&,:;=?%
Review URL: http://codereview.chromium.org/7308002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved the CanSetAsDefaultBrowser / ProtocolClient functions next to the
routines which do the setting of Chrome to be the default browser and
client.
BUG=88196
TEST=Manual testing performed
Review URL: http://codereview.chromium.org/7334003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Build on clang.
Review URL: http://codereview.chromium.org/7383005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used
A tiny cleanup.
BUG=none
TEST=green bots
Review URL: http://codereview.chromium.org/7372001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turning on CoreAnimationLayers in tabviews caused a serious performance
regression. We now use an NSAnimation to animate the close button.
xib change is to turn off layers in tabviews.
Roll GTM 440:446 - Gets us GTMKeyValueAnimation
BUG=89232, 89228
TEST=Test described in 89232. For 89228 verified that close button appears in tab, info bar and download bar.
Review URL: http://codereview.chromium.org/7375014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87283
TEST=Run on a machine with NVIDIA GeForce 7300 GT on Mac 10.5 immediately after booting.
Review URL: http://codereview.chromium.org/7373018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=89274
TEST=base_unittests --gtest_filter=MD5Test.*
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7363013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7358009
nacl_integration test is still failing. Reverting this to re-disable it.
BUG=89177
TBR=polina@google.com
Review URL: http://codereview.chromium.org/7387003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Download and save a file with uri special chars +/\@~!'"()#$&,:;=?%. The fileicon should display correctly.
Review URL: http://codereview.chromium.org/7377009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to JingleChannel class.
Added new CreateChannel() method in Session interface. The new method can be used to create arbitrary channels.
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/7326024
TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/7385002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added new CreateChannel() method in Session interface. The new method can be used to create arbitrary channels.
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/7326024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1 - fix horizontal scroll for pagers in rtl
2 - fix page shower hidden logic (don't flash them during page startup)
3 - fix nav dots so you can click the whole vertical space to select them (use a spacer div instead of margin because margins can't be clicked)
4 - fix font color for nav dots (linux doesn't like transparency and we don't need it anyway)
5 - fix z-order of recently closed menu (show on top of footer)
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7373015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=krisr@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7373016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: This was a TODO for ben.
BUG=None
TEST=views_unittests, views_examples, views_desktop.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7359006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92629 0039d316-1c4b-4281-b951-d872f2087c98
|