summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix timeout when not detacheddkegel@google.com2009-05-061-4/+12
| | | | | | | | Also fix how timeout kills subprocess on Linux and Mac Review URL: http://codereview.chromium.org/115042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15466 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where the favicon got centered vertically in RTL mode instead ofarv@chromium.org2009-05-061-1/+1
| | | | | | | | | | | keeping the value from the previous rule. The default value for background-position-y is center if not specified. http://crbug.com/11549 Review URL: http://codereview.chromium.org/113059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15465 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable ExtensionViewTest.BottomBar in purify due to some ↵erikkay@google.com2009-05-061-1/+2
| | | | | | | | | | | | | | unresolved issues with InProcessBrowserTest. BUG=8362 BUG=9846 TEST=purify bots should go green after this checkin (or try tools/purify/chrome_tests.py -t unit --gtest_filter=ExtensionViewTest.BottomBar) TBR=hclam Review URL: http://codereview.chromium.org/113062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15464 0039d316-1c4b-4281-b951-d872f2087c98
* Clicking on a folder in the bookmark bar now shows its contents as a menu.erg@google.com2009-05-0612-30/+325
| | | | | | | | http://crbug.com/11250 Review URL: http://codereview.chromium.org/114005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15463 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations to account for new tests that fail after the merge.darin@chromium.org2009-05-061-0/+16
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/113060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15462 0039d316-1c4b-4281-b951-d872f2087c98
* Raise the find bar window every time it's shown via Show().estade@chromium.org2009-05-061-0/+2
| | | | | | | | | | (It shouldn't be necessary to raise it when it's shown via SetDialogPosition().) BUG=11515 Review URL: http://codereview.chromium.org/113055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15461 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome-side of WebKit merge 43242:43321darin@chromium.org2009-05-063-5/+4
| | | | | | | | | | | The v8_proxy.h change was authored by asargent and already reviewed here: http://codereview.chromium.org/79059 R=dglazkov Review URL: http://codereview.chromium.org/113056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15460 0039d316-1c4b-4281-b951-d872f2087c98
* There are cases where a Frame may outlive its associated Page. Get thedarin@chromium.org2009-05-066-63/+72
| | | | | | | | | | | | | | | | WebViewImpl by accessing it indirectly through the Frame's Page so that we don't have to worry about cleaning up the WebFrameImpl -> WebViewImpl pointer. WebCore already clears the Frame's Page pointer when the Page is destroyed by the WebViewImpl. Patch by Marshall Greenblatt R=darin Review: http://codereview.chromium.org/99283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15458 0039d316-1c4b-4281-b951-d872f2087c98
* linux: make fontconfig deps explicit.evan@chromium.org2009-05-062-3/+7
| | | | | | Review URL: http://codereview.chromium.org/113052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15457 0039d316-1c4b-4281-b951-d872f2087c98
* Resurrect ExtensionProcessManager. Move the code for starting extensionmpcomplete@google.com2009-05-0614-102/+242
| | | | | | | | | | instances from ExtensionsService to the manager. Unlike ExtensionsService, EPM is not shared between an incognito Profile and its parent. Review URL: http://codereview.chromium.org/109044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15454 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the padding around toolstrips on the extension shelf.erikkay@google.com2009-05-061-9/+13
| | | | | | Review URL: http://codereview.chromium.org/113051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15453 0039d316-1c4b-4281-b951-d872f2087c98
* Messed up dependency key in one case when applying feedback. TBR=thomasvlpinkerton@chromium.org2009-05-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/113049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15452 0039d316-1c4b-4281-b951-d872f2087c98
* Skip the download shelf altogether for extension downloads. The current UI ↵erikkay@google.com2009-05-062-17/+35
| | | | | | | | | looks pretty weird with it. This won't work great for larger extensions that take more than a couple of seconds to download, but we'll address that with extension specific UI when the DL manager is refactored. TEST=download a crx file, verify that it installs with no shelf. download another type of file, verify that it uses the shelf properly. Review URL: http://codereview.chromium.org/113038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15450 0039d316-1c4b-4281-b951-d872f2087c98
* More test expectation updates for Linux.darin@chromium.org2009-05-061-213/+4
| | | | | | | | TBR=agl Review URL: http://codereview.chromium.org/113048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15449 0039d316-1c4b-4281-b951-d872f2087c98
* The last redesign of interstitial pages made them to be a render view ↵jcampan@chromium.org2009-05-064-2/+229
| | | | | | | | | | | | | painted on top of the normal page. Because they were not know from the tab contents container, the actual hidden page behind them would still get focus. That was particularly noticeable when tabbing. BUG=11505 TEST=Open a page that triggers an interstitial (ex: https://ebay.com). Press tab to cycle the focus. Make sure the focus is moved as expected. Review URL: http://codereview.chromium.org/113039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15446 0039d316-1c4b-4281-b951-d872f2087c98
* Implement most of the "basics" pref panel on Mac, including code to set the ↵pinkerton@chromium.org2009-05-0615-102/+1083
| | | | | | | | default browser. Fix up some related comments around the code. Review URL: http://codereview.chromium.org/113032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15445 0039d316-1c4b-4281-b951-d872f2087c98
* More tweaks to test expectations. I was a bit too hasty in removingdarin@chromium.org2009-05-061-1/+3
| | | | | | | | | | some of these expected failures. TBR=dglazkov Review URL: http://codereview.chromium.org/113045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15443 0039d316-1c4b-4281-b951-d872f2087c98
* Get visual theme support for rendererscpu@google.com2009-05-061-0/+22
| | | | | | | | | | | | | | | | - Removing COm initialization broke it - COM creates a hidden window so that was the trick TEST= using windows XP with luna theme enabled, go to a page that has a form with buttons, for example gmail.com. Observe the buttonsb being rounded flat, like the theme and not square and 3d. BUG=http://code.google.com/p/chromium/issues/detail?id=11292 Review URL: http://codereview.chromium.org/113042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15441 0039d316-1c4b-4281-b951-d872f2087c98
* gtest shouldn't link in gtest_main.cc, as that provides its own main().evan@chromium.org2009-05-064-1/+26
| | | | | | | | | | | | Split gtest into two libraries, where the latter provides main(). This is consistent with the way gtest works within Google and with its automake files. Fix binaries that require gtest's main() to depend on gtest.gyp:main. Review URL: http://codereview.chromium.org/99132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15440 0039d316-1c4b-4281-b951-d872f2087c98
* Re-re-enable the pref service ui test, this time making it expect a window ↵robertshield@google.com2009-05-062-3/+3
| | | | | | | | size that should fit on even the smallest of likely desktop resolutions. Review URL: http://codereview.chromium.org/115037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15439 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations now that some tests have been rebaselined.darin@chromium.org2009-05-061-200/+191
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/115039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15438 0039d316-1c4b-4281-b951-d872f2087c98
* Change webplugin_delegate_impl_mac from C++ to Objective-C++amanda@chromium.org2009-05-062-1/+1
| | | | | | | to accomodate upcoming implementation changes. Review URL: http://codereview.chromium.org/113041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15437 0039d316-1c4b-4281-b951-d872f2087c98
* Render a "sad tab" on tab crash.willchan@chromium.org2009-05-068-27/+277
| | | | | | | | | | Uses the NotificationRegistrar to notice TAB_CONTENTS_[DIS]CONNECTED events. When it disconnects, add a SadTabGtk to the TabContentsView. Delete it when the tab contents reconnects. BUG=http://www.crbug.com/11081 TEST=Open http://about:crash. Verify that the sad tab renders properly. Navigate to another page to make sure the SadTabGtk is correctly replaced with a new RenderWidgetHostViewGtk. Review URL: http://codereview.chromium.org/111003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15435 0039d316-1c4b-4281-b951-d872f2087c98
* Destroy browser/content related C++ object on WM_DESTROY message, rather ↵stoyan@chromium.org2009-05-062-2/+7
| | | | | | | | than OnFinalMessage Review URL: http://codereview.chromium.org/115034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15434 0039d316-1c4b-4281-b951-d872f2087c98
* Re-disable the PrefService PreservedWindowPlacementIsLoaded UI test until I ↵robertshield@google.com2009-05-061-1/+1
| | | | | | | | | | figure out why the official builder doesn't like it. TBR=hclam Review URL: http://codereview.chromium.org/113040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15433 0039d316-1c4b-4281-b951-d872f2087c98
* Have the grit rules depend on the .pak files.tc@google.com2009-05-062-2/+2
| | | | | | | | | | | chrome_resources and chrome_strings was continually rebuilding because it depended on the .h file, but the .h file doesn't get written if there are no changes. The .pak file always gets written. Review URL: http://codereview.chromium.org/115035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15432 0039d316-1c4b-4281-b951-d872f2087c98
* mac valgrind bot: Make running dsymutil an option for now, since it slows ↵dkegel@google.com2009-05-062-11/+22
| | | | | | | | down the run a lot, and causes timeouts. Reenable by default once we have multiple mac bots. Review URL: http://codereview.chromium.org/114003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15431 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remember user's last selected path for select file dialogs.estade@chromium.org2009-05-061-7/+50
| | | | | | | | | | | | | Note that paths are remembered separately for save and open. This is *not* the same behavior as windows chrome/linux firefox, which remember the same path for both save and open. My justification is the following scenario: 1. User presses ctrl-o, and selects a file from the desktop. 2. One hour later, user presses ctrl-s to save a webpage. 3. User expects to be saving to his default download dir, but instead gets the desktop. 4. Huh? Review URL: http://codereview.chromium.org/115007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15430 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable pref service's PreservedWindowPlacementIsLoaded ui test. robertshield@google.com2009-05-061-11/+11
| | | | | | | | Alter the test to use EXPECT_ instead of ASSERT_ when checking the window placement to not abort the test on data mismatch. Review URL: http://codereview.chromium.org/115027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15429 0039d316-1c4b-4281-b951-d872f2087c98
* Re-baseline and create baselines for tests added in ↵darin@chromium.org2009-05-06199-287/+325
| | | | | | | | | | | http://trac.webkit.org/changeset/43215 BUG=11483 R=dglazkov Review URL: http://codereview.chromium.org/112003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15428 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a DCHECK regression introduced by http://codereview.chromium.org/112001erikkay@google.com2009-05-061-2/+0
| | | | | | | | | | | | Code was removing itself as an observer for something it was no longer observing. TEST=interactive_ui_tests.exe --gtest_filter=BookmarkBarViewTest1.Basic TBR=sky Review URL: http://codereview.chromium.org/113037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15427 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 4376 -- Press "Tab" key to navigate - Text focus is ↵xji@chromium.org2009-05-061-2/+2
| | | | | | | | | | | | | showing at wrong place in Hebrew and Arabic. (http://crbug.com/4376) When draw focus rectangle, x-axis need to be mirrored in RTL locale. BUG = http://crbug.com/4376 Review URL: http://codereview.chromium.org/109055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15425 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor view from methods to show hung renderer dialog.tc@google.com2009-05-069-95/+92
| | | | | | | | | | This moves the methods into a header that all platforms can use and keeps the windows implementation in hung_renderer_view.cc. Review URL: http://codereview.chromium.org/109039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15424 0039d316-1c4b-4281-b951-d872f2087c98
* Add an extra colon to make inspector work again.dglazkov@chromium.org2009-05-062-2/+2
| | | | | | | | | | | | | This was broken by http://codereview.chromium.org/101026. R=glen BUG=11532 TESt=open inspector. Inspector shouldn't show a blank page. Review URL: http://codereview.chromium.org/113034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15423 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the "pick a new user data dir" dialog on windows.tc@google.com2009-05-063-6/+8
| | | | | | | | | | | | | | | | There were three things to be fixed: 1) We don't need to run a separate message loop after the dialog closes. The MessageLoopForUI handles this properly. 2) When tearing down browser_process_impl, io_loop hasn't been initialized yet, so we check to make sure it exists before using it. 3) We don't call window->Close() because that deletes the dialog class before we're done using it. This means we leak the window, but that's ok because we're going to exit anyway. Review URL: http://codereview.chromium.org/114004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15422 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused chrome switches.tc@google.com2009-05-062-9/+0
| | | | | | | | | I also looked at the test_shell switches, but they are all used. Review URL: http://codereview.chromium.org/108036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15421 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 178.0 to 179.0laforge@chromium.org2009-05-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15420 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeCanvas code to respect text alignment in Linux by using pango.willchan@chromium.org2009-05-061-0/+6
| | | | | | Review URL: http://codereview.chromium.org/111004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15418 0039d316-1c4b-4281-b951-d872f2087c98
* Create a separate UI surface for extensions (bottom shelf) and remove them ↵erikkay@google.com2009-05-0612-193/+341
| | | | | | | | | | | | | | from the bookmarks bar (for now). The current implementation doesn't do anything new except for always appear when extensions are loaded. TEST=install an extension and see it show up in the new bottom bar TEST=unit_tests.exe --gtest_filter=ExtensionViewTest.BottomBar Review URL: http://codereview.chromium.org/112001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15417 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a test for a testing that the bug http://crbug.com/9791 is really fixed.jcampan@chromium.org2009-05-064-190/+96
| | | | | | | | | | | | Removing the interstitial UI tests: they test the same functionalities as the unit-tests but are flacky and most of them have been disabled (a new unit-test for the "show interstitial and then navigate back" has been added to cover for a case that the unit-tests were not covering). TEST=Run the unit-tests. BUG=6729,3327 Review URL: http://codereview.chromium.org/109038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15416 0039d316-1c4b-4281-b951-d872f2087c98
* PageActions now work across tabs and windows.finnur@chromium.org2009-05-0612-97/+111
| | | | | | | | | | | The extension system now provides TabId to extensions so it is now possible to activate PageActions in other tabs besides the first in the tab strip. :) BUG=None TEST=None (requires a PageAction extension to test against). Review URL: http://codereview.chromium.org/109046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15415 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where we were inadvertently closing Valgrind-owned FDsrohitrao@chromium.org2009-05-061-23/+30
| | | | | | | | | | | when running under Valgrind. TEST=None http://crbug.com/11412 Review URL: http://codereview.chromium.org/108042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15414 0039d316-1c4b-4281-b951-d872f2087c98
* Re-re-write the logic to elevate uninstaller.kuchhal@chromium.org2009-05-065-118/+140
| | | | | | | | | | | | | | BUG=7178 TEST=Test install/uninstall in various combinations as described below and make sure that files or registry keys are not left behind: Distribution: {Chromium|Google Chrome} Install Level: {system|user} Delete Profile Option: {Selected|Not selected} Default Browser: {set|not set} Review URL: http://codereview.chromium.org/109037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15412 0039d316-1c4b-4281-b951-d872f2087c98
* Changes for upstreaming V8DocumentLocationCustom.cpp.levin@chromium.org2009-05-064-23/+63
| | | | | | | | | BUG=http://bugs.chromium.org/11467 TEST=Verify that Document.location works from javascript. Review URL: http://codereview.chromium.org/108024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15411 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 11479 - RTL Regression: Ellipsis showing at the right ↵xji@chromium.org2009-05-061-1/+1
| | | | | | | | | | | | | | | side of the button on "Google Chrome Options" dialog. (http://crbug.com/11479) This is another regression caused by code refactoring. Instead of assign data member "label_" directly as the input parameter in constructor, calling SetLabel() which takes care of label layout in RTL locale. BUG=http://crbug.com/11479) Review URL: http://codereview.chromium.org/113010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15410 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15399.maruel@chromium.org2009-05-068-12/+27
| | | | | | | broke purify Review URL: http://codereview.chromium.org/115026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15409 0039d316-1c4b-4281-b951-d872f2087c98
* A file list for official builds (what gets picked up for saving)thomasvl@chromium.org2009-05-061-0/+1
| | | | | | Review URL: http://codereview.chromium.org/110006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15408 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Update test expectataions.pfeldman@chromium.org2009-05-061-17/+19
| | | | | | | | BUG=11477 Review URL: http://codereview.chromium.org/113031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15406 0039d316-1c4b-4281-b951-d872f2087c98
* Redraw the location bar on reload. This change is Gtk+ port of 100198.deanm@chromium.org2009-05-061-1/+1
| | | | | | | | | | | http://codereview.chromium.org/100198 Patch by Yusuke Sato. Review URL: http://codereview.chromium.org/106007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15405 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable gconf usage from ProxyConfigServiceLinux because of Glib ↵deanm@chromium.org2009-05-063-0/+8
| | | | | | | | | | | | | races. Patch by Stephane Doyon. BUG=11442 Review URL: http://codereview.chromium.org/109040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15404 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-13 02:15:13 +0000