| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert due to compile breakage on ChromeOS.
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Review URL: http://codereview.chromium.org/8921006
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/8990002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ChromeProxyConfigService was initialized to CONFIG_UNSET (i.e. effectively
a fallback to the system configuration) until the UI thread reported the
preference stored in the PrefService. This created a race condition during
startup where restored tabs could send requests while the
ChromeProxyConfigService was not configured with the values from the
PrefService, yet.
BUG=107326
TEST=no
Review URL: http://codereview.chromium.org/8951012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
delay from one of the enums.
Autofill is assigned the value PIGGYBACK_WITH_ANOTHER_CHANGE.
Our sceheduler did not handle the case of 2 nudges being schedule with the first one being scheduled for a later time than the second one. Fixed that and added unit tests to it.
BUG=106250
TEST=sync_unit_tests.exe, unit_tests.exe, integration_tests.exe
Review URL: http://codereview.chromium.org/8787006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, added a bunch of auto generated unit tests.
TEST=unit test
BUG=107914
Review URL: http://codereview.chromium.org/8981005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107985
TEST=no
TBR=creis@chromium.org
Review URL: http://codereview.chromium.org/8986003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RendererAccessibilityBrowserTest.CrossPlatformMultipleInheritanceAccessibility2 as failling
BUG=107985
TEST=no
TBR=morrita@chromium.org
Review URL: http://codereview.chromium.org/8989002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=thakis
Review URL: http://codereview.chromium.org/8989001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Review URL: http://codereview.chromium.org/8921006
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/8984007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the 2 attempt, as the first patch was reverted by rsleevi at crrev.com/111323
BUG=100898
R=pkasting@chromium.org
TBR=ben@chromium.org,mirandac@chromium.org
Review URL: http://codereview.chromium.org/8983004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
test page
can eval(). Change InputEvent and PostMessage tests to use this.
Add proxy for PPB_Testing_Dev::SimulateInputEvent function.
BUG=NONE
TEST=ui_tests
Review URL: http://codereview.chromium.org/8920005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
testing purposes.
patch from issue 8574007
BUG=chromium-os:23316
TEST=out/Debug/test_shell_tests --gtest_filter='MemoryFileUtilTest.*'
Review URL: http://codereview.chromium.org/8907014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In additin to r114338, I should have changed the argument of
WebViewPlugin::getFormValue().
TEST=compiled.
BUG=88896
Review URL: http://codereview.chromium.org/8947014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes std::string error to string16 in various locations of the Extensions file, spanning up the tree from ExtensionErrorReporter and Extension::InitFromValue, with conversion to string16 beginning at extension_l10n_util::LocalizeExtension and Extension::Create. Later patches can continue/expand the conversion.
BUG=71980
TEST=Run existing unit tests and browser tests, which have been adjusted for string16s.
Review URL: http://codereview.chromium.org/8890086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The function does not take into account the modifier.
BUG=107837
TEST=see the bug
Review URL: http://codereview.chromium.org/8964011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:19411
TEST=Confrigure a network through policy. Check whether recommended settings show up properly in the UI.
Review URL: http://codereview.chromium.org/8918025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=src/third_party/WebKit/Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp
Review URL: http://codereview.chromium.org/8907053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove RWHVA from compositor observers on destruction
BUG=107821
TEST=see bug for repro steps
Review URL: http://codereview.chromium.org/8961008
TBR=piman@chromium.org
Review URL: http://codereview.chromium.org/8982005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107821
TEST=see bug for repro steps
Review URL: http://codereview.chromium.org/8961008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also uncomment the tests for cycle forward/backward.
BUG=107417
TEST=Manual test and aura_shell_unittests
Review URL: http://codereview.chromium.org/8934020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=106051
TEST=ExtensionPopup bubbles show without flicker or graphical artifacts (chromeos[_aura] and win[_aura]).
Review URL: http://codereview.chromium.org/8967006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104189
TEST=none
Review URL: http://codereview.chromium.org/8981003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GCF was crashing if the automation server dies while there are outstanding sub-resource requests being serviced on the new bg thread. The reason was that AutomationServerDied posts a task to InitializeComplete(AUTOMATION_SERVER_CRASHED) and then a task to Uninitialize(). The former will call ReleaseAutomationServer() without first joining on the bg resource thread. The fix is to wait and release the server in Uninitialize.
BUG=107811
TEST=Prior to fix, the following would usually trigger the crash: chrome_frame_tests.exe --gtest_repeat=20 --gtest_filter=CF/FullTabUITest.TabCrashReload/0
Review URL: http://codereview.chromium.org/8965031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79050
Review URL: http://codereview.chromium.org/8981007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
confirmation dialogs.
This CL carves a TabModalConfirmDialogDelegate class (modeled after ConfirmInfobarDelegate) out of RepostFormWarningController and makes it a subclass thereof.
It also removes the ShowRepostFormWarning method from BrowserWindow and its subclasses, in favor of a method in browser_dialogs.h.
BUG=92795
TEST=none
Review URL: http://codereview.chromium.org/8658005
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/8962012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105508
TEST=none
Review URL: http://codereview.chromium.org/8983005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=107808
Review URL: http://codereview.chromium.org/8962002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99527
TEST=with a desktop build of linux chrome, run with --use-gl=osmesa --enable-partial-swap, go to http://learningwebgl.com/lessons/lesson3/index.html, occlude the animation, notice that only the webgl frame get's redrawn (separate bug)
Review URL: http://codereview.chromium.org/8974003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17585
TEST=None
Review URL: http://codereview.chromium.org/8969014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL carves a TabModalConfirmDialogDelegate class (modeled after ConfirmInfobarDelegate) out of RepostFormWarningController and makes it a subclass thereof.
It also removes the ShowRepostFormWarning method from BrowserWindow and its subclasses, in favor of a method in browser_dialogs.h.
BUG=92795
TEST=none
Review URL: http://codereview.chromium.org/8658005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It helps renaming text box survive scrollings. Also it makes scrolling slightly smoothlier (on my example list.redraw executed ~190ms instead usual 270ms when mouse wheel rotetes on one unit).
Potentially "pinned item" may help the text box to survive (keep focus, selection and so on) even "directory change" event.
BUG=chromium-os:24054
TEST=None
Review URL: http://codereview.chromium.org/8892016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::Bind: Remove even moar OldCompletionCallback.
BUG=none
TEST=none
R=dpapad
Review URL: http://codereview.chromium.org/8947024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107869
TEST=manually tested on wrench menu and folder.
Review URL: http://codereview.chromium.org/8984001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
first steps towards an uber-looking extensions page. The code changed a lot because of a major functional change:
- no zippies -- show all controls all the time, except developer controls, which are shown in dev mode.
The old code also had some unfortunate patterns in it, so fixing that accounts for a lot of the changes as well.
TODO: re-add implementation for developer mode
TODO: aesthetics
the mocks call for open sans and for now I've set the font to open sans. However that font is not on my system so it falls back to default sans serif. We may later decide to package open sans.
BUG=107323
TEST=manual
Review URL: http://codereview.chromium.org/8970018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) re-instate r113657 from crbug/106711:
win_release_OmitFramePointers=0 must explicitly pass /Oy-
since /O2 implies /Oy
2) add win_debug_OmitFramePointers as tri-state where blank
value (the default) avoids perturbing VS defaults
3) add win_release_extra_cflags and win_debug_extra_cflags
to make it easier to add custom local flags for
tool builds
BUG=106711
TEST=Tweaked these vars via GYP_DEFINES and include.gypi and confirmed the changes in build/All.vcproj
For example:
I have "'win_release_InlineFunctionExpansion': 0" in my include.gypi:
% GYP_DEFINES='win_debug_extra_cflags="/QIfist /nologo"' gclient runhooks
% grep -E -o 'Name="[^"|]*\|[^"]*"|Omit[^ ]*|include" AdditionalOptions="[^"]*"' build/All.vcproj
Name="Release|Win32"
include" AdditionalOptions="/MP /Ob0"
OmitFramePointers="true"
Name="Debug|Win32"
include" AdditionalOptions="/MP /QIfist /nologo"
Name="Release|x64"
include" AdditionalOptions="/MP /Ob0"
OmitFramePointers="true"
Name="Debug|x64"
include" AdditionalOptions="/MP /QIfist /nologo"
% GYP_DEFINES='win_release_extra_cflags="/QIfist /nologo" win_release_OmitFramePointers=0 win_debug_OmitFramePointers=1' gclient runhooks
% grep -E -o 'Name="[^"|]*\|[^"]*"|Omit[^ ]*|include" AdditionalOptions="[^"]*"' build/All.vcproj
Name="Release|Win32"
include" AdditionalOptions="/MP /QIfist /nologo /Ob0 /Oy-"
OmitFramePointers="false"
Name="Debug|Win32"
include" AdditionalOptions="/MP"
OmitFramePointers="true"
Name="Release|x64"
include" AdditionalOptions="/MP /QIfist /nologo /Ob0 /Oy-"
OmitFramePointers="false"
Name="Debug|x64"
include" AdditionalOptions="/MP"
OmitFramePointers="true"
Review URL: http://codereview.chromium.org/8966025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107886
TEST=Manual
Review URL: http://codereview.chromium.org/8985005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107410
TEST=new tests added
Review URL: http://codereview.chromium.org/8965014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8821030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ppapi/tests compiled with gyp.
The two tests were written at around the same time and using the same test cases,
so the only piece missing was the binding and paintig of the graphics device.
BUG=none
TEST=ui_tests
Review URL: http://codereview.chromium.org/8954008
TBR=polina@google.com
Review URL: http://codereview.chromium.org/8976016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
morrita suggested this rev and try job failures look like flake.
TBR=morrita@chromium.org
Review URL: http://codereview.chromium.org/8980001
TBR=enne@chromium.org
Review URL: http://codereview.chromium.org/8976015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The indicies were wrong since it did not account for the excluded files.
R=dennisjeffrey@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8980003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Register with the component updater service if it's discovered that WebGL is blacklisted. Then register the swiftshader library with the GPU data manager.
BUG=26001
TEST=Start up chrome on a blacklisted windows machine, wait a while, and open a webgl page
Review URL: http://codereview.chromium.org/8897008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This passed on chromeos aura.
BUG=106248
TEST=StartupURLsOnNewWindowWithNoTabbedBrowser passes on chromeos aura
Review URL: http://codereview.chromium.org/8964023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/8604009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
launcher.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8964018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
compiled with gyp.
The two tests were written at around the same time and using the same test cases,
so the only piece missing was the binding and paintig of the graphics device.
BUG=none
TEST=ui_tests
Review URL: http://codereview.chromium.org/8954008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead use SigninManager to store this information.
TBR=mirandac@chromium.org
BUG=88109,93922, 107160
TEST=most scenarios with CrOS UI displaying the username, including signin dialogs
Review URL: http://codereview.chromium.org/8910003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114880 0039d316-1c4b-4281-b951-d872f2087c98
|