| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2826041
I then did quite a bit of manual editing to fix style issues.
BUG=28083
TEST=None
Review URL: http://codereview.chromium.org/4291001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=All tests should pass. Autocomplete/autofill should still work.
Review URL: http://codereview.chromium.org/4231001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like the pattern match doesn't work for some reason: http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20(valgrind)/builds/259/steps/memory%20test:%20unit/logs/stdio
BUG=61424
TEST=None
TBR=rsesek
Review URL: http://codereview.chromium.org/4276003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Another speculative fix for the crash in the bug.
BUG=58042
TEST=sync integration tests
Review URL: http://codereview.chromium.org/4275001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
above 127.
BUG=None
TEST=base_unittests --gtest_filter=*StringToInt*
Review URL: http://codereview.chromium.org/4129012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61581,chromium-os:7037
TEST=ExtensionsServiceTest.UpdatePendingExternalCrxWinsOverSync
Review URL: http://codereview.chromium.org/4147007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39963
TEST=None
TBR=rafaelw
Review URL: http://codereview.chromium.org/4241003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which is generally caused by a firewall.
Also removes the title strings for proxy and disconnected
errors, replacing them with pre-existing generic ones, and
sorting them by their new title. This avoids a debug
assertion caused by the fact neither title includes the url
of the original page. Not much of titles are seen anyways,
so not worth the effort of a workaround.
BUG=57108
TEST=manual
Review URL: http://codereview.chromium.org/4182012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AccountScreenTest.TestBasic for official build.
BUG=chromium-os:8517
TEST=Accelerators/TestBasic in desktopui_BrowserTest will not fail
Review URL: http://codereview.chromium.org/4271001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60318
TEST=See bug (enable html5 video on youtube, watch a video, click omnibox, click youtube search box. It should focus. Same on grooveshark: the search box should focus when clicked after clicking the omnibox)
Review URL: http://codereview.chromium.org/4287002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I adjusted the code so tha there was no chance
for the pending response count to get to zero
until all the increments had been applied, and
all the rendereres had been notified. Without
this change, there was a chance that the tally
would hit zero prematurely, triggering a
a premature completion.
I went through the code clarifying where
a lock was needed, and where it wasn't.
In all cases, we now either take a lock, or
assert we're consistently on a single
thread (meaning we don't need a lock).
r=davemoore
Review URL: http://codereview.chromium.org/4193008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
relying on a flaky test server:
LoginPromptTest.CancelRedundantAuths
LoginPromptTest.SupplyRedundantAuths
LoginPromptTest.TestBasicAuth
LoginPromptTest.TestCancelAuth
LoginPromptTest.TestDigestAuth
LoginPromptTest.TestTwoAuths
BUG=60937
TEST=None
Review URL: http://codereview.chromium.org/4322001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
related to the test server bugging out occasionally.
BUG=60937
TEST=NONE.
Review URL: http://codereview.chromium.org/4251003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
off and on on Vista:
[ FAILED ] SessionHistoryTest.BasicBackForward
[ FAILED ] SessionHistoryTest.FrameBackForward
[ FAILED ] SessionHistoryTest.FrameFormBackForward
[ FAILED ] SessionHistoryTest.FragmentBackForward
[ FAILED ] SessionHistoryTest.LocationChangeInSubframe
BUG=61619
TEST=None
Review URL: http://codereview.chromium.org/4298002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extension::StaticData and put"
Original CL:
Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put
its guts into Extension.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/4200005
Review URL: http://codereview.chromium.org/4277002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to the trybot.
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Moved constants to anonymous namespace.
BUG=chromium-os:5763
TEST=none. no functional/visual change.
Review URL: http://codereview.chromium.org/4252002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current implementation of EventSendingController does not set a time
stamp on touch events. This change adds time stamps to touch events
equivalent to how they are handled for mouse events including supporting
use of leapForward.
Matching WebKit implementation:
https://bugs.webkit.org/show_bug.cgi?id=48777
BUG=none
TEST=manually via future layout tests.
Review URL: http://codereview.chromium.org/4191008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
which may be why these unit tests started to time out.
R=nirnimesh
BUG=61528
TEST=none
Review URL: http://codereview.chromium.org/4278001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=61601
TEST=None
TBR=rsesek
Review URL: http://codereview.chromium.org/4262002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Parse state before zip, as they may share one label.
* Try to parse the current TD for text when parsing table labels.
BUG=61442
TEST=FormManagerTest.LabelsInferredFromTablTDInterveningElements,
AddressFieldTest.ParseStateAndZipOneLabel
Review URL: http://codereview.chromium.org/4249002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_dll. This is to avoid having non-versioned matched components in the build directory if only buildingg npchrome_frame which causes all manner of trouble.
BUG=version-mismatched binaries can reside in the build folder when building only npchrome_frame
TEST=NONE
Review URL: http://codereview.chromium.org/4288001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61488
TEST=d:\mediatests\still.webp
Review URL: http://codereview.chromium.org/4232003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
from r64716. This is identical with an an include directory changed in the ppapi repo which I'm hoping was what was confusing everything.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was passing memory from libcros to chrome and expecting chrome to
free it. I was also passing vectors across the DLL boundary. These
could both cause memory horkage.
Having implemented safe alternatives in http://codereview.chromium.org/4132006, migrate to them. Depends on cros_deps roll in http://codereview.chromium.org/4207004/show
BUG=chromium-os:8283
TEST=install on the device, log in as the first account, whitelist users, disable BWSI
Review URL: http://codereview.chromium.org/4240001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=61592
TEST=
Review URL: http://codereview.chromium.org/4316001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61593
TEST=NONE
Review URL: http://codereview.chromium.org/4315001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is a re-land from r64716.
This is identical with an an include directory changed in the ppapi repo which
I'm hoping was what was confusing everything.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61589
TEST=SharedMemoryProcessTest.Tasks
Review URL: http://codereview.chromium.org/4228003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix filtering of single (non-groupped) policies by platforms.
BUG=56531
TEST=JsonWriterUnittest.*,PolicyTemplateGeneratorUnittest.testPolicyFiltering
Review URL: http://codereview.chromium.org/4164006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61585
TBR=glider
Review URL: http://codereview.chromium.org/4244004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59379
TEST=none
Review URL: http://codereview.chromium.org/4223001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc.
Review URL: http://codereview.chromium.org/3834002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
operations return an access is denied error.
This is in preparation for adding new error text suggesting
a firewall may be causing the problem, which would be a little
embarrassing to do when an SSPI logon fails, or when trying to
open a local file one doesn't have permissions to.
BUG=57108
TEST=Install firewall, block Chrome, verify that you get
ERR_NETWORK_ACCESS_DENIED. Unblock it, fail an SSPI logon
(Or any other event that should generate an ERR_ACCESS_DENIED)
and verify that you still get an ERR_ACCESS_DENIED.
Review URL: http://codereview.chromium.org/3976004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None.
TEST=Verify that debug build doesn't crash after login.
Review URL: http://codereview.chromium.org/4300002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=46601
TEST=None
Review URL: http://codereview.chromium.org/4238003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61579
TBR=glider
Review URL: http://codereview.chromium.org/4312001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
password.html & accessaccount.html pages has changed their content visa versa.
BUG=chromium-os:8533
TEST=manual. Help content matches offline/online sign in error case.
Review URL: http://codereview.chromium.org/4306001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8463
TEST=manual
Review URL: http://codereview.chromium.org/4111016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4273001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48086
TEST=Go to a site with a content setting icon in the Omnibox. Click icon to open bubble. Hit Cmd+T; bubble closes.
Review URL: http://codereview.chromium.org/4241001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=it compiles, 'ceee' root folder is seen in Visual Studio projects tree
BUG=none
Review URL: http://codereview.chromium.org/4287001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58235
TEST=none
Review URL: http://codereview.chromium.org/4119005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4190015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=bauerb
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59806
TEST=see bug for manual test
Review URL: http://codereview.chromium.org/3987003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds dependency to OpenSSL libraries.
BUG=None
TEST=Links with use_openssl=1
Review URL: http://codereview.chromium.org/4096013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64729 0039d316-1c4b-4281-b951-d872f2087c98
|