| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugin would draw over the iframe DOM
element, effectively hiding it. This is handled by our IFrame shim geometry calculation, where we subtract the
rect of any IFrame above the plugin in the ZOrder from the plugin rect.
Webkit calls Widget::setFrameRect at various times, during layout/size changes/paints, etc. The reason this bug
showed up, was due to an optimization in our setFrameRect implementation, where we would bail out if the rect
passed in was the same size as the current plugin rect. Basically the IFrame appears above the plugin in the ZOrder
much later, which causes us to return without sending over the cutout rects to the browser when it moves the plugin
windows.
Fix is to move the rects equality check to WebPluginImpl::setFrameRect, where we don't send over the UpdateGeometry IPC to the plugin process if the rects are the same.
WebPluginImpl used to implement the webkit Widget interface a long time ago. This is no longer the case. So some
of the functions don't need to be virtual anymore. I also made this change.
This fixes bug http://b/issue?id=1722236 and http://code.google.com/p/chromium/issues/detail?id=8858
Bug=1722236,8858
Review URL: http://codereview.chromium.org/42413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change our algorithm for computing the state of our SSL security indicators. Previously, we were computing this state for a single navigation entry. Although this matches other browsers, it fails to take the same-origin policy into account. For example, if one tab is contaminated with insecure content, that insecure content can spread to all the tabs in the same security origin.
R=jcampan,wtc
BUG=8706
TEST=SSLUITest.TestMixedContentsRandomizeHash,SSLUITest.TestMixedContentsTwoTabs
Review URL: http://codereview.chromium.org/42314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The crash is fixed since WebKit@r41824, and it's not crashing since merge.
The test needs to be rebaselined due to change in JPEG decoder.
Review URL: http://codereview.chromium.org/43114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I don't know if it'll draw the border correctly).
Now with fixes to compile under Windows.
Review URL: http://codereview.chromium.org/42427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation, based on the Mozilla code
mozilla/netwerk/streamconv/converters/ParseFTPList.cpp.
Contributed by Ibrar Ahmed <ibrar.ahmad@gmail.com>.
R=darin,wtc
BUG=4965
Review URL: http://codereview.chromium.org/42261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Brett: This is FYI for you
Sid: There's a README_vi_VN but nothing for vi_VI. Can you help me figure out what's going on there? vi_VI is not listed in the openoffice page nor is it in fullpack.
Review URL: http://codereview.chromium.org/21431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we still have the hack where we pass raw pointers into the
renderer, we should catch the NULL case and return something sane.
Additionally, while I'm at it, always tell WebKit that it has a 32-bit
screen. Since it paints via IPC messages, it doesn't need to know what
the actual screen is using; we handle all that in the BackingStore.
Review URL: http://codereview.chromium.org/50030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=mbelshe,brettw
Review URL: http://codereview.chromium.org/50014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
semantics as having specified an attribute as readonly.
This allows us to unfork IDL differences where V8 wants
readonly and JSC does not by using the V8ReadOnly
tag.
Review URL: http://codereview.chromium.org/50037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
more. No functional change.
Review URL: http://codereview.chromium.org/42418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=beng
Review URL: http://codereview.chromium.org/50035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I don't know if it'll draw the border correctly).
Review URL: http://codereview.chromium.org/42414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I get this to work I'll rename it NativeButton and remove the old one.
Review URL: http://codereview.chromium.org/48117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
been landed in our codebase. See: https://bugs.webkit.org/show_bug.cgi?id=23630
The stroking-decorations test has been rebaselined already.
The output is not perfect but much better then the currect baseline. I'm also
removing the DEFER status.
Review URL: http://codereview.chromium.org/50028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42408
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Also changed Lock::AssertAcquired to be const function (it already was const, in practice, just not declared that way).
Review URL: http://codereview.chromium.org/42402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
None of these look merge-related.
TBR=tony
Review URL: http://codereview.chromium.org/42410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
platform ifdefs that are no longer necessary in Browser. Patch from thakis@google.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7259
TEST=see bug
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/45015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- check return value of write to self-pipe
Review URL: http://codereview.chromium.org/42403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the use of the mac specific type 'application' and use 'executable'
with 'mac_bundle' set to 1.
- update common.gypi to default mac_bundle to zero.
- update common.gypi to look at mac_bundle for some of the base behaviors that
were on 'application'.
- Roll DEPS to get the new version of gyp w/ the matching support.
Review URL: http://codereview.chromium.org/50015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/42406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/50019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/50025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the browser window for windows with tabs to promote re-use in contexts other than just the browser. Add code to the tab view to track drags, but it's disabled as it still needs much work.
Review URL: http://codereview.chromium.org/42397
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8100
Review URL: http://codereview.chromium.org/42377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=tony
I made a few changes to our test plugin to match changes to the upstream's plugin. It now uses console instead of printf. You are just the guy (apparently) to review this :)
Review URL: http://codereview.chromium.org/50020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/50022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
default configuration. This simplifies the build system.
My concern was that some consumers of the API might mix-up the defines.
R=dglazkov
Review URL: http://codereview.chromium.org/42392
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Issue=8127
Review URL: http://codereview.chromium.org/48082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/svg/W3C-SVG-1.1/pservers-grad-06-b.svg
LayoutTests/svg/batik/paints/patternRegionA.svg
LayoutTests/svg/W3C-SVG-1.1/pservers-pattern-01-b.svg
These are failing because of a bug in Skia. The Skia team is evaluating what the
right fix should be. Until then, DEFERd.
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/50021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/45014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to prevent timer races.
Add debugging information to the check() to see what values the timer is actually returning.
Review URL: http://codereview.chromium.org/42359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(LayoutTests/svg/batik/masking/maskRegions.svg and
LayoutTests/svg/custom/image-small-width-height.svg). Glen is still
upstreaming these, once he is
done he can unDEFER them. Also removes
LayoutTests/svg/text/text-text-08-b.svg as it has not failed in the
last 40 runs.
TEST=none
BUG=none
TBR=finnur
Review URL: http://codereview.chromium.org/42393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to make nss play well with valgrind, as recommended by Wan-Teh in
http://groups.google.com/group/mozilla.dev.tech.crypto/msg/49fe8582df376d06
Set the same environment variables in chrome_test.sh/valgrind_test.py
and valgrind.sh, and explain which is which.
Review URL: http://codereview.chromium.org/42326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
a kext) :)
Review URL: http://codereview.chromium.org/42391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
To investigate this issue, we noticed some IMEs got confused when we change the text in a rich-edit control and finish an ongoing IME composition while they are composing a text. To prevent this, we accept keywords when they are activated.
Review URL: http://codereview.chromium.org/42275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Because KiFastSystemCall is so short (4 bytes), we need to use the preceeding alignment for a 5 byte jump. The compiler is generating more complicated alignments these days. Hardcode another case.
Additionally switch to using the XP system call tables by default.
Review URL: http://codereview.chromium.org/50006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This avoids problems caused by other unit tests that modify the shared instance.
TBR=abarth
Review URL: http://codereview.chromium.org/42386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=wtc
Review URL: http://codereview.chromium.org/50002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also includes a change to not have third_party/WebKit/WebKit/chromium/public
in the global include path. Most of the code changes pertain to this.
I also took this opportunity to do some renaming:
browser/cache_manager_host -> browser/renderer_host/web_cache_manager
R=brettw
Review URL: http://codereview.chromium.org/42194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=wtc
BUG=8860
Review URL: http://codereview.chromium.org/42384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12083 0039d316-1c4b-4281-b951-d872f2087c98
|