| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
data in the file.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113917
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in some distributions.
BUG=11380
TEST=Start chrome with empty resolv.conf, fix resolv.conf; chrome should
be able to resolve sites.
Review URL: http://codereview.chromium.org/113904
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We specifically detect this case, close the channel and return an error.
This CL also silences error messages that where previously printed to the console in this situation.
BUG=12734
Review URL: http://codereview.chromium.org/113913
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115821
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
namespace change to window_sizer_mac which I noticed when doing a previous
change.
Review URL: http://codereview.chromium.org/113910
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
or not. If not valid, just pass white to ThemeEngine.
This change was motivated by the issue
http://code.google.com/p/chromium/issues/detail?id=2756, but it has been
resolved by only the upstream change
https://bugs.webkit.org/show_bug.cgi?id=25742.
However, this verification code is still useful.
BUG=2756
Checked in for tyoshino@google.com
Original review: http://codereview.chromium.org/113165
Review URL: http://codereview.chromium.org/113907
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9936
TEST=Download a .svgz file to local disk, then attempt to view it. Please make sure it didn't get decompressed during the download.
Review URL: http://codereview.chromium.org/99109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/115768
TBR=tyoshino
Review URL: http://codereview.chromium.org/115822
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add app_locale_settings and app_strings to all the locale dlls.
BUG=12309
Review URL: http://codereview.chromium.org/115820
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115813
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CWindowImpl. This makes it much easier to extend the API of Widget.
Cleans up ExternalTabContainer to better match chrome style.
BUG=none
TEST=run ui tests, verify ExternalTabContainer tests pass.
Review URL: http://codereview.chromium.org/113892
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=7697
TEST=Open RTL Chrome (--lang=he), load ynet.co.il, load mako.co.il, open new tab page. Observe that ellipsis is placed correctly at the end of the page titles for aforementioned sites and that the underline is under the whole title and not just under the ellipsis.
Review URL: http://codereview.chromium.org/112025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=With an empty history, open a new tab. The NTP should not show the link
to "Remove thumbnails". Browse 3 different sites and open a new tab again. The
link "Remove thumbnails" should now be visible.
Review URL: http://codereview.chromium.org/115787
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115811
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
localizer subclass for the prefs window.
BUG=12534
TEST=make sure branding is correct on default browser button.
Review URL: http://codereview.chromium.org/115817
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
BUG=3319
TEST=none
Review URL: http://codereview.chromium.org/113903
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=shift-zoom maximizes window, zoom sizes to intrinsic size.
Review URL: http://codereview.chromium.org/115818
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/112062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the description for that cl:
Lands http://codereview.chromium.org/115505 for bug
http://crbug.com/4030 for tyoshino.
BUG=http://crbug.com/4030
TEST=make sure control-w dismisses bookmark manager.
Review URL: http://codereview.chromium.org/113902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Now we show import progress of individual items
- In case Firefox is running we display a warning and allow user to close it before proceeding
- Delete the Firefox lock when import finishes
BUG=11191
Review URL: http://codereview.chromium.org/114047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke Modules Mac
Review URL: http://codereview.chromium.org/113901
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
developer tools by default.
Review URL: http://codereview.chromium.org/117003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/4030 for tyoshino.
BUG=http://crbug.com/4030
TEST=make sure control-w dismisses bookmark manager.
Review URL: http://codereview.chromium.org/113887
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the frontmost window type. Have cmd-key equiv correctly set depending on the window type and the number of tabs in the window. Broadcast notification when the number of tabs changes in the model. Disable "close tab" item when there's only 1 tab in the browser window.
BUG=10047
TEST=cmd-w correctly closes the expected thing (frontmost window, or tab in the frontmost window). close tab should be disabled when the frontmost tab is not a browser or if there is only 1 tab in the window.
Review URL: http://codereview.chromium.org/115789
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- introduced bound object on the agent side;
- established remote dispatch of WebInspector calls
- using fake InspectorFrontend for serializing events and sending them over the ipc
- removed net agents from both sides
- moved GetResource stuff to tools agent
Assumes following is landed:
https://bugs.webkit.org/show_bug.cgi?id=26010
Review URL: http://codereview.chromium.org/113836
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The LiveConnect test cases at http://java.sun.com/javase/6/webnotes/6u10/plugin2/liveconnect/LiveConnectTests/ now pass for Chromium.
Parts of this change is rather mechanical, and leaves room for some refactoring afterwards.
Merged the implementation of testConstruct and the "objectPointer" property from WebKit\WebKitTools\DumpRenderTree\TestNetscapePlugIn.subproj\TestObject.cpp to the Chromium TestObject.cpp for the layout test LayoutTests\plugins\netscape-construct.html pass.
BUG=http://crbug.com/3285
BUG=http://crbug.com/10354
TEST=http://java.sun.com/javase/6/webnotes/6u10/plugin2/liveconnect/LiveConnectTests/
TEST=LayoutTests\plugins\netscape-construct.html
Review URL: http://codereview.chromium.org/113823
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/12320
Review URL: http://codereview.chromium.org/113636
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was disabled in http://src.chromium.org/viewvc/chrome?view=rev&revision=16308
The root cause of crash has been fixed (see linked bug).
TEST=none
http://crbug.com/12187
Review URL: http://codereview.chromium.org/115782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The observer requires that message loop stays up and same through
its lifetime. This is not true during testing.
TEST=none
http://crbug.com/12187
Review URL: http://codereview.chromium.org/113824
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=visit an IDN URL, and open the "Basics" tab of the "Options"
dialog, select "Open the following pages", press "Add..." button,
select the IDN URL, and confirm that the URL field is shown in
Unicode, or
paste a Punycode URL to the URL field of the "Add page" dialog,
press "Add" button, and confirm that the "Open the followig pages"
list shows the Unicode URL.
http://crbug.com/3991
Patch by tkent
Original review: http://codereview.chromium.org/115759
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of Punycode host name.
http://crbug.com/4008
TEST="Copy link address" copies Unicode host name for both of <a href="punycode
URL"> and <a href="Unicode URL"> if Accept-Language preference is matched.
Patch by tkent
Original review: http://codereview.chromium.org/115752
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113886
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
data_len can be greater.
TBR=evan
BUG=none
TEST=should work on window managers that support the wm-spec.
Review URL: http://codereview.chromium.org/113884
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
reverted.
Review URL: http://codereview.chromium.org/113885
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It needs to be heightened just a bit.
BUG=11487
TEST=Open Clear Data Dialog on XP with Classic Theme and the button should not overlap the combo box.
Review URL: http://codereview.chromium.org/113880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed bug number for rebaselines after Webkit Update 43750:43770
in test_expectations.txt
BUG=12053
TEST=LayoutTests/fast/canvas-bg-zoom.html passes on linux
Review URL: http://codereview.chromium.org/113835
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115778
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The differences are JavaScript exception message only.
BUG=12611
TEST=run_webkit_test LayoutTests\fast\js\exception-for-nonobject.html passes
Review URL: http://codereview.chromium.org/115766
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes another large fonts issue.
BUG=12573
TEST=toolbar should look like it does on windows (where there is spacing, the size of it, etc.)
Review URL: http://codereview.chromium.org/115792
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/11824
TEST=Run CHrome with '--lang=ta' with Firefox runing. Try to import bookmarks and settings
from Firefox into Chrome. The dialog box alerting that Firefox is running should not be truncated.
Review URL: http://codereview.chromium.org/113516
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in an incognito window is in sync with all other download managers.
BUG=11514
TEST=Open a download manager (Ctrl+J) and an incognito window with a
download manager (Ctrl+Shift+N followed by Ctrl+J). Then start to download a
file and note that both download managers should get updated. Try pausing and
eventually click "Remove all" in either DM and all downloads should get removed
from both DMs.
Review URL: http://codereview.chromium.org/115804
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mmoss
Review URL: http://codereview.chromium.org/113879
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/115806
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1) We shouldn't use CHECK for situations that can reasonably occur.
2) We need to recover from the case where this WORKAREA property isn't
available.
Review URL: http://codereview.chromium.org/113877
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the following errors when building unit_tests:
undefined reference to `google_breakpad::WriteMinidump(char const*, int, void const*, unsigned int)'
undefined reference to `UploadCrashDump(char const*, char const*, unsigned int)'
Review URL: http://codereview.chromium.org/113876
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
window_sizer to the Linux build.
Review URL: http://codereview.chromium.org/115803
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Includes gyp update for WebKit file renaming:
AccessibilityAria* --> AccessibilityARIA*
Review URL: http://codereview.chromium.org/115800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it by asking to write out a "modified" chrome.sln).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113860
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
password was stored are different was broken.
This happened as part as some refactoring done for the form autofill last year.
BUG=12675
TEST=See bug.
Review URL: http://codereview.chromium.org/113853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16950 0039d316-1c4b-4281-b951-d872f2087c98
|