| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
- set home page / show home button
- show bookmarks bar
Review URL: http://codereview.chromium.org/7369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/7482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Rolling DEPS one more time...
TBR=ojan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of http://codereview.chromium.org/7453/For Mac and Linux build guys, here's the rundown:A webkit/port/bindings/v8/ScriptCallContextV8.cppA third_party/WebKit/WebCore/bindings/js/ScriptCallContext.cpp -- this one is for KJS build onlyA third_party/WebKit/WebCore/page/ScriptCallContext.h
Review URL: http://codereview.chromium.org/7480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixed bugs with coverage.py and added the list of binaries to be instrumented and the tests to be run.
Review URL: http://codereview.chromium.org/7469
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
dangerous downloads (see download_tab_view.cc).
Also fixes bug 3471, where if the same file is downloaded again while the first one is not finished, they would get the same name. For dangerous downloads, we now uniquify the path on download start (so the UI shows a file name most likely to be the final name), and on download complete (so if there 2 simultaneous downloads of the same file the last one does not overwrite the first).
BUG=3470, 3471
TEST=see bugs
Review URL: http://codereview.chromium.org/7395
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Needed to change the following:
* PluginHost::SetPostData: make the state machine parse post
data without any header fields
* If NPN_PostUrl is called without content-type, set the default
content type to 'application/x-www-form-urlencoded'
* Fix a silly bug in post url logic.
BUG=2858
Review URL: http://codereview.chromium.org/7612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
is flaky. This will be removed once I get a run that hangs again.
Review URL: http://codereview.chromium.org/7626
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This one: http://codereview.chromium.org/7453
TBR=darin
Review URL: http://codereview.chromium.org/7625
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is not a complete change list, and should be reviewed together with http://codereview.chromium.org/7400
I will update the DEPS roll once part uno lands.
Review URL: http://codereview.chromium.org/7453
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it so that if you restore a tab we remove from the tab restore service
(this is what control-shift-t does too).
BUG=2598
TEST=make sure closed tabs still show up on the new tab page.
Review URL: http://codereview.chromium.org/4016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a tab.
The issue was because ShelfVisibilityChangedImpl is called twice, once with a null current_tab for the closing tab (via TabClosingAt), and once on selection of the new tab (via TabSelectedAt) - the first call nulls the shelves without doing a Layout, the nulled shelves then don't show up in the second call, so Layout is never called.
http://crbug.com/2069
BUG=2069
Review URL: http://codereview.chromium.org/7155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
sub-delegate to RenderViewHostDelegate which is implemented by WebContentsView. I did a lot of plumbing and moving around as a result.
Review URL: http://codereview.chromium.org/6608
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
introduced with the Linux/NSS implementation of SSL.
Review URL: http://codereview.chromium.org/7090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
initWithHTML which tries to load the system WebKit...and then EPIC FAIL. Helps the layout tests not time out so much until we think about this more.
Review URL: http://codereview.chromium.org/7623
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
implementation dependent printing of constructors and prototypes.
Review URL: http://codereview.chromium.org/7620
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in the webkit style and does not include full paths.
Review URL: http://codereview.chromium.org/7616
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* RCFLAGS may not exist in SCons environment. Use empty list if absent.
* Accumulate generated files in grit_files and run RES on win32 only.
Patch by Seo Sanghyeon <sanxiyn@gmail.com> originally from
http://codereview.chromium.org/7247/show
Review URL: http://codereview.chromium.org/7614
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pkasting
Review URL: http://codereview.chromium.org/7613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
linux. More will come once we stop using PLATFORM_GTK_.
Review URL: http://codereview.chromium.org/7606
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
string, otherwise it will likely be grammatically incorrect.
This is a hack until http://crbug.com/3295 is implemented.
Review URL: http://codereview.chromium.org/7396
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
manager incompatible with a non-RootView, causing coordinates to get screwed up.
TBR=sky
Review URL: http://codereview.chromium.org/7471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
When a user opens a "Fonts and Languages" dialog (through [Options] -> [Change Font and Language Settings]) and presses its "OK" button without changing anything, the debug build of Chromium raises an assert exception because the LanguagePageView::SaveChanges() function reads the value of an initialized member variable |LanguagePageView::spellcheck_language_index_selected_|.
To prevent this possible assertion, this change initializes the member variable |LanguagePageView::spellcheck_language_index_selected_| to -1 in the constructor of the LanguagePageView class.
Review URL: http://codereview.chromium.org/7387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
a directory's contents change.
Review URL: http://codereview.chromium.org/6377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this variable in the first place.
TBR=evan
Review URL: http://codereview.chromium.org/7609
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7450
Patch from icefox.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
list of request headers associated with a WebRequest object. The intent is to
access this information from WebViewDelegate::DispositionForNavigationAction().
Remove the HasFormData() method that checked for upload (form) data on the
history item. The HasFormData() method is not currently being called from
anywhere, so changes elsewhere are not required.
Add HasUploadData(), GetUploadData() and SetUploadData() methods to test, get
and set the underlying request upload data as a net::UploadData object. Add
GetHttpHeaders() and SetHttpHeaders() methods to get and set all request headers
using a map of values. Add the SetHttpHeaderValue() method to set the value for
a particular request header.
Patch by Marshall Greenblatt
R=darin
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flag. Implementation follows the pattern of the visited links system.
Things still to be done:
- stop using a hardcoded script directory
- watch script directory and update shared memory when necessary
- move file io to background thread
- support for @include patterns -- now, all scripts are applied to all pages
Review URL: http://codereview.chromium.org/7254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://crbug.com/2188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
window style.
http://crbug.com/3264
Review URL: http://codereview.chromium.org/7442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jcampan
Review URL: http://codereview.chromium.org/7464
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was finally able to reproduce a problem where we would crash when
clicking Save on the Download Tab (it would also crash during animation
of the items on the download shelf after switching away from the tab
downloading).
The reason for the crash is that if the controls on the download shelf
have not been laid out once (before switching to a tab that doesn't have
a download shelf), then we'll crash inside NativeControlContainer ctor
when it tries to ValidateNativeControl() (it walks up the parent
hierarchy trying to find the ViewContainer and ends up dereferencing a
NULL pointer).
This was reviewed by jcampan as http://codereview.chromium.org/7446
I had to recreate the changelist before submitting (long story).
Review URL: http://codereview.chromium.org/7604
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/7455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from webkit/glue to the build rule.
Patch from icefox (TorchMobile)
http://codereview.chromium.org/7418
Review URL: http://codereview.chromium.org/7454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which was
a plugin layout test failure (return-error-from-new-stream-doesnt-invoke-destroy-stream.html)
The test fails because it assumes that if an error is returned from NPP_NewStream, NPP_URLNotify
is still invoked thus sending a notification to the plugin. The plugin implementation in webkit
does this.
We emulate this behavior.
Bug=2952
R=jam
Review URL: http://codereview.chromium.org/7443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
was renamed
TBR=sidchat
Review URL: http://codereview.chromium.org/7399
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/7452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/7397
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(trying to address previous review comments).
Review URL: http://codereview.chromium.org/7447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This bug was fixed in 1735, but the code to fix that
got reverted (by mistake?) in revision 2744.
Comment for 1735:
The basic issue here was that the plugin would not paint correctly.
The URLs mentioned in this bug load windowed silverlight plugin instances,
which invoke the NPN_InvalidateRect API to paint. We send over the rects
to the renderer, however these don't generate paints as the plugin is
windowed. A peek at Safari's webkit implementation revealed that they
merely invoke the InvalidateRect windows API in this context.
The fix is to emulate this behavior.
bug:666
Review URL: http://codereview.chromium.org/7370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
state to the active entry, which would be the pending entry if there is one.
That caused a problem in cases where a bad resource is loading and we are initiating a navigation from the browser (and therefore creating a pending entry).
More details:
In the GoodFrame test, the top-frame is HTTPS and we load an HTTP frame with an image. As soon as the bad frame has loaded, we navigate back (creating a pending entry). In rare cases, the notification for the mixed-content image of the HTTP frame would happen after the back action, mistakingly setting the mixed-content state on the pending entry.
BUG=2742
TEST=Run the SSL UI tests 1000 times.
Review URL: http://codereview.chromium.org/7440
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This version prevents memory overrun on malicious due to malicious encoded
content.
r=openvcdiff
Review URL: http://codereview.chromium.org/7428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3479 0039d316-1c4b-4281-b951-d872f2087c98
|