| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR
Review URL: http://codereview.chromium.org/115471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113491
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/http/tests/navigation/relativeanchor-basic.html
If a navigation only consisted of scrolling to an anchor, then we would skip
the normal 'done' processing. As a result, we would not update the 'content
state' of the NavigationEntry. The code that dumps the back/forward list
inspects the navigation entries, and it would see a blank content state for
the last entry.
BUG=11924
R=dglazkov
Review URL: http://codereview.chromium.org/113530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we delete a ResourceLoaderBridge before OnCompletedRequest is received, bad things happen. There's a lot of leaks at the following points:
1. OnMessageReceived ignores the message.
2. RemovePendingRequest removes it's internal deferred_message_queue.
But ViewHostMsg_Resource_DataReceived is not POD. We should also close the shared memory handle inside it.
Review URL: http://codereview.chromium.org/115396
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/11585
TBR=stoyan
Review URL: http://codereview.chromium.org/113534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Basically the same fix as http://codereview.chromium.org/21330 . Still no good idea on how to make that more general without being arbitrary.
Review URL: http://codereview.chromium.org/113425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This relies on issue 11680 being fixed.
BUG=http://crbug.com/12060
TEST=(Needs PageAction extension). I tried specifying .ico, .jpg, .gif, .bmp, .png and they all worked (including weird sizes).
Review URL: http://codereview.chromium.org/115411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a small performance optimization to save on paint operations on hidden widgets, and not reallocate backing stores.
BUG=http://www.crbug.com/11977
TEST=Switch between tabs. Make sure nothing breaks.
Review URL: http://codereview.chromium.org/115448
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It has more strict semantics than file_util::Move.
http://crbug.com/11585
Review URL: http://codereview.chromium.org/113207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/115451 .
BUG=http://crbug.com/12007
TEST=see bug
Review URL: http://codereview.chromium.org/113531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
as the windows baselines, we just screwed up our hashing. I've added
a comment where the hash is generated explaining the problem.
BUG=11933
Review URL: http://codereview.chromium.org/113467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
filtered out on the agent side.
Review URL: http://codereview.chromium.org/115466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Document that GetHostAndPort returns an IPv6 literal
address with square brackets.
Document that the host parameter to the ProxyServer
constructor takes an IPv6 literal address with square
brackets.
R=eroman
BUG=N/A
TEST=N/A
Review URL: http://codereview.chromium.org/113494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toolstrips around, and perhaps where we'll add other UI for manipulating an extension.
BUG=none
TEST=none
depends on the following other changes:
http://codereview.chromium.org/113481
http://codereview.chromium.org/113486
http://codereview.chromium.org/113466
Review URL: http://codereview.chromium.org/113483
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://www.crbug.com/8486
TEST=Bring up two tabs. In one tab, navigate to https://ianfette.org. Switch to the next tab. Switch back to the first tab. It should still display the interstitial page. Try this both with the focus on the interstitial page before you switch to the second tab and with the focus on the omnibox before switching tabs, to make sure focus is set properly.
Review URL: http://codereview.chromium.org/115446
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
going to do some major surgery to chrome_menu to get the rest
compiling on linux.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7937
Review URL: http://codereview.chromium.org/115425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it can implementsimple hover / tracking behavior.BUG=crbug.com/12067TEST=none (suggestions welcome)
Review URL: http://codereview.chromium.org/113481
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
their own
Review URL: http://codereview.chromium.org/112030
Patch from Antoine Labour <piman@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that are attached to browser UI. I needed another one of these for the extension shelf, and figured I'd try to make one that was generic. Ideally, we'd do more refactoring so that StatusBubbles, InfoBubble, etc. could all share some common code.
BUG=none
TEST=none (I'd love some suggestions on what to put into a unit test here)
Review URL: http://codereview.chromium.org/113486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113526
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11852.
Review URL: http://codereview.chromium.org/113363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- add necessary DEPS rules
- fix skia includes in test_shell to contain full path (third_party/skia/include/core/SkBitmap.h instead of just SkBitmap.h)
- remove forbidden chrome/common include from app/resource_bundle_mac.mm
Review URL: http://codereview.chromium.org/113147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the 'scripts' response. They are requested on demand when user selects corresponding file in the Scripts panel.
Review URL: http://codereview.chromium.org/113521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
object references in the protocol contain some display data that is enough for displaying the referenced object while it's collapsed. Child properties are requested lazily.
Review URL: http://codereview.chromium.org/113460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
performance improvements to the parser and code generator, and it
extends the script compilation cache to allow compiled code for
scripts to survive garbage collections.
Review URL: http://codereview.chromium.org/115459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and ClientSocketHandle."""
Revert "Fix a memory leak in client_socket_pool_unittest.cc."
Guess I still fail. kasperl pointed out that this managed to break layout tests and some reliability tests too.
Review URL: http://codereview.chromium.org/113517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115457
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requiring a preceding http://. The square brackets are still needed, though.
Fix some of the style problems in url_fixer_upper.cc:
- Multi-line if should have {}s
- "using namespace" is bad.
Patch by pmarks@google.com.
R=abarth
TEST=New unit tests.
http://codereview.chromium.org/113509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Need to run the MessageLoop one time to run a task to delete the canceled ConnectingSocket.
Also reorder the test to help hide the minor race condition here.
Review URL: http://codereview.chromium.org/115455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=1852854,1852794
TBR=mal
TEST=1. Run CHrome with '--lang=kn' and '--lang=te' command line flags. In Page and App menu,
make sure that low-hanging glyphs are not clipped (see the screenshots attached
to b/1852854 and b/1852789) both on Vista and XP.
2. Kannada Chrome, UI menu font size are reasonably large both on Vista and XP.
Review URL: http://codereview.chromium.org/113513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ClientSocketHandle.""
This reverts commit c235c719f964cc8f7f9343177ae6d5af724be6c0.
Fixes a use of deleted memory by making a copy instead of keeping a reference to the deleted memory.
Review URL: http://codereview.chromium.org/113512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the current data souce implementation for media resource loading
assumes forward reading, when playing some badly muxed video files that
has out-of-order read patterns a memory leak is observed. Here's the reason:
1. The video file has out-of-order read pattern
2. A lot of BufferedResourceLoader is created and destroyed to accomodate
the seek requests that cannot be served by the buffer.
3. BufferedResourceLoader is not destroyed immediately when a new request
is made, it is destroyed when the request has completed (triggered by
cancelling the request).
4. Since request completion comes at a much lower rate than creation of
BufferedResourceLoader, a lot of BufferedResourceLoader are remain
alive and keep increasing, a leak is resulted.
Adhoc solution:
We can destroy all buffers in BufferedResourceLoader when it is called
to stop. This can greatly reduce the leak amount. Although a lot of
BufferedResourceLoader are still alive, they will be destroyed eventually
(since a request completion is received due to cancelling of the request).
A better solution would be to destroy the BufferedResourceLoader right away
after it is stopped and fix the leak in ResourceDispatcher so we don't need
to lengthen the lifetime of BufferedResourceLoader.
CL for fixing ResourceDispatcher:
http://codereview.chromium.org/115396
Review URL: http://codereview.chromium.org/115394
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ClientSocketHandle."
Broke net_unittests on windows.
Review URL: http://codereview.chromium.org/113510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Provide a new api in ClientSocketPool and ClientSocketHandle for clients (notably HttpNetworkTransaction) to request connected sockets, rather than having to allocate and Connect() sockets themselves. Add a bunch of tests for it. Have not begun switching clients over to using this.
Review URL: http://codereview.chromium.org/99143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Adds messages on windows and makefile rule generate option.
Review URL: http://codereview.chromium.org/115450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sgk
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Linux bustage.
Review URL: http://codereview.chromium.org/113507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=abarth
BUG=12105
TEST=0
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of IPv6 literals appearing like "2001?4860?b005??84".
Patch by pmarks@google.com.
R=abarth
TEST=View about:dns on an IPv6 network and notice that the address render correctly.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=0
TEST=FAIL
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16253 0039d316-1c4b-4281-b951-d872f2087c98
|