| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5151001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=trybots
Review URL: http://codereview.chromium.org/5921005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the gtk extension installed button doesn't need to be themed because the background is always white (and is not the tab color, like it is in most other places in the UI)
the list item x isn't changing (the images are the same), only the URL is changing. I think this is the 'x' we want, because it's what we use on the NTP.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/5880003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5692005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5854004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If you try to exclude a test that hasn't been included, pyauto will complain
and it won't run anything. Sometimes it's harder to add exclusions per
platform, and it'd be easier to ignore tests that need to be excluded but
haven't been included.
Review URL: http://codereview.chromium.org/5913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
fixes the includes for cros to use "third_party" so that everything works.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/5854003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Ahmad Sharif <asharif@chromium.org>.
This was landed previously as r56932 and reverted in
r57445. Previous landing showed some flakiness/failures
in the DOM automation framework. Relanding to verify
if this is fixed or still broken.
BUG=53491
TEST=page cyclers stay green
Review URL: http://codereview.chromium.org/5955002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And fix callers.
BUG=23581
TEST=trybots
Review URL: http://codereview.chromium.org/5848005
TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/5905006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
And fix callers.
BUG=23581
TEST=trybots
Review URL: http://codereview.chromium.org/5848005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=yurys
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This code is the same as the previous code in bug 65331, and is also wrong.
BUG=65331
Review URL: http://codereview.chromium.org/5876004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(I missed brettw's final comment to fix this in http://codereview.chromium.org/5774004/)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5910004
Patch from Mike Wasserman <msw@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
type=file />
BUG=65780
TEST=Manual test
Review URL: http://codereview.chromium.org/5859007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since this is for developers only, developers use the console
anyway. The dialog is cute but superfluous and actually kind
of annoying.
BUG=37026
Review URL: http://codereview.chromium.org/5905005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/5730003/
Previously r69187
Check-in was almost clean, but checkdeps.py flagged it as having invalid includes (because the Clang plugins aren't meant to be built as part of Chrome). This adds the magic incantation (a DEPS file... who knew?) to make checkdeps.py ignore it. Tested by running checkdeps.py in my gclient before and after.
BUG=61004,62983
TEST=compile asserts and ppapi/tests/test_struct_sizes.c
Review URL: http://codereview.chromium.org/5927004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=67189,67191,67048
TEST=Verify that searching does not break functionality of page.
Review URL: http://codereview.chromium.org/5883006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Autofill labels.
BUG=66953,66810,66805
TEST=unit_tests --gtest_filter=AutoFillProfileTest.CreateInferredLabels*
Review URL: http://codereview.chromium.org/5851002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66072
TEST=none
Review URL: http://codereview.chromium.org/5853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have a non-NULL cert_verifier, otherwise SSLClientSocket
in off-the-record mode will crash when verifying a
certificate. Just share the same cert verifier with the
original profile.
R=agl,nirnimesh
BUG=63357
TEST=none
Review URL: http://codereview.chromium.org/5903005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
boundaries.
- Allow switch on non-content-initiated redirects.
- Allow switch on GET requests that result from a form submission (can happen if a POST destination is redirected).
- Clean up the code a bit.
This fixes an issue with the webstore where logging in would result in the webstore ending up in the wrong process.
BUG=61757,54118
TEST=Go to the webstore and sign out, then try to install an app. It will redirect you to log in, then back to the webstore. Installing at that point should not prompt you with an OK/Cancel permissions dialog.
Review URL: http://codereview.chromium.org/5860004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The NTP section transitions were updated to be smoother and reduce overlap. The sections fade-in and out more consistently and faster. The small links now fade in, and the most visited section slides up and down while switching sections.
BUG=62844
TEST=None.
Review URL: http://codereview.chromium.org/5685009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5839003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
third_party/mesa/MesaLib/src/egl/main/eglconfig.c: In function _eglCompareConfigs:
third_party/mesa/MesaLib/src/egl/main/eglconfig.h:98: error: array subscript is below array bounds
BUG=None
TEST=manual/local, and a buildbot running an otherwise affected version.
Review URL: http://codereview.chromium.org/5866007
TBR=petermayo@chromium.org
Review URL: http://codereview.chromium.org/5925005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Reland of r69420, was reverted in r69426.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
third_party/mesa/MesaLib/src/egl/main/eglconfig.c: In function _eglCompareConfigs:
third_party/mesa/MesaLib/src/egl/main/eglconfig.h:98: error: array subscript is below array bounds
BUG=None
TEST=manual/local, and a buildbot running an otherwise affected version.
Review URL: http://codereview.chromium.org/5866007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have investigated the bug in great detail. My previous fix is entirely
correct and complete. Removed the TODO, updated the comment to give a
better explanation, will close issue upon review.
BUG=66864
TEST=none
Review URL: http://codereview.chromium.org/5926001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5841002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
depend on them.
BUG=61609
TEST=When more than one product is installed with the chrome binaries, the first product should not delete the binaries but the second one should.
Review URL: http://codereview.chromium.org/5875004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
manager.
BUG=64966
TEST=manual
Review URL: http://codereview.chromium.org/5860007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r69438. It may have broken Linux dbg-shlib.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patch from Dominic Cooney, already reviewed here: http://codereview.chromium.org/5270011/)
TBR=finnur
BUG=58886
TEST=None
Review URL: http://codereview.chromium.org/5948001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
memory leak, fixed use of Win32 registry API, and refactored SetFullInstallerFlag so that it can be exercised in unit tests (tests to follow).
When --multi-install is not on command-line, "-full" is still added to the appropriate product "ap" value in official builds. When --multi-install is present, "-full" is added to the multi installer's "ap" value unless a product is being migrated from single-install to multi-install, in which case it is put on the product's "ap" value as before.
BUG=61609
TEST=Manual for now: run mini_installer.exe in various configurations, inspecting "ap" values as you go.
Review URL: http://codereview.chromium.org/5875003
TBR=grt@chromium.org
This broke the Win Builder (dbg) (Shared) bot but no-one noticed.
Review URL: http://codereview.chromium.org/5890004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also restoring the implementation of RenderView::SetReportLoadProgressEnabled that somehow went away when I synced before committing my previous CL.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5925004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67112
TEST=layout tests
Review URL: http://codereview.chromium.org/5877006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=yurys
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/5550006/ )
Implement WebKitClientImpl::loadAudioResource() to decode in-memory audio file data for use by WebKit.
Most of the interesting low-level code is being added in the media directory.
BUG=NONE
TEST=NONE (tested locally with web audio API loading files of format .wav .aif .mp3 .m4a 16bit 24bit
In the longer term, WebKit layout tests will comprehensively exercise this code)
Review URL: http://codereview.chromium.org/5880002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Official Build" to fix UMA issue.
"LastChange" for convinience.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5860001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
RealPlayer (12.0.1.609)
BUG=67106
TEST=unit_tests
Review URL: http://codereview.chromium.org/5906003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=all tests using test server not broken.
BUG=none
Review URL: http://codereview.chromium.org/5884002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Simplified mutation semantic: Update() replaced with
Save(). Set methods can be called at any time.
- JsonHostConfig now inherits from InMemoryHostConfig to
avoid code duplication.
- Added kHostEnabledConfigPath.
BUG=None
TEST=Unittests.
Review URL: http://codereview.chromium.org/5738008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59282
TEST=none
Review URL: http://codereview.chromium.org/5850004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I mistakenly did a Cancel in the callee's destructor, which would reinvoke traits_.ReleaseCallee
Since this is a programming error, it's not a required change.
BUG=None
TEST=base_unittests --gtest_filter="TaskTest.TestCancelInDestructor"
Review URL: http://codereview.chromium.org/5886002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5910003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66808
TEST=Unittests
Review URL: http://codereview.chromium.org/5761003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=67094
Review URL: http://codereview.chromium.org/5914004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
installed in an incognito window.
BUG=62752
TEST=Install extension and app in incognito and normal modes.
Review URL: http://codereview.chromium.org/5942001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many (most?) of the bugs related to the new message pump have been fixed, and it
is ready for testing. It's stable enough that it shouldn't block other people's
works.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5940003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
string. To achieve
this we need to add the desired value in the registry under the
Internet Settings\User Agent\Post Platform key. We add this under the per user or per machine
section in the registry depending on whether ChromeFrame is being installed in per user or
per machine mode. This fixes the bug where certain top level requests in IE would not have
the chrome frame UA appended to the IE UA.
Removed the BeginningTransaction vtable patch code, which only existed to add chrome frame to
the UA in outgoing requests.
The limitation with registering the chrome frame UA in the registry is that it will be sent
out even in the ChromeFrame BHO is disabled.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=45087
BUG=45087
TESt=Covered by new chrome frame test.
Review URL: http://codereview.chromium.org/5831002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Protect reading and writing startup_data_ to ensure intruction order and
to ensure the value is correctly read in the new thread.
Contributed by phanna (Android)
BUG=67145
TEST=none
http://codereview.chromium.org/5933002/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69438 0039d316-1c4b-4281-b951-d872f2087c98
|