summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Reverting 19425.ericroman@google.com2009-06-2628-135/+153
| | | | | | Review URL: http://codereview.chromium.org/147242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19432 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad commentgman@google.com2009-06-261-2/+0
| | | | | | Review URL: http://codereview.chromium.org/149098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19431 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes lots of docs issues in the IDL files.gman@google.com2009-06-2616-36/+100
| | | | | | Review URL: http://codereview.chromium.org/147144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19430 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-2685-1089/+1208
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the < sign to &lt; in jsdocsgman@google.com2009-06-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/149104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19427 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that happens when changing themes.tc@google.com2009-06-263-22/+55
| | | | | | | | | | | | | | | | | | We were holding references to images that got deleted when themes changed. These all happen to be in a NineBox, so have NineBox reload images when the theme change notification is sent. Also fix an expose bug that wasn't noticeable in the original theme. We need to always place the image at 0, 0 for the background and paint it all the way across the window (should get clipped by cairo). BUG=15366 Review URL: http://codereview.chromium.org/149102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19426 0039d316-1c4b-4281-b951-d872f2087c98
* Make net::HostResolver refcounted.ericroman@google.com2009-06-2628-153/+135
| | | | | | | | | | | This way it can be properly shared between the url request contexts, and the dns prefetcher, and dns observer. BUG=http://crbug.com/14664 TEST=existing unit tests. Review URL: http://codereview.chromium.org/149053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19425 0039d316-1c4b-4281-b951-d872f2087c98
* Add notifications for when V8Proxy creates or destroys a V8 Context.mpcomplete@chromium.org2009-06-2611-3/+93
| | | | | | | | | | BUG=no TEST=no Review URL: http://codereview.chromium.org/147124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19424 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/147235jianli@chromium.org2009-06-262-1/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19423 0039d316-1c4b-4281-b951-d872f2087c98
* Missed a test that needed to be updated with r19418.mark@chromium.org2009-06-261-7/+15
| | | | | | | | BUG=15462 TEST=unit_tests --gtest_filter=JSONValueSerializerTest.Roundtrip Review URL: http://codereview.chromium.org/149103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19422 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the win KeywordEditorView for cross platform friendliness.mattm@chromium.org2009-06-268-561/+706
| | | | | | | | | | | The TableModel is moved to search_engines/template_url_table_model.* The shared logic, and ownership of the url_model_ and table_model_, is moved to search_engines/keyword_editor_controller.* BUG=13326 Review URL: http://codereview.chromium.org/146138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19421 0039d316-1c4b-4281-b951-d872f2087c98
* Document when the Delegate methods OnCertificateRequested andwtc@chromium.org2009-06-261-1/+9
| | | | | | | | | | | | | | OnSSLCertificateError are called for a request. Document that the string passed to SetExtraRequestHeaders should not end in \r\n. R=rvargas BUG=none TEST=none Review URL: http://codereview.chromium.org/149095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19420 0039d316-1c4b-4281-b951-d872f2087c98
* divVectorVector was copied from mulVectorVector and the * was still there. ↵petersont@chromium.org2009-06-261-0/+6
| | | | | | | | Fixed bug and added test. Review URL: http://codereview.chromium.org/147231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19419 0039d316-1c4b-4281-b951-d872f2087c98
* Use platform-appropriate newlines in JSON output.mark@chromium.org2009-06-2616-49/+188
| | | | | | | | BUG=15462 TEST=base_unittests, unit_tests, check newlines in bookmarks file Review URL: http://codereview.chromium.org/147220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19418 0039d316-1c4b-4281-b951-d872f2087c98
* JS bindings for Audio ctor in place. 4 test expectations changed.kylep@chromium.org2009-06-261-4/+3
| | | | | | Review URL: http://codereview.chromium.org/149090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19417 0039d316-1c4b-4281-b951-d872f2087c98
* Do some minor cleanup I noticed in SiteInstance. Before, we would parse andbrettw@chromium.org2009-06-263-19/+24
| | | | | | | | | | | | canonicalize the three about URLs every time this function was called (I think for every page transition). This is unnecessary, so I just added a string comparison. TEST=none BUG=none Review URL: http://codereview.chromium.org/149084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19416 0039d316-1c4b-4281-b951-d872f2087c98
* Validates links which are to be passed on to the NTP by ensuring that they ↵mirandac@chromium.org2009-06-262-8/+14
| | | | | | | | | | | start with "http://" or "https://". BUG= http://crbug.com/15457 TEST= Change cached tip link in preferences file to be invalid. Note that this tip will not be included on the NTP. Review URL: http://codereview.chromium.org/149083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19415 0039d316-1c4b-4281-b951-d872f2087c98
* Use regular notifications for theme changes.tc@google.com2009-06-263-4/+15
| | | | | | | | | | | | | This should have no impact on the current behavior. On linux, we'll want to get these notifications in a few places other than just the root browser windows so having it as a regular notification makes it easier for us to just listen for the event. Review URL: http://codereview.chromium.org/149032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19414 0039d316-1c4b-4281-b951-d872f2087c98
* Create a webkit thread for use within the browser process. This patch also ↵jorlow@chromium.org2009-06-2619-5/+539
| | | | | | | | | | | includes some (soon to be fleshed out in another CL) code to demonstrate how it'll be used in DOM Storage. BUG=None TEST=None Review URL: http://codereview.chromium.org/139003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19413 0039d316-1c4b-4281-b951-d872f2087c98
* Add stubs for the rest of the gtk advanced options sections. Hook up the ↵mattm@chromium.org2009-06-263-2/+135
| | | | | | | | | | reset prefs function. BUG=11507 Review URL: http://codereview.chromium.org/149097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19412 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a menu crash.ben@chromium.org2009-06-261-0/+1
| | | | | | | | | | | The menu's host window, the message window that receives notifications from the native menu about selection changes, is destroyed, however if the menu is still active it will continue to send messages to it. SDK docs say properties set with SetProp should be removed with RemoveProp before a window is finally NCDESTROYed. The code wasn't doing this, so it was still theoretically possible for the code in the message window's window procedure to locate "something" on that property. http://crbug.com/14594 TEST=none Review URL: http://codereview.chromium.org/147230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19411 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 memory leaks in UtilityProcessHostTest.ExtensionUnpacker.tc@google.com2009-06-261-5/+6
| | | | | | | | | | | Valgrind says this test is now clean, let's hope purify agrees. BUG=15456 Review URL: http://codereview.chromium.org/149092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19410 0039d316-1c4b-4281-b951-d872f2087c98
* This test no longer crashes.abarth@chromium.org2009-06-261-2/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19409 0039d316-1c4b-4281-b951-d872f2087c98
* Two fixes:cevans@chromium.org2009-06-263-2/+96
| | | | | | | | | | | | | | | - Apply limit to cursor dimensions. Turns out that the APIs used on Windows and Linux are integer-overflow resistant to width * height issues. Not sure about Mac, though. - Ensure the renderer passed enough data for the dimensions specified, otherwise we read out of bounds. BUG=none TEST=WebCursorTest.CursorSerialization plus http://www.iconutils.com/faq/web-page-cursor.htm and http://www.hypergurl.com/customcursor.html Review URL: http://codereview.chromium.org/147193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19408 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing include, fix compile on Fedora 11.thestig@chromium.org2009-06-261-2/+3
| | | | | | Review URL: http://codereview.chromium.org/147224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19407 0039d316-1c4b-4281-b951-d872f2087c98
* Fix div typogman@google.com2009-06-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/147228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19406 0039d316-1c4b-4281-b951-d872f2087c98
* s/OS_MAC/OS_MACOSX/willchan@chromium.org2009-06-261-2/+2
| | | | | | Review URL: http://codereview.chromium.org/149087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19405 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring using_proxy_, using_tunnel_, using_socks_proxy_ into a single ↵arindam@chromium.org2009-06-264-23/+145
| | | | | | | | | | | | | | enum ProxyConfig in HttpNetworkTransaction. Fixing http://crbug.com/14982 In case of SOCKS proxies we set the url to append to the group name so that the socks endpoint is at the target server and not the socks proxy server and so can be effectively reused by the socket pool. BUG=14982 TEST=unittests Review URL: http://codereview.chromium.org/146026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19404 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tab overview show the arrow at the right location.sky@chromium.org2009-06-265-10/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/147218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19403 0039d316-1c4b-4281-b951-d872f2087c98
* GTK bookmark manager: workaround for multi row dragging.estade@chromium.org2009-06-262-14/+78
| | | | | | | | | http://crbug.com/15240 TEST=click around in the bookmark manager a lot, everything works as you'd expect. In particular, if you hold ctrl and select a few rows, then release control, then click on those rows and try to drag them, they will drag. Review URL: http://codereview.chromium.org/147188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19402 0039d316-1c4b-4281-b951-d872f2087c98
* Fix download shelf z ordering during close.estade@chromium.org2009-06-261-3/+11
| | | | | | | | | | | Pretty much the same as what we do in the find bar. I think the flickering thing in the bug desc. was another result of <http://crbug.com/14786>, as it was only present in 3.0.190.2 and not ToT, and toggling the bookmark bar fixed it. http://crbug.com/15427 TEST=see bug Review URL: http://codereview.chromium.org/149054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19401 0039d316-1c4b-4281-b951-d872f2087c98
* Enable extension protocols on all platforms. This should enable background ↵erikkay@google.com2009-06-261-8/+1
| | | | | | | | | | | pages and tab-hosted pages from extensions. BUG=none TEST=load an extension that has a background page and verify that the process is created (see chrome://extensions) Review URL: http://codereview.chromium.org/149091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19400 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two issues with Drag-N-Drop in gtk tabstrip:jhawkins@chromium.org2009-06-262-2/+37
| | | | | | | | | | | * Handle drag-leave and drag-failed by hiding or destroying the drag arrow respectively. * Hide the drop arrow instead of destroying the drop info when we set the drop index to -1. This compensates for the fact that gtk emits the drag-leave signal before the drag-data-received signal. BUG=none TEST=Drag a URL in and out of the tabstrip. The drop arrow should disappear when the dragged mouse leaves the tabstrip or when the drag fails. Review URL: http://codereview.chromium.org/149093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19399 0039d316-1c4b-4281-b951-d872f2087c98
* Mark flaky test video-src-change.html.jianli@chromium.org2009-06-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/147229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19398 0039d316-1c4b-4281-b951-d872f2087c98
* Set images svn:mime-type.maruel@chromium.org2009-06-260-0/+0
| | | | | | | | | | | | png files to image/png, bmp files to image/bmp, gif files to image/gif NO CODE CHANGE. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19397 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Delete the upstreamed files: V8NPUtils.h V8NPUtils.cpp NPV8Object.h ↵ajwong@chromium.org2009-06-265-4/+718
| | | | | | | | | | NPV8Object.cpp." This reverts commit 1bc6d3dd877193f5eb32216c05738cba1e5cbb0f. Review URL: http://codereview.chromium.org/147227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19396 0039d316-1c4b-4281-b951-d872f2087c98
* Change BrowserBubble so that clients can say if they expect canvas mirroring ↵cira@chromium.org2009-06-262-7/+3
| | | | | | | | | | | | | to happen or not. ExtensionShelf doesn't need mirroring since View methods already provide most of the RTL functionality. BUG=http://crbug.com/11880 TEST=Run chrome --lang=he and add 1+ extensions, and see if the handle is in proper position. Review URL: http://codereview.chromium.org/149045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19395 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECKs to the states that should be entered only when thewtc@chromium.org2009-06-261-0/+7
| | | | | | | | | | | previous state succeeded. R=ibrar,phajdan.jr BUG=http://crbug.com/4965 TEST=none Review URL: http://codereview.chromium.org/149013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19394 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 45203:45247jianli@chromium.org2009-06-2627-178/+7
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19392 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the upstreamed files: V8NPUtils.h V8NPUtils.cpp NPV8Object.h ↵ajwong@chromium.org2009-06-265-718/+4
| | | | | | | | NPV8Object.cpp. Review URL: http://codereview.chromium.org/141022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19391 0039d316-1c4b-4281-b951-d872f2087c98
* move the ResetToDefault function for prefs to chrome/browser/options_utilmattm@chromium.org2009-06-264-54/+89
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/147190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19390 0039d316-1c4b-4281-b951-d872f2087c98
* Foundations for gtk advanced options page.mattm@chromium.org2009-06-266-44/+275
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/147187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19389 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a layout test as flakyhclam@chromium.org2009-06-261-0/+2
| | | | | | | | | | BUG=13907 LayoutTest/media/remove-from-document.html is flaky because it triggers a deadlock. Review URL: http://codereview.chromium.org/149089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19388 0039d316-1c4b-4281-b951-d872f2087c98
* linux plugins: eliminate GtkWidget* from plugin processevan@chromium.org2009-06-2617-87/+181
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | [retry with mac hopefully fixed this time] GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19387 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash 15371finnur@chromium.org2009-06-261-1/+2
| | | | | | | | | | | We need to null check the return from GetActiveEntry. BUG=15371 TEST=Watch the crash data from the field and make sure the crash is gone. Review URL: http://codereview.chromium.org/147214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19386 0039d316-1c4b-4281-b951-d872f2087c98
* fix windows build break.kuchhal@chromium.org2009-06-261-0/+2
| | | | | | Review URL: http://codereview.chromium.org/147222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19385 0039d316-1c4b-4281-b951-d872f2087c98
* Given the results of Rohit's investigation, I think that the times that we'remark@chromium.org2009-06-265-34/+49
| | | | | | | | | | | | | getting out of the pageload tests right now are highly suspect because we're not actually getting the bits from each page to the screen. As such, I'm much less inclined to treat the "regression" in these tests as a problem. BUG=15232 TEST=throbber changes between waiting (gray) and loading (blue) at appropriate times; animation still disabled Review URL: http://codereview.chromium.org/147211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19383 0039d316-1c4b-4281-b951-d872f2087c98
* Gracefully do nothing when run loop sources fire and no delegate is available.mark@chromium.org2009-06-261-0/+26
| | | | | | | | | | | This can happen if foreign code spins the run loop without Run being on the stack. BUG=2708 TEST=none Review URL: http://codereview.chromium.org/149082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19382 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Firefox import on OS X. No UI yet.kuchhal@chromium.org2009-06-2611-201/+352
| | | | | | Review URL: http://codereview.chromium.org/143001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19381 0039d316-1c4b-4281-b951-d872f2087c98
* Sparse IO implementation for memory-only cachehclam@chromium.org2009-06-265-73/+438
| | | | | | | | | | | | | | Implemented the following methods: MemEntryImpl::ReadSparseData MemEntryImpl::WriteSparseData MemEntryImpl::GetAvailableRange TEST=DiskCacheEntryTest.Memory* original CL: http://codereview.chromium.org/140049 Review URL: http://codereview.chromium.org/147217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19380 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 10:31:42 +0000