summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add support for 8 Indian languages. jungshik@google.com2009-02-0413-9/+41
| | | | | | | | | | | | | | | * Add entries for 8 Indian languages to grd files (<translations> section) * Change the default spellcheck language for new languages to en-US for now. They'll be switched back to the UI language when we have spell check dictionaries for them * Add entries for 8 languages to installer's string offset table. This change will go in after http://codereview.chromium.org/19545 goes in with DEPS file for ICU updated. BUG=4473 Review URL: http://codereview.chromium.org/19761 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9158 0039d316-1c4b-4281-b951-d872f2087c98
* Make render_view_host_manager.cc compile on POSIX.thestig@chromium.org2009-02-044-12/+8
| | | | | | | Get rid of forward-declared enums in render_view_host.h and unneeded headers in render_view_host_manager.h. Review URL: http://codereview.chromium.org/21048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9157 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix a crash in case the TabContents gets destroyed somehow.ben@chromium.org2009-02-041-4/+12
| | | | | | | | http://crbug.com/6702 Review URL: http://codereview.chromium.org/20032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9155 0039d316-1c4b-4281-b951-d872f2087c98
* Defers the layout testsky@google.com2009-02-041-2/+3
| | | | | | | | | | | | | LayoutTests/editing/spelling/spelling-linebreak.html as it relies on showing spelling errors, which we've decided to defer for now. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/20050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9154 0039d316-1c4b-4281-b951-d872f2087c98
* The autocomplete popup menu was using the style of the edit field it is ↵jcampan@chromium.org2009-02-041-6/+18
| | | | | | | | | | associated with. This is wrong, its font should be independent of the edit field. TEST=Open a page with a form that has an input field that uses a huge font. Bring up the autocomplete popup, the items should use a normal size font. BUG=7372,6326 Review URL: http://codereview.chromium.org/20030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9153 0039d316-1c4b-4281-b951-d872f2087c98
* Add RenderWidget to the Mac build and sort the renderer compile sources.brettw@google.com2009-02-041-6/+8
| | | | | | Review URL: http://codereview.chromium.org/20047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9152 0039d316-1c4b-4281-b951-d872f2087c98
* Add a linux stub implementation for resource_bundle.tc@google.com2009-02-046-53/+128
| | | | | | | | | | | | | This should work except for the Load calls that should load .pak files. We don't generate .pak files yet so I left that code blank for now. Mac doesn't compile this yet and is still figuring out how they want to handle resources. Review URL: http://codereview.chromium.org/21020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9151 0039d316-1c4b-4281-b951-d872f2087c98
* Update test lists after the webkit merge (r40124) that jungshik@google.com2009-02-042-3/+3
| | | | | | | | | | | | included the fix for char-encoding.html. fast/encoding/char-encoding.html should pass on all platforms. fast/encoding/char-encoding-mac.html should be ignored on Linux and Windows. Review URL: http://codereview.chromium.org/18700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9150 0039d316-1c4b-4281-b951-d872f2087c98
* Partial porting of the about handler.brettw@chromium.org2009-02-042-24/+18
| | | | | | Review URL: http://codereview.chromium.org/20045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9149 0039d316-1c4b-4281-b951-d872f2087c98
* Templatizing set_quote_chars method in tokenizer.robertshield@chromium.org2009-02-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/21045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9148 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make chrome/renderer/render_main.cc cross-platform + OS X bringup."tc@google.com2009-02-048-204/+60
| | | | | | | | | | | This reverts commit r9141. TBR=jeremy Review URL: http://codereview.chromium.org/21049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9145 0039d316-1c4b-4281-b951-d872f2087c98
* Include test_web_contents in windows scons build, take 2.estade@chromium.org2009-02-041-2/+5
| | | | | | Review URL: http://codereview.chromium.org/20008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9144 0039d316-1c4b-4281-b951-d872f2087c98
* Marking a few more test statuses on the mac from bot runs.thomasvl@chromium.org2009-02-041-1/+7
| | | | | | Review URL: http://codereview.chromium.org/20043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9143 0039d316-1c4b-4281-b951-d872f2087c98
* Hands off the intercept if 'unpatch' failsjoshia@google.com2009-02-041-6/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | If IATPatchFunction::Unpatch fails during RestoreImportedFunction it means that we cannot safely unpatch the import address table patch. In this case its better to be hands off the intercept as trying to unpatch again in the destructor of IATPatchFunction is not going to be any safer. In real world, when we patch a plugin's SetCursor, we intercept npswf.dll's IAT entry of SetCursor. It seems that our unpatch fails when the plugin ref count goes to 0. It could be because some one else has patched on top of us. Then, during CRT uninitialization at process shutdown, the destructor of IATPatchFunction is called. It detects that we haven't unpatched yet and tries to unpatch. But at this time the plugin DLL is unloaded and the IAT thunk is invalid. There's no point in trying to unpatch unloaded DLL's IAT :) BUG=6886 Review URL: http://codereview.chromium.org/21044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9142 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome/renderer/render_main.cc cross-platform + OS X bringup.jeremy@chromium.org2009-02-048-60/+204
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9141 0039d316-1c4b-4281-b951-d872f2087c98
* Bring many of the template_url classes into the fold for the Mac. Note that ↵avi@google.com2009-02-0421-665/+870
| | | | | | | | template_url_model_unittest isn't there; it requires a working database first. Review URL: http://codereview.chromium.org/19714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9140 0039d316-1c4b-4281-b951-d872f2087c98
* Remove non-existent file reference.maruel@chromium.org2009-02-041-94/+12
| | | | | | Review URL: http://codereview.chromium.org/20037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9139 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests that started failing with r9120 to green linux build.ojan@google.com2009-02-041-0/+11
| | | | | | Review URL: http://codereview.chromium.org/21047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9138 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the SecondLaunch test. It fails all the timensylvain@chromium.org2009-02-041-1/+2
| | | | | | | | | now. See bug 5671 Review URL: http://codereview.chromium.org/21046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9137 0039d316-1c4b-4281-b951-d872f2087c98
* Remove test that has been disabled upstream from expected failures toager@chromium.org2009-02-041-1/+2
| | | | | | | | | | make sure that we take another look if we fail it when they enable it again. Annotate test with description and bug number. Review URL: http://codereview.chromium.org/21043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9136 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate a test in test_fixable.ager@chromium.org2009-02-041-1/+3
| | | | | | Review URL: http://codereview.chromium.org/20017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9135 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore all profiler tests in LayoutTests/fast/profiler. These tests are ↵sgjesse@chromium.org2009-02-042-7/+5
| | | | | | | | specific to the JSC profiler and the current approach to profiling with V8 will not make these tests pass. Review URL: http://codereview.chromium.org/21016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9134 0039d316-1c4b-4281-b951-d872f2087c98
* Check in the files that were deleted but not readded in my revert (forgot to ↵jam@chromium.org2009-02-043-0/+64
| | | | | | do so after doing the reverse patch). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9133 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my change to get the tree green. Not sure why the tests became ↵jam@chromium.org2009-02-0461-1534/+1796
| | | | | | | | | | flaky. I'll try to check them in again but in smaller chunks tomorrow. TBR=mpcomplete Review URL: http://codereview.chromium.org/21039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix delete to be delete[].mbelshe@google.com2009-02-041-1/+1
| | | | | | | (fix from craig.schlenter@gmail.com) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9131 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SecondLaunch which started failing after I did a clean build.jam@chromium.org2009-02-041-1/+1
| | | | | | | | I verified that this was broken before my changes by syncing to r9122. Review URL: http://codereview.chromium.org/21036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9130 0039d316-1c4b-4281-b951-d872f2087c98
* This change list fix issue 5926 -- RTL: Text in [New Tab] should be ↵xji@chromium.org2009-02-042-19/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | truncated from RightToLeft instead of LeftToRight. (http://crbug.com/5926) Basically, the issue is that in RTL locales, the thumbnail title etc. text will always be truncated from left, even if they are pure English. For example, "mail.yahoo.com" whose title is "Yahoo! the best web based email!" will be truncated to "best web-based email!". We should be able to truncate the title as "Yahoo! the be...". The fix is to set the direction style of each title in the [New Tab] html page for title to be displayed and truncated correctly. The fix consists 2 part: new_tab_ui.cc in backend and new_tab.html in frontend. 1. new_tab_ui.cc For thumbnail title, recent bookmark title, and recently closed tab titles, originally, we set "title" and "url" into the data we pass to JS in new_tab.html. The fix added the title's "direction" to the data. The direction is by default "ltr" and is set as "rtl" when there is character having strong directionality in the title. 2. new_tab.html 2.1 set text-alignment in thumbnail-title, bookmark container, and recently closed container to be "right" for RTL locales. 2.2 explicitly set title's directionality in the above 3 sections. Test: 1. open Chrome in RTL locales. 2. open the following pages: http://yahoo.com http://gmail.com http://mail.yahoo.com http://wikipedia.com http://msdn.microsoft.com/en-us/default.aspx http://arabic.arabia.msn.com/default.aspx http://he.wikipedia.org/ 3. bookmark, close some of them. 4. open [New Tab] Review URL: http://codereview.chromium.org/19738 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9129 0039d316-1c4b-4281-b951-d872f2087c98
* try to fix mac buildjam@chromium.org2009-02-042-4/+3
| | | | | | Review URL: http://codereview.chromium.org/21035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9128 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ui test failurejam@chromium.org2009-02-041-2/+1
| | | | | | TBR=mpcomplete git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9125 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a passing test.ericroman@google.com2009-02-041-1/+0
| | | | | | | | | | (fixed by 40464:40500 webkit merge). TBR=levin@chromium.org Review URL: http://codereview.chromium.org/20034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9124 0039d316-1c4b-4281-b951-d872f2087c98
* Make it easier/less work/less error-prone to create new IPC channel types ↵jam@chromium.org2009-02-0461-1854/+1535
| | | | | | | | (i.e. renderer/plugin).Instead of having each message file include the internal one several times with different ifdefs, move that logic to ipc_message_macros.h. Also make the message class starting IDs come from an enum to ensure we don't use a value twice. I simplified the logging code a bit so we don't need X_messages.cc files.Clean up places that we were doing manual packing/unpacking. Most of this was in the automation code. I added a few new template functions to make it convenient to read the parameters from a message, and updated the code to use them.I also removed unnecessary includes of render/plugin_messages.h from headers to speed up compiling.I moved the traits of IPC structs beside the struct definition to make it more apparent what's going on, so we avoid people modifying the struct and forgetting to update the traits.Amit: please look at chrome/test/automation/tab_proxy.ccMarc-Antoine: chrome/browser/printing/*Matt: the rest Review URL: http://codereview.chromium.org/20015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9123 0039d316-1c4b-4281-b951-d872f2087c98
* The first step towards Turkish spell-checker.This is a set of fixes for ↵hbono@chromium.org2009-02-043-15/+36
| | | | | | | | | supporting the Turkish dictionary provided by the tr-spell project (*1).As I wrote in http://crbug.com/4782, this issue consists of three issues: one is against our convert_dict tool, and two are against our hunspell client.(*1) http://code.google.com/p/tr-spell/Unfortunately, the BDIC file converted from this Turkish dictionary is huge (7.1MB) because the dictionary has a lot of affix rules (> 18,000) and the most of the BDIC file is occupied by "AF" lines. BUG=4782 Review URL: http://codereview.chromium.org/18041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9122 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 40474:40500 [chromium-side].ericroman@google.com2009-02-047-35/+38
| | | | | | Review URL: http://codereview.chromium.org/21029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9121 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes MOST of a layout test. Before the font was WAY off because itdsh@google.com2009-02-044-1/+10
| | | | | | | | | | | couldn't find the correct font. Now the font is perfect, but the listbox controls are different. This is expected, so I'm rebaselining the pixel test. The text diff is still off by one number, so I'm leaving that alone until we figure it out. Review URL: http://codereview.chromium.org/23001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9120 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the usage stats opt-in javascript on the in EULA dialog to return ↵gwilson@google.com2009-02-041-2/+2
| | | | | | | | | | | the correct value when the checkbox is (not) selected. BUG=7368 R=cpu Review URL: http://codereview.chromium.org/21031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9119 0039d316-1c4b-4281-b951-d872f2087c98
* This file uses commas to separate apparently. ojan@google.com2009-02-041-4/+1
| | | | | | | | We should probably make it use line-breaks for consistency sake. In either case, make it use commas for now to green the tree. Review URL: http://codereview.chromium.org/21030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9117 0039d316-1c4b-4281-b951-d872f2087c98
* Improved OTR avatar and popup window rendering. Neither one precisely ↵pkasting@chromium.org2009-02-049-149/+132
| | | | | | | | | | | matches the old code but IMO each looks better. Once again, the aero_glass_non_client_view changes here are hackish, and will get cleaned up later. BUG=5054 Review URL: http://codereview.chromium.org/20011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9116 0039d316-1c4b-4281-b951-d872f2087c98
* Add site_instance, navigation_entry, browsing_instance, ↵pinkerton@chromium.org2009-02-046-55/+130
| | | | | | | | renderer_security_policy, and render_widget_helper to mac and linux builds. Adds a hash for Profile so it can be put into a hash table on gcc. Review URL: http://codereview.chromium.org/21021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9115 0039d316-1c4b-4281-b951-d872f2087c98
* Properly honor base::SharedMemory semantics for name="" to meanjrg@chromium.org2009-02-0413-57/+390
| | | | | | | | | | | | new/private shared memory on POSIX. Transition base::SharedMemory implementation to file/mmap() to prevent leaking of wired kernel resources and allow easier cleanup. Enable one more shared_memory unit test for POSIX. Enable stats_table_unittest.cc for Mac, and modify it so it cleans up. Review URL: http://codereview.chromium.org/19724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9114 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in the extension installation code.erikkay@google.com2009-02-042-3/+6
| | | | | | Review URL: http://codereview.chromium.org/21027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9113 0039d316-1c4b-4281-b951-d872f2087c98
* Update test lists to better match the state of the tree. TBRojan@google.com2009-02-031-7/+2
| | | | | | Review URL: http://codereview.chromium.org/21026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9112 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily mask selenium failures.ericroman@google.com2009-02-031-1/+4
| | | | | | | | These broke with the webkit merge 40409:40464. Review URL: http://codereview.chromium.org/23002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9111 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9109.ojan@google.com2009-02-039-126/+10
| | | | | | | Broke the build. Review URL: http://codereview.chromium.org/20029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9110 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds macro used to track the creation and destructionjcampan@chromium.org2009-02-039-10/+126
| | | | | | | | | | | | of HWNDs, in an attempt to detect potential double-delete. A double-delete of a HWND might be responsible for the crasher http://crbug.com/4714 Review URL: http://codereview.chromium.org/21018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9109 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline an SVG layout test. There are only very slight pixel differences ↵sidchat@google.com2009-02-034-9/+9
| | | | | | | | in the way the rotated border is drawn, compared to the existing baseline. This probably happens due to slight difference in the way Skia anti-aliases lines. Review URL: http://codereview.chromium.org/19519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9108 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line flag to load a single extension from an arbitrary ↵erikkay@google.com2009-02-037-23/+78
| | | | | | | | (non-versioned) directory. This is designed for developers to iterate on extension development without having to go through the install process. Review URL: http://codereview.chromium.org/20020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9107 0039d316-1c4b-4281-b951-d872f2087c98
* Remember change in Spell Check language by putting it in the list of accept ↵sidchat@google.com2009-02-033-0/+47
| | | | | | | | | | | languages when the user changes the language from languages options menu. It also includes a fix (required for this change to work) when existing users are updated to use language only code for spellcheck languages instead of languages+region. Issue=5829 Review URL: http://codereview.chromium.org/19520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9106 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash where we would try to add a finnur@google.com2009-02-031-15/+18
| | | | | | | | | | | | | | | | | | | | DocumentMarker with the same start- and endOffset, which AddMarker in WebKit will ignore. As a result, our marker vector is empty and we try to access the element with index -1. Also added a check to avoid a NOTREACHED in debug build, which can happen under normal circumstances (when you navigate away from a page when a search is in progress). BUG=http://crbug.com/7250 TEST=We don't have reproduction steps for the crash but if we stop seeing this on our crash server we'll know that it is fixed. Review URL: http://codereview.chromium.org/20028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9105 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Add support for Windows 7 - 64 bit.rvargas@google.com2009-02-032-15/+43
| | | | | | | | | | BUG=4324 TEST=IntegrationTestsTest.* Review URL: http://codereview.chromium.org/20026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9104 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak.kuchhal@chromium.org2009-02-031-5/+5
| | | | | | | | | Bug=6535 Review URL: http://codereview.chromium.org/20009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9102 0039d316-1c4b-4281-b951-d872f2087c98