| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=39365
TEST=yes
Review URL: http://codereview.chromium.org/2822007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Concentrate the calculation in the location bar. Was going to do this
in rewiring omnibox decorations, pulled it out before creating
cocoa/location_bar/ subdir.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2846030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13685
TEST=manual
Review URL: http://codereview.chromium.org/2805030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the manifest url contains special characters like '?' or '='.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/2806025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47471
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content.ContentTest.testThreeWindows fails on linux. Disabling for now.
BUG=47457
Review URL: http://codereview.chromium.org/2808025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DNS prefetching system has been extended to handle TCP/IP
preconnection. As a result, class names and function names will
be migrated to variations on Predictor* and Predict* to better
indicate functionality.
This change is only meant to include name changes, comment
updates, and no semantic changes.
r=mbelshe
Review URL: http://codereview.chromium.org/2813031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I didn't want to mix these in with other changes that are due
to real expectations changes.
BUG=46769 (related work)
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/2811031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Replace Canvas instance users with CanvasSkia users.
- Rename Canvas2 to Canvas.
- Delete Canvas subclass of CanvasSkia.
This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2825018
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2811032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2860023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not used currently nor do we expect to switch to a horizontal layout anytime soon.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2818030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47425
TEST=All tests pass
Review URL: http://codereview.chromium.org/2867024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also updating another trace sig to SUBSTRING so that it matches a second relevant trace.
BUG=47439
Review URL: http://codereview.chromium.org/2870024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Replace Canvas instance users with CanvasSkia users.
- Rename Canvas2 to Canvas.
- Delete Canvas subclass of CanvasSkia.
This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2825018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now with one line fix to fix the mac build.
BUG=35793,42770
TEST=none
TBR=tony
Review URL: http://codereview.chromium.org/2842025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
field in an auto-filled form.
BUG=47437
TEST=AutoFillManagerTest.GetFieldSuggestionsFormIsAutoFilled
Review URL: http://codereview.chromium.org/2861025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
certificate handles during the execution of the test.
R=wtc
BUG=none
TEST=X509CertificateTest.IntermediateCertificates
Review URL: http://codereview.chromium.org/2809024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
between runs."
This reverts SVN revision 50777.
Review URL: http://codereview.chromium.org/2819024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a bug in extension icon caching where we weren't keeping track of
potential resizing done by ImageLoadingTracker before setting the cached
SkBitmap.
BUG=39494
TEST=Install an extension that includes an icon and uses the experimental
context menu API. You should see the extension's icon in the context menu
next to its top-level item.
Review URL: http://codereview.chromium.org/2867008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2806030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=35793,42770
TEST=none
Review URL: http://codereview.chromium.org/2817026
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2855021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Nuked duplicate code in Browser::addTabWithURL that invoked
wasHidden on the TabContents. This code is already in TabStripModel.
. Moved code for setting visibility of tabcontents from
TabStripModel::AddTabContents to InsertTabContentsAt. Since everything
ends up in InsertTabContentsAt it should be there.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
Review URL: http://codereview.chromium.org/2863021
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/2849025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This new version adds a missing dep to webkit/DEPS.
BUG=44688
TEST=trybots pass
Review URL: http://codereview.chromium.org/2875010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
soon...)
Old flow:
- type username/password. wait for Gaia auth and initial sync (with throbber)
- success! or error.
New flow:
- type username/password. wait for Gaia auth. (with throbber)
- error, or choose your datatypes. you can choose "keep everything synced", which will sync all present and future datatypes, or you can pick one by one.
- wait for initial sync (with throbber)
- success! or error, which brings you back to the gaia auth screen.
Smaller details:
- removed the Customize button from gaia_login.html; further removal of the old native Customize dialog to follow.
- added a logging statement to log if you cancel from the Choose Data Types screen.
- added a pref to the profile for whether you want to "keep everything synced" or choose one by one.
- added a couple more strings. Not final yet, I don't think.
BUG=45869
TEST=Exercise all the different paths through the login flow.
Review URL: http://codereview.chromium.org/2851012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unlike Windows, in Linux, we do not draw the strings in autocomplete popup by ourselves. Instead, we rely on Pango to draw the strings. We only need to pass the text, the attribute, and the width to Pango, and Pango will draw the text correctly (taking care of visual runs for bidi text).
The only small problems are that:
when the UI is RTL, for pure English text, we need to insert LRE mark so that the ending punctuation is drawn correctly as is (not flipped), for example "....(choose location)" will not be drawn as "(....(choose location" in RTL UI.
Also, for some (not all) pure English text, when eliding, the ellipsis appears at the very left of the string in RTL UI. I do not know the reason of such inconsistency, but looks like adding LRE mark to pure English also forces the ellipsis appears at the right of the string.
BUG=43800
TEST=Omnibox should elide long URLs, mixed LTR/RTL text, etc. correctly in both LTR and RTL locales
Review URL: http://codereview.chromium.org/2824027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension wants to inject script into file URLs, since this requires user
opt-in now.
BUG=47180
Review URL: http://codereview.chromium.org/2810028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Older versions of gnome keyring corrupt memory if you fetch too much
data from it. Despite our best efforts, we couldn't come up with a way
to tell if you're using the broken old version so that we could blacklist
it. Instead, we fetch passwords one-by-one, which is slow but tolerable
since we do it on a background thread anyway.
While I'm here, refactor the code a bit to simplify it.
TEST=password manager doesn't crash when using mdm's sample 100 password db
with --password-store=gnome on hardy
Review URL: http://codereview.chromium.org/2838023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Implement BackgroundContentsService::CreateBackgroundContents() to automatically relaunch registered BackgroundContents when the browser starts.
Review URL: http://codereview.chromium.org/2862026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mikhail
TEST=Tree stays green
Review URL: http://codereview.chromium.org/2861024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Introduced in CL http://codereview.chromium.org/2842024
BUG= http://crosbug.com/4208
TEST=Execute OOBE, update screen should check for update and proceed.
Review URL: http://codereview.chromium.org/2871022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to be even more effective. This reduces the size of liblzma_decompress.dylib
by 16kB, and reduces the size of differential updater disk images by 8kB.
BUG=47199
TEST=none
Review URL: http://codereview.chromium.org/2860019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Convert files in .nib format to .xib format.
BUG=38443
TEST=none
Review URL: http://codereview.chromium.org/2854020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2817030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46654
TEST=ExtensionUtilTest.IsSyncableExtension
Review URL: http://codereview.chromium.org/2803022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35793,42770
TEST=none
Review URL: http://codereview.chromium.org/2817026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
mode inside Native Client.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2834023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2857019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Bookamark manager on mac would paste a url into a bookmarks url field, and
then the same paste event would propagate up to the list and paste the page as a
new bookmark. This stops propagation of paste events from the text fields in
the list.
Also, now that the list has spacers for the dynamic rendering, the spacers would
get a 2 pixel hover effect. This removes that. You can see it by slowly moving
from the last bookmark down to below the bottom of the list.
BUG=43442
TEST=NONE
Review URL: http://codereview.chromium.org/2805031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the UI to reflect the latest mocks. Also improve the animation onto the screen.
BUG=34627
TEST=none
Review URL: http://codereview.chromium.org/2822019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=brettw
BUG=47222
TEST=none
Review URL: http://codereview.chromium.org/2859023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Re-compresses all the image data, average savings 1%-4% in filesize.
- Removes the "Created with Adobe Whatever" string from all PNGs, shrinking
the files marginally even when the image data was already optimal.
This shaves more than 100k off of chrome.pak.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2806029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46701
TEST=import Firefox passwords from the menu once the browser is running. Because import is OOP, FF passwords should be imported. All other import processes should still work as advertised.
Review URL: http://codereview.chromium.org/2800026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Nuked duplicate code in Browser::addTabWithURL that invoked
wasHidden on the TabContents. This code is already in TabStripModel.
. Moved code for setting visibility of tabcontents from
TabStripModel::AddTabContents to InsertTabContentsAt. Since everything
ends up in InsertTabContentsAt it should be there.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
Review URL: http://codereview.chromium.org/2863021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45639
TEST=Added unit test, which caused an ASSERT fail before but now passes.
Review URL: http://codereview.chromium.org/2871015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2822028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
2. put all GLES operations in one thread
BUG=none
TEST=dev platform and desktop
Review URL: http://codereview.chromium.org/2836019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bookmark sync tests were not waiting for the BookmarkModel object in each Profile to load before running tests. Adding a call to ui_test_utils::WaitForBookmarkModelToLoad() to LiveBookmarksSyncTest::SetupClients().
Also including fixes for a couple of lint errors.
BUG=47361
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/2802019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/2828023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2831023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50743 0039d316-1c4b-4281-b951-d872f2087c98
|