summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* FBTF: Remove unneeded headers from base/ (part 7)thestig@chromium.org2010-08-2781-139/+125
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
* A follow-up to r44678.wtc@chromium.org2010-08-271-3/+0
| | | | | | | | | | | | Remove the unused IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_INFO_BAR message. R=jcivelli BUG=27125 TEST=No build errors. Review URL: http://codereview.chromium.org/3262003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57736 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57265 - Disable page_cycler_database on Mac. It looks like the perf ↵chase@chromium.org2010-08-271-3/+1
| | | | | | | | | | | | | | | | | bots are having some problems, and on Mac, those problems show up the most when running this test suite. TEST=none BUG=53140 Review URL: http://codereview.chromium.org/3119042 TBR=dumi@chromium.org Review URL: http://codereview.chromium.org/3243006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57735 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57270 - Disable page_cycler_database everywhere.chase@chromium.org2010-08-271-2/+3
| | | | | | | | | | | | | TEST=none BUG=53140 TBR=rohitrao Review URL: http://codereview.chromium.org/3191025 TBR=dumi@chromium.org Review URL: http://codereview.chromium.org/3282002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57734 0039d316-1c4b-4281-b951-d872f2087c98
* Add a helper class that keeps per-profile information for FileSystem APIkinuko@chromium.org2010-08-2713-5/+289
| | | | | | | | | | | | | | | Reapplying with the correct constructor order in resource_message_filter. The original one was: http://codereview.chromium.org/3028033 Reverted due to rebase/merge failure: http://codereview.chromium.org/3243005 BUG=32277 TEST=FileSystemHostContextTest TBR=dmazzoni Review URL: http://codereview.chromium.org/3244002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57733 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move code from headers into cc files.erg@google.com2010-08-2726-101/+219
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3219002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57732 0039d316-1c4b-4281-b951-d872f2087c98
* New pyauto hook (wait until extension has been installed) and test.alyssad@google.com2010-08-272-0/+32
| | | | | | | | The hook waits until a downloaded .crx file has been installed. The test is for downloading a theme. Review URL: http://codereview.chromium.org/3152045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57731 0039d316-1c4b-4281-b951-d872f2087c98
* Update mouse support for chromoting host.garykac@google.com2010-08-275-18/+121
| | | | | | | | BUG=none TESTING=remoting unittests + run host/client Review URL: http://codereview.chromium.org/3187021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57730 0039d316-1c4b-4281-b951-d872f2087c98
* Updates suppression do to refactoring code.sky@chromium.org2010-08-271-17/+1
| | | | | | | | | BUG=52834, 52900 TEST=none Review URL: http://codereview.chromium.org/3213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57729 0039d316-1c4b-4281-b951-d872f2087c98
* Fix official build.evan@chromium.org2010-08-272-3/+3
| | | | | | | | | I changed the type of this function, but the trybots didn't catch it because it's in an offical-only ifdef. Review URL: http://codereview.chromium.org/3236006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57728 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57701 - Reland 3149027.chase@chromium.org2010-08-276-153/+13
| | | | | | | | | | | Review URL: http://codereview.chromium.org/3236004 Broke ChromiumOS browser_tests in ExtensionApiTest.Tts. TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/3224003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57727 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the focus on post reload warning constrained window.jcivelli@chromium.org2010-08-272-5/+2
| | | | | | | | | | | The initial focus was not set to the right view. BUG=41926 TEST=Navigate to a page with a post. Reload the page. A constrained window with a warning that it is going to repost. The OK button should be focused. Pressing TAB should move the button to the next button. Pressing ESC should close the dialog. Review URL: http://codereview.chromium.org/3238004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57726 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor version-getting info into a chrome::VersionInfo object.evan@chromium.org2010-08-2731-252/+253
| | | | | | | | | | | | | | | I was trying to replace wstring usage in base::FileVersionInfo, but that class is rather Windows-specific with strange fields like "private_build()" where the value and encoding aren't clear. 95% of the users of FileVersionInfo actually just care about the current Chrome version, so we can provide a much simpler interface for them. We still use FileVersionInfo for retrieving information from e.g. plugin DLLs, but in those cases the usage is clearer. Review URL: http://codereview.chromium.org/3135028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit from 66079 to 66240.tony@chromium.org2010-08-271-1/+1
| | | | | | | | TBR=yuzo Review URL: http://codereview.chromium.org/3279001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57724 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from the search engine management APIsstuartmorgan@chromium.org2010-08-2718-72/+103
| | | | | | | | | | | This stops short of doing a wstring -> string16 conversion in template_url and template_url_model since that would ripple through the omnibox and auto-search-detection code, making the change much larger and more complicated. BUG=None TEST=None Review URL: http://codereview.chromium.org/3245002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57723 0039d316-1c4b-4281-b951-d872f2087c98
* Seccomp sandbox: Add a policy flag to allow file namespace access to be disabledmseaborn@chromium.org2010-08-276-14/+103
| | | | | | | | | | | | | | | | This allows file namespace access to be turned on for the purpose of testing, and we use this in some of the tests, but it is disabled by default. This synchronises the Chromium copy with r88 in the non-Chromium copy of seccomp-sandbox. BUG=none TEST=make test Review URL: http://codereview.chromium.org/3248002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57722 0039d316-1c4b-4281-b951-d872f2087c98
* Added tested and corrected accelerometer support for the following MacBook / ↵hans@chromium.org2010-08-272-47/+69
| | | | | | | | | | | | | | | | | | | | | | | MacBook Pro models: - MacBookPro2,2 - MacBookPro3,1 - MacBookPro4,1 - MacBookPro5,1 - MacBookPro6,2 - MacBookPro7,1 This patch fixes the axis inversion problems on these. Landing for Leandro Gracia Gil <leandrogracia@google.com>. Original code review: http://codereview.chromium.org/3177035/show BUG=44654 TEST=None Review URL: http://codereview.chromium.org/3275002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57721 0039d316-1c4b-4281-b951-d872f2087c98
* Remove keepalive code from BackgroundContentsServiceatwilson@chromium.org2010-08-272-12/+0
| | | | | | | | | BUG=53602 TEST=Updated BackgroundContentsService unittests Review URL: http://codereview.chromium.org/3234003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57720 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DeviceOrientationProviderTest.hans@chromium.org2010-08-275-92/+95
| | | | | | | | | | | | | | | | There was a race that could potentially result in a reference to Provider being left after a test finished, causing the next test to fail. The test must not assume that the orientation update notification is posted on the message loop right away, but rather wait for it. I was not able to reproduce the bug, but I believe this should fix it. BUG=53468 TEST=unit_tests --gtest_filter=DeviceOrientationProviderTest* Review URL: http://codereview.chromium.org/3231003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57719 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57715 - Add a helper class that keeps per-profile information for ↵dmazzoni@chromium.org2010-08-2713-292/+8
| | | | | | | | | | | | | | FileSystem API BUG=32277 TEST=FileSystemHostContextTest Review URL: http://codereview.chromium.org/3028033 TBR=kinuko@chromium.org Review URL: http://codereview.chromium.org/3243005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57718 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt at landing http://codereview.chromium.org/3214005tommi@chromium.org2010-08-274-112/+183
| | | | | | | | | | | Factoring BuildUserAgent out to a separate lib for GCF can use it. TEST=There should be no functional change. If anything breaks it should be the build. BUG=50788 Review URL: http://codereview.chromium.org/3225003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57717 0039d316-1c4b-4281-b951-d872f2087c98
* libvpx roll to icc built libs for mac and linux (ia32/x64 targets).tomfinegan@google.com2010-08-271-1/+1
| | | | | | | | | BUG=none TEST=linux ia32/x64 and mac targets should show faster WebM decode Review URL: http://codereview.chromium.org/3224002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57716 0039d316-1c4b-4281-b951-d872f2087c98
* Add a helper class that keeps per-profile information for FileSystem APIkinuko@chromium.org2010-08-2713-8/+292
| | | | | | | | | BUG=32277 TEST=FileSystemHostContextTest Review URL: http://codereview.chromium.org/3028033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix references to pyauto doc urlsnirnimesh@chromium.org2010-08-272-2/+2
| | | | | | | | dev.chromium.org was restructured recently. Review URL: http://codereview.chromium.org/3229001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57714 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BackgroundModeManager by default for M7, and add an ↵atwilson@chromium.org2010-08-275-15/+25
| | | | | | | | | | | | | | | --enable-background-mode command line flag to enable it. Also remove related preferences items if the --enable-background-mode flag is not passed. BUG=53522 TEST=BackgroundModeManager unit tests pass, run without flag and look at preferences dialog to make sure preferences are not there, launch chrome with --keep-alive-for-test flag, see that no status icon appears Review URL: http://codereview.chromium.org/3219001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57713 0039d316-1c4b-4281-b951-d872f2087c98
* Call side tabs "Side Tabs" in labs.thakis@chromium.org2010-08-272-8/+8
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/3241004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57712 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. minor cleanup.pkasting@chromium.org2010-08-274-34/+15
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3107041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57710 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the FAILS prefix on the VerifyHistoryLength3 test as the fix for ↵ananta@chromium.org2010-08-271-3/+1
| | | | | | | | | | | | this test has been checked in. Bug=50931 Review URL: http://codereview.chromium.org/3270002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57709 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed the native_client permission to nativeClient, for consistency with ↵cbiffle@google.com2010-08-272-2/+2
| | | | | | | | | | the other permissions. BUG=52753 TEST= nacl_enabled permissions test Review URL: http://codereview.chromium.org/3181043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57708 0039d316-1c4b-4281-b951-d872f2087c98
* Support sending BlobData to browser process. Also support sending UploadDatajianli@chromium.org2010-08-2738-9/+1078
| | | | | | | | | | | with the blob info to browser process. BUG=none TEST=none Review URL: http://codereview.chromium.org/3108042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57707 0039d316-1c4b-4281-b951-d872f2087c98
* Next step integrating the HistoryQuickProvider: Implement index ↵mrossetti@chromium.org2010-08-275-11/+480
| | | | | | | | | | | | | initialization and population and provide unit test with test data. Eliminated DCHECKs which were surrounding 'release' code and causing release failures. [Previously reviewed as: http://codereview.chromium.org/3138006.] BUG=None TEST=None Review URL: http://codereview.chromium.org/3263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57706 0039d316-1c4b-4281-b951-d872f2087c98
* Fix official Linux build.evan@chromium.org2010-08-271-1/+3
| | | | | | | | | | When I moved where version info generation lives, I broke some code that had an implicit dependency. This change makes the dependency explicit. Review URL: http://codereview.chromium.org/3225002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57705 0039d316-1c4b-4281-b951-d872f2087c98
* Disable test on Linux after it timed out once.dmazzoni@chromium.org2010-08-271-1/+8
| | | | | | | | | | BUG=53607 TEST=Disables TemplateURLModelTest.MAYBE_Load on Linux TBR=levin@chromium.org Review URL: http://codereview.chromium.org/3243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57704 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 3149027.dtseng@chromium.org2010-08-276-13/+153
| | | | | | Review URL: http://codereview.chromium.org/3236004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57701 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land. Fixed previous errors.dimich@chromium.org2010-08-277-1/+240
| | | | | | | | | | | | | | | | | | | | | | | | | | Implement OSX version for "Start on Login" for background-enabled extensions. When user installs first background-enabled extension we set Chrome to be a hidden "Login Item", and when user uninstalls the last one, we remove Chrome from the "Login Items List". Login Items are the apps that are listed in Systempreferences->Accounts->Login Items, or which have a "Open on Login" check for their Dock icon. Since we manipulate the user-faced UI item here, we try to do it in a way that will likely not interfere with user settings. Most typically, users do not use 'hidden' property, so if we ever encounter setting w/o this property, we won't override. Also there is a hidden preference used to remember the fact that Chrome changed the settings earlier - to avoid override on uninstall of the last persistent app in opposite case. Using the same bit that user can manipulate separately and perhaps even knows about is beneficial since it provides for unified place to "start Chrome on Login" and reduces confusion. Implementation for Login Items List access uses LSSharedFileList API that is available starting 10.5, which I think is our minimal supported version of OSX. BUG=43382 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57569 Reverted Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57614 Reverted Review URL: http://codereview.chromium.org/3163029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57699 0039d316-1c4b-4281-b951-d872f2087c98
* Separate the "search host to TemplateURL" functionality out of the ↵levin@chromium.org2010-08-2711-114/+600
| | | | | | | | | | | | | | | | TemplateURLModel. This separation allows for a smaller surface area which can be made read-only thread-safe so that the question "IsSearchProviderInstalled" can be answered from the I/O thread. The method to that answer question is not in this patch, but this is the underlying mechanics that is necessary. BUG=38475 TEST=unit_test --gtest_filter=Keyword* or Template* or SearchHost* Review URL: http://codereview.chromium.org/3247003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57698 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: For an AppCache, now we only update thervargas@google.com2010-08-2711-33/+189
| | | | | | | | | | | | | | | | | | | | | | | | LRU list when an entry is created. This means that we don't update the list anymore when an entry is accessed, even if we are writing to the entry. The general idea is that now we should be able to open an AppCache and read from it without modifying the contents of the cache, so that if the browser crashes, we won't find "dirty" entries to discard. By minimizing writes to the LRU list, we reduce the chances that the list will get corrupt beyond the point where we cannot trust it anymore if the whole system crashes (and not just the browser). BUG=51870 TEST=net_unittests Review URL: http://codereview.chromium.org/3186032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57697 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57692 - Factoring BuildUserAgent out to a separate lib for GCF can ↵dmazzoni@chromium.org2010-08-274-173/+106
| | | | | | | | | | | | | | use it. TEST=There should be no functional change. If anything breaks it should be the build. BUG=50788 Review URL: http://codereview.chromium.org/3214005 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/3275001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57696 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for delegated kerberos tickets to Negotiate authentication.cbentzel@chromium.org2010-08-2717-66/+177
| | | | | | | | | | | This is controlled by the --auth-negotiate-delegate-whitelist command line. By default no servers are delegated to. BUG=50076 TEST=net_unittests, go to an IIS server specified in --auth-negotiate-delegate-whitelist and see if this works correctly. Review URL: http://codereview.chromium.org/3155046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57695 0039d316-1c4b-4281-b951-d872f2087c98
* Change, unify, and specify ordering of cookies from CookieMonster.rdsmith@chromium.org2010-08-2766-283/+290
| | | | | | | | | | | | | | Affected interfaces: * GetCookiesWithOptions (used by HTTP requests) * GetAllCookiesForURL (used by extensions and Cookies UI) * GetAllCookies (used by Cookies UI). BUG=8850 (indirectly) TEST=Standard cookie monster tests, unit_tests::CookiesTreeModelTest.OriginOrdering, browser_tests::ExtensionApiTest.Cookies Review URL: http://codereview.chromium.org/3170034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57694 0039d316-1c4b-4281-b951-d872f2087c98
* fix browsertest failureerikkay@chromium.org2010-08-272-2/+2
| | | | | | | | | | TBR=skerner BUG=none TEST=ExtensionBrowserTest.PropertyAppIsInstalled Review URL: http://codereview.chromium.org/3273001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57693 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring BuildUserAgent out to a separate lib for GCF can use it.tommi@chromium.org2010-08-274-106/+173
| | | | | | | | | TEST=There should be no functional change. If anything breaks it should be the build. BUG=50788 Review URL: http://codereview.chromium.org/3214005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57692 0039d316-1c4b-4281-b951-d872f2087c98
* Allow SSL_SecurityStatus, SSL_GetChannelInfo, andwtc@chromium.org2010-08-275-3/+178
| | | | | | | | | | | | | | SSL_HandshakeNegotiatedExtension to be called as soon as a false start handshake is done. R=agl BUG=53366 TEST=Visit any HTTPS sites, especially sites with certificate errors. The SSL InfoBubble should not say "your connection to www.example.com is not encrypted." Review URL: http://codereview.chromium.org/3233001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57691 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the branch name updated by sync-webkit-git.py to be overriden using thelevin@chromium.org2010-08-271-12/+30
| | | | | | | | | | | | | | | | git config in the WebKit directory. My scenario is that I have the same git repository (using git-new-workdir) under two different chromium enlistments. (Yes, even with git, I find it useful to have more than one enlistment at times.) BUG=None TEST=Did a run of the tool without the config set and with it set to an existing branch and a non-existing branch. Review URL: http://codereview.chromium.org/3239002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57690 0039d316-1c4b-4281-b951-d872f2087c98
* Implements preference setting to allow enabling/disabling theatwilson@chromium.org2010-08-276-54/+256
| | | | | | | | | | | | | | | | | BackgroundModeManager, to match the gtk/windows versions. Checkbox sets/clears the kBackgroundModeEnabled preference. Preferences.xib change: Added new section to under-the-hood, with a checkbox to enable/disable BackgroundModeManager (which controls launch-on-login behavior), as well as a link to the help center section for this feature. BUG=53173 TEST=Adding BackgroundModeManagerTest.* in separate BackgroundModeManager CL. Review URL: http://codereview.chromium.org/3199021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57689 0039d316-1c4b-4281-b951-d872f2087c98
* Download code cleanup: share most of the code between DownloadFile and SaveFile.phajdan.jr@chromium.org2010-08-2710-354/+460
| | | | | | | | | | | | | I'm not really happy about BaseFile, but removing the remaining differences will require changes to DownloadFileManager and SaveFileManager. I prefer to do that in small steps. TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3164039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57688 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Continue moving test automation code out of AutomationProvider.phajdan.jr@chromium.org2010-08-2710-376/+396
| | | | | | | | | TEST=ui_tests, chrome_frame_tests BUG=52097 Review URL: http://codereview.chromium.org/3201019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57687 0039d316-1c4b-4281-b951-d872f2087c98
* Use new libcros ownership API enumscmasone@google.com2010-08-271-2/+2
| | | | | | | | | BUG=None TEST=compile with rolled cros_deps/DEPS Review URL: http://codereview.chromium.org/3122043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57686 0039d316-1c4b-4281-b951-d872f2087c98
* Modify search engine dialog to only appear if the user does not have an ↵mirandac@chromium.org2010-08-271-2/+7
| | | | | | | | | | | | | existing preferences file. LGTM from Glen in http://codereview.chromium.org/3232001/show for patch to 472 branch. BUG=53485 TEST=search engine dialog works and appears only when user does not have a previously existing user data directory. If user has already run Chrome and set up a user data directory, dialog should not appear, and search engines should be silently imported (in organic builds). Review URL: http://codereview.chromium.org/3242004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57685 0039d316-1c4b-4281-b951-d872f2087c98
* Enable device orientation by default.hans@chromium.org2010-08-278-74/+7
| | | | | | | | | | | | Enable device orientation by default. Replace the --enable-device-orientation command-line flag with a --disable-device-orientation flag. BUG=44654 TEST=browser_tests --gtest_filter="DeviceOrientationBrowserTest.*" Review URL: http://codereview.chromium.org/3136038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57684 0039d316-1c4b-4281-b951-d872f2087c98