| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3176026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the unused IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_INFO_BAR
message.
R=jcivelli
BUG=27125
TEST=No build errors.
Review URL: http://codereview.chromium.org/3262003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bots are
having some problems, and on Mac, those problems show up the most when
running this test suite.
TEST=none
BUG=53140
Review URL: http://codereview.chromium.org/3119042
TBR=dumi@chromium.org
Review URL: http://codereview.chromium.org/3243006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=53140
TBR=rohitrao
Review URL: http://codereview.chromium.org/3191025
TBR=dumi@chromium.org
Review URL: http://codereview.chromium.org/3282002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reapplying with the correct constructor order in resource_message_filter.
The original one was: http://codereview.chromium.org/3028033
Reverted due to rebase/merge failure: http://codereview.chromium.org/3243005
BUG=32277
TEST=FileSystemHostContextTest
TBR=dmazzoni
Review URL: http://codereview.chromium.org/3244002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3219002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The hook waits until a downloaded .crx file has been installed. The test is for downloading a theme.
Review URL: http://codereview.chromium.org/3152045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TESTING=remoting unittests + run host/client
Review URL: http://codereview.chromium.org/3187021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52834, 52900
TEST=none
Review URL: http://codereview.chromium.org/3213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I changed the type of this function, but the trybots didn't catch
it because it's in an offical-only ifdef.
Review URL: http://codereview.chromium.org/3236006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3236004
Broke ChromiumOS browser_tests in ExtensionApiTest.Tts.
TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/3224003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The initial focus was not set to the right view.
BUG=41926
TEST=Navigate to a page with a post. Reload the page. A constrained window with a warning that it is going to repost. The OK button should be focused. Pressing TAB should move the button to the next button. Pressing ESC should close the dialog.
Review URL: http://codereview.chromium.org/3238004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was trying to replace wstring usage in base::FileVersionInfo, but
that class is rather Windows-specific with strange fields like
"private_build()" where the value and encoding aren't clear. 95%
of the users of FileVersionInfo actually just care about the current
Chrome version, so we can provide a much simpler interface for them.
We still use FileVersionInfo for retrieving information from e.g.
plugin DLLs, but in those cases the usage is clearer.
Review URL: http://codereview.chromium.org/3135028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yuzo
Review URL: http://codereview.chromium.org/3279001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This stops short of doing a wstring -> string16 conversion in template_url and template_url_model since that would ripple through the omnibox and auto-search-detection code, making the change much larger and more complicated.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3245002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows file namespace access to be turned on for the purpose of
testing, and we use this in some of the tests, but it is disabled by
default.
This synchronises the Chromium copy with r88 in the non-Chromium copy of
seccomp-sandbox.
BUG=none
TEST=make test
Review URL: http://codereview.chromium.org/3248002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MacBook Pro models:
- MacBookPro2,2
- MacBookPro3,1
- MacBookPro4,1
- MacBookPro5,1
- MacBookPro6,2
- MacBookPro7,1
This patch fixes the axis inversion problems on these.
Landing for Leandro Gracia Gil <leandrogracia@google.com>.
Original code review: http://codereview.chromium.org/3177035/show
BUG=44654
TEST=None
Review URL: http://codereview.chromium.org/3275002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53602
TEST=Updated BackgroundContentsService unittests
Review URL: http://codereview.chromium.org/3234003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was a race that could potentially result in a reference to Provider being
left after a test finished, causing the next test to fail. The test must not
assume that the orientation update notification is posted on the message loop
right away, but rather wait for it.
I was not able to reproduce the bug, but I believe this should fix it.
BUG=53468
TEST=unit_tests --gtest_filter=DeviceOrientationProviderTest*
Review URL: http://codereview.chromium.org/3231003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileSystem API
BUG=32277
TEST=FileSystemHostContextTest
Review URL: http://codereview.chromium.org/3028033
TBR=kinuko@chromium.org
Review URL: http://codereview.chromium.org/3243005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Factoring BuildUserAgent out to a separate lib for GCF can use it.
TEST=There should be no functional change. If anything breaks it should be the build.
BUG=50788
Review URL: http://codereview.chromium.org/3225003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=linux ia32/x64 and mac targets should show faster WebM decode
Review URL: http://codereview.chromium.org/3224002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32277
TEST=FileSystemHostContextTest
Review URL: http://codereview.chromium.org/3028033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
dev.chromium.org was restructured recently.
Review URL: http://codereview.chromium.org/3229001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--enable-background-mode
command line flag to enable it.
Also remove related preferences items if the --enable-background-mode flag is not passed.
BUG=53522
TEST=BackgroundModeManager unit tests pass, run without flag and look at preferences dialog to make sure preferences are not there, launch chrome with --keep-alive-for-test flag, see that no status icon appears
Review URL: http://codereview.chromium.org/3219001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=TEST=none
Review URL: http://codereview.chromium.org/3241004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3107041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
this test
has been checked in.
Bug=50931
Review URL: http://codereview.chromium.org/3270002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the other permissions.
BUG=52753
TEST= nacl_enabled permissions test
Review URL: http://codereview.chromium.org/3181043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with the blob info to browser process.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3108042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initialization and population and provide unit test with test data. Eliminated DCHECKs which were surrounding 'release' code and causing release failures.
[Previously reviewed as: http://codereview.chromium.org/3138006.]
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When I moved where version info generation lives, I broke some
code that had an implicit dependency. This change makes the
dependency explicit.
Review URL: http://codereview.chromium.org/3225002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=53607
TEST=Disables TemplateURLModelTest.MAYBE_Load on Linux
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/3243004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3236004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement OSX version for "Start on Login" for background-enabled extensions.
When user installs first background-enabled extension we set Chrome to be a hidden "Login Item", and when user uninstalls the last one, we remove Chrome from the "Login Items List".
Login Items are the apps that are listed in Systempreferences->Accounts->Login Items, or which have a "Open on Login" check for their Dock icon.
Since we manipulate the user-faced UI item here, we try to do it in a way that will likely not interfere with user settings. Most typically, users do not use 'hidden' property, so if we ever encounter setting w/o this property, we won't override. Also there is a hidden preference used to remember the fact that Chrome changed the settings earlier - to avoid override on uninstall of the last persistent app in opposite case.
Using the same bit that user can manipulate separately and perhaps even knows about is beneficial since it provides for unified place to "start Chrome on Login" and reduces confusion.
Implementation for Login Items List access uses LSSharedFileList API that is available starting 10.5, which I think is our minimal supported version of OSX.
BUG=43382
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57569
Reverted
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57614
Reverted
Review URL: http://codereview.chromium.org/3163029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TemplateURLModel.
This separation allows for a smaller surface area which can be made read-only
thread-safe so that the question "IsSearchProviderInstalled" can be answered
from the I/O thread. The method to that answer question is not in this patch,
but this is the underlying mechanics that is necessary.
BUG=38475
TEST=unit_test --gtest_filter=Keyword* or Template* or SearchHost*
Review URL: http://codereview.chromium.org/3247003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LRU list when an entry is created. This means that
we don't update the list anymore when an entry is
accessed, even if we are writing to the entry.
The general idea is that now we should be able to
open an AppCache and read from it without modifying
the contents of the cache, so that if the browser
crashes, we won't find "dirty" entries to discard.
By minimizing writes to the LRU list, we reduce the
chances that the list will get corrupt beyond the
point where we cannot trust it anymore if the whole
system crashes (and not just the browser).
BUG=51870
TEST=net_unittests
Review URL: http://codereview.chromium.org/3186032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use it.
TEST=There should be no functional change. If anything breaks it should be the build.
BUG=50788
Review URL: http://codereview.chromium.org/3214005
TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/3275001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is controlled by the --auth-negotiate-delegate-whitelist command line. By default no servers are delegated to.
BUG=50076
TEST=net_unittests, go to an IIS server specified in --auth-negotiate-delegate-whitelist and see if this works correctly.
Review URL: http://codereview.chromium.org/3155046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Affected interfaces:
* GetCookiesWithOptions (used by HTTP requests)
* GetAllCookiesForURL (used by extensions and Cookies UI)
* GetAllCookies (used by Cookies UI).
BUG=8850 (indirectly)
TEST=Standard cookie monster tests, unit_tests::CookiesTreeModelTest.OriginOrdering, browser_tests::ExtensionApiTest.Cookies
Review URL: http://codereview.chromium.org/3170034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=skerner
BUG=none
TEST=ExtensionBrowserTest.PropertyAppIsInstalled
Review URL: http://codereview.chromium.org/3273001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=There should be no functional change. If anything breaks it should be the build.
BUG=50788
Review URL: http://codereview.chromium.org/3214005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SSL_HandshakeNegotiatedExtension to be called as soon as a false
start handshake is done.
R=agl
BUG=53366
TEST=Visit any HTTPS sites, especially sites with certificate
errors. The SSL InfoBubble should not say "your connection to
www.example.com is not encrypted."
Review URL: http://codereview.chromium.org/3233001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
git config in the WebKit directory.
My scenario is that I have the same git repository (using git-new-workdir) under
two different chromium enlistments. (Yes, even with git, I find it useful to
have more than one enlistment at times.)
BUG=None
TEST=Did a run of the tool without the config set and with it set to an
existing branch and a non-existing branch.
Review URL: http://codereview.chromium.org/3239002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BackgroundModeManager, to match the gtk/windows versions. Checkbox
sets/clears the kBackgroundModeEnabled preference.
Preferences.xib change: Added new section to under-the-hood,
with a checkbox to enable/disable BackgroundModeManager (which
controls launch-on-login behavior), as well as a link to the help
center section for this feature.
BUG=53173
TEST=Adding BackgroundModeManagerTest.* in separate BackgroundModeManager CL.
Review URL: http://codereview.chromium.org/3199021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm not really happy about BaseFile, but removing the remaining differences
will require changes to DownloadFileManager and SaveFileManager.
I prefer to do that in small steps.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3164039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=ui_tests, chrome_frame_tests
BUG=52097
Review URL: http://codereview.chromium.org/3201019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compile with rolled cros_deps/DEPS
Review URL: http://codereview.chromium.org/3122043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
existing preferences file.
LGTM from Glen in http://codereview.chromium.org/3232001/show for patch to 472 branch.
BUG=53485
TEST=search engine dialog works and appears only when user does not have a previously existing user data directory. If user has already run Chrome and set up a user data directory, dialog should not appear, and search engines should be silently imported (in organic builds).
Review URL: http://codereview.chromium.org/3242004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable device orientation by default. Replace the --enable-device-orientation
command-line flag with a --disable-device-orientation flag.
BUG=44654
TEST=browser_tests --gtest_filter="DeviceOrientationBrowserTest.*"
Review URL: http://codereview.chromium.org/3136038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57684 0039d316-1c4b-4281-b951-d872f2087c98
|