summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Separate out most view creation from WebContents. This adds a new ↵brettw@google.com2008-10-1721-205/+363
| | | | | | | | sub-delegate to RenderViewHostDelegate which is implemented by WebContentsView. I did a lot of plumbing and moving around as a result. Review URL: http://codereview.chromium.org/6608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3527 0039d316-1c4b-4281-b951-d872f2087c98
* Removes an unneeded override.sky@google.com2008-10-172-7/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3526 0039d316-1c4b-4281-b951-d872f2087c98
* Initial Mac implementation of SSL. Requires the full-duplex socket ↵avi@google.com2008-10-175-21/+774
| | | | | | | | introduced with the Linux/NSS implementation of SSL. Review URL: http://codereview.chromium.org/7090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3525 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out writing to the pasteboard. Ends up calling NSAttributedString ↵pinkerton@google.com2008-10-171-0/+10
| | | | | | | | initWithHTML which tries to load the system WebKit...and then EPIC FAIL. Helps the layout tests not time out so much until we think about this more. Review URL: http://codereview.chromium.org/7623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3524 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaselining LayoutTests/css3/transform-value-types.html to deal with ↵olehougaard@google.com2008-10-173-1/+35
| | | | | | | | implementation dependent printing of constructors and prototypes. Review URL: http://codereview.chromium.org/7620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3523 0039d316-1c4b-4281-b951-d872f2087c98
* Use latest V8 version containing array assignment bug fix.ager@google.com2008-10-171-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3519 0039d316-1c4b-4281-b951-d872f2087c98
* Skip 'port' when checking webkit deps because it'stc@google.com2008-10-171-2/+2
| | | | | | | in the webkit style and does not include full paths. Review URL: http://codereview.chromium.org/7616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3518 0039d316-1c4b-4281-b951-d872f2087c98
* Run GRIT on all platforms.tc@google.com2008-10-172-27/+29
| | | | | | | | | | | | | * RCFLAGS may not exist in SCons environment. Use empty list if absent. * Accumulate generated files in grit_files and run RES on win32 only. Patch by Seo Sanghyeon <sanxiyn@gmail.com> originally from http://codereview.chromium.org/7247/show Review URL: http://codereview.chromium.org/7614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the check deps to allow npruntime related headers.tc@google.com2008-10-171-1/+7
| | | | | | | TBR=pkasting Review URL: http://codereview.chromium.org/7613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3515 0039d316-1c4b-4281-b951-d872f2087c98
* Start compiling a bunch of *Chromium.cpp files in our port ontc@google.com2008-10-179-34/+29
| | | | | | | | | linux. More will come once we stop using PLATFORM_GTK_. Review URL: http://codereview.chromium.org/7606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3513 0039d316-1c4b-4281-b951-d872f2087c98
* The translation lead requested that this sentence be a singletc@google.com2008-10-174-28/+43
| | | | | | | | | string, otherwise it will likely be grammatically incorrect. This is a hack until http://crbug.com/3295 is implemented. Review URL: http://codereview.chromium.org/7396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix interactive UI tests. ViewEventTestBase's View was using a layout ↵ben@chromium.org2008-10-171-1/+5
| | | | | | | | | manager incompatible with a non-RootView, causing coordinates to get screwed up. TBR=sky Review URL: http://codereview.chromium.org/7471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3507 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for a possible assertion caused by r3407.hbono@chromium.org2008-10-171-1/+2
| | | | | | | | When a user opens a "Fonts and Languages" dialog (through [Options] -> [Change Font and Language Settings]) and presses its "OK" button without changing anything, the debug build of Chromium raises an assert exception because the LanguagePageView::SaveChanges() function reads the value of an initialized member variable |LanguagePageView::spellcheck_language_index_selected_|. To prevent this possible assertion, this change initializes the member variable |LanguagePageView::spellcheck_language_index_selected_| to -1 in the constructor of the LanguagePageView class. Review URL: http://codereview.chromium.org/7387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3506 0039d316-1c4b-4281-b951-d872f2087c98
* Add DirectoryWatcher tests to SConscript.evanm@google.com2008-10-171-0/+2
| | | | | | | Review URL: http://codereview.chromium.org/7470 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3505 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DirectoryWatcher class, allowing objects to be notified wheneverevanm@google.com2008-10-175-7/+321
| | | | | | | | a directory's contents change. Review URL: http://codereview.chromium.org/6377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3504 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple more build errors, one in glue and one (the last one!) in WebCore.pkasting@chromium.org2008-10-172-2/+2
| | | | | | Review URL: http://codereview.chromium.org/7467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3502 0039d316-1c4b-4281-b951-d872f2087c98
* fix build, UINT is not defined on linux and we don't usetc@google.com2008-10-171-1/+1
| | | | | | | | | | | this variable in the first place. TBR=evan Review URL: http://codereview.chromium.org/7609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3500 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing file from r3496.aa@google.com2008-10-171-0/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3499 0039d316-1c4b-4281-b951-d872f2087c98
* These files now compile on Linux so they don't need to be disabled.erg@google.com2008-10-171-34/+0
| | | | | | | | Review URL: http://codereview.chromium.org/7450 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3498 0039d316-1c4b-4281-b951-d872f2087c98
* Currently, there is no way to access or modify the upload data and/or completedarin@google.com2008-10-173-6/+125
| | | | | | | | | | | | | | | | | | | | | | | list of request headers associated with a WebRequest object. The intent is to access this information from WebViewDelegate::DispositionForNavigationAction(). Remove the HasFormData() method that checked for upload (form) data on the history item. The HasFormData() method is not currently being called from anywhere, so changes elsewhere are not required. Add HasUploadData(), GetUploadData() and SetUploadData() methods to test, get and set the underlying request upload data as a net::UploadData object. Add GetHttpHeaders() and SetHttpHeaders() methods to get and set all request headers using a map of values. Add the SetHttpHeaderValue() method to set the value for a particular request header. Patch by Marshall Greenblatt R=darin git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3497 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a bit of Greasemonkey support hidden behind the --enable-greasemonkey ↵aa@google.com2008-10-1619-18/+389
| | | | | | | | | | | | | flag. Implementation follows the pattern of the visited links system. Things still to be done: - stop using a hardcoded script directory - watch script directory and update shared memory when necessary - move file io to background thread - support for @include patterns -- now, all scripts are applied to all pages Review URL: http://codereview.chromium.org/7254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3496 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-16362-3531/+3402
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Fix weird NC painting in classic mode by removing an apparently unnecessary ↵ben@chromium.org2008-10-161-4/+1
| | | | | | | | | window style. http://crbug.com/3264 Review URL: http://codereview.chromium.org/7442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3494 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing build: GetViewContainer changed name from under me. :)finnur@google.com2008-10-161-2/+2
| | | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/7464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in downloading files (issue 3423).finnur@google.com2008-10-161-0/+9
| | | | | | | | | | | | | | | | | | | | | | | I was finally able to reproduce a problem where we would crash when clicking Save on the Download Tab (it would also crash during animation of the items on the download shelf after switching away from the tab downloading). The reason for the crash is that if the controls on the download shelf have not been laid out once (before switching to a tab that doesn't have a download shelf), then we'll crash inside NativeControlContainer ctor when it tries to ValidateNativeControl() (it walks up the parent hierarchy trying to find the ViewContainer and ends up dereferencing a NULL pointer). This was reviewed by jcampan as http://codereview.chromium.org/7446 I had to recreate the changelist before submitting (long story). Review URL: http://codereview.chromium.org/7604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3492 0039d316-1c4b-4281-b951-d872f2087c98
* Fix windows build bustage from unbalanced pragma macros.tc@google.com2008-10-161-1/+2
| | | | | | | TBR=evan Review URL: http://codereview.chromium.org/7455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3491 0039d316-1c4b-4281-b951-d872f2087c98
* Replace MSVC pragmas with the macro. Also adds two filestc@google.com2008-10-1652-112/+209
| | | | | | | | | | | | from webkit/glue to the build rule. Patch from icefox (TorchMobile) http://codereview.chromium.org/7418 Review URL: http://codereview.chromium.org/7454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3490 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes bug http://code.google.com/p/chromium/issues/detail?id=2952, ↵ananta@chromium.org2008-10-162-2/+3
| | | | | | | | | | | | | | | | | | | which was a plugin layout test failure (return-error-from-new-stream-doesnt-invoke-destroy-stream.html) The test fails because it assumes that if an error is returned from NPP_NewStream, NPP_URLNotify is still invoked thus sending a notification to the plugin. The plugin implementation in webkit does this. We emulate this behavior. Bug=2952 R=jam Review URL: http://codereview.chromium.org/7443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3489 0039d316-1c4b-4281-b951-d872f2087c98
* fix the scons build that broke when the hunspell dictionarytc@google.com2008-10-161-1/+1
| | | | | | | | | | | was renamed TBR=sidchat Review URL: http://codereview.chromium.org/7399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3487 0039d316-1c4b-4281-b951-d872f2087c98
* SkStream.cpp was listed twice.agl@chromium.org2008-10-161-1/+0
| | | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/7452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3486 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more shared_event that I missed last timeagl@chromium.org2008-10-165-5/+0
| | | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/7397 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3485 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused shared_event.agl@chromium.org2008-10-166-214/+0
| | | | | | | Review URL: http://codereview.chromium.org/7439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3484 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call the callback in an unexpected case that will never happen anyway.mark@chromium.org2008-10-161-1/+2
| | | | | | Review URL: http://codereview.chromium.org/7449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3483 0039d316-1c4b-4281-b951-d872f2087c98
* Misc style changes.ericroman@google.com2008-10-163-30/+15
| | | | | | | | (trying to address previous review comments). Review URL: http://codereview.chromium.org/7447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3482 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a problem with rdi.ca where the video (silverlight) is not painting.nsylvain@chromium.org2008-10-161-1/+11
| | | | | | | | | | | | | | | | | | | | | This bug was fixed in 1735, but the code to fix that got reverted (by mistake?) in revision 2744. Comment for 1735: The basic issue here was that the plugin would not paint correctly. The URLs mentioned in this bug load windowed silverlight plugin instances, which invoke the NPN_InvalidateRect API to paint. We send over the rects to the renderer, however these don't generate paints as the plugin is windowed. A peek at Safari's webkit implementation revealed that they merely invoke the InvalidateRect windows API in this context. The fix is to emulate this behavior. bug:666 Review URL: http://codereview.chromium.org/7370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3481 0039d316-1c4b-4281-b951-d872f2087c98
* When a mixed-content resource was loaded, we would apply the mixed-content ↵jcampan@chromium.org2008-10-162-5/+4
| | | | | | | | | | | | | | | state to the active entry, which would be the pending entry if there is one. That caused a problem in cases where a bad resource is loading and we are initiating a navigation from the browser (and therefore creating a pending entry). More details: In the GoodFrame test, the top-frame is HTTPS and we load an HTTP frame with an image. As soon as the bad frame has loaded, we navigate back (creating a pending entry). In rare cases, the notification for the mixed-content image of the HTTP frame would happen after the back action, mistakingly setting the mixed-content state on the pending entry. BUG=2742 TEST=Run the SSL UI tests 1000 times. Review URL: http://codereview.chromium.org/7440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3480 0039d316-1c4b-4281-b951-d872f2087c98
* Roll version 20 of open-vcdiff into chrome tree for SDCH supportjar@google.com2008-10-161-1/+1
| | | | | | | | | | | This version prevents memory overrun on malicious due to malicious encoded content. r=openvcdiff Review URL: http://codereview.chromium.org/7428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3479 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at fixing image corruption on drag and drop.tc@google.com2008-10-163-5/+4
| | | | | | | | Fix a unittest that needs to specify the size when reading char* data. Review URL: http://codereview.chromium.org/7441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3478 0039d316-1c4b-4281-b951-d872f2087c98
* Follow-up to r3444 (which forked ↵jungshik@google.com2008-10-162-0/+18
| | | | | | | | | | | | | | http/tests/misc/frame-default-enc-same-domain.html until we pick up the upstream fix). I forgot to move 'resources' directory. Sorry for my stupid mistake (and not running the test after forking). TBR=darin Review URL: http://codereview.chromium.org/7448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3477 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable SpellCheck tests by adding en-US-1-1.bdic to copy rule in hunspell ↵sidchat@google.com2008-10-163-3/+3
| | | | | | | | project and also add the new dictionary, en-US-1-1.bdic, in the hunspell dictionary directory. Review URL: http://codereview.chromium.org/7394 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3476 0039d316-1c4b-4281-b951-d872f2087c98
* fix unittestben@chromium.org2008-10-161-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3475 0039d316-1c4b-4281-b951-d872f2087c98
* add more files to the linux webcore buildtc@google.com2008-10-161-16/+1
| | | | | | | | | | original patch from icefox (TorchMobile) http://codereview.chromium.org/7383 Review URL: http://codereview.chromium.org/7445 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3474 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some more extraneous NOTIMPLEMENTEDs to "fix" failing layout tests.darin@chromium.org2008-10-161-3/+0
| | | | | | | | | It looks as though shouldMoveRangeAfterDelete exists for the purpose of non-browser embeddings of WebKit. WebKit on Windows also just answers true here without asking the embedder, whereas WebKit on Mac asks the embedder. I'm guessing that Mail.app may make use of this API to customize the behavior of WebKit's rich text editor. For us, just answering true seems fine. TBR=tony Review URL: http://codereview.chromium.org/7444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3473 0039d316-1c4b-4281-b951-d872f2087c98
* Disable spellCheck tests temporarily. A new version of dictionary has been ↵sidchat@google.com2008-10-161-2/+2
| | | | | | | | updated for automatic download and use. However, buildbot cannot download anything. So, have to update the dictionary manually - otherwise, all the tests will fail. Review URL: http://codereview.chromium.org/7392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3472 0039d316-1c4b-4281-b951-d872f2087c98
* Make View::SetBounds take a const gfx::Rect& instead of a const CRect&ben@chromium.org2008-10-1699-572/+298
| | | | | | | | | | Make View::DidChangeBounds call Layout by default, eliminating this function from most places. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3471 0039d316-1c4b-4281-b951-d872f2087c98
* Return without doing anything instead of dereferencing junk in unexpected cases.mark@chromium.org2008-10-161-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3470 0039d316-1c4b-4281-b951-d872f2087c98
* Don't user uninitialized variables. We should at least fail predictably inmark@chromium.org2008-10-161-1/+1
| | | | | | | not-reached cases. Review URL: http://codereview.chromium.org/7362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3469 0039d316-1c4b-4281-b951-d872f2087c98
* Update SpellChecker to download the latest version of the bdic dictionary files.sidchat@google.com2008-10-162-3/+46
| | | | | | Review URL: http://codereview.chromium.org/6474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3468 0039d316-1c4b-4281-b951-d872f2087c98
* Clearly distinguish the multiple "path_util" modules in use.mmoss@google.com2008-10-162-6/+9
| | | | | | | | | This revises r3257 as per suggestion from pamg (and brings that Windows fix to the Mac version). Review URL: http://codereview.chromium.org/7422 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3467 0039d316-1c4b-4281-b951-d872f2087c98
* Updating dependencies for the following projects to fix build errors.ananta@chromium.org2008-10-161-0/+6
| | | | | | | | | | | | 1. startup tests. 2. Reliability tests. 3. Interactive UI tests. TBR=tony Review URL: http://codereview.chromium.org/7389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3466 0039d316-1c4b-4281-b951-d872f2087c98