summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Detach verify thread from NSPR on linux.ukai@chromium.org2009-05-291-0/+14
| | | | | | | | | | | | | The threads in our thread pool terminate after we have called PR_Cleanup. Unless we detach them from NSPR, if we use CertVerifier, net_unittests dies with segfault on shutdown. BUG=10911 TEST=net_unittests passes with code that uses CertVerifier. Review URL: http://codereview.chromium.org/115856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17160 0039d316-1c4b-4281-b951-d872f2087c98
* Gets NativeTabContentsContainerGtk to compile and removes somesky@chromium.org2009-05-294-28/+4
| | | | | | | | | | | unneeded methods from NativeTabContentsContainerWin. BUG=none TEST=none Review URL: http://codereview.chromium.org/115903 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17159 0039d316-1c4b-4281-b951-d872f2087c98
* linux: wrap prefs checkbox in options window.evan@chromium.org2009-05-291-2/+10
| | | | | | | | | | | This is a quick hack, that will be replaced once we have the rest of prefs implemented. BUG=12736 Review URL: http://codereview.chromium.org/113977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17158 0039d316-1c4b-4281-b951-d872f2087c98
* Pressing "enter" while the JS prompt text entry has focus shouldtc@google.com2009-05-291-1/+3
| | | | | | | | | accept the user's text. Review URL: http://codereview.chromium.org/114058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17157 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a bug with the unit_tests, which caused it to leave hebrew enabledhbono@chromium.org2009-05-293-15/+46
| | | | | | | | | | | | | vista without hebrew support the bug reason is documented in the source for all to see and the bug=12093 (http://code.google.com/p/chromium/issues/detail?id=12093) the code has been tested with and without a debugger but i have to admit, the unit_tests rarely pass on my machine (the ui ones never do)but this code i changed leaves the state EXACTLY like it was and solves this issue at least BUG=12093 TEST=run unit_tests.exe on Hebrew Windows; run Chrome; open a page which contains a <textarea dir="ltr"></textarea> element; press control+right-shift key, and; verify its "dir" attribute becomes "rtl". Review URL: http://codereview.chromium.org/115849 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17156 0039d316-1c4b-4281-b951-d872f2087c98
* Re-add the code to only add sse2 flags on Chromium builds. Ittc@google.com2009-05-291-3/+9
| | | | | | | | | | | was accidentally lost in r16719. BUG=9007 Review URL: http://codereview.chromium.org/115902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17155 0039d316-1c4b-4281-b951-d872f2087c98
* Get textfield to compile on linux.sky@chromium.org2009-05-292-1/+11
| | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/113981 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17153 0039d316-1c4b-4281-b951-d872f2087c98
* Add Linux packaging tools to the build output and the buildbot archive.mmoss@chromium.org2009-05-293-384/+501
| | | | | | | | | | | | | | | | | This makes the buildbot archive hermetic for package building, rather than pulling files from the package builder's source tree (e.g. BRANDING) and system (e.g. lib32 stuff). Note, this currently only applies to official builds since that's all we package. This depends on: http://codereview.chromium.org/115842 http://codereview.chromium.org/113966 Review URL: http://codereview.chromium.org/115843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17151 0039d316-1c4b-4281-b951-d872f2087c98
* Allow passing in a file path to a file that will be used for the new new tabarv@google.com2009-05-292-4/+50
| | | | | | | | | | | | | | page. This allows faster prototyping (F5) of the NNTP. TEST=Start Chrome with --new-new-tab-page=path/to/file.html. The NTP should show the file. Make a visible change in the file and reload the tab page and the change should be visible immidiately. BUG=None Review URL: http://codereview.chromium.org/113927 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17150 0039d316-1c4b-4281-b951-d872f2087c98
* Fix branded resource buiding.jrg@chromium.org2009-05-292-3/+13
| | | | | | | | | | | One visible change: new tab page has Google icon, not Chromium. Gyp doesn't have a set environment variable facility; hence the addition of a command line option to grit. Review URL: http://codereview.chromium.org/113974 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17148 0039d316-1c4b-4281-b951-d872f2087c98
* Gets GoButton to compile on Linux.sky@chromium.org2009-05-292-4/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115879 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17146 0039d316-1c4b-4281-b951-d872f2087c98
* Hoist TrimHttpPrefix() so we only have one copy, not one per provider.pkasting@chromium.org2009-05-298-55/+37
| | | | | | | | | Make use of this in HistoryContentsProvider so results from it get their schemes trimmed appropriately. BUG=10558 Review URL: http://codereview.chromium.org/115885 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17145 0039d316-1c4b-4281-b951-d872f2087c98
* Treat alt-(arrows/pgup/pgdn) like alt was not pressed. There's no reason to ↵pkasting@chromium.org2009-05-291-1/+2
| | | | | | | | | | ignore these keypresses. BUG=6992 TEST=Type a letter so the omnibox dropdown shows. Press alt-down. If you used the numpad down arrow, nothing should happen (until you release both keys, then a special character might appear). If you used the standalone arrow keys, the selection should move down one row. Review URL: http://codereview.chromium.org/115891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17144 0039d316-1c4b-4281-b951-d872f2087c98
* This adds a DEPS file for o3d that maps in all of its dependencies,gspencer@google.com2009-05-295-15/+142
| | | | | | | and updates the build files so that it will build. Review URL: http://codereview.chromium.org/115847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17142 0039d316-1c4b-4281-b951-d872f2087c98
* Major refactoring of Croc.rspangler@google.com2009-05-298-320/+1320
| | | | | | | | | | | | Add support for scanning missing source files for executable lines. Add support for HTML output. Now reports percent coverage. BUG=none TEST=by hand on experimental buildbot Review URL: http://codereview.chromium.org/113980 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17141 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where SetBounds would change the z-order. This was resultingsky@chromium.org2009-05-291-1/+1
| | | | | | | | | | | | in windows that triggered status bubble (such as gmail) to always come to front. BUG=none TEST=see bug Review URL: http://codereview.chromium.org/113962 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17140 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling in a new version of gyp.bradnelson@chromium.org2009-05-291-1/+1
| | | | | | | | This will generate prettier looking sln files. Review URL: http://codereview.chromium.org/113979 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17138 0039d316-1c4b-4281-b951-d872f2087c98
* linux: remove the word "Alpha" from all UI.evan@chromium.org2009-05-284-13/+15
| | | | | | | | It mostly confuses the press. Review URL: http://codereview.chromium.org/113978 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17137 0039d316-1c4b-4281-b951-d872f2087c98
* Add alert box suppression check box to linux js dialogs.tc@google.com2009-05-281-24/+57
| | | | | | | | | BUG=12174 Review URL: http://codereview.chromium.org/115893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17136 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken Gears after gyp conversion. The path to gears.dll has changed.kuchhal@chromium.org2009-05-282-2/+2
| | | | | | | | | | BUG=12844 TEST=Install Chromium and make sure gears.dll is present. Review URL: http://codereview.chromium.org/113976 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17135 0039d316-1c4b-4281-b951-d872f2087c98
* IE and Firefox always translate (alt+numpad 7) as an accelerator. We should ↵pkasting@chromium.org2009-05-282-22/+24
| | | | | | | | | | too. BUG=5372 TEST=Navigate somewhere, focus the omnibox, and hit alt+numpad 7. You should navigate to your home page (by default, the new tab page). Review URL: http://codereview.chromium.org/113971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17134 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out textfield on GTKben@chromium.org2009-05-287-6/+135
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115886 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17133 0039d316-1c4b-4281-b951-d872f2087c98
* Paint a focus indication on LinkButtonGtk buttons.estade@chromium.org2009-05-2811-49/+53
| | | | | | | | | | | | | Also, rearrange helper code for centering things in hboxes so they don't expand to take up the full vertical space. Also, don't allow focus on gtk_chrome_button buttons. This is to prevent the "Other bookmarks" button from getting focus (which matches windows) and is in line with disallowing focus on all custom chrome buttons (see CustomDrawButton). BUG=12829 TEST=everything should look the same. Also if you tab to focus on a link button (e.g. download shelf's "show all downloads"), it should have a dotted line around the exterior. Review URL: http://codereview.chromium.org/113970 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17132 0039d316-1c4b-4281-b951-d872f2087c98
* Rename policy_url to first_party_for_cookies in one more place.abarth@chromium.org2009-05-281-4/+4
| | | | | | | | | | | | This should have been in my earlier CL, but I had a gcl fail. TBR=darin BUG=None TEST=No behavior change Review URL: http://codereview.chromium.org/112067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17131 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize gtk syles before first run dialog. (Missed in r17104)thestig@chromium.org2009-05-281-6/+6
| | | | | | | | BUG=none TEST=Linux first run dialog should be properly styled? Review URL: http://codereview.chromium.org/115890 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17130 0039d316-1c4b-4281-b951-d872f2087c98
* Removing gmock from build since it has unresolvned xternsjar@chromium.org2009-05-281-1/+1
| | | | | | | | | Repairing tree bustage. r=jrg Review URL: http://codereview.chromium.org/113975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17129 0039d316-1c4b-4281-b951-d872f2087c98
* Automatically adapt to faster/slower uploads of renderer histogramsjar@chromium.org2009-05-2817-79/+525
| | | | | | | | | | | | | | | | | | | | | This replaces the current time based approach (chrome is given N seconds to upload all renederer histograms) with an asynch callback approach that waits until all renderers have responded (with their updates). It uses a fall-back timer to ensure that a hung renderer won't delay things forever as well. This causes faster (and complete) updates in about:histograms as well as generally assuring complete updates during UMA gatherings. This code was contributed by Raman Tenneti in CL 42496 http://codereview.chromium.org/42496 bug=12850 r=raman Review URL: http://codereview.chromium.org/113473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17123 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up Linux crash reporting setting to options dialog.thestig@chromium.org2009-05-281-0/+2
| | | | | | Review URL: http://codereview.chromium.org/115878 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17121 0039d316-1c4b-4281-b951-d872f2087c98
* linux: simplify gfx::Font constructor logic and add CHECK()s.evan@chromium.org2009-05-282-44/+41
| | | | | | | | | | | | | | Trying to track down a bug that a user is seeing. The getter we were using to extract the value before was for a debugger-compatible string. Perhaps it was the quote-removal code that was getting us before; if not, these CHECKs will track it down. BUG=12530 Review URL: http://codereview.chromium.org/115877 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17118 0039d316-1c4b-4281-b951-d872f2087c98
* Moving things a little so this will work when chrome.sln gets eaten by gyp.bradnelson@chromium.org2009-05-282-304/+311
| | | | | | Review URL: http://codereview.chromium.org/115869 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17117 0039d316-1c4b-4281-b951-d872f2087c98
* Add general options page. Options are working with the following exceptions:tc@google.com2009-05-2813-48/+726
| | | | | | | | | | | | | | | | | | | Custom start urls and default search options widgets aren't hooked up. Home page settings work, but are overridden by the linux start page settings. Default browser checking/setting functions are not implemented, so the option isn't useful yet. Refactors some common code out of browser/views/options/options_page_view.* into browser/options_page_base.{cc,h} BUG=11507 Patch by Matt Mueller (mattm@google.com). Review URL: http://codereview.chromium.org/113967 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17115 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some dead code.pkasting@chromium.org2009-05-282-6/+0
| | | | | | Review URL: http://codereview.chromium.org/113965 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17113 0039d316-1c4b-4281-b951-d872f2087c98
* Make Textfield more portable.ben@chromium.org2009-05-2818-1243/+1382
| | | | | | | | | | | | | Split off Windows bits into NativeTextfieldWin class obscured behind NativeTextfieldWrapper interface. The APIs aren't perfectly tidy yet but this is a good first pass. BUG=none TEST=make sure you can still edit text fields, run the view unit tests. Review URL: http://codereview.chromium.org/113940 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17112 0039d316-1c4b-4281-b951-d872f2087c98
* Limit Breakpad Linux to 8 url-chunk entries.thestig@chromium.org2009-05-281-0/+3
| | | | | | Review URL: http://codereview.chromium.org/115876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17111 0039d316-1c4b-4281-b951-d872f2087c98
* Restore parent semantings for external tab container creation, and error ↵ben@chromium.org2009-05-281-1/+5
| | | | | | | | | | | check the HWND. BUG=none TEST=none Review URL: http://codereview.chromium.org/115852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17110 0039d316-1c4b-4281-b951-d872f2087c98
* Adds bookmark_context_menu to compile list and fixes wildcard forsky@chromium.org2009-05-281-1/+3
| | | | | | | | | | | | _views.foo. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/115875 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17109 0039d316-1c4b-4281-b951-d872f2087c98
* Correct forward declaration.stoyan@chromium.org2009-05-281-1/+3
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/115873 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17108 0039d316-1c4b-4281-b951-d872f2087c98
* Add debugging symbols to official Linux Chrome builds.thestig@chromium.org2009-05-281-0/+5
| | | | | | Review URL: http://codereview.chromium.org/115874 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17107 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: call xdg-open on downloaded files to open them.estade@chromium.org2009-05-2812-40/+71
| | | | | | | | BUG=12299 TEST=1) right click/save as on some image. Clicking on the download item's filename area should launch it in some image viewer (assuming xdg-open works for you---as it happens, ubuntu broke xdg-open for desktops that are not gnome, kde, or xfce). 2) Download a large file. Click on the download item before it is finished. The text should change to "opening in..." and the checkbox in the dropdown menu should show as checked. 3) completed downloads should have the "open when finished" menu item replaced by the "open" menu item. Selecting that should also open the download. Review URL: http://codereview.chromium.org/112064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17106 0039d316-1c4b-4281-b951-d872f2087c98
* We need to save bookmarks file when the persist_ids settings changesmunjal@chromium.org2009-05-284-0/+42
| | | | | | | | or when the file is detected to be changed externally. Review URL: http://codereview.chromium.org/114055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17105 0039d316-1c4b-4281-b951-d872f2087c98
* Respect Linux user prefs with regards to crash reporting.thestig@chromium.org2009-05-2814-202/+196
| | | | | | | | | | This involves implementing GoogleUpdateSettings::[GS]etCollectStatsConsent, and a whole lot of refactoring. BUG=none TEST=delete config dir, run official Linux build, don't enable crash reporting, crash browser -> no crash reporting. Review URL: http://codereview.chromium.org/115808 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17104 0039d316-1c4b-4281-b951-d872f2087c98
* Do a keyboard grab when select popups are showing. This matchestc@google.com2009-05-281-4/+17
| | | | | | | | | | other gtk popups (e.g., gtkmenu). Always allow Esc to close the popup so a hung renderer doesn't require mouse usage. Review URL: http://codereview.chromium.org/113959 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17103 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some code to make it more comprehensible. No functional change.pkasting@chromium.org2009-05-281-16/+29
| | | | | | Review URL: http://codereview.chromium.org/112063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17102 0039d316-1c4b-4281-b951-d872f2087c98
* Removes ifdef around include of tooltip_manager now that it's beensky@chromium.org2009-05-281-2/+0
| | | | | | | | | | | | ported. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/113963 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17101 0039d316-1c4b-4281-b951-d872f2087c98
* Gets bookmark_bar_view to compile on Linux.sky@chromium.org2009-05-282-7/+24
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115872 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17098 0039d316-1c4b-4281-b951-d872f2087c98
* Handle opening URLs when there is no window open.avi@chromium.org2009-05-281-1/+8
| | | | | | | | | BUG=http://crbug.com/12550 TEST=as described in bug report Review URL: http://codereview.chromium.org/113960 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17097 0039d316-1c4b-4281-b951-d872f2087c98
* Add default version information and ability to output to stdout.mmoss@chromium.org2009-05-281-9/+35
| | | | | | | | | | This is useful for getting general build version information, such as needed for Linux packaging. Review URL: http://codereview.chromium.org/115842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17096 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement GtkFloatingContainer and implement StatusBubble on top of it.erg@google.com2009-05-287-83/+491
| | | | | | | | | | | This introduces a hybrid GtkBin/GtkFixed container which exposes a signal to absolutely position widgets. This also fixes the current flickering issues with the status bubble. http://crbug.com/11635 TEST=Goto a site with a long list of links (I used reddit.com) and move the mouse cursor up and down the list quickly. There shouldn't be flickering in the top left corner. Review URL: http://codereview.chromium.org/115835 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17095 0039d316-1c4b-4281-b951-d872f2087c98
* Add more logging on a NOTREACHED() in hopes of getting more data about why ↵pkasting@chromium.org2009-05-281-1/+2
| | | | | | | | | we're hitting it. BUG=12684 Review URL: http://codereview.chromium.org/113958 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17094 0039d316-1c4b-4281-b951-d872f2087c98
* Make automation proxy objects to ref_counted. That allows to process async ↵stoyan@chromium.org2009-05-2859-521/+668
| | | | | | | | | | | notifications directly in channel background thread. Add support for listener-less ChannelProxy. BUG=none TEST=none Review URL: http://codereview.chromium.org/113722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98