summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Switch ResourceBundle::GetLocalizedString to return a string16 insteadtc@google.com2009-04-145-19/+19
| | | | | | | | | | | | of a wstring. This saves us a conversion to wstring on linux when getting utf8 strings. BUG=9911 Review URL: http://codereview.chromium.org/67134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13692 0039d316-1c4b-4281-b951-d872f2087c98
* grit: cut down on chattiness.evan@chromium.org2009-04-142-5/+10
| | | | | | | | | - We don't need to print the copyright every time we run. - Don't print empty lines when there are no warnings. Review URL: http://codereview.chromium.org/67085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13691 0039d316-1c4b-4281-b951-d872f2087c98
* Link to DiamondX plugin.evan@chromium.org2009-04-141-0/+1
| | | | | | Review URL: http://codereview.chromium.org/67105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13690 0039d316-1c4b-4281-b951-d872f2087c98
* Update playback extension so that javascript functions return consistent ↵ace@google.com2009-04-141-2/+6
| | | | | | | | (but not constant) values in an attempt to preserve the functionality but improve compatibility of the extension. Review URL: http://codereview.chromium.org/62165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13688 0039d316-1c4b-4281-b951-d872f2087c98
* Add routing_id to the ipc debugging log output.willchan@chromium.org2009-04-142-1/+6
| | | | | | Review URL: http://codereview.chromium.org/66051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13687 0039d316-1c4b-4281-b951-d872f2087c98
* The history tests relies on being about to reset a profile, which means we needthomasvl@chromium.org2009-04-142-0/+18
| | | | | | | | | to load a bunch of resources. For the Mac, this means we build the app first and the unittest looks into the app bundle to pull resources. Review URL: http://codereview.chromium.org/73046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13686 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where scrolling up would draw over the horizontalavi@google.com2009-04-141-1/+10
| | | | | | | | | | | scrollbar on mac. Patch by rohitrao. http://codereview.chromium.org/73042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13685 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Enable the code that sets the max size automatically.rvargas@google.com2009-04-143-10/+69
| | | | | | | | (still limiting the ceiling). Review URL: http://codereview.chromium.org/68007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13684 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reserve space for an auto-hide taskbar that's not always-on-top. ↵pkasting@chromium.org2009-04-144-12/+13
| | | | | | | | | Windows native behavior is to cover these. BUG=9976 Review URL: http://codereview.chromium.org/66055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13683 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't drop invalid scroll requests.agl@chromium.org2009-04-141-20/+18
| | | | | | | | | | | | When performing an anchor jump, WebKit will send a scroll request with an invalid scroll magnitude (greater than the size of the window). We must still process the paint request attached however. BUG=10494 http://codereview.chromium.org/67132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13682 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problems correctly invalidating/repainting when our updated paint rect ↵pkasting@chromium.org2009-04-147-20/+62
| | | | | | | | for a large area came back while we were repainting a smaller area. Review URL: http://codereview.chromium.org/66013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13681 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused notifications.paulg@google.com2009-04-143-27/+0
| | | | | | | | | The old download tab page was the only consumer of these notifications, so they're no longer necessary. Review URL: http://codereview.chromium.org/69003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13680 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when the browser opens a popup window in Linux.jhawkins@chromium.org2009-04-141-0/+5
| | | | | | Review URL: http://codereview.chromium.org/73045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13679 0039d316-1c4b-4281-b951-d872f2087c98
* Get the first set of page_cycler_tests working on Mac. This means: MozFile,nirnimesh@chromium.org2009-04-142-30/+41
| | | | | | | | | | | | | DomFile and DhtmlFile corpus sets. Not enabling Intl1File, Intl2File yet coz they crash Chromium. Not enabling PageCyclerReferenceTest yet coz we don't yet have a reference build. Review URL: http://codereview.chromium.org/67127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13677 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a gcc warning about uninitialized variables.tc@google.com2009-04-141-2/+2
| | | | | | | | | | app_modal_dialog_gtk.cc:46:warning: ‘message_type’ may be used uninitialized in this function app_modal_dialog_gtk.cc:46:warning: ‘buttons’ may be used uninitialized in this function Review URL: http://codereview.chromium.org/73040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13676 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test for status bubble mac.pinkerton@chromium.org2009-04-143-0/+112
| | | | | | Review URL: http://codereview.chromium.org/67131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13674 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/68009dimich@google.com2009-04-141-0/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13673 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that the WinSock DLL supports version 2.2.wtc@chromium.org2009-04-141-9/+14
| | | | | | | R=cpu Review URL: http://codereview.chromium.org/67111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13672 0039d316-1c4b-4281-b951-d872f2087c98
* Color/emphasize correct portions of view-source: URLs. Original patch by ↵pkasting@chromium.org2009-04-144-8/+104
| | | | | | | | Shinichiro Hamaji (see http://codereview.chromium.org/62094/show ), r=me. BUG=2349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13671 0039d316-1c4b-4281-b951-d872f2087c98
* Fix status bubble shadow being opaque, which made the bubble appear to be ↵pkasting@chromium.org2009-04-143-43/+38
| | | | | | | | | off by one pixel. This reverts Brett's fix for issue 8651 and instead fixes that issue by ensuring the text bounding box does not overlap the status bubble shadow. This also makes kShadowThickness (renamed for consistency with the browser frame) a class-scoped constant so the browser view can access it, eliminating a magic number. BUG=9928 Review URL: http://codereview.chromium.org/67059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13670 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo. Original patch by Shinichiro Hamaji (see ↵pkasting@chromium.org2009-04-142-10/+10
| | | | | | http://codereview.chromium.org/67123 ), r=me. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13669 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the omnibox show past searches and suggestions for keywords.sky@chromium.org2009-04-1410-189/+526
| | | | | | | | | | | | | | | We talked about primary and secondary, but after doing it all I felt keyword and default better portrayed what is going on. After trying this out I think we need to tune relevancy. But that can be done later BUG=3636 TEST=make sure omnibox isn't broken. Review URL: http://codereview.chromium.org/66073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13668 0039d316-1c4b-4281-b951-d872f2087c98
* Save and restore the value of GetLastError() when [D]LOG/[D]CHECK etc on ↵tommi@google.com2009-04-142-0/+28
| | | | | | | | | | Windows. Also for log levels higher than INFO, the value of GLE is tagged onto the log message. Review URL: http://codereview.chromium.org/73010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13667 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the internal GetStringF to use string16. This saves atc@google.com2009-04-144-82/+83
| | | | | | | | | | | | | | | conversion from string16 to wstring on the linux side when calling GetStringFUTF8 methods. It actually adds extra conversions when calling GetStringF, but we're going to get rid of all those, right? BUG=9911 Review URL: http://codereview.chromium.org/67112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13666 0039d316-1c4b-4281-b951-d872f2087c98
* Rendering dependencies inherited from version.rules less relative.robertshield@google.com2009-04-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/73016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13665 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the new Omnibox resources to follow convention and use underscores. ↵deanm@chromium.org2009-04-146-0/+5
| | | | | | | | | Add these resources to theme_resources.grd. Review URL: http://codereview.chromium.org/73030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13664 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the test_expectations.txt file to add bugs to all tests without ↵gwilson@google.com2009-04-141-754/+754
| | | | | | | | | | | | bugs and not marked as WONTFIX. The bugs have already been created, this just updates the expectations file. R=ojan Review URL: http://codereview.chromium.org/73026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13663 0039d316-1c4b-4281-b951-d872f2087c98
* Added undo tab closing item to Tab menu.idanan@chromium.org2009-04-146-0/+27
| | | | | | Review URL: http://codereview.chromium.org/62151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13662 0039d316-1c4b-4281-b951-d872f2087c98
* Collapse bookmark bars into a single bar per window, rather than one per tab.pinkerton@chromium.org2009-04-1413-159/+198
| | | | | | | | Create a separate controller for the bar. Hide bar when it's not supposed to be visible instead of just allowing it to be covered by content (it's not always covered, which leads to drawing errors). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13661 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent an extension from double observing a message filter.maruel@chromium.org2009-04-142-13/+25
| | | | | | | | | | | Fixes Vista ui_test debug failures. Patch by Paul Godavari Review: http://codereview.chromium.org/67120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13660 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.1.9.1 to fix broken Mac build.kasperl@google.com2009-04-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/73033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13656 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium to version 1.1.8. The motivation for thiskasperl@google.com2009-04-142-1/+3
| | | | | | | | | change is to get the V8 latest builder compiling again so we can keep track of any regressions (new files were introduced - need to update the v8.gyp file). Review URL: http://codereview.chromium.org/73032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13654 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add JsonSchema-based validation for the tab APIs."aa@chromium.org2009-04-1420-1358/+228
| | | | | | | | | | | This reverts commit 4f47758f5238f2e5b05d9de18f390bfe2aeb6980. Revert "TBR: Fix unit tests, line endings." This reverts commit 257fa01e20c46c68dce1c5992b75c64686cb1a66. Review URL: http://codereview.chromium.org/67122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13652 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Fix unit tests, line endings.aa@chromium.org2009-04-142-312/+312
| | | | | | Review URL: http://codereview.chromium.org/67121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13651 0039d316-1c4b-4281-b951-d872f2087c98
* Fast flag for h264 improves performance of loop filter.fbarchard@chromium.org2009-04-141-0/+1
| | | | | | | | Increases performance by about 10% with minimal quality loss. Review URL: http://codereview.chromium.org/63107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13650 0039d316-1c4b-4281-b951-d872f2087c98
* Add JsonSchema-based validation for the tab APIs.aa@chromium.org2009-04-1420-228/+1358
| | | | | | | | | Arv: can you take json_schema.js and json_schema_test.js. Matt: you take the rest. Review URL: http://codereview.chromium.org/66006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13649 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 13647 (broke build).sgjesse@chromium.org2009-04-141-2/+0
| | | | | | | TBR=yurys@chromium.org Review URL: http://codereview.chromium.org/67118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13648 0039d316-1c4b-4281-b951-d872f2087c98
* Added new V8 files to v8.gyp.sgjesse@chromium.org2009-04-141-0/+2
| | | | | | | TBR=yurys@chromium.org Review URL: http://codereview.chromium.org/73027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13647 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 174.0 to 175.0laforge@chromium.org2009-04-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13646 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash where the ResourceMessageFilter is deleted before apaulg@google.com2009-04-149-35/+113
| | | | | | | | | | | | | | | | | | SafeBrowsing check has completed. The problem occurs since the SafeBrowsingResourceHandler is not deleted when its associated URLRequest is cleaned up *and* a SafeBrowsing check is in progress. When the check completes, the next resource handler in the chain (the AsyncResourceHandler which caches a pointer the now deleted ResourceMessageFilter) will crash. This CL adds a notification for objects to know when the ResourceMessageFilter is destroyed. BUG=8544 (http://crbug.com) Review URL: http://codereview.chromium.org/63036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13644 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Ignore certain menu accelerators.estade@chromium.org2009-04-145-34/+47
| | | | | | Review URL: http://codereview.chromium.org/73003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13643 0039d316-1c4b-4281-b951-d872f2087c98
* Matching v8 build settings more closely to try to fix regression in performance.bradnelson@google.com2009-04-142-5/+18
| | | | | | Review URL: http://codereview.chromium.org/67092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13642 0039d316-1c4b-4281-b951-d872f2087c98
* Update to version 26 of open-vcdiff (underpinnings for SDCH decoder)jar@chromium.org2009-04-142-1/+2
| | | | | | | | | | | | | This supports a restricted memory model, that does not require the current section (window) of expanded data (from an SDCH decompression) to remain memory resident (for future reference). Also added the change to tell vcdiff that Chrome only supports the more memory effecient mode. r=openvcdiff Review URL: http://codereview.chromium.org/66070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13641 0039d316-1c4b-4281-b951-d872f2087c98
* Typo in test is exposed as a flaky testjar@chromium.org2009-04-141-1/+1
| | | | | | | | | | | | | I recently updated these tests to reduce flakiness, but there was a typo in one line of the update. Since tasks were run serially, the total time to run N-1 tasks should be greater than or EQUAL to the task durtaion, times N-1. r=mark Review URL: http://codereview.chromium.org/74003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13640 0039d316-1c4b-4281-b951-d872f2087c98
* Revert changes causing memory_test problems. asargent@chromium.org2009-04-141-11/+2
| | | | | | | | | | | | This undoes changes from: http://codereview.chromium.org/66045 Review URL: http://codereview.chromium.org/67114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13639 0039d316-1c4b-4281-b951-d872f2087c98
* Print median, mean and std_deviation for test running times.ojan@google.com2009-04-132-45/+106
| | | | | | | | | | | | Prints these for the time spent in test_shell and the time spent doing each diff comparison. Also removes the check to compute statistics only in debug mode. That was an overoptimization (computing the statistics takes ~100ms). Review URL: http://codereview.chromium.org/73017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13638 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the DOMUIHost. It is not used by any code.brettw@chromium.org2009-04-1311-188/+4
| | | | | | | This also does a minor fix for forward-declares of RenderViewHostFactory. Review URL: http://codereview.chromium.org/66046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13637 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the title of a JavaScript dialog box.tc@google.com2009-04-132-7/+20
| | | | | | | | | | | | | | | | | | Currently, the title of a JavaScript dialog box contains "Alert" regardless of how it's made: whether by alert(), prompt(), or confirm(). "Alert" should be there only when the dialog box is created by alert(). Tested by: unittest, ui_tests, manually BUG=2359 Original patch by yuzo@google.com at http://codereview.chromium.org/67099 Review URL: http://codereview.chromium.org/70002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13636 0039d316-1c4b-4281-b951-d872f2087c98
* roll DEPS to pick up latest third_party/WebKitdarin@chromium.org2009-04-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13635 0039d316-1c4b-4281-b951-d872f2087c98
* Histogram time from request till first byte of header is receivedjar@chromium.org2009-04-132-7/+22
| | | | | | | | | Use this as part of the DNS testing trials. r=wtc Review URL: http://codereview.chromium.org/67083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13634 0039d316-1c4b-4281-b951-d872f2087c98