summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add missing icon to gmail checker.aa@chromium.org2009-10-271-0/+0
| | | | | | TBR=estade@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30271 0039d316-1c4b-4281-b951-d872f2087c98
* Move glue/EditorClientImpl.h/cpp to webkit/api/srcyaar@chromium.org2009-10-278-1103/+1119
| | | | | | Review URL: http://codereview.chromium.org/330021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30270 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prevent using tab context menu after tab closed.shess@chromium.org2009-10-271-0/+11
| | | | | | | | | | | | | | | JavaScript can close windows while in the event loop processing a right-click menu. This change prevents sending messages to the tab controller after it has been closed. BUG=25462, 25465 TEST=See bug for test.html. TEST=Run test.html, right-click tab, after close all items should be grayed out. TEST=Run test.html, click tab's close button and hold until tab closes. Should not crash on release. Review URL: http://codereview.chromium.org/335048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30269 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit 50158:10171jorlow@chromium.org2009-10-272-1/+3
| | | | | | | | | | TBR=rolandsteiner TEST=none BUG=none Review URL: http://codereview.chromium.org/337047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30268 0039d316-1c4b-4281-b951-d872f2087c98
* KSR should always support the new registration API now.mark@chromium.org2009-10-271-24/+6
| | | | | | | | | BUG=24814 TEST=Keystone-enabled Chrome launches without crashing and is able to check for and install updates. Review URL: http://codereview.chromium.org/329041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30267 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build error.ananta@chromium.org2009-10-271-1/+1
| | | | | | | | TBR=amit Review URL: http://codereview.chromium.org/340015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30266 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: make the slidey animation fastevan@chromium.org2009-10-271-2/+2
| | | | | | | | Personal crusade. Review URL: http://codereview.chromium.org/344003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30265 0039d316-1c4b-4281-b951-d872f2087c98
* Update test_expectations for some flaky testsjaphet@chromium.org2009-10-271-7/+8
| | | | | | | | | | BUG=none TEST=none TBR=markus Review URL: http://codereview.chromium.org/341003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30264 0039d316-1c4b-4281-b951-d872f2087c98
* If a HTTP post to a server returns any redirect code other than 307, then ↵ananta@chromium.org2009-10-275-9/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | browsers don't preserve the request method, i.e. they convert the POST request to GET. For 307 redirects browsers preserve redirects. This CL fixes the following issues :- 1. As per the above description, we reset the method which ensures that we don't generate the post related headers. The Post302RedirectGet net test does test this very case. However it works correctly as Chrome follows the redirect and reissues the GET request. In this case this does not occur as the only calls which are invoked on the bind status callback after the redirect are GetBindInfo and BeginningTransaction where we incorrectly return the post related information. Ideally we would want to turn off follow redirects in Urlmon or Chrome. I tried the latter which has a number of issues. 2. In debug mode the chrome_frame_net_tests cause a DCHECK to be fired which indicates that the test is not being run on the UI thread. 3. As the Urlmon requests are now destroyed asynchronously having a DCHECK after the Stop call on the Urlmon request object in the CleanupAsyncRequests function is incorrect. Removed this DCHECK Fixes bug http://code.google.com/p/chromium/issues/detail?id=25643 Bug=25643 Review URL: http://codereview.chromium.org/333043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30261 0039d316-1c4b-4281-b951-d872f2087c98
* Run a Chrome message loop on the mediator thread, allowing certificates to ↵zork@chromium.org2009-10-271-1/+8
| | | | | | | | | | | | | | be verified. BUG=none TEST= 1. Enable bookmark syncing on a mac or linux build. 2. Run chrome with --log-level=0. 3. Options menu -> Sync my Bookmarks. Log in. 4. Check that "XmppSocketAdapter::OnConnectEvent - STATE_TLS_OPEN" appears in the output. Review URL: http://codereview.chromium.org/340007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30259 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at this. The only change between this and the first is to add the ↵sky@chromium.org2009-10-2716-36/+241
| | | | | | | | | | | | | | | GetType message to the end of the list and to keep the old message for creating a new browser as well as adding one that takes the type. To change the params of the message requires updating the reference build. That's best done on a weekend when I'm bored. Makes session restore on Chrome OS restore popups. BUG=18862 TEST=none Review URL: http://codereview.chromium.org/329040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30255 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add -fvisibility=hidden to build flagsevan@chromium.org2009-10-272-10/+22
| | | | | | | | | | | | We use this on OS X, so it shouldn't be harmful and it will fix a visibility issue that came up in http://groups.google.com/group/chromium-dev/browse_thread/thread/800bda968bdc8f29 BUG=17943 Review URL: http://codereview.chromium.org/332035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30253 0039d316-1c4b-4281-b951-d872f2087c98
* Log the PLT to the log file. This is a convenience formbelshe@google.com2009-10-272-0/+26
| | | | | | | | | | | debugging. BUG=none TEST=none Review URL: http://codereview.chromium.org/330030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30252 0039d316-1c4b-4281-b951-d872f2087c98
* NewTabUITest.NTPHasThumbnails can be flakey if it takes more thantony@chromium.org2009-10-271-4/+12
| | | | | | | | | | | 2 sec for the history results to be returned (displaying the thumbnails). Work around this by giving extra time to the test. BUG=25949 Review URL: http://codereview.chromium.org/339029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30249 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more suppression for a data race in libjingletimurrrr@chromium.org2009-10-271-1/+7
| | | | | | | | BUG=25913 TBR=dank Review URL: http://codereview.chromium.org/343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30247 0039d316-1c4b-4281-b951-d872f2087c98
* Added printing of a couple of links to documentation in case warnings are ↵timurrrr@chromium.org2009-10-271-3/+14
| | | | | | | | | reporteed. I think this may increase the popularity and usability of our tools. Review URL: http://codereview.chromium.org/343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30246 0039d316-1c4b-4281-b951-d872f2087c98
* Loosen RFC 1738 compliance check to allow underscores where we already ↵pkasting@chromium.org2009-10-275-22/+26
| | | | | | | | | | | | allowed hyphens, to match real-world needs. I don't believe further loosening will be required but that data will hopefully be coming soon. In the meantime people are asking for this fix. BUG=25714 TEST=Entring "a_b.com" in the omnibox should default to navigate, not search Review URL: http://codereview.chromium.org/339017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30245 0039d316-1c4b-4281-b951-d872f2087c98
* s/FAIL/CRASH/jorlow@chromium.org2009-10-271-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30244 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix call to string->empty() that meant ->clear()mattm@chromium.org2009-10-271-1/+1
| | | | | | | | | | CID=127 BUG=none TEST=none Review URL: http://codereview.chromium.org/304009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30243 0039d316-1c4b-4281-b951-d872f2087c98
* Modify DataPacks so they can return RefCountedStaticMemory objects.erg@google.com2009-10-278-36/+37
| | | | | | | | | | (This is in preparation for a very large reworking of BrowserThemeProvider). BUG=http://crbug.com/21121 Review URL: http://codereview.chromium.org/338027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30241 0039d316-1c4b-4281-b951-d872f2087c98
* Map update check failure to "update server not available."mark@chromium.org2009-10-272-10/+11
| | | | | | | | | | | BUG=25948 TEST=With a suitably recent KSR, mess up the update server URL in the ticket, and verify that the update status line in the About box shows the gray icon with "update server not available" after attempting to check for an update. Review URL: http://codereview.chromium.org/344002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30240 0039d316-1c4b-4281-b951-d872f2087c98
* Enable sqlite3_release_memory().pkasting@chromium.org2009-10-271-1/+2
| | | | | | | | BUG=23400 TEST=none Review URL: http://codereview.chromium.org/333034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30239 0039d316-1c4b-4281-b951-d872f2087c98
* Add more test expectations.jorlow@chromium.org2009-10-271-2/+10
| | | | | | | | | | TBR=japhet BUG=none TEST=none Review URL: http://codereview.chromium.org/339028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30238 0039d316-1c4b-4281-b951-d872f2087c98
* Add test expectations.jorlow@chromium.org2009-10-271-0/+44
| | | | | | | | | | TBR=japhet BUG=none TEST=none Review URL: http://codereview.chromium.org/329038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30237 0039d316-1c4b-4281-b951-d872f2087c98
* Renames addItemToTimeline to addRecordToTimeline due to WebKitjamesr@chromium.org2009-10-271-1/+1
| | | | | | | | | | | | | change: https://bugs.webkit.org/show_bug.cgi?id=30785 Patch by: Kelly Norton (knorton@google.com) TEST=create extension, register for events, verify that they fire BUG=none Review URL: http://codereview.chromium.org/339016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30236 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the o3d-internal include path before the others so that if ↵vangelis@google.com2009-10-272-0/+4
| | | | | | | | | o3d-internal is there it will be picked up first. This is how scons was setup. This is important for initializing swiftshader. Review URL: http://codereview.chromium.org/331002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30235 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead variables.pkasting@chromium.org2009-10-271-10/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/329030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30234 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit to 50158jorlow@chromium.org2009-10-272-1/+7
| | | | | | | | | | TBR=rolandsteiner TEST=none BUG=none Review URL: http://codereview.chromium.org/338045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30233 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of files into webkit/api/srcdarin@chromium.org2009-10-2725-1784/+2018
| | | | | | | | | | R=yaar BUG=25898,25899,25900,25901, TEST=none Review URL: http://codereview.chromium.org/338041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30232 0039d316-1c4b-4281-b951-d872f2087c98
* We should be de-serializing an int64 for the UploadData identifier.darin@chromium.org2009-10-271-1/+1
| | | | | | | | | | | | | This is hard to test since this bug could only cause a very rare cache collision. R=eroman BUG=25939 TEST=none Review URL: http://codereview.chromium.org/338046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30231 0039d316-1c4b-4281-b951-d872f2087c98
* Change the download location NSPathControl to refuse first responder.rsesek@chromium.org2009-10-271-1/+1
| | | | | | | | | BUG=None TEST=Preferences-->Under the Hood. Click on downloads path, don't get awkward blue focus ring. Review URL: http://codereview.chromium.org/330028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30230 0039d316-1c4b-4281-b951-d872f2087c98
* Actually copy the autofill data into the FormFieldValues vector. Fixes a ↵jhawkins@chromium.org2009-10-271-2/+2
| | | | | | | | | | regression caused by r29913. BUG=25874 TEST=none Review URL: http://codereview.chromium.org/338047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30229 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leaks in media_bench.scherkus@chromium.org2009-10-271-12/+19
| | | | | | | | | | BUG=25855,25945 TEST=valgrind should report no leaks caused by media_bench itself Review URL: http://codereview.chromium.org/332038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30228 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Draw floating bookmark bar correctly during resizes.estade@chromium.org2009-10-272-20/+83
| | | | | | | | | BUG=23907 TEST=Using ratchet + clank theme, go to NTP while bookmark bar is off so you see a floating bar. Maximize the window. It should look right. Review URL: http://codereview.chromium.org/329022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30226 0039d316-1c4b-4281-b951-d872f2087c98
* Add "remember my choice" checkbox for windows external protocol dialog.estade@chromium.org2009-10-272-3/+25
| | | | | | | | BUG=24085 Review URL: http://codereview.chromium.org/332039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30225 0039d316-1c4b-4281-b951-d872f2087c98
* Better owner, group, and mode management for .keystone_install.mark@chromium.org2009-10-271-14/+27
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/338048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30224 0039d316-1c4b-4281-b951-d872f2087c98
* GPUPluginObject has methods to query its current window size.apatrick@google.com2009-10-273-0/+96
| | | | | | | | | | GPUPluginObject sends event to client process when its window is resized. TEST=none BUG=none Review URL: http://codereview.chromium.org/344001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30223 0039d316-1c4b-4281-b951-d872f2087c98
* Move Mac build tool scripts only used by chrome.gyp from build/mac intomark@chromium.org2009-10-278-23/+16
| | | | | | | | | | chrome/tools/build/mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/334049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30222 0039d316-1c4b-4281-b951-d872f2087c98
* Update o3d_code_rev from 154 to 157, to get the new bitmap-draw-image ↵kkania@google.com2009-10-273-3/+3
| | | | | | | | reference image. Review URL: http://codereview.chromium.org/333051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30221 0039d316-1c4b-4281-b951-d872f2087c98
* Move console stack dumping code to a function so it can be reused in ↵maruel@chromium.org2009-10-278-120/+170
| | | | | | | | | | test_shell_tests. TEST=none BUG=13770 Review URL: http://codereview.chromium.org/339024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30220 0039d316-1c4b-4281-b951-d872f2087c98
* Further polish to extensions_ui page.rafaelw@chromium.org2009-10-276-25/+103
| | | | | | | | | | This changes the details text from gray to black. It also persists in the preferences the state of devMode (whether the developer tools are showing). Lastly, it adds a fade/slide effect on page elements which are shown in devMode. BUG=25471 Review URL: http://codereview.chromium.org/329018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30219 0039d316-1c4b-4281-b951-d872f2087c98
* Page action pixel-god appeasement (better positioning and spacing for the ↵finnur@chromium.org2009-10-271-2/+8
| | | | | | | | | | | page action icons). BUG=25708 TEST=Visual inspection. See bug. Review URL: http://codereview.chromium.org/329028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30218 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug introduced in r28333, where we were checking if path.empty() ↵cira@chromium.org2009-10-271-9/+20
| | | | | | | | | | | | | instead of !PathExists(path). In addition makes background page load check. BUG=24041 TEST=Try loading extension with content script that doesn't exist on disk, but is listed in manifest. Review URL: http://codereview.chromium.org/335037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30217 0039d316-1c4b-4281-b951-d872f2087c98
* Disable fullscreen for Mstone-4 / ReleaseBlock-Beta.jrg@chromium.org2009-10-272-2/+15
| | | | | | Review URL: http://codereview.chromium.org/341001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30216 0039d316-1c4b-4281-b951-d872f2087c98
* Make KeystoneGlue less antisocial.mark@chromium.org2009-10-274-28/+15
| | | | | | | | | | | | | | | | | Remove -clearRecentStatus which really tied KeystoneGlue too closely to AboutWindowController. If KeystoneGlue ever wound up with any other clients, this relationship would have been harmful. AboutWindowController now maintains a static variable to handle what -clearRecentStatus had been used for. Remove -releaseDefaultKeystoneGlue, which was only intended to be used for testing, as a workaround for test flake. The test flake has been removed. BUG=none TEST=none Review URL: http://codereview.chromium.org/333049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30215 0039d316-1c4b-4281-b951-d872f2087c98
* Changed button text in Edit Search Engine... dialog to conformtony@chromium.org2009-10-272-1/+5
| | | | | | | | | | | | | | with GNOME HIG. BUG=18076 TEST=Compile and see label Original patch by Ramkumar Ramachandra <artagnon@gmail.com> at http://codereview.chromium.org/338015/show Review URL: http://codereview.chromium.org/333052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30214 0039d316-1c4b-4281-b951-d872f2087c98
* Make Pepper NPN variable return a pointer to an allocatedsehr@google.com2009-10-274-58/+79
| | | | | | | | | | structure rather than using several variables. Added a stub DestroyRendererContext function. Updates the test to work with the changes. Review URL: http://codereview.chromium.org/322003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30213 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed WebContextMenuClientImpl -> ContextMenuClientImplyaar@chromium.org2009-10-274-13/+13
| | | | | | Review URL: http://codereview.chromium.org/338002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30212 0039d316-1c4b-4281-b951-d872f2087c98
* Let layout tests run on Windows 7.maruel@chromium.org2009-10-271-2/+3
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/337043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30211 0039d316-1c4b-4281-b951-d872f2087c98
* Add TODOs.thakis@chromium.org2009-10-272-0/+5
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/334029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30210 0039d316-1c4b-4281-b951-d872f2087c98