| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=17568
TEST=none
Review URL: http://codereview.chromium.org/160034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/160133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
theme installation can happens sans-prompt.
Review URL: http://codereview.chromium.org/160087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17709
TEST=None
Review URL: http://codereview.chromium.org/159380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=layout tests should pass
TBR=fbarchard
Review URL: http://codereview.chromium.org/160134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Seems Windows only lets you set some text inside the dialog above the tree view, and not in the titlebar.
BUG=16890
TEST=should be obvious
Review URL: http://codereview.chromium.org/159326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
over their modal parent or the screen if there is no modal parent. This means child windows don't open at 0,0 anymore.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15686
TEST=none
Review URL: http://codereview.chromium.org/159371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR: thiago
Review URL: http://codereview.chromium.org/159378
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This might break some layout tests, but that's ok -- we'll disable them for now.
BUG=16636,16779
TEST=none
Review URL: http://codereview.chromium.org/160125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
set the application id as a property on the shortcut As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar. However, they can not be pinned from the main application window nor can they be pinned from the shortcut. The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button. Instead in the latter case a web appliation will form a new group.
Bug=7028
Test=None. (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly)
Review URL: http://codereview.chromium.org/159336
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=thiago
Review URL: http://codereview.chromium.org/159377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=nsylvain
Review URL: http://codereview.chromium.org/159375
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=glen@chromium.org
BUG=15079
TEST=none
Review URL: http://codereview.chromium.org/160130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16669
TEST=Make sure that resetting your theme to the default on Aero Glass causes you to see a black frame.
Review URL: http://codereview.chromium.org/159332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15854
TEST=NONE
Review URL: http://codereview.chromium.org/159360
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Patch by tfarina
Original Review: http://codereview.chromium.org/155888
Review URL: http://codereview.chromium.org/160088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12969
TEST=Open a page with a redirect loop. The error page should mention allowing third-party cookies as a way to fix the problem.
Review URL: http://codereview.chromium.org/159145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before the sandbox is triggered.
BUG=16860 (http://crbug.com/16860 )
TEST=Run Chrome with LC_ALL=en_US.UTF-8. 1. Make sure that you don't see
any warning about 'setlocale failing'. 2. Upload a file whose name
contains non-ASCII characters in UTF-8 (e.g. "café.txt" or "一二.txt" ) . The
filename field in a form should be populated with the name (rather than empty).
Review URL: http://codereview.chromium.org/160112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o3djs.util.setMainEngine(...V8) in any sample
and you use scripts that you don't want run in V8,
for example Adsense, Google Analyitics, Wave,
Google WebElements then the o3djs would attempt
to pull in that javascript and execute it in V8.
Specifically this refers to inline <script> tags
instead HTML. Not <script src="url"> tags.
The solution is we add an id to the tags we want
o3djs to pull in. Any script with an id that starts
with "o3d" will get pulled in.
This CL changes our samples to have that id on their
script tags.
Review URL: http://codereview.chromium.org/159339
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
moving image_diff from chrome/tools/test/image_diff to tools/imagediff
(not moving to tools/image_diff to avoid some svn unpleasantness with that
directory having been created in CL 21366).
Also change test_shell.gyp to depend on everything needed to run the layout
tests.
R=darin@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes Drew Wilson's patch here:
http://codereview.chromium.org/159066
That CL was already reviewed by Dmitry Titov, so the only thing
to review here is the DEPS file change.
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Separator that should be between id and version parameters was at the end of version
-Missing the "uc" parameter which the gallery server code was expecting as indication
of an update check
BUG=http://crbug.com/17469
TEST=extensions auto-update should work
Review URL: http://codereview.chromium.org/159224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
mouse leaves the tab strip. Also turn off zordering fix from before, it regressed things.
BUG=14912
TEST=creating a bunch of tabs and making sure that after you close them and mouse away, they return to the correct sizes. Creating new tabs after that should all be the correct size as well.
Review URL: http://codereview.chromium.org/160116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=estade
Review URL: http://codereview.chromium.org/159367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches the pixel sizes on Windows. The location bar is
a couple pixels shorter and the font is a little smaller.
BUG=17580
Review URL: http://codereview.chromium.org/159303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't actually do anything yet, since right now the ICO decoder still takes the desired size as an argument to setData(), and returns exactly one frame. However, I will be changing that upstream soon.
I didn't add the same code to the CG decoder because I haven't tested to see what order the CG decoder returns frames in.
BUG=none
TEST=Covered by existing unittests.
Review URL: http://codereview.chromium.org/160121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the behavior for active toplevel windows and focus follows mouse that moving the mouse onto and then off of the bookmark bubble will close it.
This also fixes that we might paint the tab strip active while the system title bar is painted inactive. Unfortunately we can't stop the browser window from painting inactive when using the system frame.
This reverts us to the old bad behavior that you could drag around the browser window and the bookmark bubble will stay in place. It also reverts us to allowing the info bubble to being able to persist even if it doesnt have focus. This doesn't match windows, but I'm not convinced windows is all that great.
BUG=none
TEST=see above
Review URL: http://codereview.chromium.org/159288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
image.
I tried to also make the tab strip use stock gtk close button but that is gonna require a lot more work to get layout right so leave it alone for now.
BUG=none
TEST=close button on download shelf is sanely sized
Review URL: http://codereview.chromium.org/159325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=2716,4565,5054
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the FindBarWin is instanciated.
It is not clear how this can happen.
BUG=17056
TEST=None
Review URL: http://codereview.chromium.org/161001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=The background color of the lower sections on the NNTP should be light blue.
Review URL: http://codereview.chromium.org/159350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this was causing diffs to show up in layout tests on vista
BUG=none
TEST=none
R=maruel@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to CL 21434 test_shell did not actually check if ClearType was
disabled. I had thought that the requirement for the layout tests was
that *all* font smoothing was disabled (both ClearType and standard). Turns
out that standard is okay, so I am reenabling it here.
Note that CL 21434 was really just a re-reverting of 21368.
TEST=none
BUG=none
R=tony@chromium.org
Review URL: http://codereview.chromium.org/160082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=2696
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=2714,2715
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
request after it
has been deleted.
TBR=jam
Review URL: http://codereview.chromium.org/159358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=senorblanco
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=fishd
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
though we already changed the find text.
On Linux, we would continue doing a find operation. On Windows,
the find operation would stop, but the find box would not be
cleared.
TEST=Go to a long page (like the html 5 spec). Do a find for a very
common string (e.g., any single letter). Press backspace to clear
the find box while results are still populating. The find box
should be cleared and the find stopped.
Review URL: http://codereview.chromium.org/159321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This appears to fix http://crbug.com/17326 since the last test that was failing
in that set is now passing.
LayoutTests/editing/selection/move-begin-end.html is also passing now. I'm not
sure which WebKit patch to attribute that to.
http://trac.webkit.org/changeset/46363 caused a boat-load of tests to need to be
re-baselined, but that is expected and probably a temporary condition. Stephen
wanted to revert his WebCore change to see if it would resolve the reliability
test failure.
Otherwise, it looks like we picked up some media related crashers :-(
TBR=pkasting
BUG=17326
TEST=none
Review URL: http://codereview.chromium.org/160110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handle it.
The problem is that the page changes the focused area in the mouse release handler.
Even after this fix, it is possible to paste into the wrong place. The place that gets the text is whichever text input is focused when the browser sends back the clipboard contents, not the text input that is focused when the middle click is handled. This has always been true but seems harmless in most cases.
BUG=17504
TEST=open gmail chat. Put something in your PRIMARY. Click in the text entry area. Middle click in the chat display area. The selection shouldn't paste into the text entry. Otherwise, middle click paste should still work.
TEST=the reduction in the bug acts as expected
Review URL: http://codereview.chromium.org/160065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it should be all.)
Review URL: http://codereview.chromium.org/160107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21552 0039d316-1c4b-4281-b951-d872f2087c98
|