| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=11457
TEST=Drag thumbnail on NTP. Shouldn't dcheck.
Review URL: http://codereview.chromium.org/2807023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the os says we should, or focus was on the button that triggered
showing the menu. Also changes mnemonic processing to not guess at
mnemonic if menu has mnemonics.
BUG=45734
TEST=none
Review URL: http://codereview.chromium.org/2831031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=brettw
BUG=47461
TEST=none
Review URL: http://codereview.chromium.org/2852024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
adding the example project.
R=bradnelson
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2844025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Each translate infobar is now its own class and most of the logic is in the delegate.
BUG=40828
TEST=Thoroughly test the translate feature on Linux.
Review URL: http://codereview.chromium.org/2867017
Review URL: http://codereview.chromium.org/2836023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was trying to debug some code, and noticed some excess
complexity.
There are no significant semantic changes.
DCHECK on a foo.get() is a waste given we're about to deref
the pointer.
Execution cost should be be minially less, and we get rid
of several lines of code.
BUG=46263
r=mbelshe
Review URL: http://codereview.chromium.org/2805033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
triggering builds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2847028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests are failing. Reverting last two rolls.
TBR=hclam
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2835017
TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/2806035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(text-intro-05-t).
Tests are failing. Reverting last two rolls.
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2845024
TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/2836027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2845024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=47518
TEST=none
Review URL: http://codereview.chromium.org/2805035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2814033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2835017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46672
RBR=glider,senorblanco
TEST=TSan UI should remain green
Review URL: http://codereview.chromium.org/2861027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subsequent changes will:
* Allow URLPatterns to specify * for scheme, so that http/https doesn't need to be repeated for each host.
* Fix the overlap detection.
Suggested review order:
- test files
- url_pattern*
- extension_extent*
- extension*
- everything else
BUG=46633
Review URL: http://codereview.chromium.org/2876007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Change the order and make the rules a bit more specific to handle disabled action buttons.
Review URL: http://codereview.chromium.org/2805028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Reverted r50804 as it seems to be related to memory error.
Review URL: http://codereview.chromium.org/2833033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
items.""
This reverts r50828 as the error is already suppressed r50793.
TBR=asargent
Review URL: http://codereview.chromium.org/2844028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11457
TEST=Go to google.com, drag logo around. Should be attached to cursor.
Review URL: http://codereview.chromium.org/2870026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the logic to disable the "remeber" functions in the UI elements (basically reverting r44084, but leaves the incognito host content setting map in place. Changes to this map are allowed but do not get stored in preferences.
BUG=44480
TEST=none
Review URL: http://codereview.chromium.org/2811025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=asargent@chromium.org
TEST=Tree goes green
Review URL: http://codereview.chromium.org/2812025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
display name.
BUG=cros:2318
TEST=Log in with two users with the same username but different domains. Check that tooltips are enabled on the next run of login screen. Remove one of the users. Check that tooltips are disabled and stay disabled until new user is added with duplicate username.
Review URL: http://codereview.chromium.org/2841026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
debug-plugin-loading mode and uses LOG_IF consistently (I thought it would be
more understandable to have the condition explicit rather than some extra macro
that would now have to be moved to a common header file).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2799032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=47213
TEST=manual test?
Review URL: http://codereview.chromium.org/2868031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We shouldn't declare global variables of class types, because they are forbidden by
the style guide. See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Static_and_Global_Variables#Static_and_Global_Variables for futher information.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/2873021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=--enable-chat-manager no longer runs the chat_manager component extension.
Review URL: http://codereview.chromium.org/2833031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=new unittests
Review URL: http://codereview.chromium.org/2831029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mal
Review URL: http://codereview.chromium.org/2808026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dantasse@chromium.org
TEST=Valgrind bot goes green
BUG=none
Review URL: http://codereview.chromium.org/2827025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=viettrungluu
Review URL: http://codereview.chromium.org/2832025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
crash if the pdf plugin couldn't be loaded.
BUG=47362
TBR=thestig
Review URL: http://codereview.chromium.org/2852026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ericu, michaeln
Review URL: http://codereview.chromium.org/2863025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=hclam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=arv@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
JSONReader and JSONWriter are used to read/write json file instead
of JsonPrefStore.
BUG=none
TEST=unittests
Review URL: http://codereview.chromium.org/2819026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(DevTools functions should not be Windows-specific)
Review URL: http://codereview.chromium.org/2817029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
by one of the tests, but it is needed by more than one of them.
Review URL: http://codereview.chromium.org/2853007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix regression where gkt menu didn't close itself when screen is locked.
putting gtk_add_grab() back before removing all of grab widget.
This was also causing the problem
* Fix copy&paste error in HandleGrabBroke. It was not checking mouse_grab_status
* Enable double buffering to avoid flicker on native textfield.
* Add more logging to help troubleshooting problem in release build.
BUG=chromium-os:4222
TEST=see bug for instruction how to reproduce the bug. Screen Locker should kick in even with menu opened and unlocking should work too.
Review URL: http://codereview.chromium.org/2868024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2814026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made it take options for enabled/incognito enabled state to apply
on install.
BUG=46515
TEST=unittests, manual (newly-synced disabled extensions should stay
disabled)
Review URL: http://codereview.chromium.org/2819023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/2458
TEST=Disable desktop->gnome->interface->show_input_method_menu option in gconf-editor, and then right click in a webpage's input box. The context menu should not contain input method sub menu.
Review URL: http://codereview.chromium.org/2804024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix simple_host to work when \Users\<username> is on a different drive than the chrome repository.
BUG=none
TEST=run scripts & host process on Windows
Review URL: http://codereview.chromium.org/2822029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkModelVerifier::Create() is called by LiveBookmarksSyncTest::SetupClients() and LiveBookmarksSyncTest::SetupSync(). This results in a duplicate bookmarks bar in the verifier profile, causing some tests to fail.
LiveSyncTest::SetupSync() polymorphically calls LiveBookmarksSyncTest::SetupClients(). Therefore, the correct fix is to remove the override method LiveBookmarksSyncTest::SetupSync(), since there is no need to do anything additional there.
BUG=47451
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/2851024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mikhail
TEST=Tree stays green
BUG=none
Review URL: http://codereview.chromium.org/2817031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Push the AutocompleteTextFieldCell knowledge into LocationBarViewMac.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2806031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39365
TEST=yes
Review URL: http://codereview.chromium.org/2822007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Concentrate the calculation in the location bar. Was going to do this
in rewiring omnibox decorations, pulled it out before creating
cocoa/location_bar/ subdir.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2846030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13685
TEST=manual
Review URL: http://codereview.chromium.org/2805030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50796 0039d316-1c4b-4281-b951-d872f2087c98
|